Dart Code Reviews - Google Groups

Groups

1–30 of 127447

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

12:03 PM

[M] Change in dart/sdk[main]: DAS plugins: Include generated configuration hash in state folder name

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569682 Change information

unread,

[M] Change in dart/sdk[main]: DAS plugins: Include generated configuration hash in state folder name

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569682 Change information

12:03 PM

Ben Konyi (Gerrit)4

12:00 PM

[XL] Change in dart/sdk[main]: [dds] Preserve early `readyToResume` approvals until isolate pauses

Ben Konyi voted Commit-Queue+1 on change 561140 Commit-Queue +1 Open in Gerrit Related details

unread,

[XL] Change in dart/sdk[main]: [dds] Preserve early `readyToResume` approvals until isolate pauses

Ben Konyi voted Commit-Queue+1 on change 561140 Commit-Queue +1 Open in Gerrit Related details

12:00 PM

Chitresh Yadav (csy) (Gerrit)

11:54 AM

[L] Change in dart/sdk[main]: [analysis_server] Keep declaring final and var

Attention needed from Samuel Rawlins Chitresh Yadav (csy) has uploaded change 570160 for review

unread,

[L] Change in dart/sdk[main]: [analysis_server] Keep declaring final and var

Attention needed from Samuel Rawlins Chitresh Yadav (csy) has uploaded change 570160 for review

11:54 AM

Jake Macdonald (Gerrit), Phil Quitslund (Gerrit)3

11:49 AM

[XS] Change in dart/sdk[main]: Bump tools to 1840a6779762fe5672e094f714d7ddd2ebcb30ff

Jake Macdonald <jak...@google.com> abandoned this change. View Change Abandoned obsolete Jake

unread,

[XS] Change in dart/sdk[main]: Bump tools to 1840a6779762fe5672e094f714d7ddd2ebcb30ff

Jake Macdonald <jak...@google.com> abandoned this change. View Change Abandoned obsolete Jake

11:49 AM

Jonas Jensen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

11:48 AM

[XS] Change in dart/sdk[main]: Bump tools to eee87b12f5a7f42149c4dff130eb6d5600fae883

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570001 Change information

unread,

[XS] Change in dart/sdk[main]: Bump tools to eee87b12f5a7f42149c4dff130eb6d5600fae883

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570001 Change information

11:48 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)11

11:27 AM

[M] Change in dart/sdk[main]: [vm,dynamic_modules] Fix breakpoints for returns with finalizers.

Tess Strickland voted Commit-Queue+2 on change 567422 Commit-Queue +2 Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm,dynamic_modules] Fix breakpoints for returns with finalizers.

Tess Strickland voted Commit-Queue+2 on change 567422 Commit-Queue +2 Open in Gerrit Related details

11:27 AM

Søren Pedersen (Gerrit)

11:18 AM

[M] Change in dart/sdk[main]: [dart2wasm] CFG support for null and reference comparisons

Attention needed from Martin Kustermann Søren Pedersen voted Commit-Queue+1 on change 570120 Commit-

unread,

[M] Change in dart/sdk[main]: [dart2wasm] CFG support for null and reference comparisons

Attention needed from Martin Kustermann Søren Pedersen voted Commit-Queue+1 on change 570120 Commit-

11:18 AM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

11:09 AM

[XS] Change in dart/sdk[main]: [analysis_server] Attempt to fix flake in get_refactoring_test

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569500 Change information

unread,

[XS] Change in dart/sdk[main]: [analysis_server] Attempt to fix flake in get_refactoring_test

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569500 Change information

11:09 AM

Samuel Rawlins (Gerrit), Danny Tuppeny (Gerrit)3

11:08 AM

[L] Change in dart/sdk[main]: [analysis_server] Ensure cancellation tokens are passed down through ...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Samuel Rawlins voted Code-Review+1 on

unread,

[L] Change in dart/sdk[main]: [analysis_server] Ensure cancellation tokens are passed down through ...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Samuel Rawlins voted Code-Review+1 on

11:08 AM

Samuel Rawlins (Gerrit), Danny Tuppeny (Gerrit)3

11:05 AM

[L] Change in dart/sdk[main]: [analysis_server] Use `checkAbort` helper in command handlers

Attention needed from Danny Tuppeny and Keerti Parthasarathy Samuel Rawlins voted Code-Review+1 on

unread,

[L] Change in dart/sdk[main]: [analysis_server] Use `checkAbort` helper in command handlers

Attention needed from Danny Tuppeny and Keerti Parthasarathy Samuel Rawlins voted Code-Review+1 on

11:05 AM

Jonas Jensen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

10:42 AM

[XS] Change in dart/sdk[main]: [dartpad] Only re-export VmService

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570081 Change information

unread,

[XS] Change in dart/sdk[main]: [dartpad] Only re-export VmService

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570081 Change information

10:42 AM

Jonas Jensen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

10:42 AM

[S] Change in dart/sdk[main]: [dartpad] Make workspace fields private

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570080 Change information

unread,

[S] Change in dart/sdk[main]: [dartpad] Make workspace fields private

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570080 Change information

10:42 AM

Jonas Jensen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

10:42 AM

[S] Change in dart/sdk[main]: [dartpad] Make Workspace.id and LanguageServer.id private

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570060 Change information

unread,

[S] Change in dart/sdk[main]: [dartpad] Make Workspace.id and LanguageServer.id private

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570060 Change information

10:42 AM

Jonas Jensen (Gerrit)

10:40 AM

[XS] Change in dart/sdk[main]: [vm/io] Only call _nativeSocketType on macOS in _RawSocket._readPipe

Attention needed from Brian Quinlan Jonas Jensen voted and added 1 comment on change 566400 Votes

unread,

[XS] Change in dart/sdk[main]: [vm/io] Only call _nativeSocketType on macOS in _RawSocket._readPipe

Attention needed from Brian Quinlan Jonas Jensen voted and added 1 comment on change 566400 Votes

10:40 AM

Nate Bosch (Gerrit), Brian Wilkerson (Gerrit)2

10:29 AM

[M] Change in dart/sdk[main]: [linter] Allow omit_local_variable_types annotations for dot shorthands

Attention needed from Konstantin Shcheglov and Nate Bosch Brian Wilkerson added 1 comment on change

unread,

[M] Change in dart/sdk[main]: [linter] Allow omit_local_variable_types annotations for dot shorthands

Attention needed from Konstantin Shcheglov and Nate Bosch Brian Wilkerson added 1 comment on change

10:29 AM

Alexander Markov (Gerrit), Ryan Macnak (Gerrit)3

10:29 AM

[L] Change in dart/sdk[main]: [modular_aot] InvokeDartCode and InvokeDartCodeFromBytecode stubs

Attention needed from Slava Egorov Alexander Markov voted and added 3 comments on change 568621 Votes

unread,

[L] Change in dart/sdk[main]: [modular_aot] InvokeDartCode and InvokeDartCodeFromBytecode stubs

Attention needed from Slava Egorov Alexander Markov voted and added 3 comments on change 568621 Votes

10:29 AM

Brian Wilkerson (Gerrit)

10:16 AM

[XS] Change in dart/sdk[main]: [analysis_server] Attempt to fix flake in get_type_hierarchy_test

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted on change 569560 Code-

unread,

[XS] Change in dart/sdk[main]: [analysis_server] Attempt to fix flake in get_type_hierarchy_test

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted on change 569560 Code-

10:16 AM

Johnni Winther (Gerrit)

10:02 AM

[L] Change in dart/sdk[main]: [cfe] Add test for mixing in a named mixin application

Attention needed from Nicholas Shahan Johnni Winther voted Commit-Queue+1 on change 570021 Commit-

unread,

[L] Change in dart/sdk[main]: [cfe] Add test for mixing in a named mixin application

Attention needed from Nicholas Shahan Johnni Winther voted Commit-Queue+1 on change 570021 Commit-

10:02 AM

Lasse Nielsen (Gerrit), … Jens Johansen (Gerrit)9

9:59 AM

[XL] Change in dart/sdk[main]: Allowing `dart.tool.TOOLNAME` in conditional URIs.

Attention needed from Lasse Nielsen, Nate Bosch, Paul Berry and Ryan Macnak Jens Johansen added 1

unread,

[XL] Change in dart/sdk[main]: Allowing `dart.tool.TOOLNAME` in conditional URIs.

Attention needed from Lasse Nielsen, Nate Bosch, Paul Berry and Ryan Macnak Jens Johansen added 1

9:59 AM

Jens Johansen (Gerrit), … Johnni Winther (Gerrit)5

9:46 AM

[L] Change in dart/sdk[main]: [CFE] Fix incremental compiler never completing Completer if crashing

Jens Johansen voted Commit-Queue+2 on change 569980 Commit-Queue +2 Open in Gerrit Related details

unread,

[L] Change in dart/sdk[main]: [CFE] Fix incremental compiler never completing Completer if crashing

Jens Johansen voted Commit-Queue+2 on change 569980 Commit-Queue +2 Open in Gerrit Related details

9:46 AM

Johnni Winther (Gerrit), … Jens Johansen (Gerrit)4

9:46 AM

[L] Change in dart/sdk[main]: [CFE] Incremental compiler: Bail on advanced invalidation if non-inva...

Jens Johansen voted Commit-Queue+2 on change 570002 Commit-Queue +2 Open in Gerrit Related details

unread,

[L] Change in dart/sdk[main]: [CFE] Incremental compiler: Bail on advanced invalidation if non-inva...

Jens Johansen voted Commit-Queue+2 on change 570002 Commit-Queue +2 Open in Gerrit Related details

9:46 AM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

9:46 AM

[S] Change in dart/sdk[main]: [CFE] Cleanup some problemOnLibrary (part 1)

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569981 Change information

unread,

[S] Change in dart/sdk[main]: [CFE] Cleanup some problemOnLibrary (part 1)

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 569981 Change information

9:46 AM

Mark Zhou (Gerrit), … Martin Kustermann (Gerrit)5

9:45 AM

[L] Change in dart/sdk[main]: [dart2wasm/dev] Add instance calls to the wasm dev runtime and compiler

Attention needed from Mark Zhou and Nicholas Shahan Martin Kustermann voted and added 3 comments on

unread,

[L] Change in dart/sdk[main]: [dart2wasm/dev] Add instance calls to the wasm dev runtime and compiler

Attention needed from Mark Zhou and Nicholas Shahan Martin Kustermann voted and added 3 comments on

9:45 AM

Vasil Vasilich (Gerrit), … Søren Pedersen (Gerrit)9

9:31 AM

[S] Change in dart/sdk[main]: [dart2wasm] Validate all digits after the first radix parse block

Attention needed from Martin Kustermann and Vasil Vasilich Søren Pedersen voted on change 569220 Code

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Validate all digits after the first radix parse block

Attention needed from Martin Kustermann and Vasil Vasilich Søren Pedersen voted on change 569220 Code

9:31 AM

Modestas Valauskas (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)26

9:24 AM

[M] Change in dart/sdk[main]: [typed_data] Make unmodifiable views reject every write

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 556420 Change information

unread,

[M] Change in dart/sdk[main]: [typed_data] Make unmodifiable views reject every write

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 556420 Change information

9:24 AM

Martin Kustermann (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:07 AM

[S] Change in dart/sdk[main]: [cfg] Recognize single-block self-loops in computeLoops

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570000 Change information

unread,

[S] Change in dart/sdk[main]: [cfg] Recognize single-block self-loops in computeLoops

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted change 570000 Change information

9:07 AM

Johnni Winther (Gerrit)

7:49 AM

[S] Change in dart/sdk[main]: AST. Split V1 getFragmentDeclaration checks out of test_getResolvedLi...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 on

unread,

[S] Change in dart/sdk[main]: AST. Split V1 getFragmentDeclaration checks out of test_getResolvedLi...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 on

7:49 AM

Johnni Winther (Gerrit)

7:16 AM

[L] Change in dart/sdk[main]: Issue 64687. Use fragment formal parameters for flow analysis.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment on

unread,

[L] Change in dart/sdk[main]: Issue 64687. Use fragment formal parameters for flow analysis.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment on

7:16 AM

Martin Kustermann (Gerrit), … Lasse Nielsen (Gerrit)4

7:09 AM

[L] Change in dart/sdk[main]: [dart2js] Fix soundness and await semantics in AsyncLowering

Attention needed from Martin Kustermann Lasse Nielsen voted and added 15 comments on change 564580

unread,

[L] Change in dart/sdk[main]: [dart2js] Fix soundness and await semantics in AsyncLowering

Attention needed from Martin Kustermann Lasse Nielsen voted and added 15 comments on change 564580

7:09 AM

Johnni Winther (Gerrit)

6:37 AM

[S] Change in dart/sdk[main]: AST. Make Annotation.parent2 nullable.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 on

unread,

[S] Change in dart/sdk[main]: AST. Make Annotation.parent2 nullable.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 on

6:37 AM

Search

Clear search

Close search

Google apps

Main menu