Groups

Dart Code Reviews

1–30 of 121331

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Tess Strickland (Gerrit), Alexander Markov (Gerrit)8

7:25 AM

[M] Change in dart/sdk[main]: [vm,dyn_modules] Update some coverage information for bytecode.

Tess Strickland added 2 comments File runtime/vm/bytecode_reader.cc Line 2193, Patchset 14:

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Update some coverage information for bytecode.

Tess Strickland added 2 comments File runtime/vm/bytecode_reader.cc Line 2193, Patchset 14:

7:25 AM

Moritz Sümmermann (Gerrit), … Daco Harkes (Gerrit)6

7:18 AM

[L] Change in dart/sdk[main]: [record_use] Small fixes

Attention needed from Daco Harkes and Johnni Winther Moritz Sümmermann added 3 comments Commit

unread,

[L] Change in dart/sdk[main]: [record_use] Small fixes

Attention needed from Daco Harkes and Johnni Winther Moritz Sümmermann added 3 comments Commit

7:18 AM

Johnni Winther (Gerrit)

7:14 AM

[L] Change in dart/sdk[main]: [cfe] Support nested prefixes

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[L] Change in dart/sdk[main]: [cfe] Support nested prefixes

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

7:14 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)6

6:53 AM

[L] Change in dart/sdk[main]: [cfe] Merge Resolver.buildFieldInitializer1/2

Commit Queue submitted the change Change information Commit message: [cfe] Merge Resolver.

unread,

[L] Change in dart/sdk[main]: [cfe] Merge Resolver.buildFieldInitializer1/2

Commit Queue submitted the change Change information Commit message: [cfe] Merge Resolver.

6:53 AM

Brian Wilkerson (Gerrit), … Lasse Nielsen (Gerrit)5

5:22 AM

[M] Change in dart/sdk[main]: analyzer: Tidy up documentation for the new Deprecated annotation war...

Attention needed from Samuel Rawlins Lasse Nielsen added 3 comments File pkg/analyzer/messages.yaml

unread,

[M] Change in dart/sdk[main]: analyzer: Tidy up documentation for the new Deprecated annotation war...

Attention needed from Samuel Rawlins Lasse Nielsen added 3 comments File pkg/analyzer/messages.yaml

5:22 AM

Moritz Sümmermann (Gerrit), … Daco Harkes (Gerrit)4

4:50 AM

[M] Change in dart/sdk[main]: Use package:record_use for dart2js

Attention needed from Moritz Sümmermann and Stephen Adams Daco Harkes added 2 comments Patchset-level

unread,

[M] Change in dart/sdk[main]: Use package:record_use for dart2js

Attention needed from Moritz Sümmermann and Stephen Adams Daco Harkes added 2 comments Patchset-level

4:50 AM

Johnni Winther (Gerrit)

4:00 AM

[L] Change in dart/sdk[main]: Fine. Add RequirementsManifestDigest; stop caching linked bundles

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[L] Change in dart/sdk[main]: Fine. Add RequirementsManifestDigest; stop caching linked bundles

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

4:00 AM

Johnni Winther (Gerrit)

3:51 AM

[S] Change in dart/sdk[main]: Fine. Use manifest hash to fast-path export validation

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: Fine. Use manifest hash to fast-path export validation

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:51 AM

Johnni Winther (Gerrit)

3:49 AM

[S] Change in dart/sdk[main]: Fine. Add set metric to OperationPerformance; track detail URIs

Attention needed from Konstantin Shcheglov Johnni Winther voted Code-Review+1 Code-Review +1 Open in

unread,

[S] Change in dart/sdk[main]: Fine. Add set metric to OperationPerformance; track detail URIs

Attention needed from Konstantin Shcheglov Johnni Winther voted Code-Review+1 Code-Review +1 Open in

3:49 AM

Konstantin Shcheglov (Gerrit), Johnni Winther (Gerrit)2

3:46 AM

[M] Change in dart/sdk[main]: Fine. Add Hash class.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: Fine. Add Hash class.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:46 AM

Johnni Winther (Gerrit)

3:44 AM

[S] Change in dart/sdk[main]: Fine. Add stable id to RequirementsManifest; bump data version

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: Fine. Add stable id to RequirementsManifest; bump data version

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:44 AM

Johnni Winther (Gerrit)

3:43 AM

[XS] Change in dart/sdk[main]: Fine. Clear type hierarchies when idle to reduce memory

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[XS] Change in dart/sdk[main]: Fine. Clear type hierarchies when idle to reduce memory

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:43 AM

Stephen Adams (Gerrit), … Commit Queue (Gerrit)7

Sep 28

[S] Change in dart/sdk[main]: Core libs: Introduce Deprecated.optional, a new annotation.

Commit Queue submitted the change Change information Commit message: Core libs: Introduce Deprecated.

unread,

[S] Change in dart/sdk[main]: Core libs: Introduce Deprecated.optional, a new annotation.

Commit Queue submitted the change Change information Commit message: Core libs: Introduce Deprecated.

Sep 28

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)5

Sep 27

[M] Change in dart/sdk[main]: DAS plugins: Only use fix edits which apply to each file with a match...

Attention needed from Brian Wilkerson and Danny Tuppeny Samuel Rawlins added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: DAS plugins: Only use fix edits which apply to each file with a match...

Attention needed from Brian Wilkerson and Danny Tuppeny Samuel Rawlins added 1 comment File pkg/

Sep 27

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)7

Sep 26

[L] Change in dart/sdk[main]: [analyzer] Adds new diagnostic for `unsupported_lint`

Attention needed from Felipe Morschel and Konstantin Shcheglov Brian Wilkerson added 4 comments

unread,

[L] Change in dart/sdk[main]: [analyzer] Adds new diagnostic for `unsupported_lint`

Attention needed from Felipe Morschel and Konstantin Shcheglov Brian Wilkerson added 4 comments

Sep 26

Alexander Aprelev (Gerrit)

Sep 26

[S] Change in dart/sdk[main]: [io] Fix race between closing socket and requesting its type.

Attention needed from Slava Egorov Alexander Aprelev voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[S] Change in dart/sdk[main]: [io] Fix race between closing socket and requesting its type.

Attention needed from Slava Egorov Alexander Aprelev voted Commit-Queue+1 Commit-Queue +1 Open in

Sep 26

Alexander Aprelev (Gerrit), … Slava Egorov (Gerrit)8

Sep 26

[S] Change in dart/sdk[main]: [io/socket] Make Socket::fd_ atomic since it can get updated from mul...

Alexander Aprelev added 1 comment Patchset-level comments File-level comment, Patchset 4 (Latest):

unread,

[S] Change in dart/sdk[main]: [io/socket] Make Socket::fd_ atomic since it can get updated from mul...

Alexander Aprelev added 1 comment Patchset-level comments File-level comment, Patchset 4 (Latest):

Sep 26

Alexander Aprelev (Gerrit), … Commit Queue (Gerrit)4

Sep 26

[XS] Change in dart/sdk[main]: [gardening] Remove multiple_timer_test from isolate stress test suite.

Commit Queue submitted the change Change information Commit message: [gardening] Remove

unread,

[XS] Change in dart/sdk[main]: [gardening] Remove multiple_timer_test from isolate stress test suite.

Commit Queue submitted the change Change information Commit message: [gardening] Remove

Sep 26

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)7

Sep 26

[M] Change in dart/sdk[main]: [analyzer_testing] Duplicates `ExpectedContextMessage` to start migra...

Commit Queue submitted the change Change information Commit message: [analyzer_testing] Duplicates `

unread,

[M] Change in dart/sdk[main]: [analyzer_testing] Duplicates `ExpectedContextMessage` to start migra...

Commit Queue submitted the change Change information Commit message: [analyzer_testing] Duplicates `

Sep 26

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

Sep 26

[M] Change in dart/sdk[main]: [DAS] Fixes `Add missing Switch cases` not importing src libraries

Commit Queue submitted the change Change information Commit message: [DAS] Fixes `Add missing Switch

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes `Add missing Switch cases` not importing src libraries

Commit Queue submitted the change Change information Commit message: [DAS] Fixes `Add missing Switch

Sep 26

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Sep 26

[M] Change in dart/sdk[main]: Fine. Short-circuit requirement checks with hashForRequirements

Commit Queue submitted the change Change information Commit message: Fine. Short-circuit requirement

unread,

[M] Change in dart/sdk[main]: Fine. Short-circuit requirement checks with hashForRequirements

Commit Queue submitted the change Change information Commit message: Fine. Short-circuit requirement

Sep 26

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)5

Sep 26

[S] Change in dart/sdk[main]: analyzer: add inference failure tests for dot-shorthands

Commit Queue submitted the change Change information Commit message: analyzer: add inference failure

unread,

[S] Change in dart/sdk[main]: analyzer: add inference failure tests for dot-shorthands

Commit Queue submitted the change Change information Commit message: analyzer: add inference failure

Sep 26

Kallen Tu (Gerrit), … Commit Queue (Gerrit)4

Sep 26

[S] Change in dart/sdk[main]: analyzer: Check deprecated member use on DotShorthandInvocation

Commit Queue submitted the change Change information Commit message: analyzer: Check deprecated

unread,

[S] Change in dart/sdk[main]: analyzer: Check deprecated member use on DotShorthandInvocation

Commit Queue submitted the change Change information Commit message: analyzer: Check deprecated

Sep 26

Kallen Tu (Gerrit), … Commit Queue (Gerrit)5

Sep 26

[M] Change in dart/sdk[main]: analyzer: Guard DotShorthandConstructorInvocation from Deprecated.ins...

Commit Queue submitted the change Change information Commit message: analyzer: Guard

unread,

[M] Change in dart/sdk[main]: analyzer: Guard DotShorthandConstructorInvocation from Deprecated.ins...

Commit Queue submitted the change Change information Commit message: analyzer: Guard

Sep 26

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)14

Sep 26

[M] Change in dart/sdk[main]: [DAS] Makes `AbstractContextTest.createAnalysisOptionsFile` like `ana...

Commit Queue submitted the change Change information Commit message: [DAS] Makes `AbstractContextTest

unread,

[M] Change in dart/sdk[main]: [DAS] Makes `AbstractContextTest.createAnalysisOptionsFile` like `ana...

Commit Queue submitted the change Change information Commit message: [DAS] Makes `AbstractContextTest

Sep 26

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)7

Sep 26

[M] Change in dart/sdk[main]: [DAS] Fixes "Create missing overrides" for unary operators

Commit Queue submitted the change Change information Commit message: [DAS] Fixes "Create missing

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes "Create missing overrides" for unary operators

Commit Queue submitted the change Change information Commit message: [DAS] Fixes "Create missing

Sep 26

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)5

Sep 26

[S] Change in dart/sdk[main]: [DAS] Adds private type test to `Add type annotation` fix tests

Commit Queue submitted the change Change information Commit message: [DAS] Adds private type test to

unread,

[S] Change in dart/sdk[main]: [DAS] Adds private type test to `Add type annotation` fix tests

Commit Queue submitted the change Change information Commit message: [DAS] Adds private type test to

Sep 26

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Sep 26

[XL] Change in dart/sdk[main]: Fine. Compute and persist LibraryManifest.hashForRequirements

Commit Queue submitted the change Change information Commit message: Fine. Compute and persist

unread,

[XL] Change in dart/sdk[main]: Fine. Compute and persist LibraryManifest.hashForRequirements

Commit Queue submitted the change Change information Commit message: Fine. Compute and persist

Sep 26

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Sep 26

[M] Change in dart/sdk[main]: analyzer: More tests for Deprecated.instantiate

Commit Queue submitted the change Change information Commit message: analyzer: More tests for

unread,

[M] Change in dart/sdk[main]: analyzer: More tests for Deprecated.instantiate

Commit Queue submitted the change Change information Commit message: analyzer: More tests for

Sep 26

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Sep 26

[S] Change in dart/sdk[main]: CQ. Stop using dart:io in analyzer/lib/src/dart/sdk/sdk.dart

Commit Queue submitted the change Change information Commit message: CQ. Stop using dart:io in

unread,

[S] Change in dart/sdk[main]: CQ. Stop using dart:io in analyzer/lib/src/dart/sdk/sdk.dart

Commit Queue submitted the change Change information Commit message: CQ. Stop using dart:io in

Sep 26

Search

Clear search

Close search

Google apps

Main menu