Groups

Dart Code Reviews

1–30 of 123537

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)10

5:42 PM

[S] Change in dart/sdk[main]: [analysis_server] Use the minimum of SDK language version and formatt...

Commit Queue submitted the change Change information Commit message: [analysis_server] Use the

unread,

[S] Change in dart/sdk[main]: [analysis_server] Use the minimum of SDK language version and formatt...

Commit Queue submitted the change Change information Commit message: [analysis_server] Use the

5:42 PM

Brian Wilkerson (Gerrit), … Samuel Rawlins (Gerrit)3

5:38 PM

[L] Change in dart/sdk[main]: Update the addMissingParameterNamed fix for primary constructors

Attention needed from Brian Wilkerson Samuel Rawlins voted and added 1 comment Votes added by Samuel

unread,

[L] Change in dart/sdk[main]: Update the addMissingParameterNamed fix for primary constructors

Attention needed from Brian Wilkerson Samuel Rawlins voted and added 1 comment Votes added by Samuel

5:38 PM

Elliott Brooks (Gerrit), … Commit Queue (Gerrit)5

5:34 PM

[S] Change in dart/sdk[stable]: [stable] Cherry-pick DevTools 2.54.2

Commit Queue submitted the change Change information Commit message: [stable] Cherry-pick DevTools

unread,

[S] Change in dart/sdk[stable]: [stable] Cherry-pick DevTools 2.54.2

Commit Queue submitted the change Change information Commit message: [stable] Cherry-pick DevTools

5:34 PM

Ben Konyi (Gerrit), Nicholas Shahan (Gerrit)2

5:08 PM

[M] Change in dart/sdk[main]: [ Service ] Fix dart:developer service extensions, add getSupportedPr...

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted Code-Review+1 Code-Review +1

unread,

[M] Change in dart/sdk[main]: [ Service ] Fix dart:developer service extensions, add getSupportedPr...

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted Code-Review+1 Code-Review +1

5:08 PM

Ben Konyi (Gerrit), Nicholas Shahan (Gerrit)4

5:02 PM

[L] Change in dart/sdk[main]: [ Service ] Add expression evaluation support to dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

unread,

[L] Change in dart/sdk[main]: [ Service ] Add expression evaluation support to dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

5:02 PM

Brian Wilkerson (Gerrit)

4:55 PM

[M] Change in dart/sdk[main]: DAS insights: Linkify more files to their contents

Attention needed from Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: DAS insights: Linkify more files to their contents

Attention needed from Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

4:55 PM

Nicholas Shahan (Gerrit)

4:48 PM

[XL] Change in dart/sdk[main]: [dwds_test_common] Migrate package to the SDK repository

Attention needed from Ben Konyi, Jessy Yameogo and Mark Zhou Nicholas Shahan added 2 comments

unread,

[XL] Change in dart/sdk[main]: [dwds_test_common] Migrate package to the SDK repository

Attention needed from Ben Konyi, Jessy Yameogo and Mark Zhou Nicholas Shahan added 2 comments

4:48 PM

Danny Tuppeny (Gerrit), … Samuel Rawlins (Gerrit)7

4:48 PM

[M] Change in dart/sdk[main]: [analysis_server] Don't let format errors fail change building

Attention needed from Danny Tuppeny, Helin Shiah and Phil Quitslund Samuel Rawlins voted Commit-Queue

unread,

[M] Change in dart/sdk[main]: [analysis_server] Don't let format errors fail change building

Attention needed from Danny Tuppeny, Helin Shiah and Phil Quitslund Samuel Rawlins voted Commit-Queue

4:48 PM

Alexander Markov (Gerrit), … Commit Queue (Gerrit)4

3:34 PM

[XS] Change in dart/sdk[main]: [infra] Roll clang to d0ddae678e3f634c988542dfbdde1dd0afe66344.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[XS] Change in dart/sdk[main]: [infra] Roll clang to d0ddae678e3f634c988542dfbdde1dd0afe66344.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

3:34 PM

Alexander Markov (Gerrit), … Commit Queue (Gerrit)3

3:16 PM

[XS] Change in dart/sdk[main]: [gardening] Reduce test thread concurrency to make sure it passes und...

Commit Queue submitted the change Change information Commit message: [gardening] Reduce test thread

unread,

[XS] Change in dart/sdk[main]: [gardening] Reduce test thread concurrency to make sure it passes und...

Commit Queue submitted the change Change information Commit message: [gardening] Reduce test thread

3:16 PM

Chloe Stefantsova (Gerrit), Alexander Markov (Gerrit)2

3:15 PM

[M] Change in dart/sdk[main]: [cfe] Produce synthetic assignments in for-in loops in output form

Attention needed from Chloe Stefantsova Alexander Markov voted and added 1 comment Votes added by

unread,

[M] Change in dart/sdk[main]: [cfe] Produce synthetic assignments in for-in loops in output form

Attention needed from Chloe Stefantsova Alexander Markov voted and added 1 comment Votes added by

3:15 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

2:27 PM

[XL] Change in dart/sdk[main]: Revert "CQ. Use List<Token> tokens in DottedName, using it for Librar...

Commit Queue submitted the change Change information Commit message: Revert "CQ. Use List<

unread,

[XL] Change in dart/sdk[main]: Revert "CQ. Use List<Token> tokens in DottedName, using it for Librar...

Commit Queue submitted the change Change information Commit message: Revert "CQ. Use List<

2:27 PM

Alexander Markov (Gerrit), … Daco Harkes (Gerrit)11

1:36 PM

[L] Change in dart/sdk[main]: [record_use][tfa] Moving `isBeingUsed` to `NativeCodeOracle`

Attention needed from Alexander Markov and Johnni Winther Daco Harkes added 2 comments Patchset-level

unread,

[L] Change in dart/sdk[main]: [record_use][tfa] Moving `isBeingUsed` to `NativeCodeOracle`

Attention needed from Alexander Markov and Johnni Winther Daco Harkes added 2 comments Patchset-level

1:36 PM

Daco Harkes (Gerrit), Sigmund Cherem (Gerrit)2

12:58 PM

[L] Change in dart/sdk[main]: [record_use] Support `double` constants

Attention needed from Daco Harkes Sigmund Cherem voted and added 1 comment Votes added by Sigmund

unread,

[L] Change in dart/sdk[main]: [record_use] Support `double` constants

Attention needed from Daco Harkes Sigmund Cherem voted and added 1 comment Votes added by Sigmund

12:58 PM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

12:50 PM

[M] Change in dart/sdk[main]: AD. Issue 62760. Optimize LibraryContext.remove

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[M] Change in dart/sdk[main]: AD. Issue 62760. Optimize LibraryContext.remove

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

12:50 PM

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)8

12:50 PM

[L] Change in dart/sdk[main]: DAS plugins: Add print-debugging support in Insights pages.

Samuel Rawlins voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

unread,

[L] Change in dart/sdk[main]: DAS plugins: Add print-debugging support in Insights pages.

Samuel Rawlins voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

12:50 PM

Alexander Markov (Gerrit), … Commit Queue (Gerrit)3

12:27 PM

[XS] Change in dart/sdk[main]: Reapply "Roll BoringSSL from 9a74210911fd to 6a584e1d58d1 (7 revisions)"

Commit Queue submitted the change Change information Commit message: Reapply "Roll BoringSSL

unread,

[XS] Change in dart/sdk[main]: Reapply "Roll BoringSSL from 9a74210911fd to 6a584e1d58d1 (7 revisions)"

Commit Queue submitted the change Change information Commit message: Reapply "Roll BoringSSL

12:27 PM

Konstantin Shcheglov (Gerrit), Morgan :) (Gerrit)10

12:08 PM

[S] Change in dart/sdk[main]: Optimize LibraryContext.remove.

Morgan :) abandoned this change. View Change Abandoned https://dart-review.googlesource.com/c/sdk/+/

unread,

[S] Change in dart/sdk[main]: Optimize LibraryContext.remove.

Morgan :) abandoned this change. View Change Abandoned https://dart-review.googlesource.com/c/sdk/+/

12:08 PM

Morgan :) (Gerrit), … Commit Queue (Gerrit)5

12:03 PM

[M] Change in dart/sdk[main]: AD. Collect LibraryCycle(s) to load iteratively.

Morgan :) added 2 comments Patchset-level comments File-level comment, Patchset 3 (Latest): Morgan :)

unread,

[M] Change in dart/sdk[main]: AD. Collect LibraryCycle(s) to load iteratively.

Morgan :) added 2 comments Patchset-level comments File-level comment, Patchset 3 (Latest): Morgan :)

12:03 PM

Erik Ernst (Gerrit), … Commit Queue (Gerrit)15

11:54 AM

[XL] Change in dart/sdk[main]: Take steps to support anonymous block bodies

Commit Queue submitted the change Change information Commit message: Take steps to support anonymous

unread,

[XL] Change in dart/sdk[main]: Take steps to support anonymous block bodies

Commit Queue submitted the change Change information Commit message: Take steps to support anonymous

11:54 AM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)7

11:44 AM

[L] Change in dart/sdk[main]: [analyzer] Adds warning for missng await in return in try block

Attention needed from Konstantin Shcheglov Felipe Morschel voted and added 1 comment Votes added by

unread,

[L] Change in dart/sdk[main]: [analyzer] Adds warning for missng await in return in try block

Attention needed from Konstantin Shcheglov Felipe Morschel voted and added 1 comment Votes added by

11:44 AM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

9:56 AM

[M] Change in dart/sdk[main]: Update the annotateOverrides lint for primary constructors

Commit Queue submitted the change Change information Commit message: Update the annotateOverrides

unread,

[M] Change in dart/sdk[main]: Update the annotateOverrides lint for primary constructors

Commit Queue submitted the change Change information Commit message: Update the annotateOverrides

9:56 AM

Chloe Stefantsova (Gerrit), … Alexander Markov (Gerrit)5

8:48 AM

[M] Change in dart/sdk[main]: [dart2bytecode] Visit new variables in Visitors of dart2bytecode

Alexander Markov added 1 comment File pkg/dart2bytecode/lib/local_vars.dart Line 853, Patchset 3:

unread,

[M] Change in dart/sdk[main]: [dart2bytecode] Visit new variables in Visitors of dart2bytecode

Alexander Markov added 1 comment File pkg/dart2bytecode/lib/local_vars.dart Line 853, Patchset 3:

8:48 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)5

8:42 AM

[L] Change in dart/sdk[main]: [cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionV...

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[L] Change in dart/sdk[main]: [cfe,vm,dart2bytecode] Rename Variable into BaseVariable, ExpressionV...

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

8:42 AM

Brian Wilkerson (Gerrit), … Morgan :) (Gerrit)3

8:24 AM

[S] Change in dart/sdk[main]: Issue 62870. Add shouldPumpEventQueuePeriodically flag

Attention needed from Konstantin Shcheglov and Paul Berry Morgan :) added 1 comment Patchset-level

unread,

[S] Change in dart/sdk[main]: Issue 62870. Add shouldPumpEventQueuePeriodically flag

Attention needed from Konstantin Shcheglov and Paul Berry Morgan :) added 1 comment Patchset-level

8:24 AM

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)6

6:34 AM

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 457888d41cd357469854343278e2c4202e6f1125

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 457888d41cd357469854343278e2c4202e6f1125

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

6:34 AM

Jens Johansen (Gerrit), … Commit Queue (Gerrit)5

5:43 AM

[M] Change in dart/sdk[main]: [analyzer] Replace regex in ignore_info with normal code

Commit Queue submitted the change Change information Commit message: [analyzer] Replace regex in

unread,

[M] Change in dart/sdk[main]: [analyzer] Replace regex in ignore_info with normal code

Commit Queue submitted the change Change information Commit message: [analyzer] Replace regex in

5:43 AM

Ben Konyi (Gerrit), Slava Egorov (Gerrit)2

5:37 AM

[M] Change in dart/sdk[main]: [dtd_impl] Update PID file logic to use dart_data_home logic

Attention needed from Jaime Wren Slava Egorov added 1 comment File pkg/dtd_impl/lib/src/

unread,

[M] Change in dart/sdk[main]: [dtd_impl] Update PID file logic to use dart_data_home logic

Attention needed from Jaime Wren Slava Egorov added 1 comment File pkg/dtd_impl/lib/src/

5:37 AM

Nicholas Shahan (Gerrit)

Mar 12

[XL] Change in dart/sdk[main]: hack pubspec to run tests

Attention needed from Jonas Jensen Nicholas Shahan added 7 comments Patchset-level comments File-

unread,

[XL] Change in dart/sdk[main]: hack pubspec to run tests

Attention needed from Jonas Jensen Nicholas Shahan added 7 comments Patchset-level comments File-

Mar 12

Daco Harkes (Gerrit)

Mar 12

[L] Change in dart/sdk[main]: [tfa] Moving `isBeingUsed` to `NativeCodeOracle`

Attention needed from Alexander Markov Daco Harkes added 5 comments File pkg/vm/lib/transformations/

unread,

[L] Change in dart/sdk[main]: [tfa] Moving `isBeingUsed` to `NativeCodeOracle`

Attention needed from Alexander Markov Daco Harkes added 5 comments File pkg/vm/lib/transformations/

Mar 12

Search

Clear search

Close search

Google apps

Main menu