Groups

Dart Code Reviews

1–30 of 120719

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Paul Berry (Gerrit), … Phil Quitslund (Gerrit)5

1:28 PM

[XL] Change in dart/sdk[main]: [analyzer/linter] Clean up error message comments.

Attention needed from Brian Wilkerson and Paul Berry Phil Quitslund voted Code-Review+1 Code-Review +

unread,

[XL] Change in dart/sdk[main]: [analyzer/linter] Clean up error message comments.

Attention needed from Brian Wilkerson and Paul Berry Phil Quitslund voted Code-Review+1 Code-Review +

1:28 PM

Paul Berry (Gerrit), … Phil Quitslund (Gerrit)4

1:28 PM

[S] Change in dart/sdk[main]: [analyzer] Add parameter deprecation support to api.txt.

Attention needed from Brian Wilkerson and Paul Berry Phil Quitslund voted Code-Review+1 Code-Review +

unread,

[S] Change in dart/sdk[main]: [analyzer] Add parameter deprecation support to api.txt.

Attention needed from Brian Wilkerson and Paul Berry Phil Quitslund voted Code-Review+1 Code-Review +

1:28 PM

Paul Berry (Gerrit)

8:15 AM

[M] Change in dart/sdk[main]: [analyzer] Stop using Diagnostic.data and deprecate it.

Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov New activity on the

unread,

[M] Change in dart/sdk[main]: [analyzer] Stop using Diagnostic.data and deprecate it.

Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov New activity on the

8:15 AM

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Aug 8

[S] Change in dart/sdk[main]: Fine. Make ManifestItemId comparable.

Commit Queue submitted the change Change information Commit message: Fine. Make ManifestItemId

unread,

[S] Change in dart/sdk[main]: Fine. Make ManifestItemId comparable.

Commit Queue submitted the change Change information Commit message: Fine. Make ManifestItemId

Aug 8

Bob Nystrom (Gerrit)

Aug 8

[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.

Attention needed from Alexander Thomas Bob Nystrom voted Auto-Submit +1 Commit-Queue +1 Open in

unread,

[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.

Attention needed from Alexander Thomas Bob Nystrom voted Auto-Submit +1 Commit-Queue +1 Open in

Aug 8

Mayank Patke (Gerrit), … Commit Queue (Gerrit)3

Aug 8

[M] Change in dart/sdk[main]: [js_runtime] Modernize and simplify `_AsyncRun._scheduleImmediate`.

Commit Queue submitted the change Change information Commit message: [js_runtime] Modernize and

unread,

[M] Change in dart/sdk[main]: [js_runtime] Modernize and simplify `_AsyncRun._scheduleImmediate`.

Commit Queue submitted the change Change information Commit message: [js_runtime] Modernize and

Aug 8

Alexander Markov (Gerrit)

Aug 8

[XS] Change in dart/sdk[main]: Run all tests on vm-dyn-linux-debug-x64 configuration

Attention needed from Ryan Macnak New activity on the change Open in Gerrit Related details Attention

unread,

[XS] Change in dart/sdk[main]: Run all tests on vm-dyn-linux-debug-x64 configuration

Attention needed from Ryan Macnak New activity on the change Open in Gerrit Related details Attention

Aug 8

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

Aug 8

[L] Change in dart/sdk[main]: Remove redundant firstTokenOffset nulls across fragments

Commit Queue submitted the change Change information Commit message: Remove redundant

unread,

[L] Change in dart/sdk[main]: Remove redundant firstTokenOffset nulls across fragments

Commit Queue submitted the change Change information Commit message: Remove redundant

Aug 8

Alexander Markov (Gerrit)

Aug 8

[M] Change in dart/sdk[main]: [vm,dyn_modules] Support expression evaluation using bytecode

Attention needed from Slava Egorov and Tess Strickland New activity on the change Open in Gerrit

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Support expression evaluation using bytecode

Attention needed from Slava Egorov and Tess Strickland New activity on the change Open in Gerrit

Aug 8

Paul Berry (Gerrit), Konstantin Shcheglov (Gerrit)2

Aug 8

[XL] Change in dart/sdk[main]: [analyzer/linter] Document message parameter names and types.

Attention needed from Brian Wilkerson, Johnni Winther, Paul Berry and Phil Quitslund Konstantin

unread,

[XL] Change in dart/sdk[main]: [analyzer/linter] Document message parameter names and types.

Attention needed from Brian Wilkerson, Johnni Winther, Paul Berry and Phil Quitslund Konstantin

Aug 8

Felipe Morschel (Gerrit)2

Aug 8

[S] Change in dart/sdk[main]: [analyzer] Fixes `undefined_identifier` case for static `Object` members

Attention needed from Konstantin Shcheglov Felipe Morschel added 1 comment File pkg/analyzer/lib/src/

unread,

[S] Change in dart/sdk[main]: [analyzer] Fixes `undefined_identifier` case for static `Object` members

Attention needed from Konstantin Shcheglov Felipe Morschel added 1 comment File pkg/analyzer/lib/src/

Aug 8

Derek Xu (Gerrit)

Aug 8

[XS] Change in dart/sdk[main]: [VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky

Attention needed from Ben Konyi New activity on the change Open in Gerrit Related details Attention

unread,

[XS] Change in dart/sdk[main]: [VM/Service] Tweak profile_startup_cli_flag_test to make it less flaky

Attention needed from Ben Konyi New activity on the change Open in Gerrit Related details Attention

Aug 8

Paul Berry (Gerrit), … Konstantin Shcheglov (Gerrit)4

Aug 8

[XL] Change in dart/sdk[main]: [analyzer/linter] Use structured parameter format in messages.yaml.

Attention needed from Brian Wilkerson, Johnni Winther, Paul Berry and Phil Quitslund Konstantin

unread,

[XL] Change in dart/sdk[main]: [analyzer/linter] Use structured parameter format in messages.yaml.

Attention needed from Brian Wilkerson, Johnni Winther, Paul Berry and Phil Quitslund Konstantin

Aug 8

Paul Berry (Gerrit), … Konstantin Shcheglov (Gerrit)3

Aug 8

[S] Change in dart/sdk[main]: [analyzer/linter] Prevent backsliding to the old messages.yaml format.

Attention needed from Brian Wilkerson and Paul Berry Konstantin Shcheglov voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: [analyzer/linter] Prevent backsliding to the old messages.yaml format.

Attention needed from Brian Wilkerson and Paul Berry Konstantin Shcheglov voted Code-Review+1 Code-

Aug 8

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Aug 8

[M] Change in dart/sdk[main]: Make nameOffset name more precise on Directives and remove -2 suffix ...

Commit Queue submitted the change Change information Commit message: Make nameOffset name more

unread,

[M] Change in dart/sdk[main]: Make nameOffset name more precise on Directives and remove -2 suffix ...

Commit Queue submitted the change Change information Commit message: Make nameOffset name more

Aug 8

Derek Xu (Gerrit), Commit Queue (Gerrit)2

Aug 8

[L] Change in dart/sdk[main]: [DDS] Deprecate DDS APIs related to CPU sample caching

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[L] Change in dart/sdk[main]: [DDS] Deprecate DDS APIs related to CPU sample caching

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Aug 8

Alexander Markov (Gerrit), … Commit Queue (Gerrit)4

Aug 8

[S] Change in dart/sdk[main]: [vm] Fix msvc build

Commit Queue submitted the change Change information Commit message: [vm] Fix msvc build Use standard

unread,

[S] Change in dart/sdk[main]: [vm] Fix msvc build

Commit Queue submitted the change Change information Commit message: [vm] Fix msvc build Use standard

Aug 8

Derek Xu (Gerrit), Ben Konyi (Gerrit)5

Aug 8

[L] Change in dart/sdk[main]: [DDS] Deprecate `getAvailableCachedCpuSamples` and `getCachedCpuSamples`

Derek Xu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

unread,

[L] Change in dart/sdk[main]: [DDS] Deprecate `getAvailableCachedCpuSamples` and `getCachedCpuSamples`

Derek Xu voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

Aug 8

Daco Harkes (Gerrit), … Michael Goderbauer (Gerrit)3

Aug 8

[XL] Change in dart/sdk[main]: [dartdev] `dart install`

Attention needed from Daco Harkes Michael Goderbauer added 10 comments File pkg/dartdev/lib/src/

unread,

[XL] Change in dart/sdk[main]: [dartdev] `dart install`

Attention needed from Daco Harkes Michael Goderbauer added 10 comments File pkg/dartdev/lib/src/

Aug 8

Felipe Morschel (Gerrit)2

Aug 8

[M] Change in dart/sdk[main]: [DAS] Fixes values suggestion without enum name

Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins Felipe Morschel added 1

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes values suggestion without enum name

Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins Felipe Morschel added 1

Aug 8

Moritz Sümmermann (Gerrit), … Lasse Nielsen (Gerrit)4

Aug 8

[M] Change in dart/sdk[main]: Add signature to target kind

Attention needed from Moritz Sümmermann and Samuel Rawlins Lasse Nielsen added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: Add signature to target kind

Attention needed from Moritz Sümmermann and Samuel Rawlins Lasse Nielsen added 1 comment File pkg/

Aug 8

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Aug 8

[M] Change in dart/sdk[main]: [cfe] Cleanup status files (though not messages)

Commit Queue submitted the change Change information Commit message: [cfe] Cleanup status files (

unread,

[M] Change in dart/sdk[main]: [cfe] Cleanup status files (though not messages)

Commit Queue submitted the change Change information Commit message: [cfe] Cleanup status files (

Aug 8

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Aug 8

[M] Change in dart/sdk[main]: [CFE] Strong_suite fuzzing wraps in part; Fix crashes because of wron...

Commit Queue submitted the change Change information Commit message: [CFE] Strong_suite fuzzing wraps

unread,

[M] Change in dart/sdk[main]: [CFE] Strong_suite fuzzing wraps in part; Fix crashes because of wron...

Commit Queue submitted the change Change information Commit message: [CFE] Strong_suite fuzzing wraps

Aug 8

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)22

Aug 8

[L] Change in dart/sdk[main]: [DAS] Adds some warnings for the `analysis_options` file

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Samuel Rawlins Felipe Morschel voted

unread,

[L] Change in dart/sdk[main]: [DAS] Adds some warnings for the `analysis_options` file

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Samuel Rawlins Felipe Morschel voted

Aug 8

Erik Ernst (Gerrit), Sergey Grekhov (Gerrit)3

Aug 8

[S] Change in dart/sdk[main]: [co19] Roll co19 to 46c52754a2033f5127f01ea4e0df0e8a3f934cb6

Attention needed from Alexander Thomas and Erik Ernst Sergey Grekhov added 1 comment Patchset-level

unread,

[S] Change in dart/sdk[main]: [co19] Roll co19 to 46c52754a2033f5127f01ea4e0df0e8a3f934cb6

Attention needed from Alexander Thomas and Erik Ernst Sergey Grekhov added 1 comment Patchset-level

Aug 8

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)8

Aug 7

[L] Change in dart/sdk[main]: Analyzer warnings: add support for @Deprecation.subclass

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[L] Change in dart/sdk[main]: Analyzer warnings: add support for @Deprecation.subclass

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Aug 7

Devon Carew (Gerrit), … Commit Queue (Gerrit)3

Aug 7

[S] Change in dart/sdk[main]: [deps] rev dartdoc, ecosystem, i18n, shelf, tools, web, webdev

Commit Queue submitted the change Change information Commit message: [deps] rev dartdoc, ecosystem,

unread,

[S] Change in dart/sdk[main]: [deps] rev dartdoc, ecosystem, i18n, shelf, tools, web, webdev

Commit Queue submitted the change Change information Commit message: [deps] rev dartdoc, ecosystem,

Aug 7

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)6

Aug 7

[XL] Change in dart/sdk[main]: [DAS] Differentiates tearoff fixes from invocation fixes for methods ...

Commit Queue submitted the change Change information Commit message: [DAS] Differentiates tearoff

unread,

[XL] Change in dart/sdk[main]: [DAS] Differentiates tearoff fixes from invocation fixes for methods ...

Commit Queue submitted the change Change information Commit message: [DAS] Differentiates tearoff

Aug 7

Brian Wilkerson (Gerrit), Samuel Rawlins (Gerrit)2

Aug 7

[L] Change in dart/sdk[main]: Add documentation for several additional warnings

Attention needed from Brian Wilkerson Samuel Rawlins voted and added 2 comments Votes added by Samuel

unread,

[L] Change in dart/sdk[main]: Add documentation for several additional warnings

Attention needed from Brian Wilkerson Samuel Rawlins voted and added 2 comments Votes added by Samuel

Aug 7

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)8

Aug 7

[XS] Change in dart/sdk[main]: Prepare to publish analyzer 8.1.0 and _fe_analyzer_shared 87.0.0

Commit Queue submitted the change Change information Commit message: Prepare to publish analyzer 8.1.

unread,

[XS] Change in dart/sdk[main]: Prepare to publish analyzer 8.1.0 and _fe_analyzer_shared 87.0.0

Commit Queue submitted the change Change information Commit message: Prepare to publish analyzer 8.1.

Aug 7

Search

Clear search

Close search

Google apps

Main menu