Groups

Dart Code Reviews

1–30 of 123124

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)9

12:17 PM

[XS] Change in dart/sdk[main]: [co19] Roll co19 to ac779cf0ef7215bc226d00af16f31fe35b1850f5

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to ac779cf0ef7215bc226d00af16f31fe35b1850f5

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

12:17 PM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)2

10:32 AM

[M] Change in dart/sdk[main]: [DAS] Fixes some `Replace 'final' with 'var'` false-negatives

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes some `Replace 'final' with 'var'` false-negatives

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-

10:32 AM

Parker Lougheed (Gerrit), Sigurd Meldgaard (Gerrit)3

10:22 AM

[S] Change in dart/sdk[main]: [dartdev] Update and fix a few links in tool output and comments

Attention needed from Ben Konyi and Parker Lougheed Sigurd Meldgaard added 1 comment Patchset-level

unread,

[S] Change in dart/sdk[main]: [dartdev] Update and fix a few links in tool output and comments

Attention needed from Ben Konyi and Parker Lougheed Sigurd Meldgaard added 1 comment Patchset-level

10:22 AM

Daco Harkes (Gerrit), … Commit Queue (Gerrit)12

10:19 AM

[L] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Attention needed from Michael Goderbauer and Nate Biggs Daco Harkes voted Auto-Submit+1 Auto-Submit +

unread,

[L] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Attention needed from Michael Goderbauer and Nate Biggs Daco Harkes voted Auto-Submit+1 Auto-Submit +

10:19 AM

Sigmund Cherem (Gerrit), … Commit Queue (Gerrit)4

9:57 AM

[M] Change in dart/sdk[main]: [dart2bytecode] Add test for prefixed duplicate libraries

Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

unread,

[M] Change in dart/sdk[main]: [dart2bytecode] Add test for prefixed duplicate libraries

Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

9:57 AM

Martin Kustermann (Gerrit)

8:22 AM

[S] Change in dart/sdk[main]: [dart2wasm] Fix issue of copying mixin applications with deferred pre...

Attention needed from Nate Biggs Martin Kustermann voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix issue of copying mixin applications with deferred pre...

Attention needed from Nate Biggs Martin Kustermann voted Commit-Queue+1 Commit-Queue +1 Open in

8:22 AM

Lasse Nielsen (Gerrit), … Johnni Winther (Gerrit)3

4:14 AM

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `pkg/`.

Attention needed from Lasse Nielsen, Mayank Patke and Ryan Macnak Johnni Winther voted and added 3

unread,

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `pkg/`.

Attention needed from Lasse Nielsen, Mayank Patke and Ryan Macnak Johnni Winther voted and added 3

4:14 AM

Erik Ernst (Gerrit)2

3:36 AM

[L] Change in dart/sdk[main]: Implement analyzer support for `=>` anonymous methods

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry Erik Ernst added 1 comment

unread,

[L] Change in dart/sdk[main]: Implement analyzer support for `=>` anonymous methods

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry Erik Ernst added 1 comment

3:36 AM

Konstantin Shcheglov (Gerrit)

Feb 15

[S] Change in dart/sdk[main]: PP. Run do-nothing RecursiveAstVisitor 100 times on every file.

Konstantin Shcheglov voted Code-Review-1 Code-Review -1 Open in Gerrit Related details Attention set

unread,

[S] Change in dart/sdk[main]: PP. Run do-nothing RecursiveAstVisitor 100 times on every file.

Konstantin Shcheglov voted Code-Review-1 Code-Review -1 Open in Gerrit Related details Attention set

Feb 15

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Feb 15

[L] Change in dart/sdk[main]: CQ. Use _withScope / _withTypeParameterScope in ReferenceResolver.

Commit Queue submitted the change Change information Commit message: CQ. Use _withScope /

unread,

[L] Change in dart/sdk[main]: CQ. Use _withScope / _withTypeParameterScope in ReferenceResolver.

Commit Queue submitted the change Change information Commit message: CQ. Use _withScope /

Feb 15

Konstantin Shcheglov (Gerrit)

Feb 14

[M] Change in dart/sdk[main]: linter: Support primary constructors in sort{,_unnamed}_constructors_...

Attention needed from Brian Wilkerson and Samuel Rawlins Konstantin Shcheglov voted and added 2

unread,

[M] Change in dart/sdk[main]: linter: Support primary constructors in sort{,_unnamed}_constructors_...

Attention needed from Brian Wilkerson and Samuel Rawlins Konstantin Shcheglov voted and added 2

Feb 14

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

Feb 14

[M] Change in dart/sdk[main]: linter: Support primary constructors in always_specify_types

Commit Queue submitted the change Change information Commit message: linter: Support primary

unread,

[M] Change in dart/sdk[main]: linter: Support primary constructors in always_specify_types

Commit Queue submitted the change Change information Commit message: linter: Support primary

Feb 14

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Feb 14

[L] Change in dart/sdk[main]: CQ. Use dedicated scopes in ResolutionVisitor

Commit Queue submitted the change Change information Commit message: CQ. Use dedicated scopes in

unread,

[L] Change in dart/sdk[main]: CQ. Use dedicated scopes in ResolutionVisitor

Commit Queue submitted the change Change information Commit message: CQ. Use dedicated scopes in

Feb 14

Elliott Brooks (Gerrit), Samuel Rawlins (Gerrit)3

Feb 14

[XS] Change in dart/sdk[beta]: [beta] Cherry-pick DevTools 2.55.0

Attention needed from Elliott Brooks and Kenzie Davisson Samuel Rawlins voted Code-Review+1 Code-

unread,

[XS] Change in dart/sdk[beta]: [beta] Cherry-pick DevTools 2.55.0

Attention needed from Elliott Brooks and Kenzie Davisson Samuel Rawlins voted Code-Review+1 Code-

Feb 14

Sigmund Cherem (Gerrit)

Feb 13

[S] Change in dart/sdk[main]: [dyn_modules] add snapshot target for faster iteration.

Attention needed from Alexander Markov Sigmund Cherem voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[S] Change in dart/sdk[main]: [dyn_modules] add snapshot target for faster iteration.

Attention needed from Alexander Markov Sigmund Cherem voted Commit-Queue+1 Commit-Queue +1 Open in

Feb 13

Sigmund Cherem (Gerrit)

Feb 13

[S] Change in dart/sdk[main]: [dyn_modules] allow extension_type key in dynamic interface.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [dyn_modules] allow extension_type key in dynamic interface.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

Feb 13

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)6

Feb 13

[M] Change in dart/sdk[main]: [analysis_server_plugin] Fixes non-`LintCode` fixes showing up for users

Commit Queue submitted the change Change information Commit message: [analysis_server_plugin] Fixes

unread,

[M] Change in dart/sdk[main]: [analysis_server_plugin] Fixes non-`LintCode` fixes showing up for users

Commit Queue submitted the change Change information Commit message: [analysis_server_plugin] Fixes

Feb 13

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)11

Feb 13

[M] Change in dart/sdk[main]: [linter, DAS] Makes `use_null_aware_elements` to report on cascade el...

Attention needed from Brian Wilkerson and Nate Biggs Felipe Morschel added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: [linter, DAS] Makes `use_null_aware_elements` to report on cascade el...

Attention needed from Brian Wilkerson and Nate Biggs Felipe Morschel added 1 comment File pkg/

Feb 13

Bob Nystrom (Gerrit), Brian Wilkerson (Gerrit)2

Feb 13

[M] Change in dart/sdk[main]: Enable "private-named-parameters" experiment flag.

Attention needed from Bob Nystrom, Morgan :) and Ryan Macnak Brian Wilkerson voted and added 1

unread,

[M] Change in dart/sdk[main]: Enable "private-named-parameters" experiment flag.

Attention needed from Bob Nystrom, Morgan :) and Ryan Macnak Brian Wilkerson voted and added 1

Feb 13

Elliott Brooks (Gerrit), … Commit Queue (Gerrit)4

Feb 13

[XS] Change in dart/sdk[main]: Update DevTools rev to 0a0cf24dcd589e9436e266d09b6ababa09b8c70e

Commit Queue submitted the change Change information Commit message: Update DevTools rev to

unread,

[XS] Change in dart/sdk[main]: Update DevTools rev to 0a0cf24dcd589e9436e266d09b6ababa09b8c70e

Commit Queue submitted the change Change information Commit message: Update DevTools rev to

Feb 13

Martin Kustermann (Gerrit), … Commit Queue (Gerrit)5

Feb 13

[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in handling of forwarding stubs to fields

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix bug in handling

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in handling of forwarding stubs to fields

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix bug in handling

Feb 13

Ömer Ağacan (Gerrit), … Martin Kustermann (Gerrit)12

Feb 13

[L] Change in dart/sdk[main]: [dart2wasm] Update JS exception catching

Attention needed from Nate Biggs, Srujan Gaddam and Ömer Ağacan Martin Kustermann voted and added 1

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Update JS exception catching

Attention needed from Nate Biggs, Srujan Gaddam and Ömer Ağacan Martin Kustermann voted and added 1

Feb 13

Kevin Moore (Gerrit), Nate Bosch (Gerrit)2

Feb 13

[M] Change in dart/sdk[main]: Update docs/External-Package-Maintenance.md

Attention needed from Kevin Moore Nate Bosch added 1 comment Patchset-level comments File-level

unread,

[M] Change in dart/sdk[main]: Update docs/External-Package-Maintenance.md

Attention needed from Kevin Moore Nate Bosch added 1 comment Patchset-level comments File-level

Feb 13

Nate Bosch (Gerrit)

Feb 13

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `test/`.

Attention needed from Lasse Nielsen Nate Bosch voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `test/`.

Attention needed from Lasse Nielsen Nate Bosch voted Code-Review+1 Code-Review +1 Open in Gerrit

Feb 13

Lasse Nielsen (Gerrit)

Feb 13

[L] Change in dart/sdk[main]: Remove all occurrences of `var`/`final` parameters in `sdk/` and `too...

Lasse Nielsen abandoned this change. View Change Abandoned Lasse Nielsen abandoned this change

unread,

[L] Change in dart/sdk[main]: Remove all occurrences of `var`/`final` parameters in `sdk/` and `too...

Lasse Nielsen abandoned this change. View Change Abandoned Lasse Nielsen abandoned this change

Feb 13

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Feb 13

[M] Change in dart/sdk[main]: CQ. Give TypeParameterScope the enclosing library FeatureSet.

Commit Queue submitted the change Change information Commit message: CQ. Give TypeParameterScope the

unread,

[M] Change in dart/sdk[main]: CQ. Give TypeParameterScope the enclosing library FeatureSet.

Commit Queue submitted the change Change information Commit message: CQ. Give TypeParameterScope the

Feb 13

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Feb 13

[M] Change in dart/sdk[main]: CQ. Use InstanceScope / ExtensionScope instead of manual _defineEleme...

Commit Queue submitted the change Change information Commit message: CQ. Use InstanceScope /

unread,

[M] Change in dart/sdk[main]: CQ. Use InstanceScope / ExtensionScope instead of manual _defineEleme...

Commit Queue submitted the change Change information Commit message: CQ. Use InstanceScope /

Feb 13

Ömer Ağacan (Gerrit), Nate Biggs (Gerrit)10

Feb 13

[M] Change in dart/sdk[main]: [dart2wasm] Generate relative file paths in source map sources section

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs added 1 comment File pkg/dart2wasm

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Generate relative file paths in source map sources section

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs added 1 comment File pkg/dart2wasm

Feb 13

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)5

Feb 13

[M] Change in dart/sdk[main]: DeCo. Report assignmentToPrimaryConstructorParameter.

Commit Queue submitted the change Change information Commit message: DeCo. Report

unread,

[M] Change in dart/sdk[main]: DeCo. Report assignmentToPrimaryConstructorParameter.

Commit Queue submitted the change Change information Commit message: DeCo. Report

Feb 13

Johnni Winther (Gerrit), … Erik Ernst (Gerrit)15

Feb 13

[L] Change in dart/sdk[main]: CQ. Start using InstanceScope in ResolutionVisitor, a little.

Erik Ernst added 2 comments Patchset-level comments File-level comment, Patchset 2: Johnni Winther .

unread,

[L] Change in dart/sdk[main]: CQ. Start using InstanceScope in ResolutionVisitor, a little.

Erik Ernst added 2 comments Patchset-level comments File-level comment, Patchset 2: Johnni Winther .

Feb 13

Search

Clear search

Close search

Google apps

Main menu