Groups

Dart Code Reviews

1–30 of 122532

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)2

12:17 PM

[L] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completions when feature is disabled

Attention needed from Felipe Morschel and Kallen Tu Samuel Rawlins voted and added 1 comment Votes

unread,

[L] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completions when feature is disabled

Attention needed from Felipe Morschel and Kallen Tu Samuel Rawlins voted and added 1 comment Votes

12:17 PM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)3

Jan 9

[M] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completion for if case and `&&`/`||` operators

Attention needed from Keerti Parthasarathy and Samuel Rawlins Felipe Morschel voted and added 1

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes dot shorthand completion for if case and `&&`/`||` operators

Attention needed from Keerti Parthasarathy and Samuel Rawlins Felipe Morschel voted and added 1

Jan 9

Simon Binder (Gerrit), Martin Kustermann (Gerrit)9

Jan 9

[XL] Change in dart/sdk[main]: [dart2wasm] Interfaces for accessing memories

Attention needed from Martin Kustermann Simon Binder added 18 comments File pkg/dart2wasm/lib/

unread,

[XL] Change in dart/sdk[main]: [dart2wasm] Interfaces for accessing memories

Attention needed from Martin Kustermann Simon Binder added 18 comments File pkg/dart2wasm/lib/

Jan 9

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Jan 9

[M] Change in dart/sdk[main]: DeCo. Support for primary initializer scope in fine manifests.

Commit Queue submitted the change Change information Commit message: DeCo. Support for primary

unread,

[M] Change in dart/sdk[main]: DeCo. Support for primary initializer scope in fine manifests.

Commit Queue submitted the change Change information Commit message: DeCo. Support for primary

Jan 9

Bob Nystrom (Gerrit), … Brian Wilkerson (Gerrit)5

Jan 9

[L] Change in dart/sdk[main]: Clean up the prefer_initializing_formals lint.

Bob Nystrom voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

unread,

[L] Change in dart/sdk[main]: Clean up the prefer_initializing_formals lint.

Bob Nystrom voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

Jan 9

Alexander Markov (Gerrit)

Jan 9

[XL] Change in dart/sdk[main]: Initial implementation of lowering and codegen block order

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XL] Change in dart/sdk[main]: Initial implementation of lowering and codegen block order

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jan 9

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)5

Jan 9

[XS] Change in dart/sdk[main]: DAS plugins: Bump to 0.3.6 with fix

Commit Queue submitted the change Change information Commit message: DAS plugins: Bump to 0.3.6 with

unread,

[XS] Change in dart/sdk[main]: DAS plugins: Bump to 0.3.6 with fix

Commit Queue submitted the change Change information Commit message: DAS plugins: Bump to 0.3.6 with

Jan 9

Daco Harkes (Gerrit), … Commit Queue (Gerrit)6

Jan 9

[L] Change in dart/sdk[main]: [dart2js] Remove `@pragma('dart2js:resource-identifier')`

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[L] Change in dart/sdk[main]: [dart2js] Remove `@pragma('dart2js:resource-identifier')`

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Jan 9

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Jan 9

[S] Change in dart/sdk[main]: DAS: Use a shared mock in plugin_watcher_test

Commit Queue submitted the change Change information Commit message: DAS: Use a shared mock in

unread,

[S] Change in dart/sdk[main]: DAS: Use a shared mock in plugin_watcher_test

Commit Queue submitted the change Change information Commit message: DAS: Use a shared mock in

Jan 9

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Jan 9

[S] Change in dart/sdk[main]: DAS: Use a shared mock in analytics_manager_test

Commit Queue submitted the change Change information Commit message: DAS: Use a shared mock in

unread,

[S] Change in dart/sdk[main]: DAS: Use a shared mock in analytics_manager_test

Commit Queue submitted the change Change information Commit message: DAS: Use a shared mock in

Jan 9

Keerti Parthasarathy (Gerrit), … Commit Queue (Gerrit)4

Jan 9

[M] Change in dart/sdk[main]: Add a few more Flutter use cases for data driven fixes.

Commit Queue submitted the change Change information Commit message: Add a few more Flutter use cases

unread,

[M] Change in dart/sdk[main]: Add a few more Flutter use cases for data driven fixes.

Commit Queue submitted the change Change information Commit message: Add a few more Flutter use cases

Jan 9

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

Jan 9

[M] Change in dart/sdk[main]: linter: Refactor ASCII utils file

Commit Queue submitted the change Change information Commit message: linter: Refactor ASCII utils

unread,

[M] Change in dart/sdk[main]: linter: Refactor ASCII utils file

Commit Queue submitted the change Change information Commit message: linter: Refactor ASCII utils

Jan 9

Brian Wilkerson (Gerrit), Jake Macdonald (Gerrit)5

Jan 9

[M] Change in dart/sdk[main]: Capture workspace and file status in the log

Attention needed from Brian Wilkerson Jake Macdonald voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: Capture workspace and file status in the log

Attention needed from Brian Wilkerson Jake Macdonald voted Code-Review+1 Code-Review +1 Open in

Jan 9

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)7

Jan 9

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev voted and added 4 comments Votes added by

unread,

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev voted and added 4 comments Votes added by

Jan 9

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)8

Jan 9

[M] Change in dart/sdk[main]: [DAS Plugins] Fixes diagnostic messages not showing for plugins

Commit Queue submitted the change Change information Commit message: [DAS Plugins] Fixes diagnostic

unread,

[M] Change in dart/sdk[main]: [DAS Plugins] Fixes diagnostic messages not showing for plugins

Commit Queue submitted the change Change information Commit message: [DAS Plugins] Fixes diagnostic

Jan 9

Alexander Markov (Gerrit)

Jan 9

[XL] Change in dart/sdk[main]: [cfg] Support more operations in CFG IR and AST-to-CFG translation

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XL] Change in dart/sdk[main]: [cfg] Support more operations in CFG IR and AST-to-CFG translation

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jan 9

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)2

Jan 9

[M] Change in dart/sdk[main]: Add a --no-plugins option to prevent analyzer plugins from running

Attention needed from Daco Harkes and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review

unread,

[M] Change in dart/sdk[main]: Add a --no-plugins option to prevent analyzer plugins from running

Attention needed from Daco Harkes and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review

Jan 9

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

Jan 9

[M] Change in dart/sdk[main]: linter: Refactor flutter utils

Commit Queue submitted the change Change information Commit message: linter: Refactor flutter utils

unread,

[M] Change in dart/sdk[main]: linter: Refactor flutter utils

Commit Queue submitted the change Change information Commit message: linter: Refactor flutter utils

Jan 9

Slava Egorov (Gerrit), … Commit Queue (Gerrit)3

Jan 9

[L] Change in dart/sdk[main]: [vm/unsendable] Fix field handling in finding retaining path for unse...

Commit Queue submitted the change Change information Commit message: [vm/unsendable] Fix field

unread,

[L] Change in dart/sdk[main]: [vm/unsendable] Fix field handling in finding retaining path for unse...

Commit Queue submitted the change Change information Commit message: [vm/unsendable] Fix field

Jan 9

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)8

Jan 9

[M] Change in dart/sdk[main]: Add documentation for the principle of consistency

Commit Queue submitted the change Change information Commit message: Add documentation for the

unread,

[M] Change in dart/sdk[main]: Add documentation for the principle of consistency

Commit Queue submitted the change Change information Commit message: Add documentation for the

Jan 9

Johnni Winther (Gerrit), … Commit Queue (Gerrit)4

Jan 9

[M] Change in dart/sdk[main]: [cfe][PrivateNamedParameters] Share code for checking public name

Commit Queue submitted the change Change information Commit message: [cfe][PrivateNamedParameters]

unread,

[M] Change in dart/sdk[main]: [cfe][PrivateNamedParameters] Share code for checking public name

Commit Queue submitted the change Change information Commit message: [cfe][PrivateNamedParameters]

Jan 9

Ömer Ağacan (Gerrit), Martin Kustermann (Gerrit)18

Jan 9

[M] Change in dart/sdk[main]: [dart2wasm] Fix dummy initializations of cyclic types

Attention needed from Martin Kustermann Ömer Ağacan added 1 comment File pkg/dart2wasm/lib/

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Fix dummy initializations of cyclic types

Attention needed from Martin Kustermann Ömer Ağacan added 1 comment File pkg/dart2wasm/lib/

Jan 9

Johnni Winther (Gerrit), … Commit Queue (Gerrit)4

Jan 9

[L] Change in dart/sdk[main]: [cfe][PrimaryConstructor] Refactor handling of formals in body builder

Commit Queue submitted the change Change information Commit message: [cfe][PrimaryConstructor]

unread,

[L] Change in dart/sdk[main]: [cfe][PrimaryConstructor] Refactor handling of formals in body builder

Commit Queue submitted the change Change information Commit message: [cfe][PrimaryConstructor]

Jan 9

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)5

Jan 9

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 379503dac3a560fa1651d50d2920ab77f01e3d3a

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 379503dac3a560fa1651d50d2920ab77f01e3d3a

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

Jan 9

Ömer Ağacan (Gerrit), Martin Kustermann (Gerrit)6

Jan 9

[S] Change in dart/sdk[main]: [dart2wasm] Use `JSStringImpl` class for string value types

Ömer Ağacan abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Use `JSStringImpl` class for string value types

Ömer Ağacan abandoned this change Related details Attention set is empty Submit Requirements: Code-

Jan 9

Sergey Grekhov (Gerrit), Erik Ernst (Gerrit)3

Jan 9

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 48717bdfb2a4b2f191892610c2cc5bdb24635462

Sergey Grekhov abandoned this change Related details Attention set is empty Submit Requirements: Code

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 48717bdfb2a4b2f191892610c2cc5bdb24635462

Sergey Grekhov abandoned this change Related details Attention set is empty Submit Requirements: Code

Jan 9

Jonas Jensen (Gerrit), Samuel Rawlins (Gerrit)3

Jan 9

[S] Change in dart/sdk[main]: Ignore internal errors in YamlEditor

Attention needed from Samuel Rawlins Jonas Jensen voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit

unread,

[S] Change in dart/sdk[main]: Ignore internal errors in YamlEditor

Attention needed from Samuel Rawlins Jonas Jensen voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit

Jan 9

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)7

Jan 8

[XL] Change in dart/sdk[main]: DeCo. Use primary initializer scope for field initializers.

Commit Queue submitted the change Change information Commit message: DeCo. Use primary initializer

unread,

[XL] Change in dart/sdk[main]: DeCo. Use primary initializer scope for field initializers.

Commit Queue submitted the change Change information Commit message: DeCo. Use primary initializer

Jan 8

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Jan 8

[S] Change in dart/sdk[main]: CQ. Use DiagnosticReporter in UnusedLocalElementsVerifier.

Commit Queue submitted the change Change information Commit message: CQ. Use DiagnosticReporter in

unread,

[S] Change in dart/sdk[main]: CQ. Use DiagnosticReporter in UnusedLocalElementsVerifier.

Commit Queue submitted the change Change information Commit message: CQ. Use DiagnosticReporter in

Jan 8

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Jan 8

[S] Change in dart/sdk[main]: DeCo. Get primary constructor documentation comment from PrimaryConst...

Commit Queue submitted the change Change information Commit message: DeCo. Get primary constructor

unread,

[S] Change in dart/sdk[main]: DeCo. Get primary constructor documentation comment from PrimaryConst...

Commit Queue submitted the change Change information Commit message: DeCo. Get primary constructor

Jan 8

Search

Clear search

Close search

Google apps

Main menu