Dart Code Reviews - Google Groups

Groups

1–30 of 125767

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Alexander Aprelev (Gerrit), Ryan Macnak (Gerrit)3

6:18 PM

[XS] Change in dart/sdk[main]: [gardening] Skip http_request_pipelining_test on Fuchsia.

Ryan Macnak submitted the change Change information Commit message: [gardening] Skip

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip http_request_pipelining_test on Fuchsia.

Ryan Macnak submitted the change Change information Commit message: [gardening] Skip

6:18 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

6:12 PM

[XS] Change in dart/sdk[main]: [gardening] Skip least_and_greatest_closure_A09_t01 on AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip least_and_greatest_closure_A09_t01 on AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

6:12 PM

Arnav Arora (Gerrit), Srujan Gaddam (Gerrit)5

6:04 PM

[S] Change in dart/sdk[main]: [dart:js_interop] Support extension types on generic type parameters

Attention needed from Nate Biggs and Srujan Gaddam Arnav Arora voted and added 3 comments Votes added

unread,

[S] Change in dart/sdk[main]: [dart:js_interop] Support extension types on generic type parameters

Attention needed from Nate Biggs and Srujan Gaddam Arnav Arora voted and added 3 comments Votes added

6:04 PM

Paul Berry (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

6:01 PM

[XL] Change in dart/sdk[main]: AST. Implement DirectAssignment and UnqualifiedNameAssignmentTarget.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: AST. Implement DirectAssignment and UnqualifiedNameAssignmentTarget.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

6:01 PM

Ryan Macnak (Gerrit)

6:01 PM

[S] Change in dart/sdk[main]: [build] Update sysroot to Jammy.

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [build] Update sysroot to Jammy.

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

6:01 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:49 PM

[M] Change in dart/sdk[main]: [modular_aot] _List default factory constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [modular_aot] _List default factory constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:49 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:49 PM

[S] Change in dart/sdk[main]: [vm, arm64] Don't generate push sp.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [vm, arm64] Don't generate push sp.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:49 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:41 PM

[L] Change in dart/sdk[main]: [modular_aot] Typed data factory constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [modular_aot] Typed data factory constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:41 PM

Konstantin Shcheglov (Gerrit), … Paul Berry (Gerrit)4

5:35 PM

[S] Change in dart/sdk[main]: Issue 63972. Fix recovery when missing class body after primary const...

Attention needed from Brian Wilkerson Konstantin Shcheglov voted Commit-Queue+2 Commit-Queue +2 Open

unread,

[S] Change in dart/sdk[main]: Issue 63972. Fix recovery when missing class body after primary const...

Attention needed from Brian Wilkerson Konstantin Shcheglov voted Commit-Queue+2 Commit-Queue +2 Open

5:35 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:20 PM

[M] Change in dart/sdk[main]: Enable recommended lints when verifying diagnostic documentation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Enable recommended lints when verifying diagnostic documentation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:20 PM

FMorschel (Gerrit), Brian Wilkerson (Gerrit)3

5:07 PM

[S] Change in dart/sdk[main]: [DAS] Bump tools and fix linter rules completion case

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[S] Change in dart/sdk[main]: [DAS] Bump tools and fix linter rules completion case

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

5:07 PM

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)16

5:05 PM

[L] Change in dart/sdk[main]: [DAS] Adds more information to type parameter hovers

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[L] Change in dart/sdk[main]: [DAS] Adds more information to type parameter hovers

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

5:05 PM

Keerti Parthasarathy (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:07 PM

[M] Change in dart/sdk[main]: Look at export statements too for replaceBy transform

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Look at export statements too for replaceBy transform

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:07 PM

Kallen Tu (Gerrit), Brian Wilkerson (Gerrit)2

4:07 PM

[M] Change in dart/sdk[main]: [dartdev][migrate] Allow multiple target packages.

Attention needed from Kallen Tu Brian Wilkerson voted and added 1 comment Votes added by Brian

unread,

[M] Change in dart/sdk[main]: [dartdev][migrate] Allow multiple target packages.

Attention needed from Kallen Tu Brian Wilkerson voted and added 1 comment Votes added by Brian

4:07 PM

Ryan Macnak (Gerrit)

3:56 PM

[M] Change in dart/sdk[main]: [vm, arm64e] Authenticate pointers for image header access.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm, arm64e] Authenticate pointers for image header access.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

3:56 PM

Ben Konyi (Gerrit), … Mark Zhou (Gerrit)6

2:46 PM

[S] Change in dart/sdk[main]: [Service] dap_adapters: Add LICENSE and rename main library

Ben Konyi submitted the change Change information Commit message: [Service] dap_adapters: Add LICENSE

unread,

[S] Change in dart/sdk[main]: [Service] dap_adapters: Add LICENSE and rename main library

Ben Konyi submitted the change Change information Commit message: [Service] dap_adapters: Add LICENSE

2:46 PM

Ben Konyi (Gerrit), Helin Shiah (Gerrit)5

2:45 PM

[XL] Change in dart/sdk[main]: [vm/service] Remove Java implementation and code generator

Ben Konyi submitted the change Change information Commit message: [vm/service] Remove Java

unread,

[XL] Change in dart/sdk[main]: [vm/service] Remove Java implementation and code generator

Ben Konyi submitted the change Change information Commit message: [vm/service] Remove Java

2:45 PM

Daco Harkes (Gerrit), Ryan Macnak (Gerrit)2

2:21 PM

[XL] Change in dart/sdk[main]: [vm/service]: Add _getFfiStructLayout RPC for FFI struct field layout

Attention needed from Ben Konyi and Nourhan Hasan Ryan Macnak added 1 comment Patchset-level comments

unread,

[XL] Change in dart/sdk[main]: [vm/service]: Add _getFfiStructLayout RPC for FFI struct field layout

Attention needed from Ben Konyi and Nourhan Hasan Ryan Macnak added 1 comment Patchset-level comments

2:21 PM

FMorschel (Gerrit), … Brian Wilkerson (Gerrit)8

2:21 PM

[M] Change in dart/sdk[main]: [DAS] Adds `Remove async` fix for `async_return_with_no_await`

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[M] Change in dart/sdk[main]: [DAS] Adds `Remove async` fix for `async_return_with_no_await`

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

2:21 PM

Martin Kustermann (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

2:11 PM

[XS] Change in dart/sdk[main]: [wasm] add sra@ as owner

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [wasm] add sra@ as owner

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:11 PM

FMorschel (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

1:55 PM

[M] Change in dart/sdk[main]: [DAS] Fixes primary constructor body completion

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes primary constructor body completion

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:55 PM

Modestas Valauskas (Gerrit)

1:52 PM

[M] Change in dart/sdk[main]: [typed_data] Add Int32x4.splat constructor

Attention needed from Lasse Nielsen and Martin Kustermann Modestas Valauskas voted and added 1

unread,

[M] Change in dart/sdk[main]: [typed_data] Add Int32x4.splat constructor

Attention needed from Lasse Nielsen and Martin Kustermann Modestas Valauskas voted and added 1

1:52 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:51 PM

[S] Change in dart/sdk[main]: [analysis_server] Update comments explaining placeholders outside of ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [analysis_server] Update comments explaining placeholders outside of ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:51 PM

FMorschel (Gerrit), Brian Wilkerson (Gerrit)4

1:37 PM

[XL] Change in dart/sdk[main]: [DAS] Adds completion option for some shadowed names

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[XL] Change in dart/sdk[main]: [DAS] Adds completion option for some shadowed names

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

1:37 PM

Ryan Macnak (Gerrit)

1:26 PM

[XS] Change in dart/sdk[main]: Skip http_request_pipelining_test on Fuchsia.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

unread,

[XS] Change in dart/sdk[main]: Skip http_request_pipelining_test on Fuchsia.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

1:26 PM

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:22 PM

[M] Change in dart/sdk[main]: [migrate] Add tool tip to use apply after a dry run.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [migrate] Add tool tip to use apply after a dry run.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:22 PM

FMorschel (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)10

12:42 PM

[L] Change in dart/sdk[main]: [DAS, linter] Fixes `no_leading_underscores` fixes when shadowing

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [DAS, linter] Fixes `no_leading_underscores` fixes when shadowing

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:42 PM

Ivan Inozemtsev (Gerrit), Alexander Markov (Gerrit)3

12:23 PM

[XS] Change in dart/sdk[main]: Fix DART_TARGET_OS_WINDOWS define

Attention needed from Alexander Markov Ivan Inozemtsev voted Commit-Queue+2 Commit-Queue +2 Open in

unread,

[XS] Change in dart/sdk[main]: Fix DART_TARGET_OS_WINDOWS define

Attention needed from Alexander Markov Ivan Inozemtsev voted Commit-Queue+2 Commit-Queue +2 Open in

12:23 PM

Nate Bosch (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

12:06 PM

[XS] Change in dart/sdk[main]: Bump test to 4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Bump test to 4838365e7fb3a2d0302cdbbd8330b7884f7d3c0d

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:06 PM

Ben Konyi (Gerrit), … Nicholas Shahan (Gerrit)5

12:04 PM

[L] Change in dart/sdk[main]: Reland "[security] Harden Host and Origin checks across VM Service, D...

Attention needed from Mark Zhou and Nicholas Shahan Ben Konyi voted and added 13 comments Votes added

unread,

[L] Change in dart/sdk[main]: Reland "[security] Harden Host and Origin checks across VM Service, D...

Attention needed from Mark Zhou and Nicholas Shahan Ben Konyi voted and added 13 comments Votes added

12:04 PM

Search

Clear search

Close search

Google apps

Main menu