Dart Code Reviews

1–30 of 109377

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit)2

4:09 PM

[XS] Change in dart/sdk[main]: [build] Don't export API symbols in gen_snapshot.

Attention is currently required from: Daco Harkes. View Change To view, visit change 329200. To

unread,

[XS] Change in dart/sdk[main]: [build] Don't export API symbols in gen_snapshot.

Attention is currently required from: Daco Harkes. View Change To view, visit change 329200. To

4:09 PM

Brian Wilkerson (Gerrit), CBuild (Gerrit)5

3:59 PM

[XL] Change in dart/sdk[main]: Add diagnostic docs for extension types

Attention is currently required from: Marya Belanger. go/dart-cbuild result: SUCCESS Details: https:/

unread,

[XL] Change in dart/sdk[main]: Add diagnostic docs for extension types

Attention is currently required from: Marya Belanger. go/dart-cbuild result: SUCCESS Details: https:/

3:59 PM

Ryan Macnak (Gerrit), CBuild (Gerrit)4

3:06 PM

[M] Change in dart/sdk[main]: [vm, compiler] Fix Float32x4.greaterThan[OrEqual] on IA32 and X64 to ...

Attention is currently required from: Alexander Markov. Ryan Macnak uploaded patch set #2 to this

unread,

[M] Change in dart/sdk[main]: [vm, compiler] Fix Float32x4.greaterThan[OrEqual] on IA32 and X64 to ...

Attention is currently required from: Alexander Markov. Ryan Macnak uploaded patch set #2 to this

3:06 PM

Ryan Macnak (Gerrit), … CBuild (Gerrit)8

2:25 PM

[S] Change in dart/sdk[main]: [vm, profiler] Don't assume the isolate has a mutator during a profil...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: [vm, profiler] Don't assume the isolate has a mutator during a profil...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

2:25 PM

Ben Konyi (Gerrit), … CBuild (Gerrit)7

2:25 PM

[S] Change in dart/sdk[main]: Update package:dds and package:dds_service_extensions to vm_service ^...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: Update package:dds and package:dds_service_extensions to vm_service ^...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

2:25 PM

CBuild (Gerrit), Samuel Rawlins (Gerrit)3

2:11 PM

[M] Change in dart/sdk[main]: Linter: move control_flow_in_finally tests

Attention is currently required from: Phil Quitslund. Patch set 1:Auto-Submit +1Commit-Queue +1 View

unread,

[M] Change in dart/sdk[main]: Linter: move control_flow_in_finally tests

Attention is currently required from: Phil Quitslund. Patch set 1:Auto-Submit +1Commit-Queue +1 View

2:11 PM

Ryan Macnak (Gerrit), … CBuild (Gerrit)10

1:38 PM

[S] Change in dart/sdk[main]: [vm, compiler] Don't try to compile abstract entry points.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: [vm, compiler] Don't try to compile abstract entry points.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

1:38 PM

Zijie He (Gerrit), … Ryan Macnak (Gerrit)13

1:33 PM

[M] Change in dart/sdk[main]: [Fuchsia] Allows FuchsiaEmulatorCFv2 to start daemon and emulator

Attention is currently required from: Alexander Thomas. View Change 1 comment: File DEPS: Patch Set #

unread,

[M] Change in dart/sdk[main]: [Fuchsia] Allows FuchsiaEmulatorCFv2 to start daemon and emulator

Attention is currently required from: Alexander Thomas. View Change 1 comment: File DEPS: Patch Set #

1:33 PM

Elliott Brooks (Gerrit), … CBuild (Gerrit)9

12:36 PM

[XS] Change in dart/sdk[main]: Remove webdev pin

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[XS] Change in dart/sdk[main]: Remove webdev pin

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

12:36 PM

Danny Tuppeny (Gerrit), … CBuild (Gerrit)16

12:05 PM

[M] Change in dart/sdk[main]: [dds/dap] Add support for "restart frame"

go/dart-cbuild result: FAILURE (NO REGRESSIONS DETECTED) Details: https://goto.google.com/dart-cbuild

unread,

[M] Change in dart/sdk[main]: [dds/dap] Add support for "restart frame"

go/dart-cbuild result: FAILURE (NO REGRESSIONS DETECTED) Details: https://goto.google.com/dart-cbuild

12:05 PM

CBuild (Gerrit)

11:02 AM

[M] Change in dart/sdk[main]: linter: Move avoid_multiple_declarations_per_line tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: linter: Move avoid_multiple_declarations_per_line tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

11:02 AM

CBuild (Gerrit)

11:02 AM

[L] Change in dart/sdk[main]: Move prefer_const_constructors_in_immutables tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[L] Change in dart/sdk[main]: Move prefer_const_constructors_in_immutables tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

11:02 AM

Chloe Stefantsova (Gerrit), CBuild (Gerrit)3

10:46 AM

[XL] Change in dart/sdk[main]: [cfe] Error on variable use before declaration, not on declaration

Attention is currently required from: Johnni Winther. go/dart-cbuild result: SUCCESS Details: https:/

unread,

[XL] Change in dart/sdk[main]: [cfe] Error on variable use before declaration, not on declaration

Attention is currently required from: Johnni Winther. go/dart-cbuild result: SUCCESS Details: https:/

10:46 AM

Chloe Stefantsova (Gerrit), … CBuild (Gerrit)10

10:33 AM

[L] Change in dart/sdk[main]: [cfe] Remove useCounter from FutureTypeInstantiator

Attention is currently required from: Johnni Winther. Patch set 4:Commit-Queue +2 View Change To view

unread,

[L] Change in dart/sdk[main]: [cfe] Remove useCounter from FutureTypeInstantiator

Attention is currently required from: Johnni Winther. Patch set 4:Commit-Queue +2 View Change To view

10:33 AM

Jake Macdonald (Gerrit), … Johnni Winther (Gerrit)6

10:26 AM

[M] Change in dart/sdk[main]: Get started on some augmentation library tests.

Attention is currently required from: Konstantin Scheglov. View Change 2 comments: File tests/

unread,

[M] Change in dart/sdk[main]: Get started on some augmentation library tests.

Attention is currently required from: Konstantin Scheglov. View Change 2 comments: File tests/

10:26 AM

Jens Johansen (Gerrit), … CBuild (Gerrit)29

7:54 AM

[M] Change in dart/sdk[main]: [analyzer] Deduplicate simple InterfaceTypeImpl (take 2)

go/dart-cbuild result: FAILURE (NO REGRESSIONS DETECTED) Details: https://goto.google.com/dart-cbuild

unread,

[M] Change in dart/sdk[main]: [analyzer] Deduplicate simple InterfaceTypeImpl (take 2)

go/dart-cbuild result: FAILURE (NO REGRESSIONS DETECTED) Details: https://goto.google.com/dart-cbuild

7:54 AM

Rajesh Malviya (Gerrit), … Lasse Nielsen (Gerrit)6

7:27 AM

[L] Change in dart/sdk[main]: [lib/math] Implement fillRandom for Random

Attention is currently required from: Rajesh Malviya, Stephen Adams. View Change 3 comments: File sdk

unread,

[L] Change in dart/sdk[main]: [lib/math] Implement fillRandom for Random

Attention is currently required from: Rajesh Malviya, Stephen Adams. View Change 3 comments: File sdk

7:27 AM

CBuild (Gerrit), … Lasse Nielsen (Gerrit)27

6:38 AM

[M] Change in dart/sdk[main]: Adds tests and documentation for print line ending behavior

Attention is currently required from: Brian Quinlan. Lasse Nielsen removed a vote from this change.

unread,

[M] Change in dart/sdk[main]: Adds tests and documentation for print line ending behavior

Attention is currently required from: Brian Quinlan. Lasse Nielsen removed a vote from this change.

6:38 AM

CBuild (Gerrit), … Lasse Nielsen (Gerrit)17

6:38 AM

[M] Change in dart/sdk[main]: Add warning for type checks on type variables

Attention is currently required from: Marya Belanger, Nate Bosch. Patch set 5:Code-Review +1 View

unread,

[M] Change in dart/sdk[main]: Add warning for type checks on type variables

Attention is currently required from: Marya Belanger, Nate Bosch. Patch set 5:Code-Review +1 View

6:38 AM

Daco Harkes (Gerrit), … Lasse Nielsen (Gerrit)4

6:03 AM

[XS] Change in dart/sdk[main]: [ffi/doc] Document the type requirements of native functions

Attention is currently required from: Daco Harkes. Patch set 2:Code-Review +1 View Change 2 comments:

unread,

[XS] Change in dart/sdk[main]: [ffi/doc] Document the type requirements of native functions

Attention is currently required from: Daco Harkes. Patch set 2:Code-Review +1 View Change 2 comments:

6:03 AM

Ömer Ağacan (Gerrit)2

5:30 AM

[S] Change in dart/sdk[main]: [dart2wasm] Add inline pragmas to JS typed array classes

Attention is currently required from: Aske Simon Christensen, Jackson Gardner. View Change 1 comment:

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Add inline pragmas to JS typed array classes

Attention is currently required from: Aske Simon Christensen, Jackson Gardner. View Change 1 comment:

5:30 AM

Ömer Ağacan (Gerrit)2

4:27 AM

[S] Change in dart/sdk[main]: [dart2wasm] Fix prefer-inline annotation checking, handle never-inline

Attention is currently required from: Aske Simon Christensen, Jackson Gardner. View Change To view,

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix prefer-inline annotation checking, handle never-inline

Attention is currently required from: Aske Simon Christensen, Jackson Gardner. View Change To view,

4:27 AM

Liam Appelbe (Gerrit), … Lasse Nielsen (Gerrit)9

4:20 AM

[M] Change in dart/sdk[main]: [ffi] Make nativeFunction throw if already closed

Attention is currently required from: Liam Appelbe. View Change 3 comments: Patchset: Patch Set #6:

unread,

[M] Change in dart/sdk[main]: [ffi] Make nativeFunction throw if already closed

Attention is currently required from: Liam Appelbe. View Change 3 comments: Patchset: Patch Set #6:

4:20 AM

CBuild (Gerrit)10

4:00 AM

[M] Change in dart/sdk[main]: test

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: test

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:00 AM

Alexander Thomas (Gerrit), … Devon Carew (Gerrit)27

Oct 1

[XL] Change in dart/sdk[main]: [analysis_server] Move language server protocol to third_party

Attention is currently required from: Alexander Thomas. Patch set 12:Code-Review +1 View Change To

unread,

[XL] Change in dart/sdk[main]: [analysis_server] Move language server protocol to third_party

Attention is currently required from: Alexander Thomas. Patch set 12:Code-Review +1 View Change To

Oct 1

Konstantin Shcheglov (Gerrit), … CBuild (Gerrit)6

Sep 30

[S] Change in dart/sdk[main]: Issue 53391. Check mixin constraints for reference to the sealed class.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: Issue 53391. Check mixin constraints for reference to the sealed class.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

Sep 30

Konstantin Shcheglov (Gerrit), CBuild (Gerrit)3

Sep 30

[XL] Change in dart/sdk[main]: Augment. Support multiple augmentations of the same element in the sa...

Attention is currently required from: Brian Wilkerson, Phil Quitslund. go/dart-cbuild result: SUCCESS

unread,

[XL] Change in dart/sdk[main]: Augment. Support multiple augmentations of the same element in the sa...

Attention is currently required from: Brian Wilkerson, Phil Quitslund. go/dart-cbuild result: SUCCESS

Sep 30

Daco Harkes (Gerrit), … CBuild (Gerrit)6

Sep 30

[M] Change in dart/sdk[main]: [vm/test] Unify vm/cc/Assembler_LoadWordFromBoxOrSmi tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [vm/test] Unify vm/cc/Assembler_LoadWordFromBoxOrSmi tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

Sep 30

Daco Harkes (Gerrit), … CBuild (Gerrit)12

Sep 30

[M] Change in dart/sdk[main]: [vm] Unify `LoadInt32FromBoxOrSmi` in assemblers

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [vm] Unify `LoadInt32FromBoxOrSmi` in assemblers

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

Sep 30

Daco Harkes (Gerrit), … CBuild (Gerrit)11

Sep 30

[M] Change in dart/sdk[main]: [vm/test] Add `EnterTestFrame` for ia32 assembler tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [vm/test] Add `EnterTestFrame` for ia32 assembler tests

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

Sep 30

Search

Clear search

Close search

Google apps

Main menu