Dart Code Reviews - Google Groups

Groups

1–30 of 125154

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Bob Nystrom (Gerrit), … Nate Bosch (Gerrit)31

10:48 PM

[M] Change in dart/sdk[main]: Roll the latest dart_style into the SDK.

Bob Nystrom submitted the change Change information Commit message: Roll the latest dart_style into

unread,

[M] Change in dart/sdk[main]: Roll the latest dart_style into the SDK.

Bob Nystrom submitted the change Change information Commit message: Roll the latest dart_style into

10:48 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

10:11 PM

[L] Change in dart/sdk[main]: Ensure that default type of type parameters is not modified by augmen...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Ensure that default type of type parameters is not modified by augmen...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

10:11 PM

Konstantin Shcheglov (Gerrit)

9:36 PM

[M] Change in dart/sdk[main]: Ensure that augmentation parameter types check for structural equalit...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: Ensure that augmentation parameter types check for structural equalit...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

9:36 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

8:53 PM

[XS] Change in dart/sdk[main]: Fix Fuchsia build.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Fix Fuchsia build.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

8:53 PM

Ryan Macnak (Gerrit)

8:39 PM

[M] Change in dart/sdk[main]: Fix depfile generation.

Attention needed from Daco Harkes Ryan Macnak added 1 comment Patchset-level comments File-level

unread,

[M] Change in dart/sdk[main]: Fix depfile generation.

Attention needed from Daco Harkes Ryan Macnak added 1 comment Patchset-level comments File-level

8:39 PM

Lasse Nielsen (Gerrit), … Nate Bosch (Gerrit)6

8:09 PM

[L] Change in dart/sdk[main]: Make concrete `_ZoneFunction`s not generic.

Attention needed from Lasse Nielsen Nate Bosch added 3 comments Patchset-level comments File-level

unread,

[L] Change in dart/sdk[main]: Make concrete `_ZoneFunction`s not generic.

Attention needed from Lasse Nielsen Nate Bosch added 3 comments Patchset-level comments File-level

8:09 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

8:03 PM

[S] Change in dart/sdk[main]: Reduce build set for isolate stress testing.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Reduce build set for isolate stress testing.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

8:03 PM

Alexander Markov (Gerrit)

7:32 PM

[M] Change in dart/sdk[main]: [modular_aot] Reuse class and function type arguments when instantiating

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [modular_aot] Reuse class and function type arguments when instantiating

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

7:32 PM

Kallen Tu (Gerrit), Brian Wilkerson (Gerrit)2

7:20 PM

[M] Change in dart/sdk[main]: [migrate] Allow the tool to perform dry runs.

Attention needed from Kallen Tu Brian Wilkerson voted and added 2 comments Votes added by Brian

unread,

[M] Change in dart/sdk[main]: [migrate] Allow the tool to perform dry runs.

Attention needed from Kallen Tu Brian Wilkerson voted and added 2 comments Votes added by Brian

7:20 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

7:14 PM

[L] Change in dart/sdk[main]: Infer field / super formal parameter element type only if the first f...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Infer field / super formal parameter element type only if the first f...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

7:14 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

7:06 PM

[M] Change in dart/sdk[main]: Replace skipped with failing for tests

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Replace skipped with failing for tests

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

7:06 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

6:08 PM

[XL] Change in dart/sdk[main]: linter: Rename "markdown" APIs to "markup"

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: linter: Rename "markdown" APIs to "markup"

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

6:08 PM

FMorschel (Gerrit)

5:55 PM

[M] Change in dart/sdk[main]: Record ConstructorElement references from metadata annotations.

Attention needed from Konstantin Shcheglov FMorschel added 1 comment Patchset-level comments File-

unread,

[M] Change in dart/sdk[main]: Record ConstructorElement references from metadata annotations.

Attention needed from Konstantin Shcheglov FMorschel added 1 comment Patchset-level comments File-

5:55 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:52 PM

[M] Change in dart/sdk[main]: [dart:io, fuchsia] Fix use-after-free when closing a server socket on...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [dart:io, fuchsia] Fix use-after-free when closing a server socket on...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

5:52 PM

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:51 PM

[M] Change in dart/sdk[main]: [migrate] Print details for the fixes applied.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [migrate] Print details for the fixes applied.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

4:51 PM

Konstantin Shcheglov (Gerrit), Fedor Shcheglov (Gerrit)2

4:46 PM

[XL] Change in dart/sdk[main]: Report missingFunctionBody or alreadyCompleteSemanticEntity for augme...

Fedor Shcheglov abandoned this change. View Change Abandoned Change already made. Fedor Shcheglov

unread,

[XL] Change in dart/sdk[main]: Report missingFunctionBody or alreadyCompleteSemanticEntity for augme...

Fedor Shcheglov abandoned this change. View Change Abandoned Change already made. Fedor Shcheglov

4:46 PM

Srujan Gaddam (Gerrit)

4:39 PM

[M] Change in dart/sdk[main]: [dart2wasm] Separate concept of minification from omitting error details

Attention needed from Martin Kustermann Srujan Gaddam voted and added 1 comment Votes added by Srujan

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Separate concept of minification from omitting error details

Attention needed from Martin Kustermann Srujan Gaddam voted and added 1 comment Votes added by Srujan

4:39 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

4:02 PM

[L] Change in dart/sdk[main]: [vm] Allocate separate cages for each isolate group under compressed ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: [vm] Allocate separate cages for each isolate group under compressed ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

4:02 PM

FMorschel (Gerrit), … Brian Wilkerson (Gerrit)7

3:51 PM

[M] Change in dart/sdk[main]: [DAS] Fixes renaming constructor invocation on annotation

Attention needed from FMorschel Brian Wilkerson added 1 comment File pkg/analyzer/test/src/dart/

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes renaming constructor invocation on annotation

Attention needed from FMorschel Brian Wilkerson added 1 comment File pkg/analyzer/test/src/dart/

3:51 PM

Brian Quinlan (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:44 PM

[XS] Change in dart/sdk[main]: [frontend_server_client] Copy changes from github

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [frontend_server_client] Copy changes from github

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:44 PM

Kevin Moore (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)10

3:12 PM

[M] Change in dart/sdk[main]: [vm/io] leaf cert in badCertificateCallback

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 6

unread,

[M] Change in dart/sdk[main]: [vm/io] leaf cert in badCertificateCallback

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 6

3:12 PM

Alexander Markov (Gerrit)

3:04 PM

[XS] Change in dart/sdk[main]: [modular_aot] Fixes for TypeCast slow path

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XS] Change in dart/sdk[main]: [modular_aot] Fixes for TypeCast slow path

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

3:04 PM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)5

3:01 PM

[M] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound arguments to FfiCalls.

Attention needed from Tess Strickland Alexander Markov voted and added 1 comment Votes added by

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound arguments to FfiCalls.

Attention needed from Tess Strickland Alexander Markov voted and added 1 comment Votes added by

3:01 PM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)5

2:47 PM

[L] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound returns from FfiCalls.

Attention needed from Tess Strickland Alexander Markov added 8 comments File runtime/vm/

unread,

[L] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound returns from FfiCalls.

Attention needed from Tess Strickland Alexander Markov added 8 comments File runtime/vm/

2:47 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

2:45 PM

[M] Change in dart/sdk[main]: CQ. Store FormalParameterElementImpl flags.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: CQ. Store FormalParameterElementImpl flags.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

2:45 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

2:39 PM

[XL] Change in dart/sdk[main]: AO. Parse and validate at the same time.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XL] Change in dart/sdk[main]: AO. Parse and validate at the same time.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

2:39 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

2:37 PM

[L] Change in dart/sdk[main]: Convert more lint tests to use markdown

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: Convert more lint tests to use markdown

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

2:37 PM

Nate Biggs (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

2:00 PM

[L] Change in dart/sdk[main]: [dart2wasm] Use M / M<id> for module names

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Use M / M<id> for module names

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:00 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

1:26 PM

[M] Change in dart/sdk[main]: DeCo. Report missingPrimaryConstructorParameters when has primary con...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: DeCo. Report missingPrimaryConstructorParameters when has primary con...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:26 PM

Jonas Jensen (Gerrit), … Stephen Adams (Gerrit)6

1:21 PM

[S] Change in dart/sdk[main]: Avoid using List<int>, prefer Uint8List

Stephen Adams added 1 comment Patchset-level comments File-level comment, Patchset 1: Sigurd

unread,

[S] Change in dart/sdk[main]: Avoid using List<int>, prefer Uint8List

Stephen Adams added 1 comment Patchset-level comments File-level comment, Patchset 1: Sigurd

1:21 PM

Search

Clear search

Close search

Google apps

Main menu