Groups

Dart Code Reviews

1–30 of 122309

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

10:23 PM

[S] Change in dart/sdk[main]: [vm] Fix race between DartEntry::InvokeFunction and background compil...

Commit Queue submitted the change Change information Commit message: [vm] Fix race between DartEntry:

unread,

[S] Change in dart/sdk[main]: [vm] Fix race between DartEntry::InvokeFunction and background compil...

Commit Queue submitted the change Change information Commit message: [vm] Fix race between DartEntry:

10:23 PM

Felipe Morschel (Gerrit), … Samuel Rawlins (Gerrit)14

9:40 PM

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Attention needed from Brian Wilkerson, Connie Ooi and Felipe Morschel Samuel Rawlins voted Code-

unread,

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Attention needed from Brian Wilkerson, Connie Ooi and Felipe Morschel Samuel Rawlins voted Code-

9:40 PM

Alexander Aprelev (Gerrit), … Nate Bosch (Gerrit)16

7:58 PM

[M] Change in dart/sdk[main]: [vm/sdk] Use FinalThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev, Nate Biggs and Slava Egorov Nate Bosch voted and added 1

unread,

[M] Change in dart/sdk[main]: [vm/sdk] Use FinalThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev, Nate Biggs and Slava Egorov Nate Bosch voted and added 1

7:58 PM

Kallen Tu (Gerrit), Paul Berry (Gerrit)2

6:55 PM

[L] Change in dart/sdk[main]: [analyzer] Dot shorthands: Remove error when a constructor conflicts ...

Attention needed from Kallen Tu Paul Berry voted and added 1 comment Votes added by Paul Berry Code-

unread,

[L] Change in dart/sdk[main]: [analyzer] Dot shorthands: Remove error when a constructor conflicts ...

Attention needed from Kallen Tu Paul Berry voted and added 1 comment Votes added by Paul Berry Code-

6:55 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

5:58 PM

[L] Change in dart/sdk[main]: analyzer_testing: Move last flutter mocks to multi-line strings

Commit Queue submitted the change Change information Commit message: analyzer_testing: Move last

unread,

[L] Change in dart/sdk[main]: analyzer_testing: Move last flutter mocks to multi-line strings

Commit Queue submitted the change Change information Commit message: analyzer_testing: Move last

5:58 PM

Bob Nystrom (Gerrit), … Konstantin Shcheglov (Gerrit)9

4:40 PM

[L] Change in dart/sdk[main]: [private named parameters] Handle rename refactoring.

Attention needed from Bob Nystrom Konstantin Shcheglov added 1 comment File pkg/analyzer/test/src/

unread,

[L] Change in dart/sdk[main]: [private named parameters] Handle rename refactoring.

Attention needed from Bob Nystrom Konstantin Shcheglov added 1 comment File pkg/analyzer/test/src/

4:40 PM

Kallen Tu (Gerrit), … Commit Queue (Gerrit)5

4:20 PM

[M] Change in dart/sdk[stable]: [stable][DAS] Fixes completion for `!=` for dot shorthands

Commit Queue submitted the change Change information Commit message: [stable][DAS] Fixes completion

unread,

[M] Change in dart/sdk[stable]: [stable][DAS] Fixes completion for `!=` for dot shorthands

Commit Queue submitted the change Change information Commit message: [stable][DAS] Fixes completion

4:20 PM

Felipe Morschel (Gerrit)3

3:46 PM

[XL] Change in dart/sdk[main]: [DAS] Fixes type argument handling for `Create function/method/operator`

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted Auto-Submit+1 Auto-

unread,

[XL] Change in dart/sdk[main]: [DAS] Fixes type argument handling for `Create function/method/operator`

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted Auto-Submit+1 Auto-

3:46 PM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)6

3:21 PM

[M] Change in dart/sdk[main]: [analyzer] Fixes SearchEngine for dot shorthand constructor references

Attention needed from Paul Berry and Samuel Rawlins Felipe Morschel voted and added 1 comment Votes

unread,

[M] Change in dart/sdk[main]: [analyzer] Fixes SearchEngine for dot shorthand constructor references

Attention needed from Paul Berry and Samuel Rawlins Felipe Morschel voted and added 1 comment Votes

3:21 PM

Morgan :) (Gerrit), … Commit Queue (Gerrit)5

2:27 PM

[XL] Change in dart/sdk[main]: Bump tools to 97014f33a2aad59385df73f25baf9c304ca5c866

Commit Queue submitted the change Change information Commit message: Bump tools to

unread,

[XL] Change in dart/sdk[main]: Bump tools to 97014f33a2aad59385df73f25baf9c304ca5c866

Commit Queue submitted the change Change information Commit message: Bump tools to

2:27 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

2:19 PM

[L] Change in dart/sdk[main]: [vm] Nicer disassembly for RISC-V hints.

Commit Queue submitted the change Change information Commit message: [vm] Nicer disassembly for RISC-

unread,

[L] Change in dart/sdk[main]: [vm] Nicer disassembly for RISC-V hints.

Commit Queue submitted the change Change information Commit message: [vm] Nicer disassembly for RISC-

2:19 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)6

2:15 PM

[S] Change in dart/sdk[main]: analyzer: Add a CHANGELOG entry for Dart 3.11 and analysis_server_plugin

Commit Queue submitted the change Change information Commit message: analyzer: Add a CHANGELOG entry

unread,

[S] Change in dart/sdk[main]: analyzer: Add a CHANGELOG entry for Dart 3.11 and analysis_server_plugin

Commit Queue submitted the change Change information Commit message: analyzer: Add a CHANGELOG entry

2:15 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

2:07 PM

[M] Change in dart/sdk[main]: [DAS] Fixes create member inference for switch expressions

Commit Queue submitted the change Change information Commit message: [DAS] Fixes create member

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes create member inference for switch expressions

Commit Queue submitted the change Change information Commit message: [DAS] Fixes create member

2:07 PM

Ben Konyi (Gerrit), Mark Zhou (Gerrit)2

1:58 PM

[L] Change in dart/sdk[main]: [ SDK ] Add `js_dev_runtime` stubs for `dart:ffi`

Attention needed from Ben Konyi, Daco Harkes, Johnni Winther and Sigmund Cherem Mark Zhou voted and

unread,

[L] Change in dart/sdk[main]: [ SDK ] Add `js_dev_runtime` stubs for `dart:ffi`

Attention needed from Ben Konyi, Daco Harkes, Johnni Winther and Sigmund Cherem Mark Zhou voted and

1:58 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)5

1:58 PM

[S] Change in dart/sdk[main]: [DAS] Makes `Convert to wildcard` fix apply automatically for `unnece...

Commit Queue submitted the change Change information Commit message: [DAS] Makes `Convert to wildcard

unread,

[S] Change in dart/sdk[main]: [DAS] Makes `Convert to wildcard` fix apply automatically for `unnece...

Commit Queue submitted the change Change information Commit message: [DAS] Makes `Convert to wildcard

1:58 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)8

1:40 PM

[M] Change in dart/sdk[main]: [DAS] Fixes `Create (extension) method` for unresolved closure return...

Commit Queue submitted the change Change information Commit message: [DAS] Fixes `Create (extension)

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes `Create (extension) method` for unresolved closure return...

Commit Queue submitted the change Change information Commit message: [DAS] Fixes `Create (extension)

1:40 PM

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)17

1:38 PM

[M] Change in dart/sdk[main]: [DAS] Adds support for using `TestCode` markers in `AnalysisRuleTest`

Attention needed from Brian Wilkerson Felipe Morschel added 1 comment Patchset-level comments File-

unread,

[M] Change in dart/sdk[main]: [DAS] Adds support for using `TestCode` markers in `AnalysisRuleTest`

Attention needed from Brian Wilkerson Felipe Morschel added 1 comment Patchset-level comments File-

1:38 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

1:23 PM

[S] Change in dart/sdk[main]: analyzer_testing: Add mixed-in types; other fixes

Commit Queue submitted the change Change information Commit message: analyzer_testing: Add mixed-in

unread,

[S] Change in dart/sdk[main]: analyzer_testing: Add mixed-in types; other fixes

Commit Queue submitted the change Change information Commit message: analyzer_testing: Add mixed-in

1:23 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)5

1:14 PM

[M] Change in dart/sdk[main]: Add tests for documentColor in primary constructors

Commit Queue submitted the change Change information Commit message: Add tests for documentColor in

unread,

[M] Change in dart/sdk[main]: Add tests for documentColor in primary constructors

Commit Queue submitted the change Change information Commit message: Add tests for documentColor in

1:14 PM

Sigmund Cherem (Gerrit), Ben Konyi (Gerrit)6

12:57 PM

[M] Change in dart/sdk[main]: [ DDC / CFE ] Add support for allowing imports of unsupported libraries

Attention needed from Jens Johansen and Sigmund Cherem Ben Konyi added 1 comment Patchset-level

unread,

[M] Change in dart/sdk[main]: [ DDC / CFE ] Add support for allowing imports of unsupported libraries

Attention needed from Jens Johansen and Sigmund Cherem Ben Konyi added 1 comment Patchset-level

12:57 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)3

12:19 PM

[M] Change in dart/sdk[main]: [vm/shared] Maintain visited set when assessing immutability in closu...

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[M] Change in dart/sdk[main]: [vm/shared] Maintain visited set when assessing immutability in closu...

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

12:19 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)6

11:57 AM

[M] Change in dart/sdk[main]: DeCo. Use more general FormalParameterImpl.fullTypeAnnotation

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[M] Change in dart/sdk[main]: DeCo. Use more general FormalParameterImpl.fullTypeAnnotation

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

11:57 AM

Tess Strickland (Gerrit), … Commit Queue (Gerrit)4

11:50 AM

[M] Change in dart/sdk[main]: [vm] Improvements for --trace-debugger-stacktrace output.

Commit Queue submitted the change Change information Commit message: [vm] Improvements for --trace-

unread,

[M] Change in dart/sdk[main]: [vm] Improvements for --trace-debugger-stacktrace output.

Commit Queue submitted the change Change information Commit message: [vm] Improvements for --trace-

11:50 AM

Alexander Markov (Gerrit), Slava Egorov (Gerrit)3

11:40 AM

[L] Change in dart/sdk[main]: Support more function kinds and nodes in AST-to-IR translation

Attention needed from Slava Egorov Alexander Markov voted and added 3 comments Votes added by

unread,

[L] Change in dart/sdk[main]: Support more function kinds and nodes in AST-to-IR translation

Attention needed from Slava Egorov Alexander Markov voted and added 3 comments Votes added by

11:40 AM

Alexander Aprelev (Gerrit), … Commit Queue (Gerrit)9

11:30 AM

[L] Change in dart/sdk[main]: [vm/shared] Prohibit capturing of 'late final' variables by isolategr...

Commit Queue submitted the change Change information Commit message: [vm/shared] Prohibit capturing

unread,

[L] Change in dart/sdk[main]: [vm/shared] Prohibit capturing of 'late final' variables by isolategr...

Commit Queue submitted the change Change information Commit message: [vm/shared] Prohibit capturing

11:30 AM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

11:12 AM

[M] Change in dart/sdk[main]: [DAS] Fixes completion for `!=` for dot-shorthand

Commit Queue submitted the change Change information Commit message: [DAS] Fixes completion for `!=`

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes completion for `!=` for dot-shorthand

Commit Queue submitted the change Change information Commit message: [DAS] Fixes completion for `!=`

11:12 AM

Kallen Tu (Gerrit), … Commit Queue (Gerrit)5

10:33 AM

[S] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthands completion for enum constant creation

Commit Queue submitted the change Change information Commit message: [stable][DAS] Fixes dot-

unread,

[S] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthands completion for enum constant creation

Commit Queue submitted the change Change information Commit message: [stable][DAS] Fixes dot-

10:33 AM

Alexander Markov (Gerrit), Slava Egorov (Gerrit)3

9:31 AM

[XL] Change in dart/sdk[main]: [vm] Generate Dart declarations for runtime offsets

Attention needed from Slava Egorov Alexander Markov added 1 comment File pkg/native_compiler/lib/

unread,

[XL] Change in dart/sdk[main]: [vm] Generate Dart declarations for runtime offsets

Attention needed from Slava Egorov Alexander Markov added 1 comment File pkg/native_compiler/lib/

9:31 AM

Alexander Markov (Gerrit), … Commit Queue (Gerrit)4

8:51 AM

[L] Change in dart/sdk[main]: Control flow optimizations

Commit Queue submitted the change Change information Commit message: Control flow optimizations Add a

unread,

[L] Change in dart/sdk[main]: Control flow optimizations

Commit Queue submitted the change Change information Commit message: Control flow optimizations Add a

8:51 AM

Jens Johansen (Gerrit), … Commit Queue (Gerrit)4

8:29 AM

[M] Change in dart/sdk[main]: [CFE] Incremental compiler test for flutter issue 178740

Commit Queue submitted the change Change information Commit message: [CFE] Incremental compiler test

unread,

[M] Change in dart/sdk[main]: [CFE] Incremental compiler test for flutter issue 178740

Commit Queue submitted the change Change information Commit message: [CFE] Incremental compiler test

8:29 AM

Search

Clear search

Close search

Google apps

Main menu