Groups

Dart Code Reviews

1–30 of 122189

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Tess Strickland (Gerrit), Alexander Markov (Gerrit)5

8:10 AM

[S] Change in dart/sdk[main]: [vm,dyn_modules] Fix evaluation expression function self-reference.

Attention needed from Alexander Markov Tess Strickland voted and added 3 comments Votes added by Tess

unread,

[S] Change in dart/sdk[main]: [vm,dyn_modules] Fix evaluation expression function self-reference.

Attention needed from Alexander Markov Tess Strickland voted and added 3 comments Votes added by Tess

8:10 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)5

8:06 AM

[M] Change in dart/sdk[main]: [vm,dyn_modules] Mark extension type members appropriately.

Attention needed from Alexander Markov Tess Strickland voted Auto-Submit+1 Auto-Submit +1 Open in

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Mark extension type members appropriately.

Attention needed from Alexander Markov Tess Strickland voted Auto-Submit+1 Auto-Submit +1 Open in

8:06 AM

Slava Egorov (Gerrit), … Commit Queue (Gerrit)6

8:01 AM

[L] Change in dart/sdk[stable]: [stable] Fix Process::Exec stdio handle inheritance

Commit Queue submitted the change Change information Commit message: [stable] Fix Process::Exec stdio

unread,

[L] Change in dart/sdk[stable]: [stable] Fix Process::Exec stdio handle inheritance

Commit Queue submitted the change Change information Commit message: [stable] Fix Process::Exec stdio

8:01 AM

Tess Strickland (Gerrit), … Alexander Markov (Gerrit)5

7:59 AM

[S] Change in dart/sdk[main]: [vm,dyn_modules] Handle evaluation in extensions/extension type members.

Attention needed from Alexander Markov and Johnni Winther Tess Strickland voted and added 2 comments

unread,

[S] Change in dart/sdk[main]: [vm,dyn_modules] Handle evaluation in extensions/extension type members.

Attention needed from Alexander Markov and Johnni Winther Tess Strickland voted and added 2 comments

7:59 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)3

7:30 AM

[S] Change in dart/sdk[main]: [pkg/vm_service] Handle lack of optimized out variables in interpreter.

Attention needed from Alexander Markov Tess Strickland voted and added 2 comments Votes added by Tess

unread,

[S] Change in dart/sdk[main]: [pkg/vm_service] Handle lack of optimized out variables in interpreter.

Attention needed from Alexander Markov Tess Strickland voted and added 2 comments Votes added by Tess

7:30 AM

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)2

7:30 AM

[M] Change in dart/sdk[main]: [vm/sdk] Use FinalThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev Slava Egorov voted and added 1 comment Votes added by Slava

unread,

[M] Change in dart/sdk[main]: [vm/sdk] Use FinalThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev Slava Egorov voted and added 1 comment Votes added by Slava

7:30 AM

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)9

7:23 AM

[XL] Change in dart/sdk[main]: [vm] Add graph intrinsics for ThreadLocal hasValue and getValue methods.

Attention needed from Alexander Aprelev Slava Egorov voted and added 2 comments Votes added by Slava

unread,

[XL] Change in dart/sdk[main]: [vm] Add graph intrinsics for ThreadLocal hasValue and getValue methods.

Attention needed from Alexander Aprelev Slava Egorov voted and added 2 comments Votes added by Slava

7:23 AM

Ömer Ağacan (Gerrit), Martin Kustermann (Gerrit)3

7:12 AM

[L] Change in dart/sdk[main]: [dart2wasm] Prune library imports after TFA for better deferred modul...

Attention needed from Martin Kustermann Ömer Ağacan voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Prune library imports after TFA for better deferred modul...

Attention needed from Martin Kustermann Ömer Ağacan voted Code-Review+1 Code-Review +1 Open in Gerrit

7:12 AM

Erik Ernst (Gerrit), Paul Berry (Gerrit)4

6:38 AM

[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer.

Attention needed from Johnni Winther and Paul Berry Erik Ernst added 3 comments Patchset-level

unread,

[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer.

Attention needed from Johnni Winther and Paul Berry Erik Ernst added 3 comments Patchset-level

6:38 AM

Martin Kustermann (Gerrit), … Commit Queue (Gerrit)5

6:06 AM

[L] Change in dart/sdk[main]: [dart2wasm] Make IR tests more stable

Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Make IR tests more stable

Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved

6:06 AM

Samuel Rawlins (Gerrit), Johnni Winther (Gerrit)3

6:01 AM

[XL] Change in dart/sdk[main]: DeCo. Add PropertyInducingElement.isOriginDeclaration, isOriginGetter...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 2 comments

unread,

[XL] Change in dart/sdk[main]: DeCo. Add PropertyInducingElement.isOriginDeclaration, isOriginGetter...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 2 comments

6:01 AM

Bob Nystrom (Gerrit), Johnni Winther (Gerrit)2

5:49 AM

[L] Change in dart/sdk[main]: [private named parameters] Report collision between public name and o...

Attention needed from Bob Nystrom Johnni Winther voted and added 2 comments Votes added by Johnni

unread,

[L] Change in dart/sdk[main]: [private named parameters] Report collision between public name and o...

Attention needed from Bob Nystrom Johnni Winther voted and added 2 comments Votes added by Johnni

5:49 AM

Alexander Markov (Gerrit), Slava Egorov (Gerrit)2

5:24 AM

[M] Change in dart/sdk[main]: Enable omit_obvious_local_variable_types lint for pkg/cfg and pkg/nat...

Attention needed from Alexander Markov Slava Egorov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[M] Change in dart/sdk[main]: Enable omit_obvious_local_variable_types lint for pkg/cfg and pkg/nat...

Attention needed from Alexander Markov Slava Egorov voted Code-Review+1 Code-Review +1 Open in Gerrit

5:24 AM

Felipe Morschel (Gerrit), … Samuel Rawlins (Gerrit)6

Dec 1

[M] Change in dart/sdk[main]: [DAS] Fixes part of `Convert Getter to Method` bug in pattern field r...

Attention needed from Felipe Morschel and Paul Berry Samuel Rawlins voted Code-Review+1 Code-Review +

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes part of `Convert Getter to Method` bug in pattern field r...

Attention needed from Felipe Morschel and Paul Berry Samuel Rawlins voted Code-Review+1 Code-Review +

Dec 1

Slava Egorov (Gerrit), … Sigmund Cherem (Gerrit)6

Dec 1

[S] Change in dart/sdk[main]: [sdk/vm] Make Encoding._nameToEncoding map const.

Attention needed from Alexander Aprelev and Stephen Adams Sigmund Cherem voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: [sdk/vm] Make Encoding._nameToEncoding map const.

Attention needed from Alexander Aprelev and Stephen Adams Sigmund Cherem voted Code-Review+1 Code-

Dec 1

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)5

Dec 1

[M] Change in dart/sdk[main]: [vm, compiler] Add --target-address-sanitizer.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[M] Change in dart/sdk[main]: [vm, compiler] Add --target-address-sanitizer.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Dec 1

Phil Quitslund (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[XS] Change in dart/sdk[main]: DeCo. Don't remove experiment from shared experimentsForTests.

Commit Queue submitted the change Change information Commit message: DeCo. Don't remove

unread,

[XS] Change in dart/sdk[main]: DeCo. Don't remove experiment from shared experimentsForTests.

Commit Queue submitted the change Change information Commit message: DeCo. Don't remove

Dec 1

Kallen Tu (Gerrit), … Commit Queue (Gerrit)5

Dec 1

[M] Change in dart/sdk[stable]: [stable][analyzer] Dot shorthands: Error when using type arguments on...

Commit Queue submitted the change Change information Commit message: [stable][analyzer] Dot

unread,

[M] Change in dart/sdk[stable]: [stable][analyzer] Dot shorthands: Error when using type arguments on...

Commit Queue submitted the change Change information Commit message: [stable][analyzer] Dot

Dec 1

Elliott Brooks (Gerrit), Samuel Rawlins (Gerrit)2

Dec 1

[XS] Change in dart/sdk[main]: Update DevTools rev to bac6843cce3c98d8794a7cce796faaa8860cc00f

Attention needed from Elliott Brooks Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[XS] Change in dart/sdk[main]: Update DevTools rev to bac6843cce3c98d8794a7cce796faaa8860cc00f

Attention needed from Elliott Brooks Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in Gerrit

Dec 1

Bob Nystrom (Gerrit), … Commit Queue (Gerrit)5

Dec 1

[S] Change in dart/sdk[main]: [private named parameters] Update diagnostic documentation.

Commit Queue submitted the change Change information Commit message: [private named parameters]

unread,

[S] Change in dart/sdk[main]: [private named parameters] Update diagnostic documentation.

Commit Queue submitted the change Change information Commit message: [private named parameters]

Dec 1

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[M] Change in dart/sdk[main]: [vm] Report the current sanitizer in the compiler environment.

Commit Queue submitted the change Change information Commit message: [vm] Report the current

unread,

[M] Change in dart/sdk[main]: [vm] Report the current sanitizer in the compiler environment.

Commit Queue submitted the change Change information Commit message: [vm] Report the current

Dec 1

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[M] Change in dart/sdk[main]: [build] Put sanitizer versions of the AOT runtime into the SDK for te...

Commit Queue submitted the change Change information Commit message: [build] Put sanitizer versions

unread,

[M] Change in dart/sdk[main]: [build] Put sanitizer versions of the AOT runtime into the SDK for te...

Commit Queue submitted the change Change information Commit message: [build] Put sanitizer versions

Dec 1

Johnni Winther (Gerrit), … Paul Berry (Gerrit)5

Dec 1

[XL] Change in dart/sdk[main]: DeCo. Use origin flags for constructors.

Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov Paul Berry voted and

unread,

[XL] Change in dart/sdk[main]: DeCo. Use origin flags for constructors.

Attention needed from Brian Wilkerson, Johnni Winther and Konstantin Shcheglov Paul Berry voted and

Dec 1

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[M] Change in dart/sdk[main]: analyzer_testing: Migrate dart:ui mocks to live in source strings

Commit Queue submitted the change Change information Commit message: analyzer_testing: Migrate dart:

unread,

[M] Change in dart/sdk[main]: analyzer_testing: Migrate dart:ui mocks to live in source strings

Commit Queue submitted the change Change information Commit message: analyzer_testing: Migrate dart:

Dec 1

Brian Wilkerson (Gerrit), Samuel Rawlins (Gerrit)2

Dec 1

[S] Change in dart/sdk[main]: Make corrections to the language fidelity page

Attention needed from Brian Wilkerson Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in

unread,

[S] Change in dart/sdk[main]: Make corrections to the language fidelity page

Attention needed from Brian Wilkerson Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in

Dec 1

Jake Macdonald (Gerrit)

Dec 1

[M] Change in dart/sdk[main]: start on a log normalization tool

Attention needed from Brian Wilkerson Jake Macdonald voted Auto-Submit +1 Commit-Queue +1 Open in

unread,

[M] Change in dart/sdk[main]: start on a log normalization tool

Attention needed from Brian Wilkerson Jake Macdonald voted Auto-Submit +1 Commit-Queue +1 Open in

Dec 1

Kallen Tu (Gerrit), … Johnni Winther (Gerrit)7

Dec 1

[XL] Change in dart/sdk[main]: Rename 'declaring-constructors' to 'primary-constructors' experiment ...

Kallen Tu submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

unread,

[XL] Change in dart/sdk[main]: Rename 'declaring-constructors' to 'primary-constructors' experiment ...

Kallen Tu submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

Dec 1

Brian Quinlan (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[S] Change in dart/sdk[main]: deps: rev ai, ecosystem, http, protobuf, shelf, test, tools, web

Commit Queue submitted the change Change information Commit message: deps: rev ai, ecosystem, http,

unread,

[S] Change in dart/sdk[main]: deps: rev ai, ecosystem, http, protobuf, shelf, test, tools, web

Commit Queue submitted the change Change information Commit message: deps: rev ai, ecosystem, http,

Dec 1

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[M] Change in dart/sdk[main]: DeCo. Don't check for isSynthetic in getClassMembers.

Commit Queue submitted the change Change information Commit message: DeCo. Don't check for

unread,

[M] Change in dart/sdk[main]: DeCo. Don't check for isSynthetic in getClassMembers.

Commit Queue submitted the change Change information Commit message: DeCo. Don't check for

Dec 1

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Dec 1

[S] Change in dart/sdk[main]: [vm] Fix Fuchsia RISC-V build.

Commit Queue submitted the change Change information Commit message: [vm] Fix Fuchsia RISC-V build.

unread,

[S] Change in dart/sdk[main]: [vm] Fix Fuchsia RISC-V build.

Commit Queue submitted the change Change information Commit message: [vm] Fix Fuchsia RISC-V build.

Dec 1

Search

Clear search

Close search

Google apps

Main menu