Dart Code Reviews

1–30 of 105253

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Mayank Patke (Gerrit), … Nicholas Shahan (Gerrit)14

6:47 PM

[S] Change in dart/sdk[main]: [ddc] Add dart.web.assertions_enabled environment variable.

Attention is currently required from: Anna Gringauze, Mayank Patke, Sigmund Cherem. Patch set 15:Code

unread,

[S] Change in dart/sdk[main]: [ddc] Add dart.web.assertions_enabled environment variable.

Attention is currently required from: Anna Gringauze, Mayank Patke, Sigmund Cherem. Patch set 15:Code

6:47 PM

Konstantin Shcheglov (Gerrit), … CBuild (Gerrit)7

6:36 PM

[S] Change in dart/sdk[main]: Suppport ForEachPartsWithPattern in NodeReplacer.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: Suppport ForEachPartsWithPattern in NodeReplacer.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

6:36 PM

Derek Xu (Gerrit), CBuild (Gerrit)3

6:35 PM

[M] Change in dart/sdk[main]: [VM/Service] Reduce number of generated `is` checks in `package:vm_se...

Attention is currently required from: Ben Konyi, Siva Annamalai. go/dart-cbuild result: SUCCESS

unread,

[M] Change in dart/sdk[main]: [VM/Service] Reduce number of generated `is` checks in `package:vm_se...

Attention is currently required from: Ben Konyi, Siva Annamalai. go/dart-cbuild result: SUCCESS

6:35 PM

Konstantin Shcheglov (Gerrit), … Samuel Rawlins (Gerrit)4

6:27 PM

[XL] Change in dart/sdk[main]: Issue 51137. Don't use the type inferred from the initializer to reso...

Attention is currently required from: Konstantin Shcheglov. Patch set 2:Code-Review +1 View Change 2

unread,

[XL] Change in dart/sdk[main]: Issue 51137. Don't use the type inferred from the initializer to reso...

Attention is currently required from: Konstantin Shcheglov. Patch set 2:Code-Review +1 View Change 2

6:27 PM

Derek Xu (Gerrit), … CBuild (Gerrit)9

6:08 PM

[M] Change in dart/sdk[main]: [VM/Service] Fix generation of toJson() calls on dynamic variables

View Change 6 comments: Patchset: Patch Set #2: I presume this change is related to seeing unboxed

unread,

[M] Change in dart/sdk[main]: [VM/Service] Fix generation of toJson() calls on dynamic variables

View Change 6 comments: Patchset: Patch Set #2: I presume this change is related to seeing unboxed

6:08 PM

Phil Quitslund (Gerrit), … CBuild (Gerrit)8

6:04 PM

[M] Change in dart/sdk[main]: + remove_break fix (for `unnecessary_breaks`)

Attention is currently required from: Keerti Parthasarathy, Phil Quitslund. go/dart-cbuild result:

unread,

[M] Change in dart/sdk[main]: + remove_break fix (for `unnecessary_breaks`)

Attention is currently required from: Keerti Parthasarathy, Phil Quitslund. go/dart-cbuild result:

6:04 PM

Brian Wilkerson (Gerrit), … CBuild (Gerrit)4

6:04 PM

[L] Change in dart/sdk[main]: Add completion support for map patterns

Attention is currently required from: Brian Wilkerson. go/dart-cbuild result: SUCCESS Details: https:

unread,

[L] Change in dart/sdk[main]: Add completion support for map patterns

Attention is currently required from: Brian Wilkerson. go/dart-cbuild result: SUCCESS Details: https:

6:04 PM

Jackson Gardner (Gerrit), … Nicholas Shahan (Gerrit)16

6:04 PM

[S] Change in dart/sdk[main]: [dart2wasm] Include wasm-opt in the shipped dart-sdk.

Attention is currently required from: Aske Simon Christensen, Jackson Gardner, Martin Kustermann.

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Include wasm-opt in the shipped dart-sdk.

Attention is currently required from: Aske Simon Christensen, Jackson Gardner, Martin Kustermann.

6:04 PM

Martin Kustermann (Gerrit), … Ryan Macnak (Gerrit)6

5:54 PM

[M] Change in dart/sdk[main]: [vm] Allow sharing of deeply lists across isolates

Attention is currently required from: Martin Kustermann. Patch set 1:Code-Review +1 View Change 1

unread,

[M] Change in dart/sdk[main]: [vm] Allow sharing of deeply lists across isolates

Attention is currently required from: Martin Kustermann. Patch set 1:Code-Review +1 View Change 1

5:54 PM

Brian Wilkerson (Gerrit), … CBuild (Gerrit)7

5:48 PM

[M] Change in dart/sdk[main]: Add support for constant-requiring patterns

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: Add support for constant-requiring patterns

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

5:48 PM

Alexander Markov (Gerrit), Nicholas Shahan (Gerrit)3

5:39 PM

[M] Change in dart/sdk[main]: [kernel] Cleanup Target.enableSuperMixins flag

Attention is currently required from: Alexander Markov, Johnni Winther. Patch set 2:Code-Review +1

unread,

[M] Change in dart/sdk[main]: [kernel] Cleanup Target.enableSuperMixins flag

Attention is currently required from: Alexander Markov, Johnni Winther. Patch set 2:Code-Review +1

5:39 PM

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)5

5:29 PM

[L] Change in dart/sdk[stable]: [stable] [analyzer] Limit the number of plugins-per-context to one

Attention is currently required from: Samuel Rawlins. View Change 1 comment: File pkg/analyzer/lib/

unread,

[L] Change in dart/sdk[stable]: [stable] [analyzer] Limit the number of plugins-per-context to one

Attention is currently required from: Samuel Rawlins. View Change 1 comment: File pkg/analyzer/lib/

5:29 PM

Martin Kustermann (Gerrit), … Ryan Macnak (Gerrit)4

5:24 PM

[M] Change in dart/sdk[main]: [vm] Ensure we copy shallow (but not deeply) immutable lists

Attention is currently required from: Martin Kustermann. Patch set 2:Code-Review +1 View Change To

unread,

[M] Change in dart/sdk[main]: [vm] Ensure we copy shallow (but not deeply) immutable lists

Attention is currently required from: Martin Kustermann. Patch set 2:Code-Review +1 View Change To

5:24 PM

Stephen Adams (Gerrit), … CBuild (Gerrit)12

5:16 PM

[M] Change in dart/sdk[main]: [js_ast] Add annotations facility

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [js_ast] Add annotations facility

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

5:16 PM

Joshua Litt (Gerrit), … Srujan Gaddam (Gerrit)8

5:05 PM

[L] Change in dart/sdk[main]: [js] Move `allowInterop` functions to `dart:js_util`.

Attention is currently required from: Joshua Litt. Patch set 16:Code-Review +1 View Change To view,

unread,

[L] Change in dart/sdk[main]: [js] Move `allowInterop` functions to `dart:js_util`.

Attention is currently required from: Joshua Litt. Patch set 16:Code-Review +1 View Change To view,

5:05 PM

Ahmed Ashour (Gerrit), … CBuild (Gerrit)26

4:44 PM

[M] Change in dart/sdk[main]: [analyzer] introduce `UNNECESSARY_SET_LITERAL`

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [analyzer] introduce `UNNECESSARY_SET_LITERAL`

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:44 PM

Paul Berry (Gerrit), … CBuild (Gerrit)8

4:43 PM

[L] Change in dart/sdk[main]: Flow analysis: add support for relational patterns.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[L] Change in dart/sdk[main]: Flow analysis: add support for relational patterns.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:43 PM

Mayank Patke (Gerrit), … CBuild (Gerrit)5

4:28 PM

[S] Change in dart/sdk[main]: [dart2js] Add a 'FALSE' JS_GET_FLAG.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: [dart2js] Add a 'FALSE' JS_GET_FLAG.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:28 PM

Phil Quitslund (Gerrit), … CBuild (Gerrit)17

4:28 PM

[M] Change in dart/sdk[main]: linter 1.33.0 rc

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: linter 1.33.0 rc

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:28 PM

Mayank Patke (Gerrit), … CBuild (Gerrit)5

4:28 PM

[M] Change in dart/sdk[main]: [dart2js] Add phase 1 kernel transformer to simplify const conditionals.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [dart2js] Add phase 1 kernel transformer to simplify const conditionals.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

4:28 PM

Ahmed Ashour (Gerrit)2

4:18 PM

[M] Change in dart/sdk[main]: [analyzer] add `OVERRIDE_ON_NON_OVERRIDING_FUNCTION`

Ahmed Ashour uploaded patch set #2 to this change. View Change [analyzer] add `

unread,

[M] Change in dart/sdk[main]: [analyzer] add `OVERRIDE_ON_NON_OVERRIDING_FUNCTION`

Ahmed Ashour uploaded patch set #2 to this change. View Change [analyzer] add `

4:18 PM

Ahmed Ashour (Gerrit), … CBuild (Gerrit)7

3:56 PM

[M] Change in dart/sdk[main]: [analysis_server] remove `UseConst`

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [analysis_server] remove `UseConst`

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

3:56 PM

Mayank Patke (Gerrit), … CBuild (Gerrit)10

3:40 PM

[M] Change in dart/sdk[main]: [dart2js] Extend const simplifier to local/static reads and invocations.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[M] Change in dart/sdk[main]: [dart2js] Extend const simplifier to local/static reads and invocations.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

3:40 PM

Ahmed Ashour (Gerrit), Brian Wilkerson (Gerrit)17

3:14 PM

[L] Change in dart/sdk[main]: [analysis_server] add a fix for `use_decorated_box`

Attention is currently required from: Brian Wilkerson. View Change 2 comments: File pkg/

unread,

[L] Change in dart/sdk[main]: [analysis_server] add a fix for `use_decorated_box`

Attention is currently required from: Brian Wilkerson. View Change 2 comments: File pkg/

3:14 PM

Ryan Macnak (Gerrit), … CBuild (Gerrit)7

2:21 PM

[S] Change in dart/sdk[main]: Reland "[build] Make `build_analyze_snapshot` consistent between the ...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: Reland "[build] Make `build_analyze_snapshot` consistent between the ...

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

2:21 PM

Brian Wilkerson (Gerrit), … CBuild (Gerrit)12

2:06 PM

[L] Change in dart/sdk[main]: Compute the context type within patterns

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[L] Change in dart/sdk[main]: Compute the context type within patterns

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

2:06 PM

Paul Berry (Gerrit), … CBuild (Gerrit)7

1:50 PM

[L] Change in dart/sdk[main]: Flow analysis: add support for constant patterns.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[L] Change in dart/sdk[main]: Flow analysis: add support for constant patterns.

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

1:50 PM

Ryan Macnak (Gerrit), … William Hesse (Gerrit)11

1:38 PM

[S] Change in dart/sdk[main]: [build] Make `build_analyze_snapshot` consistent between the host and...

View Change 1 comment: Patchset: Patch Set #2: Thanks, Bill. Reland that also handles Fuchsia at

unread,

[S] Change in dart/sdk[main]: [build] Make `build_analyze_snapshot` consistent between the host and...

View Change 1 comment: Patchset: Patch Set #2: Thanks, Bill. Reland that also handles Fuchsia at

1:38 PM

Kevin Chisholm (Gerrit), … Commit Queue (Gerrit)5

1:37 PM

[S] Change in dart/sdk[stable]: Version 2.19.2

Commit Queue submitted this change. View Change Approvals: William Hesse: Looks good to me, approved

unread,

[S] Change in dart/sdk[stable]: Version 2.19.2

Commit Queue submitted this change. View Change Approvals: William Hesse: Looks good to me, approved

1:37 PM

Devon Carew (Gerrit), … CBuild (Gerrit)8

1:03 PM

[S] Change in dart/sdk[main]: [deps] revert the recent roll of package:csslib

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

unread,

[S] Change in dart/sdk[main]: [deps] revert the recent roll of package:csslib

go/dart-cbuild result: SUCCESS Details: https://goto.google.com/dart-cbuild/find/

1:03 PM

Search

Clear search

Close search

Google apps

Main menu