Groups

Dart Code Reviews

1–30 of 124431

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

10:03 AM

[S] Change in dart/sdk[main]: linter: collection_methods_unrelated_type: Null not related to non-nu...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: linter: collection_methods_unrelated_type: Null not related to non-nu...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

10:03 AM

Chloe Stefantsova (Gerrit)

9:42 AM

[XL] Change in dart/sdk[main]: [cfe][Contexts] Split VariableDeclaration and VariableStatement

Attention needed from Alexander Markov, Johnni Winther, Martin Kustermann and Nicholas Shahan Chloe

unread,

[XL] Change in dart/sdk[main]: [cfe][Contexts] Split VariableDeclaration and VariableStatement

Attention needed from Alexander Markov, Johnni Winther, Martin Kustermann and Nicholas Shahan Chloe

9:42 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

8:58 AM

[L] Change in dart/sdk[main]: [modular_aot] Closures, part 2

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [modular_aot] Closures, part 2

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

8:58 AM

SLSA Policy Verification Service (Gerrit)

8:54 AM

[XL] Change in dart/sdk[main]: TMP: Never

SLSA Policy Verification Service voted SLSA-Policy-Verified+1 SLSA-Policy-Verified +1 Open in Gerrit

unread,

[XL] Change in dart/sdk[main]: TMP: Never

SLSA Policy Verification Service voted SLSA-Policy-Verified+1 SLSA-Policy-Verified +1 Open in Gerrit

8:54 AM

Tess Strickland (Gerrit)

8:49 AM

[XS] Change in dart/sdk[main]: [vm,dyn_modules] Drop initializing formals/wildcards from local vars ...

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

unread,

[XS] Change in dart/sdk[main]: [vm,dyn_modules] Drop initializing formals/wildcards from local vars ...

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

8:49 AM

Ryan Macnak (Gerrit), … Tess Strickland (Gerrit)14

8:47 AM

[XL] Change in dart/sdk[main]: [vm] Remove the VM isolate.

Attention needed from Ryan Macnak Tess Strickland added 3 comments Patchset-level comments File-level

unread,

[XL] Change in dart/sdk[main]: [vm] Remove the VM isolate.

Attention needed from Ryan Macnak Tess Strickland added 3 comments Patchset-level comments File-level

8:47 AM

Chloe Stefantsova (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

7:21 AM

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Sort members in internal/external_ast_helper

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Sort members in internal/external_ast_helper

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

7:21 AM

Sigmund Cherem (Gerrit), … Slava Egorov (Gerrit)19

6:49 AM

[M] Change in dart/sdk[main]: [dyn_modules] Check target of dcall from dynamic modules is valid.

Attention needed from Alexander Markov and Sigmund Cherem Slava Egorov voted and added 2 comments

unread,

[M] Change in dart/sdk[main]: [dyn_modules] Check target of dcall from dynamic modules is valid.

Attention needed from Alexander Markov and Sigmund Cherem Slava Egorov voted and added 2 comments

6:49 AM

Johnni Winther (Gerrit)

6:29 AM

[L] Change in dart/sdk[main]: CQ. Add UriSource, use it.

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-

unread,

[L] Change in dart/sdk[main]: CQ. Add UriSource, use it.

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-

6:29 AM

Johnni Winther (Gerrit)

5:58 AM

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. RST.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. RST.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment

5:58 AM

Johnni Winther (Gerrit)

5:28 AM

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. I.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 3 comments

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. I.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 3 comments

5:28 AM

Chloe Stefantsova (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

5:11 AM

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Use internal/external helpers to create AST nodes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Use internal/external helpers to create AST nodes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:11 AM

Chloe Stefantsova (Gerrit), … Alexander Markov (Gerrit)8

4:55 AM

[M] Change in dart/sdk[main]: [cfe] Make VariableBase.context independent from VariableBase.parent

Chloe Stefantsova added 1 comment File pkg/kernel/lib/src/ast/variables.dart Line 9, Patchset 7:

unread,

[M] Change in dart/sdk[main]: [cfe] Make VariableBase.context independent from VariableBase.parent

Chloe Stefantsova added 1 comment File pkg/kernel/lib/src/ast/variables.dart Line 9, Patchset 7:

4:55 AM

Chloe Stefantsova (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:40 AM

[L] Change in dart/sdk[main]: [cfe] Make Scope and VariableContext data objects, not TreeNodes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 2

unread,

[L] Change in dart/sdk[main]: [cfe] Make Scope and VariableContext data objects, not TreeNodes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 2

4:40 AM

Johnni Winther (Gerrit)

4:34 AM

[S] Change in dart/sdk[main]: CQ. Convert file paths in expected diagnostics to POSIX.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: CQ. Convert file paths in expected diagnostics to POSIX.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

4:34 AM

SLSA Policy Verification Service (Gerrit), … Johnni Winther (Gerrit)3

4:33 AM

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. LMNOP.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. LMNOP.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

4:33 AM

Konstantin Shcheglov (Gerrit), Johnni Winther (Gerrit)2

4:10 AM

[M] Change in dart/sdk[main]: Augment. Pre-fix functionAlreadyComplete in AugmentationReturnTypeMis...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: Augment. Pre-fix functionAlreadyComplete in AugmentationReturnTypeMis...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

4:10 AM

Srujan Gaddam (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

3:23 AM

[M] Change in dart/sdk[main]: [dart2wasm] Explicitly model functions that do not return

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 15

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Explicitly model functions that do not return

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 15

3:23 AM

Martin Kustermann (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:22 AM

[L] Change in dart/sdk[main]: [dart2wasm] Remove synthesizing values from nothing

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Remove synthesizing values from nothing

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:22 AM

Erik Ernst (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

3:08 AM

[M] Change in dart/sdk[main]: Modify property promotion: only `this`

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Modify property promotion: only `this`

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:08 AM

Yash Hosalli (Gerrit), … Brian Quinlan (Gerrit)4

2:00 AM

[XS] Change in dart/sdk[main]: Clarify WebSocket.addError behavior

Attention needed from Brian Quinlan and Hangyu Jin Yash Hosalli added 1 comment File sdk/lib/_http/

unread,

[XS] Change in dart/sdk[main]: Clarify WebSocket.addError behavior

Attention needed from Brian Quinlan and Hangyu Jin Yash Hosalli added 1 comment File sdk/lib/_http/

2:00 AM

Kevin Moore (Gerrit), … Paul Berry (Gerrit)4

12:48 AM

[XS] Change in dart/sdk[main]: api_summary: skipping too slow test

Attention needed from Mark Zhou Kevin Moore voted and added 1 comment Votes added by Kevin Moore Auto

unread,

[XS] Change in dart/sdk[main]: api_summary: skipping too slow test

Attention needed from Mark Zhou Kevin Moore voted and added 1 comment Votes added by Kevin Moore Auto

12:48 AM

SLSA Policy Verification Service (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

May 12

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. DEFG.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. DEFG.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

May 12

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

May 12

[M] Change in dart/sdk[main]: analyzer: Move errorRange utilities to public API

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: analyzer: Move errorRange utilities to public API

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

May 12

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

May 12

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. C.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate diagnostics tests to resolveTestCodeWithDiagnostics. C.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

May 12

Alexander Aprelev (Gerrit), … Ryan Macnak (Gerrit)18

May 12

[L] Change in dart/sdk[main]: [vm/shared] Introduce isolate event loop handling dart api.

Attention needed from Alexander Aprelev, Kevin Moore and Slava Egorov Ryan Macnak added 1 comment

unread,

[L] Change in dart/sdk[main]: [vm/shared] Introduce isolate event loop handling dart api.

Attention needed from Alexander Aprelev, Kevin Moore and Slava Egorov Ryan Macnak added 1 comment

May 12

Samuel Rawlins (Gerrit)

May 12

[M] Change in dart/sdk[main]: linter: Simplify code that uses the "write or read element"

Attention needed from Keerti Parthasarathy Samuel Rawlins voted Commit-Queue+1 Commit-Queue +1 Open

unread,

[M] Change in dart/sdk[main]: linter: Simplify code that uses the "write or read element"

Attention needed from Keerti Parthasarathy Samuel Rawlins voted Commit-Queue+1 Commit-Queue +1 Open

May 12

Kevin Moore (Gerrit), … Paul Berry (Gerrit)9

May 12

[M] Change in dart/sdk[main]: api_summary: add basic CLI and validation test

Attention needed from Kevin Moore Paul Berry added 1 comment Patchset-level comments File-level

unread,

[M] Change in dart/sdk[main]: api_summary: add basic CLI and validation test

Attention needed from Kevin Moore Paul Berry added 1 comment Patchset-level comments File-level

May 12

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

May 12

[M] Change in dart/sdk[main]: linter: Use an extension type's representation type when calculating ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: linter: Use an extension type's representation type when calculating ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

May 12

Simon Binder (Gerrit)

May 12

[XL] Change in dart/sdk[main]: [dart2wasm, standalone] Migrate `String`

Attention needed from Kevin Moore and Simon Binder Message from Simon Binder Set Ready For Review

unread,

[XL] Change in dart/sdk[main]: [dart2wasm, standalone] Migrate `String`

Attention needed from Kevin Moore and Simon Binder Message from Simon Binder Set Ready For Review

May 12

Search

Clear search

Close search

Google apps

Main menu