Groups

Dart Code Reviews

1–30 of 124787

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Brian Wilkerson (Gerrit), Konstantin Shcheglov (Gerrit)2

5:10 PM

[L] Change in dart/sdk[main]: linter: Introduce no_raw_types replacing strict-raw-types

Attention needed from Connie Ooi and Samuel Rawlins Konstantin Shcheglov voted Code-Review+1 Code-

unread,

[L] Change in dart/sdk[main]: linter: Introduce no_raw_types replacing strict-raw-types

Attention needed from Connie Ooi and Samuel Rawlins Konstantin Shcheglov voted Code-Review+1 Code-

5:10 PM

Samuel Rawlins (Gerrit), … Brian Wilkerson (Gerrit)4

4:35 PM

[M] Change in dart/sdk[main]: meta: Introduce TargetKind.importDirective

Samuel Rawlins submitted the change Change information Commit message: meta: Introduce TargetKind.

unread,

[M] Change in dart/sdk[main]: meta: Introduce TargetKind.importDirective

Samuel Rawlins submitted the change Change information Commit message: meta: Introduce TargetKind.

4:35 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:08 PM

[XS] Change in dart/sdk[main]: [infra] Rebalance Linux ARM64 JIT versus AOT shards.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [infra] Rebalance Linux ARM64 JIT versus AOT shards.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:08 PM

Konstantin Shcheglov (Gerrit)

4:02 PM

[M] Change in dart/sdk[main]: Augment. Rename ExecutableFragmentImpl.isCompleteDeclaration to isCom...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Konstantin Shcheglov voted

unread,

[M] Change in dart/sdk[main]: Augment. Rename ExecutableFragmentImpl.isCompleteDeclaration to isCom...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Konstantin Shcheglov voted

4:02 PM

Konstantin Shcheglov (Gerrit)

4:02 PM

[XL] Change in dart/sdk[main]: Augment. Rename FragmentImpl.isCompleteDeclaration to isComplete, tex...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Konstantin Shcheglov voted

unread,

[XL] Change in dart/sdk[main]: Augment. Rename FragmentImpl.isCompleteDeclaration to isComplete, tex...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Konstantin Shcheglov voted

4:02 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:33 PM

[M] Change in dart/sdk[main]: [build] Remove unused "exec_script" mode from gn_run_binary.py.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [build] Remove unused "exec_script" mode from gn_run_binary.py.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:33 PM

Chloe Stefantsova (Gerrit), Paul Berry (Gerrit)2

3:25 PM

[L] Change in dart/sdk[main]: [fe][rti] Add shared structural context schemas

Attention needed from Chloe Stefantsova Paul Berry voted and added 3 comments Votes added by Paul

unread,

[L] Change in dart/sdk[main]: [fe][rti] Add shared structural context schemas

Attention needed from Chloe Stefantsova Paul Berry voted and added 3 comments Votes added by Paul

3:25 PM

Ryan Macnak (Gerrit)

3:23 PM

[S] Change in dart/sdk[main]: [build] Use ad-hoc code signing by default for non-sanitizer builds.

Attention needed from Ryan Macnak and Slava Egorov Ryan Macnak voted Commit-Queue+1 Commit-Queue +1

unread,

[S] Change in dart/sdk[main]: [build] Use ad-hoc code signing by default for non-sanitizer builds.

Attention needed from Ryan Macnak and Slava Egorov Ryan Macnak voted Commit-Queue+1 Commit-Queue +1

3:23 PM

Alexander Markov (Gerrit)

3:13 PM

[M] Change in dart/sdk[main]: [modular_aot] Handle parallel moves when the same source location is ...

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [modular_aot] Handle parallel moves when the same source location is ...

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

3:13 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:12 PM

[S] Change in dart/sdk[main]: [modular_aot] Fix simplification of string interpolation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix simplification of string interpolation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:12 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:10 PM

[M] Change in dart/sdk[main]: [modular_aot] Fix LiveRange.findRegisterUseAfter

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [modular_aot] Fix LiveRange.findRegisterUseAfter

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:10 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

2:32 PM

[M] Change in dart/sdk[main]: [vm,aot] Fix parameter type checks in the implicit setters of covaria...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [vm,aot] Fix parameter type checks in the implicit setters of covaria...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:32 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

2:32 PM

[XS] Change in dart/sdk[main]: [modular_aot] Serialization of UndefinedConstant in module snapshots

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

unread,

[XS] Change in dart/sdk[main]: [modular_aot] Serialization of UndefinedConstant in module snapshots

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

2:32 PM

Johnni Winther (Gerrit), Paul Berry (Gerrit)4

2:17 PM

[M] Change in dart/sdk[main]: [cfe] Add test for issue 63506

Paul Berry submitted the change Change information Commit message: [cfe] Add test for issue 63506

unread,

[M] Change in dart/sdk[main]: [cfe] Add test for issue 63506

Paul Berry submitted the change Change information Commit message: [cfe] Add test for issue 63506

2:17 PM

Paul Berry (Gerrit), Konstantin Shcheglov (Gerrit)5

2:14 PM

[L] Change in dart/sdk[main]: CQ. Use assertDartObjectText() with raw multi-line string in more pla...

Konstantin Shcheglov submitted the change Change information Commit message: CQ. Use

unread,

[L] Change in dart/sdk[main]: CQ. Use assertDartObjectText() with raw multi-line string in more pla...

Konstantin Shcheglov submitted the change Change information Commit message: CQ. Use

2:14 PM

Ryan Macnak (Gerrit)

1:57 PM

[S] Change in dart/sdk[main]: Remove the JIT entitlement from gen_snapshot.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: Remove the JIT entitlement from gen_snapshot.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

1:57 PM

Ryan Macnak (Gerrit)

1:57 PM

[S] Change in dart/sdk[main]: [dartfuzz] Fix flag_fuzzer_dart2js AOT steps.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [dartfuzz] Fix flag_fuzzer_dart2js AOT steps.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

1:57 PM

Samuel Rawlins (Gerrit), … Brian Wilkerson (Gerrit)3

1:43 PM

[S] Change in dart/sdk[main]: [analysis_server] Fix filters + resource type for Move to File in Int...

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: [analysis_server] Fix filters + resource type for Move to File in Int...

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-

1:43 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:48 PM

[S] Change in dart/sdk[main]: [build] Use ad-hoc code signing by default.

Ryan Macnak has created a revert of this change Open original change Related details Attention set is

unread,

[S] Change in dart/sdk[main]: [build] Use ad-hoc code signing by default.

Ryan Macnak has created a revert of this change Open original change Related details Attention set is

12:48 PM

Samuel Rawlins (Gerrit)2

12:35 PM

[M] Change in dart/sdk[main]: DevTools: Add a script that runs all of the DevTools tests

Attention needed from Alexander Aprelev and Kenzie Davisson Samuel Rawlins added 1 comment Patchset-

unread,

[M] Change in dart/sdk[main]: DevTools: Add a script that runs all of the DevTools tests

Attention needed from Alexander Aprelev and Kenzie Davisson Samuel Rawlins added 1 comment Patchset-

12:35 PM

Konstantin Shcheglov (Gerrit), Johnni Winther (Gerrit)3

11:52 AM

[XL] Change in dart/sdk[main]: Patterns. Fix for parsing nested pattern assigment: 'v2 = (v1) = 0'.

Konstantin Shcheglov submitted the change Change information Commit message: Patterns. Fix for

unread,

[XL] Change in dart/sdk[main]: Patterns. Fix for parsing nested pattern assigment: 'v2 = (v1) = 0'.

Konstantin Shcheglov submitted the change Change information Commit message: Patterns. Fix for

11:52 AM

Samuel Rawlins (Gerrit), … Brian Wilkerson (Gerrit)7

11:47 AM

[L] Change in dart/sdk[main]: [analysis_server] Add command/resolve to support using Interactive Fo...

Samuel Rawlins submitted the change Change information Commit message: [analysis_server] Add command/

unread,

[L] Change in dart/sdk[main]: [analysis_server] Add command/resolve to support using Interactive Fo...

Samuel Rawlins submitted the change Change information Commit message: [analysis_server] Add command/

11:47 AM

Slava Egorov (Gerrit), dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)2

10:11 AM

[XS] Change in dart/sdk[main]: [vm] Mark _OperatorEqualsAndHashCode._hashCode for inlining

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [vm] Mark _OperatorEqualsAndHashCode._hashCode for inlining

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

10:11 AM

Johnni Winther (Gerrit), Jens Johansen (Gerrit)3

9:54 AM

[S] Change in dart/sdk[main]: [analyzer] Avoid _SlowSetRange in Scanner.tokenize

Jens Johansen voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

unread,

[S] Change in dart/sdk[main]: [analyzer] Avoid _SlowSetRange in Scanner.tokenize

Jens Johansen voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

9:54 AM

Nate Bosch (Gerrit), Lasse Nielsen (Gerrit)2

8:31 AM

[S] Change in dart/sdk[main]: Use "concurrent" in place of "parallel" in docs

Attention needed from Nate Bosch Lasse Nielsen voted and added 2 comments Votes added by Lasse

unread,

[S] Change in dart/sdk[main]: Use "concurrent" in place of "parallel" in docs

Attention needed from Nate Bosch Lasse Nielsen voted and added 2 comments Votes added by Lasse

8:31 AM

Johnni Winther (Gerrit)

4:42 AM

[M] Change in dart/sdk[main]: [analyzer] Avoid more _SlowSetRange

Attention needed from Jens Johansen Johnni Winther voted and added 7 comments Votes added by Johnni

unread,

[M] Change in dart/sdk[main]: [analyzer] Avoid more _SlowSetRange

Attention needed from Jens Johansen Johnni Winther voted and added 7 comments Votes added by Johnni

4:42 AM

Sigurd Meldgaard (Gerrit), … Slava Egorov (Gerrit)4

3:54 AM

[L] Change in dart/sdk[main]: [dart:io] Support microsecond-precision file timestamps

Attention needed from Sigurd Meldgaard Slava Egorov added 4 comments File runtime/bin/file_win.cc

unread,

[L] Change in dart/sdk[main]: [dart:io] Support microsecond-precision file timestamps

Attention needed from Sigurd Meldgaard Slava Egorov added 4 comments File runtime/bin/file_win.cc

3:54 AM

Martin Kustermann (Gerrit), Srujan Gaddam (Gerrit)6

3:27 AM

[L] Change in dart/sdk[main]: [dart2wasm] Enable --gufa also in deferred loading scenario

Attention needed from Srujan Gaddam Martin Kustermann added 1 comment File pkg/dart2wasm/lib/compile.

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Enable --gufa also in deferred loading scenario

Attention needed from Srujan Gaddam Martin Kustermann added 1 comment File pkg/dart2wasm/lib/compile.

3:27 AM

Ben Konyi (Gerrit), … Slava Egorov (Gerrit)21

3:23 AM

[M] Change in dart/sdk[main]: [vm/service]: Add _readNativeMemory RPC and OS::SafeReadMemory for sa...

Attention needed from Nourhan Hasan Slava Egorov added 3 comments Patchset-level comments File-level

unread,

[M] Change in dart/sdk[main]: [vm/service]: Add _readNativeMemory RPC and OS::SafeReadMemory for sa...

Attention needed from Nourhan Hasan Slava Egorov added 3 comments Patchset-level comments File-level

3:23 AM

Kevin Moore (Gerrit), Martin Kustermann (Gerrit)9

3:03 AM

[XS] Change in dart/sdk[main]: [dart2wasm] Fix unsound type-argument check optimization on covarianc...

Attention needed from Jackson Gardner and Kevin Moore Martin Kustermann voted and added 4 comments

unread,

[XS] Change in dart/sdk[main]: [dart2wasm] Fix unsound type-argument check optimization on covarianc...

Attention needed from Jackson Gardner and Kevin Moore Martin Kustermann voted and added 4 comments

3:03 AM

Search

Clear search

Close search

Google apps

Main menu