Groups

Dart Code Reviews

1–30 of 122410

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Konstantin Shcheglov (Gerrit)

8:12 PM

[XL] Change in dart/sdk[main]: DeCo. Parse extension type primary constructor as is, recover during ...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

unread,

[XL] Change in dart/sdk[main]: DeCo. Parse extension type primary constructor as is, recover during ...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

8:12 PM

Kallen Tu (Gerrit), … Konstantin Shcheglov (Gerrit)5

8:10 PM

[XS] Change in dart/sdk[main]: DeCo. Remove variants without representation type from tests/language...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

unread,

[XS] Change in dart/sdk[main]: DeCo. Remove variants without representation type from tests/language...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

8:10 PM

Konstantin Shcheglov (Gerrit), Fedor Shcheglov (Gerrit)5

8:03 PM

[L] Change in dart/sdk[main]: Implement lazy reading/writing of EnumElement and EnumFragment.

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 4 comments File pkg/analyzer/test/

unread,

[L] Change in dart/sdk[main]: Implement lazy reading/writing of EnumElement and EnumFragment.

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 4 comments File pkg/analyzer/test/

8:03 PM

Konstantin Shcheglov (Gerrit)

Dec 23

[XL] Change in dart/sdk[main]: Renamed variables, formal parameters, and declared identifiers that w...

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 3 comments File pkg/analysis_server/

unread,

[XL] Change in dart/sdk[main]: Renamed variables, formal parameters, and declared identifiers that w...

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 3 comments File pkg/analysis_server/

Dec 23

Konstantin Shcheglov (Gerrit)

Dec 23

[XS] Change in dart/sdk[main]: Remove misleading comment.

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

unread,

[XS] Change in dart/sdk[main]: Remove misleading comment.

Attention needed from Fedor Shcheglov Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

Dec 23

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)4

Dec 23

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File pkg/vm/lib/modular/

unread,

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File pkg/vm/lib/modular/

Dec 23

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)6

Dec 23

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Commit Queue submitted the change Change information Commit message: meta: Annotate nonVirtual with

unread,

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Commit Queue submitted the change Change information Commit message: meta: Annotate nonVirtual with

Dec 23

Daco Harkes (Gerrit), … Commit Queue (Gerrit)4

Dec 23

[M] Change in dart/sdk[main]: [test] Change the `record_use` tests to semantic equality

Commit Queue submitted the change Change information Commit message: [test] Change the `record_use`

unread,

[M] Change in dart/sdk[main]: [test] Change the `record_use` tests to semantic equality

Commit Queue submitted the change Change information Commit message: [test] Change the `record_use`

Dec 23

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)6

Dec 23

[S] Change in dart/sdk[main]: [dart2wasm] compile_benchmark: always run wasm-opt when optimizations...

Commit Queue submitted the change Change information Commit message: [dart2wasm] compile_benchmark:

unread,

[S] Change in dart/sdk[main]: [dart2wasm] compile_benchmark: always run wasm-opt when optimizations...

Commit Queue submitted the change Change information Commit message: [dart2wasm] compile_benchmark:

Dec 23

Ömer Ağacan (Gerrit), Nate Biggs (Gerrit)5

Dec 23

[S] Change in dart/sdk[main]: [dart2wasm] Fix --strip-wasm handling in dart compile CLI

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs voted and added 1 comment Votes

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix --strip-wasm handling in dart compile CLI

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs voted and added 1 comment Votes

Dec 23

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Dec 23

[XS] Change in dart/sdk[main]: DeCo. Remove duplicate filtering for ExtensionTypeElement interfaces.

Commit Queue submitted the change Change information Commit message: DeCo. Remove duplicate filtering

unread,

[XS] Change in dart/sdk[main]: DeCo. Remove duplicate filtering for ExtensionTypeElement interfaces.

Commit Queue submitted the change Change information Commit message: DeCo. Remove duplicate filtering

Dec 23

Johnni Winther (Gerrit)2

Dec 23

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Add Argument nodes

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Add Argument nodes

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

Dec 23

Johnni Winther (Gerrit), … Daco Harkes (Gerrit)14

Dec 23

[XL] Change in dart/sdk[main]: [dart2js] Migrate resource identifiers output to record use

Daco Harkes added 1 comment File pkg/compiler/lib/src/ir/annotations.dart Line 428, Patchset 31:

unread,

[XL] Change in dart/sdk[main]: [dart2js] Migrate resource identifiers output to record use

Daco Harkes added 1 comment File pkg/compiler/lib/src/ir/annotations.dart Line 428, Patchset 31:

Dec 23

Johnni Winther (Gerrit)

Dec 23

[XL] Change in dart/sdk[main]: [parser][InternalNodes] Add handlePositionalArgument and handlePositi...

Attention needed from Jens Johansen Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[XL] Change in dart/sdk[main]: [parser][InternalNodes] Add handlePositionalArgument and handlePositi...

Attention needed from Jens Johansen Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

Dec 23

Johnni Winther (Gerrit)

Dec 23

[XL] Change in dart/sdk[main]: [parser] Add handlePositionalArgument and handlePositionalRecordField

Johnni Winther abandoned this change Related details Attention set is empty Submit Requirements: Code

unread,

[XL] Change in dart/sdk[main]: [parser] Add handlePositionalArgument and handlePositionalRecordField

Johnni Winther abandoned this change Related details Attention set is empty Submit Requirements: Code

Dec 23

Ömer Ağacan (Gerrit), Nate Biggs (Gerrit)13

Dec 23

[L] Change in dart/sdk[main]: [dart2wasm] Catch JS exceptions with the right tag, improve toString ...

Attention needed from Martin Kustermann and Nate Biggs Ömer Ağacan added 2 comments File pkg/

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Catch JS exceptions with the right tag, improve toString ...

Attention needed from Martin Kustermann and Nate Biggs Ömer Ağacan added 2 comments File pkg/

Dec 23

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Dec 22

[M] Change in dart/sdk[main]: Fix a bug where renaming a field formal parameter would not rename th...

Commit Queue submitted the change Change information Commit message: Fix a bug where renaming a field

unread,

[M] Change in dart/sdk[main]: Fix a bug where renaming a field formal parameter would not rename th...

Commit Queue submitted the change Change information Commit message: Fix a bug where renaming a field

Dec 22

Alexander Markov (Gerrit), … Alexander Aprelev (Gerrit)9

Dec 22

[XL] Change in dart/sdk[main]: [vm/shared] Ensure stores into shared static variables are checked.

Alexander Aprelev abandoned this change Related details Attention set is empty Submit Requirements:

unread,

[XL] Change in dart/sdk[main]: [vm/shared] Ensure stores into shared static variables are checked.

Alexander Aprelev abandoned this change Related details Attention set is empty Submit Requirements:

Dec 22

Ömer Ağacan (Gerrit), Nate Biggs (Gerrit)3

Dec 22

[XS] Change in dart/sdk[main]: [dart2wasm] Use == instead of identical for when converting value types

Ömer Ağacan abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[XS] Change in dart/sdk[main]: [dart2wasm] Use == instead of identical for when converting value types

Ömer Ağacan abandoned this change Related details Attention set is empty Submit Requirements: Code-

Dec 22

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)4

Dec 22

[L] Change in dart/sdk[main]: [test_runner] Show hidden flags in `--help` with `--verbose`

Commit Queue submitted the change Change information Commit message: [test_runner] Show hidden flags

unread,

[L] Change in dart/sdk[main]: [test_runner] Show hidden flags in `--help` with `--verbose`

Commit Queue submitted the change Change information Commit message: [test_runner] Show hidden flags

Dec 22

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

Dec 21

[M] Change in dart/sdk[main]: analyzer: Remove some deprecated items related to analysis options

Commit Queue submitted the change Change information Commit message: analyzer: Remove some deprecated

unread,

[M] Change in dart/sdk[main]: analyzer: Remove some deprecated items related to analysis options

Commit Queue submitted the change Change information Commit message: analyzer: Remove some deprecated

Dec 21

Parker Lougheed (Gerrit)

Dec 20

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Parker Lougheed has uploaded the change for review Commit message [sdk] Update dart.dev links in dart

unread,

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Parker Lougheed has uploaded the change for review Commit message [sdk] Update dart.dev links in dart

Dec 20

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)10

Dec 20

[M] Change in dart/sdk[main]: [analyzer_plugin] Fixes writing recursive type parameter

Attention needed from Erik Ernst, Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-

unread,

[M] Change in dart/sdk[main]: [analyzer_plugin] Fixes writing recursive type parameter

Attention needed from Erik Ernst, Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-

Dec 20

Brian Wilkerson (Gerrit), … Konstantin Shcheglov (Gerrit)4

Dec 19

[L] Change in dart/sdk[main]: analyzer: Move the mock 'dart:ui' library to the mock SDK

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

unread,

[L] Change in dart/sdk[main]: analyzer: Move the mock 'dart:ui' library to the mock SDK

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

Dec 19

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[M] Change in dart/sdk[main]: [DAS] Fixes go to imports for annotations constructors

Commit Queue submitted the change Change information Commit message: [DAS] Fixes go to imports for

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes go to imports for annotations constructors

Commit Queue submitted the change Change information Commit message: [DAS] Fixes go to imports for

Dec 19

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[M] Change in dart/sdk[main]: [DAS] Fixes import with prefix to work with annotations

Commit Queue submitted the change Change information Commit message: [DAS] Fixes import with prefix

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes import with prefix to work with annotations

Commit Queue submitted the change Change information Commit message: [DAS] Fixes import with prefix

Dec 19

Brian Wilkerson (Gerrit), … Samuel Rawlins (Gerrit)3

Dec 19

[XS] Change in dart/sdk[main]: Rev tools to 125b9a9a5556fa88ecec26f649e1cddb1623aa2f

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

unread,

[XS] Change in dart/sdk[main]: Rev tools to 125b9a9a5556fa88ecec26f649e1cddb1623aa2f

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

Dec 19

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused bash function find_flags

Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused bash

unread,

[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused bash function find_flags

Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused bash

Dec 19

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)9

Dec 19

[S] Change in dart/sdk[main]: Add documentation for the deprecated_factory_method warning

Commit Queue submitted the change Change information Commit message: Add documentation for the

unread,

[S] Change in dart/sdk[main]: Add documentation for the deprecated_factory_method warning

Commit Queue submitted the change Change information Commit message: Add documentation for the

Dec 19

Samuel Rawlins (Gerrit), … Konstantin Shcheglov (Gerrit)7

Dec 19

[M] Change in dart/sdk[main]: analyzer: For must_be_immutable, check fields declared in primary con...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

unread,

[M] Change in dart/sdk[main]: analyzer: For must_be_immutable, check fields declared in primary con...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

Dec 19

Search

Clear search

Close search

Google apps

Main menu