Dart Code Reviews

Contact owners and managers

1–30 of 112975

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Elliott Brooks (Gerrit), … Danny Tuppeny (Gerrit)8

8:25 PM

[M] Change in dart/sdk[main]: [DAP] Set `requirePermissionToResume` and `requireUserPermissionToRes...

Attention needed from Ben Konyi and Danny Tuppeny Elliott Brooks added 1 comment Patchset-level

unread,

[M] Change in dart/sdk[main]: [DAP] Set `requirePermissionToResume` and `requireUserPermissionToRes...

Attention needed from Ben Konyi and Danny Tuppeny Elliott Brooks added 1 comment Patchset-level

8:25 PM

Phil Quitslund (Gerrit), … Commit Queue (Gerrit)3

8:13 PM

[XL] Change in dart/sdk[main]: Augment. Build extension type elements.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[XL] Change in dart/sdk[main]: Augment. Build extension type elements.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

8:13 PM

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)2

6:13 PM

[M] Change in dart/sdk[main]: Fixed `@doNotSubmit` to prohibit same-library, allow nested functions.

Attention needed from Matan Lurey and Samuel Rawlins Brian Wilkerson added 2 comments File pkg/

unread,

[M] Change in dart/sdk[main]: Fixed `@doNotSubmit` to prohibit same-library, allow nested functions.

Attention needed from Matan Lurey and Samuel Rawlins Brian Wilkerson added 2 comments File pkg/

6:13 PM

Alexander Markov (Gerrit), Siva Annamalai (Gerrit)2

5:33 PM

[S] Change in dart/sdk[beta]: [beta] [tfa] Fix crash when building field guard summary with capture...

Attention needed from Alexander Markov and Slava Egorov Siva Annamalai voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[beta]: [beta] [tfa] Fix crash when building field guard summary with capture...

Attention needed from Alexander Markov and Slava Egorov Siva Annamalai voted Code-Review+1 Code-

5:33 PM

Matan Lurey (Gerrit), … Phil Quitslund (Gerrit)8

4:46 PM

[S] Change in dart/sdk[main]: Remove linting of empty string literals.

Attention needed from Brian Wilkerson and Samuel Rawlins Matan Lurey added 1 comment File pkg/linter/

unread,

[S] Change in dart/sdk[main]: Remove linting of empty string literals.

Attention needed from Brian Wilkerson and Samuel Rawlins Matan Lurey added 1 comment File pkg/linter/

4:46 PM

Phil Quitslund (Gerrit), … Commit Queue (Gerrit)3

4:01 PM

[S] Change in dart/sdk[main]: Write library units before augmentations.

Commit Queue submitted the change Change information Commit message: Write library units before

unread,

[S] Change in dart/sdk[main]: Write library units before augmentations.

Commit Queue submitted the change Change information Commit message: Write library units before

4:01 PM

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)9

3:49 PM

[S] Change in dart/sdk[main]: [analysis_server] Fix AddDiagnosticPropertyReference when in augmenta...

Commit Queue submitted the change Change information Commit message: [analysis_server] Fix

unread,

[S] Change in dart/sdk[main]: [analysis_server] Fix AddDiagnosticPropertyReference when in augmenta...

Commit Queue submitted the change Change information Commit message: [analysis_server] Fix

3:49 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

2:37 PM

[M] Change in dart/sdk[main]: Ignore abstract classes, mixins, sealed classes.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[M] Change in dart/sdk[main]: Ignore abstract classes, mixins, sealed classes.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

2:37 PM

Rajesh Malviya (Gerrit), … Kevin Moore (Gerrit)5

2:28 PM

[L] Change in dart/sdk[main]: [lib/math] Implement fillRange for Random

Attention needed from Lasse Nielsen, Rajesh Malviya, Stephen Adams and Ömer Ağacan Kevin Moore added

unread,

[L] Change in dart/sdk[main]: [lib/math] Implement fillRange for Random

Attention needed from Lasse Nielsen, Rajesh Malviya, Stephen Adams and Ömer Ağacan Kevin Moore added

2:28 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

1:32 PM

[M] Change in dart/sdk[main]: DAS: Remove unnecessary BaseProcessor

Commit Queue submitted the change Change information Commit message: DAS: Remove unnecessary

unread,

[M] Change in dart/sdk[main]: DAS: Remove unnecessary BaseProcessor

Commit Queue submitted the change Change information Commit message: DAS: Remove unnecessary

1:32 PM

Stephen Adams (Gerrit), … Srujan Gaddam (Gerrit)5

12:15 PM

[L] Change in dart/sdk[main]: [web] Unify [Expando]/[WeakReference]/[Finalizer] implementation on t...

Attention needed from Martin Kustermann and Stephen Adams Srujan Gaddam added 1 comment Patchset-

unread,

[L] Change in dart/sdk[main]: [web] Unify [Expando]/[WeakReference]/[Finalizer] implementation on t...

Attention needed from Martin Kustermann and Stephen Adams Srujan Gaddam added 1 comment Patchset-

12:15 PM

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)5

11:54 AM

[S] Change in dart/sdk[main]: [dds/dap] Don't untruncate toString() values in debug views

Commit Queue submitted the change Change information Commit message: [dds/dap] Don't untruncate

unread,

[S] Change in dart/sdk[main]: [dds/dap] Don't untruncate toString() values in debug views

Commit Queue submitted the change Change information Commit message: [dds/dap] Don't untruncate

11:54 AM

Ben Konyi (Gerrit), … Commit Queue (Gerrit)3

11:37 AM

[S] Change in dart/sdk[main]: [dds/dap] Don't include empty output events when output ends with \n

Commit Queue submitted the change Change information Commit message: [dds/dap] Don't include

unread,

[S] Change in dart/sdk[main]: [dds/dap] Don't include empty output events when output ends with \n

Commit Queue submitted the change Change information Commit message: [dds/dap] Don't include

11:37 AM

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)6

11:12 AM

[M] Change in dart/sdk[main]: [analysis_server] Fix missing types on factory constructor arguments ...

Commit Queue submitted the change Change information Commit message: [analysis_server] Fix missing

unread,

[M] Change in dart/sdk[main]: [analysis_server] Fix missing types on factory constructor arguments ...

Commit Queue submitted the change Change information Commit message: [analysis_server] Fix missing

11:12 AM

Daco Harkes (Gerrit), … Lasse Nielsen (Gerrit)20

11:08 AM

[XL] Change in dart/sdk[main]: [vm/ffi] `address` of operator for FFI leaf calls

Attention needed from Martin Kustermann Daco Harkes voted and added 6 comments Votes added by Daco

unread,

[XL] Change in dart/sdk[main]: [vm/ffi] `address` of operator for FFI leaf calls

Attention needed from Martin Kustermann Daco Harkes voted and added 6 comments Votes added by Daco

11:08 AM

Ben Konyi (Gerrit), … Commit Queue (Gerrit)4

10:44 AM

[S] Change in dart/sdk[main]: [ VM ] Remove hard coded line and token numbers from JSON_JSONStream_...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[S] Change in dart/sdk[main]: [ VM ] Remove hard coded line and token numbers from JSON_JSONStream_...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

10:44 AM

Jens Johansen (Gerrit)

10:21 AM

[XL] Change in dart/sdk[main]: [parser] Listener calls should not be on the next (unrelated) token

Attention needed from Brian Wilkerson and Johnni Winther Jens Johansen added 1 comment Patchset-level

unread,

[XL] Change in dart/sdk[main]: [parser] Listener calls should not be on the next (unrelated) token

Attention needed from Brian Wilkerson and Johnni Winther Jens Johansen added 1 comment Patchset-level

10:21 AM

Alexander Markov (Gerrit), … Commit Queue (Gerrit)3

10:17 AM

[S] Change in dart/sdk[main]: [vm] Fix pragma vm:unsafe:no-interrupts

Commit Queue submitted the change Change information Commit message: [vm] Fix pragma vm:unsafe:no-

unread,

[S] Change in dart/sdk[main]: [vm] Fix pragma vm:unsafe:no-interrupts

Commit Queue submitted the change Change information Commit message: [vm] Fix pragma vm:unsafe:no-

10:17 AM

Oleh Prypin (Gerrit), … Commit Queue (Gerrit)7

10:12 AM

[XL] Change in dart/sdk[main]: DAS plugins: Move CorrectionUtils to analysis_server_plugin

Commit Queue submitted the change Change information Commit message: DAS plugins: Move

unread,

[XL] Change in dart/sdk[main]: DAS plugins: Move CorrectionUtils to analysis_server_plugin

Commit Queue submitted the change Change information Commit message: DAS plugins: Move

10:12 AM

Daco Harkes (Gerrit), … Commit Queue (Gerrit)4

7:00 AM

[XS] Change in dart/sdk[main]: [gardening] Skip test in iso-stress

Commit Queue submitted the change Change information Commit message: [gardening] Skip test in iso-

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip test in iso-stress

Commit Queue submitted the change Change information Commit message: [gardening] Skip test in iso-

7:00 AM

Martin Kustermann (Gerrit), … Commit Queue (Gerrit)4

6:03 AM

[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in restoration of `this` in async functions.

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix bug in

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Fix bug in restoration of `this` in async functions.

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix bug in

6:03 AM

Slava Egorov (Gerrit), … Commit Queue (Gerrit)5

4:52 AM

[L] Change in dart/sdk[main]: [vm] Add vm:align-loops pragma

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[L] Change in dart/sdk[main]: [vm] Add vm:align-loops pragma

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

4:52 AM

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)4

4:05 AM

[M] Change in dart/sdk[main]: [dart2wasm] Simplify libraries.yaml setup:

Commit Queue submitted the change Change information Commit message: [dart2wasm] Simplify libraries.

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Simplify libraries.yaml setup:

Commit Queue submitted the change Change information Commit message: [dart2wasm] Simplify libraries.

4:05 AM

William Hesse (Gerrit), … Commit Queue (Gerrit)7

Apr 23

[L] Change in dart/sdk[main]: [test] Convert most lib/mirrors multitests to static error tests

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[L] Change in dart/sdk[main]: [test] Convert most lib/mirrors multitests to static error tests

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Apr 23

William Hesse (Gerrit), … Commit Queue (Gerrit)7

Apr 23

[S] Change in dart/sdk[main]: [test] Convert syntax_native_test to a static error test

Commit Queue submitted the change Change information Commit message: [test] Convert

unread,

[S] Change in dart/sdk[main]: [test] Convert syntax_native_test to a static error test

Commit Queue submitted the change Change information Commit message: [test] Convert

Apr 23

Kallen Tu (Gerrit), … Commit Queue (Gerrit)6

Apr 23

[M] Change in dart/sdk[main]: [analyzer] Const: Add assert message for assert errors.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[M] Change in dart/sdk[main]: [analyzer] Const: Add assert message for assert errors.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Apr 23

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

Apr 23

[S] Change in dart/sdk[main]: analyzer: add CHANGELOG entry regarding doNotSubmit and mustBeConst

Commit Queue submitted the change Change information Commit message: analyzer: add CHANGELOG entry

unread,

[S] Change in dart/sdk[main]: analyzer: add CHANGELOG entry regarding doNotSubmit and mustBeConst

Commit Queue submitted the change Change information Commit message: analyzer: add CHANGELOG entry

Apr 23

Phil Quitslund (Gerrit), … Commit Queue (Gerrit)4

Apr 23

[L] Change in dart/sdk[main]: Augment. Move primaryConstructor, representation, typeErasure into Au...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[L] Change in dart/sdk[main]: Augment. Move primaryConstructor, representation, typeErasure into Au...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Apr 23

Derek Xu (Gerrit), … Alexander Aprelev (Gerrit)6

Apr 23

[L] Change in dart/sdk[main]: [VM/Debugger] Force valid breakpoints to resolve by ensuring function...

Attention needed from Derek Xu and Ryan Macnak Alexander Aprelev added 1 comment File runtime/vm/

unread,

[L] Change in dart/sdk[main]: [VM/Debugger] Force valid breakpoints to resolve by ensuring function...

Attention needed from Derek Xu and Ryan Macnak Alexander Aprelev added 1 comment File runtime/vm/

Apr 23

Alexander Markov (Gerrit), … Commit Queue (Gerrit)4

Apr 23

[S] Change in dart/sdk[main]: [tfa] Fix crash when building field guard summary with captured receiver

Commit Queue submitted the change Change information Commit message: [tfa] Fix crash when building

unread,

[S] Change in dart/sdk[main]: [tfa] Fix crash when building field guard summary with captured receiver

Commit Queue submitted the change Change information Commit message: [tfa] Fix crash when building

Apr 23

Search

Clear search

Close search

Google apps

Main menu