Groups

Dart Code Reviews

1–30 of 121606

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Kallen Tu (Gerrit)

9:18 PM

[L] Change in dart/sdk[main]: [tests] Declaring constructors - Tests for initializers, const, and m...

Attention needed from Erik Ernst Kallen Tu added 1 comment File tests/language/declaring_constructors

unread,

[L] Change in dart/sdk[main]: [tests] Declaring constructors - Tests for initializers, const, and m...

Attention needed from Erik Ernst Kallen Tu added 1 comment File tests/language/declaring_constructors

9:18 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)11

9:09 PM

[XL] Change in dart/sdk[main]: DeCo. Add AST for primary constructors behind feature flag.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 12 is the latest

unread,

[XL] Change in dart/sdk[main]: DeCo. Add AST for primary constructors behind feature flag.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 12 is the latest

9:09 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

8:51 PM

[S] Change in dart/sdk[main]: [vm] Synchronize between switchable call patching and loading in the ...

Commit Queue submitted the change Change information Commit message: [vm] Synchronize between

unread,

[S] Change in dart/sdk[main]: [vm] Synchronize between switchable call patching and loading in the ...

Commit Queue submitted the change Change information Commit message: [vm] Synchronize between

8:51 PM

Brian Wilkerson (Gerrit), … Konstantin Shcheglov (Gerrit)15

8:36 PM

[L] Change in dart/sdk[main]: DeCo. AST for PrimaryConstructorDeclaration and ClassBody.

Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/dart/ast/ast.dart Line 3049, Patchset

unread,

[L] Change in dart/sdk[main]: DeCo. AST for PrimaryConstructorDeclaration and ClassBody.

Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/dart/ast/ast.dart Line 3049, Patchset

8:36 PM

Konstantin Shcheglov (Gerrit)

8:34 PM

[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandConstructorInvocation to E...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandConstructorInvocation to E...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

8:34 PM

Devon Carew (Gerrit), … Commit Queue (Gerrit)3

8:24 PM

[XS] Change in dart/sdk[main]: [deps] rev protobuf, tools, web, webdev

Commit Queue submitted the change Change information Commit message: [deps] rev protobuf, tools, web,

unread,

[XS] Change in dart/sdk[main]: [deps] rev protobuf, tools, web, webdev

Commit Queue submitted the change Change information Commit message: [deps] rev protobuf, tools, web,

8:24 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)5

8:24 PM

[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandInvocation to ExitDetector.

Commit Queue submitted the change Change information Commit message: Implement a visitor method for

unread,

[S] Change in dart/sdk[main]: Implement a visitor method for DotShorthandInvocation to ExitDetector.

Commit Queue submitted the change Change information Commit message: Implement a visitor method for

8:24 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

7:46 PM

[M] Change in dart/sdk[main]: Fine. Fix for NPE when re-exporting dart:core with its in-nowhere dyn...

Commit Queue submitted the change Change information Commit message: Fine. Fix for NPE when re-

unread,

[M] Change in dart/sdk[main]: Fine. Fix for NPE when re-exporting dart:core with its in-nowhere dyn...

Commit Queue submitted the change Change information Commit message: Fine. Fix for NPE when re-

7:46 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

7:42 PM

[M] Change in dart/sdk[main]: Fine. Fix for crash when constructor field initializer uses not seria...

Commit Queue submitted the change Change information Commit message: Fine. Fix for crash when

unread,

[M] Change in dart/sdk[main]: Fine. Fix for crash when constructor field initializer uses not seria...

Commit Queue submitted the change Change information Commit message: Fine. Fix for crash when

7:42 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

7:32 PM

[S] Change in dart/sdk[main]: CQ. Fix NPE in DartUnitOccurrencesComputerVisitor when unresolved imp...

Commit Queue submitted the change Change information Commit message: CQ. Fix NPE in

unread,

[S] Change in dart/sdk[main]: CQ. Fix NPE in DartUnitOccurrencesComputerVisitor when unresolved imp...

Commit Queue submitted the change Change information Commit message: CQ. Fix NPE in

7:32 PM

Konstantin Shcheglov (Gerrit)

7:26 PM

[S] Change in dart/sdk[main]: Add a visitor for DotShorthandInvocation to exit_detector, and add te...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[S] Change in dart/sdk[main]: Add a visitor for DotShorthandInvocation to exit_detector, and add te...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

7:26 PM

Ryan Macnak (Gerrit)

6:59 PM

[S] Change in dart/sdk[main]: Roll Clang from 9d7449a82b83 to 8b93f27cf7e6

Attention needed from Brian Quinlan New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: Roll Clang from 9d7449a82b83 to 8b93f27cf7e6

Attention needed from Brian Quinlan New activity on the change Open in Gerrit Related details

6:59 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

6:58 PM

[S] Change in dart/sdk[main]: [vm] Fix TSAN symbolization for Mac.

Commit Queue submitted the change Change information Commit message: [vm] Fix TSAN symbolization for

unread,

[S] Change in dart/sdk[main]: [vm] Fix TSAN symbolization for Mac.

Commit Queue submitted the change Change information Commit message: [vm] Fix TSAN symbolization for

6:58 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

6:36 PM

[XS] Change in dart/sdk[main]: [vm] Fix Android ARM32 build.

Commit Queue submitted the change Change information Commit message: [vm] Fix Android ARM32 build.

unread,

[XS] Change in dart/sdk[main]: [vm] Fix Android ARM32 build.

Commit Queue submitted the change Change information Commit message: [vm] Fix Android ARM32 build.

6:36 PM

Konstantin Shcheglov (Gerrit)

5:39 PM

[S] Change in dart/sdk[main]: CQ. Fix for NPE in RequiredParametersVerifier.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[S] Change in dart/sdk[main]: CQ. Fix for NPE in RequiredParametersVerifier.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

5:39 PM

Ryan Macnak (Gerrit)

5:25 PM

[M] Change in dart/sdk[main]: [vm, compiler] Refactor IA32 leaf runtime calls to be more like the o...

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm, compiler] Refactor IA32 leaf runtime calls to be more like the o...

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

5:25 PM

Ryan Macnak (Gerrit)

5:24 PM

[S] Change in dart/sdk[main]: [dartfuzz] Fix flag fuzzer after dart2wasm change that requires outpu...

Attention needed from Martin Kustermann New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [dartfuzz] Fix flag fuzzer after dart2wasm change that requires outpu...

Attention needed from Martin Kustermann New activity on the change Open in Gerrit Related details

5:24 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

5:13 PM

[M] Change in dart/sdk[main]: analyzer: Detect and report usage of redirected-constructor parameters

Commit Queue submitted the change Change information Commit message: analyzer: Detect and report

unread,

[M] Change in dart/sdk[main]: analyzer: Detect and report usage of redirected-constructor parameters

Commit Queue submitted the change Change information Commit message: analyzer: Detect and report

5:13 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

4:46 PM

[S] Change in dart/sdk[main]: CHANGELOG entries for analyzer packages

Commit Queue submitted the change Change information Commit message: CHANGELOG entries for analyzer

unread,

[S] Change in dart/sdk[main]: CHANGELOG entries for analyzer packages

Commit Queue submitted the change Change information Commit message: CHANGELOG entries for analyzer

4:46 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)15

4:37 PM

[XL] Change in dart/sdk[main]: [analyzer] Migrates to `contexMessages` from `analyzer_testing` package

Commit Queue submitted the change Change information Commit message: [analyzer] Migrates to `

unread,

[XL] Change in dart/sdk[main]: [analyzer] Migrates to `contexMessages` from `analyzer_testing` package

Commit Queue submitted the change Change information Commit message: [analyzer] Migrates to `

4:37 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

3:58 PM

[M] Change in dart/sdk[main]: analyzer: Remove AnalysisErrorListener and friends

Commit Queue submitted the change Change information Commit message: analyzer: Remove

unread,

[M] Change in dart/sdk[main]: analyzer: Remove AnalysisErrorListener and friends

Commit Queue submitted the change Change information Commit message: analyzer: Remove

3:58 PM

Samuel Rawlins (Gerrit), Konstantin Shcheglov (Gerrit)3

2:41 PM

[XS] Change in dart/sdk[main]: Release analysis_server_plugin 0.3.3, analyzer_testing 0.1.5

Samuel Rawlins abandoned this change Related details Attention set is empty Submit Requirements: Code

unread,

[XS] Change in dart/sdk[main]: Release analysis_server_plugin 0.3.3, analyzer_testing 0.1.5

Samuel Rawlins abandoned this change Related details Attention set is empty Submit Requirements: Code

2:41 PM

Felipe Morschel (Gerrit), Brian Wilkerson (Gerrit)2

2:35 PM

[S] Change in dart/sdk[main]: [DAS] Fixes `Convert to switch statement` for expression and single c...

Attention needed from Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-Review +1 Commit-

unread,

[S] Change in dart/sdk[main]: [DAS] Fixes `Convert to switch statement` for expression and single c...

Attention needed from Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-Review +1 Commit-

2:35 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

2:27 PM

[S] Change in dart/sdk[main]: [DAS] Makes sure `Go to Definition` on `FunctionType.call` is correct

Commit Queue submitted the change Change information Commit message: [DAS] Makes sure `Go to

unread,

[S] Change in dart/sdk[main]: [DAS] Makes sure `Go to Definition` on `FunctionType.call` is correct

Commit Queue submitted the change Change information Commit message: [DAS] Makes sure `Go to

2:27 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)5

1:49 PM

[L] Change in dart/sdk[main]: [vm] Record stack for JIT TSAN.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 24 is the latest

unread,

[L] Change in dart/sdk[main]: [vm] Record stack for JIT TSAN.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 24 is the latest

1:49 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)6

1:07 PM

[L] Change in dart/sdk[main]: Fine. Fix NPE when constant expression uses operator of unnamed exten...

Commit Queue submitted the change Change information Commit message: Fine. Fix NPE when constant

unread,

[L] Change in dart/sdk[main]: Fine. Fix NPE when constant expression uses operator of unnamed exten...

Commit Queue submitted the change Change information Commit message: Fine. Fix NPE when constant

1:07 PM

Felipe Morschel (Gerrit)

1:06 PM

[L] Change in dart/sdk[main]: [DAS] Adds new `Split when condition` assist

Felipe Morschel has uploaded the change for review Commit message [DAS] Adds new `Split when

unread,

[L] Change in dart/sdk[main]: [DAS] Adds new `Split when condition` assist

Felipe Morschel has uploaded the change for review Commit message [DAS] Adds new `Split when

1:06 PM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)4

11:35 AM

[XS] Change in dart/sdk[main]: [analyzer] Include static-extensions in experimentsForTests

Commit Queue submitted the change Change information Commit message: [analyzer] Include static-

unread,

[XS] Change in dart/sdk[main]: [analyzer] Include static-extensions in experimentsForTests

Commit Queue submitted the change Change information Commit message: [analyzer] Include static-

11:35 AM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)7

11:23 AM

[M] Change in dart/sdk[main]: [analysis_server] Update LSP Selection Range tests to use EOL normali...

Commit Queue submitted the change Change information Commit message: [analysis_server] Update LSP

unread,

[M] Change in dart/sdk[main]: [analysis_server] Update LSP Selection Range tests to use EOL normali...

Commit Queue submitted the change Change information Commit message: [analysis_server] Update LSP

11:23 AM

Felipe Morschel (Gerrit)

9:53 AM

[M] Change in dart/sdk[main]: [DAS] Fixes occurrences for `FunctionType.call`

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes occurrences for `

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes occurrences for `FunctionType.call`

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes occurrences for `

9:53 AM

Search

Clear search

Close search

Google apps

Main menu