[dart-lang/sdk] b18b1c: CQ. Remove FeatureSets.latestWithVariance, already...
0 views
Skip to first unread message
Konstantin Scheglov
11:12 AM (11 hours ago) 11:12 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Felipe Morschel
12:57 PM (9 hours ago) 12:57 PM
to com...@dartlang.org
Branch: refs/heads/lkgr
https://github.com/dart-lang/sdk/commit/f2de280b40e903ff6eaa2108f0eba8a84efcef16
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
Log Message:
-----------
DeCo. Report initializingFormalForNonExistentField for primary constructors.
Change-Id: I42d2516902a0d7c2a3eb914d39afe01a10d4bf86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482640
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: e8df76286e8a958da6253a0623738a6bea2750c1
https://github.com/dart-lang/sdk/commit/e8df76286e8a958da6253a0623738a6bea2750c1
Author: FMorschel <g...@fmorschel.dev>
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
Log Message:
-----------
[analysis_server_plugin] Skips files that are analyzer excluded.
Fixes: https://github.com/dart-lang/sdk/issues/62729
Change-Id: I4b60ad02b10009decfa091d8dce84a0e765a7b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482460
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 265b75c74e46e1a6a1543f261633d92e264082e1
https://github.com/dart-lang/sdk/commit/265b75c74e46e1a6a1543f261633d92e264082e1
Author: Sam Rawlins <sraw...@google.com>
M pkg/linter/test/rules/cancel_subscriptions_test.dart
Log Message:
-----------
linter: leak_detectors: fix case for method invocation with no target
Fixes new failures in flutter bot: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8689087561632725585/+/u/analyze_Flutter_repositories/stdout?format=raw
Regression introduced by https://dart-review.googlesource.com/c/sdk/+/482444
The bug was that we bailed out too early, when looking at a method
invocation, and we are deciding whether it might represent a valid
cancelation. There are some checks that are only valid if the invocation
has a real target. But there are other checks that should be made even
if the function has an implicit target.
Change-Id: Id67d381aa1f78de8bf0f264a962ee2bbbdc6a030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482860
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: 94c31ded4ab1f7f9379d9148b1a93666a3a904be
https://github.com/dart-lang/sdk/commit/94c31ded4ab1f7f9379d9148b1a93666a3a904be
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
Log Message:
-----------
DeCo. Extract visitClassDeclaration, visitExtensionDeclaration, visitExtensionTypeDeclaration into ScopeContext.
Change-Id: Ic9c15bfe66326625a91b1cc813204251b6eb36a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482620
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
https://github.com/dart-lang/sdk/commit/1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
Author: FMorschel <g...@fmorschel.dev>
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
Log Message:
-----------
[analyzer_plugin] Fixes recursive type writing on `DartEditBuilder.writeType`
Fixes: https://github.com/dart-lang/sdk/issues/62549
Change-Id: Ia5f8b7cf7f923d63a73a9b155d1590052a61eaa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476800
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/ba4bfeabdade...1f8861f4f972
Home: https://github.com/dart-lang/sdk
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: f2de280b40e903ff6eaa2108f0eba8a84efcef16
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
https://github.com/dart-lang/sdk/commit/f2de280b40e903ff6eaa2108f0eba8a84efcef16
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/generated/error_verifier.dart
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
Log Message:
-----------
DeCo. Report initializingFormalForNonExistentField for primary constructors.
Change-Id: I42d2516902a0d7c2a3eb914d39afe01a10d4bf86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482640
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: e8df76286e8a958da6253a0623738a6bea2750c1
https://github.com/dart-lang/sdk/commit/e8df76286e8a958da6253a0623738a6bea2750c1
Author: FMorschel <g...@fmorschel.dev>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
Changed paths:
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
Log Message:
-----------
[analysis_server_plugin] Skips files that are analyzer excluded.
Fixes: https://github.com/dart-lang/sdk/issues/62729
Change-Id: I4b60ad02b10009decfa091d8dce84a0e765a7b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482460
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 265b75c74e46e1a6a1543f261633d92e264082e1
https://github.com/dart-lang/sdk/commit/265b75c74e46e1a6a1543f261633d92e264082e1
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/linter/lib/src/util/leak_detector_visitor.dart
Changed paths:
M pkg/linter/test/rules/cancel_subscriptions_test.dart
Log Message:
-----------
linter: leak_detectors: fix case for method invocation with no target
Fixes new failures in flutter bot: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8689087561632725585/+/u/analyze_Flutter_repositories/stdout?format=raw
Regression introduced by https://dart-review.googlesource.com/c/sdk/+/482444
The bug was that we bailed out too early, when looking at a method
invocation, and we are deciding whether it might represent a valid
cancelation. There are some checks that are only valid if the invocation
has a real target. But there are other checks that should be made even
if the function has an implicit target.
Change-Id: Id67d381aa1f78de8bf0f264a962ee2bbbdc6a030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482860
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: 94c31ded4ab1f7f9379d9148b1a93666a3a904be
https://github.com/dart-lang/sdk/commit/94c31ded4ab1f7f9379d9148b1a93666a3a904be
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
Log Message:
-----------
DeCo. Extract visitClassDeclaration, visitExtensionDeclaration, visitExtensionTypeDeclaration into ScopeContext.
Change-Id: Ic9c15bfe66326625a91b1cc813204251b6eb36a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482620
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
https://github.com/dart-lang/sdk/commit/1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
Author: FMorschel <g...@fmorschel.dev>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
Changed paths:
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
Log Message:
-----------
[analyzer_plugin] Fixes recursive type writing on `DartEditBuilder.writeType`
Fixes: https://github.com/dart-lang/sdk/issues/62549
Change-Id: Ia5f8b7cf7f923d63a73a9b155d1590052a61eaa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476800
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/ba4bfeabdade...1f8861f4f972
Reply all
Reply to author
Forward
0 new messages