[dart-lang/sdk] 6de258: [vm/ffi] Migrate legacy multi-test files to Proces...

0 views
Skip to first unread message

Ankit Ranjan

unread,
10:27 AM (5 hours ago) 10:27 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 6de2588d56220c93e212c9674712e1f01548d5f9
https://github.com/dart-lang/sdk/commit/6de2588d56220c93e212c9674712e1f01548d5f9
Author: Ankit Ranjan <ankitra...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M tests/ffi/abi_specific_int_incomplete_aot_test.dart
A tests/ffi/abi_specific_int_incomplete_aot_test_helper.dart
M tests/ffi/ffi.status
M tests/ffi/vmspecific_enable_ffi_test.dart
A tests/ffi/vmspecific_enable_ffi_test_helper.dart

Log Message:
-----------
[vm/ffi] Migrate legacy multi-test files to Process.run

Migrates vmspecific_enable_ffi_test.dart and
abi_specific_int_incomplete_aot_test.dart away from legacy multi-test
markers. Since these tests verify VM/gen_snapshot compile-time errors
(not CFE errors), they cannot use // [cfe] expectations. Instead, they
now spawn a subprocess and verify the expected error is produced.

- vmspecific_enable_ffi_test: Runs helper with --enable-ffi=false, checks for error
- abi_specific_int_incomplete_aot_test: Compiles helper with `dart compile aot-snapshot`, checks for error

Both tests self-spawn AOT tooling (gen_snapshot) or the JIT `dart` CLI,
so they only run on the dartkp host bots and are skipped elsewhere
(ia32, android, fuchsia, qemu) via tests/ffi/ffi.status.

Fixes https://github.com/dart-lang/sdk/issues/60212

Change-Id: Ib2482c3172b20a4366f984da33544fc515b540c4
Cq-Include-Trybots: dart/try:vm-aot-android-debug-arm64c-try,vm-aot-android-debug-arm_x64-try,vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-debug-arm64-try,vm-aot-mac-debug-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-asan-mac-release-arm64-try,vm-asan-win-release-x64-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-mac-release-arm64-try,vm-ubsan-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508020
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Ankit Ranjan <ankitra...@gmail.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Konstantin Scheglov

unread,
11:42 AM (4 hours ago) 11:42 AM
to com...@dartlang.org
Branch: refs/heads/lkgr
Commit: 649a56d6e4a0d95eb62d6d5ba875b960474f4825
https://github.com/dart-lang/sdk/commit/649a56d6e4a0d95eb62d6d5ba875b960474f4825
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
M pkg/analyzer/test/src/diagnostics/analysis_options/analysis_options_test_support.dart
M pkg/analyzer/test/src/diagnostics/analysis_options/include_file_not_found_test.dart
M pkg/analyzer/test/src/diagnostics/analysis_options/include_file_warning_test.dart
M pkg/analyzer/test/src/diagnostics/analysis_options/recursive_include_file_test.dart
M pkg/analyzer/test/src/diagnostics/analysis_options/test_all.dart
M pkg/analyzer/test/src/options/options_file_validator_test.dart
M pkg/analyzer/test/src/options/options_rule_validator_test.dart

Log Message:
-----------
CQ. Switch analysis options tests to inline expected diagnostics.

Change-Id: I2c33dbd645bd8611836cbcbab597a23165d1fb9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511060
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>


Commit: be4df1a8690006dd570bb9b4c5f2d02760cb9fe4
https://github.com/dart-lang/sdk/commit/be4df1a8690006dd570bb9b4c5f2d02760cb9fe4
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/analysis_server/lib/src/context_manager.dart
M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_migrate.dart
M pkg/analysis_server/lib/src/plugin/plugin_locator.dart
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart
M pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart
M pkg/analysis_server/lib/src/services/correction/dart/update_sdk_constraints.dart
M pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_manager.dart
M pkg/analysis_server/lib/src/services/pub/pub_package_service.dart
M pkg/analysis_server/lib/src/services/user_prompts/user_prompts.dart
M pkg/analysis_server/lib/src/status/pages/contexts_page.dart
M pkg/analysis_server/test/analysis/reanalyze_test.dart
M pkg/analysis_server/test/analysis/set_priority_files_test.dart
M pkg/analysis_server/test/support/configuration_files.dart
M pkg/analysis_server/test/verify_no_utf8_encode_test.dart
M pkg/analyzer/api.txt
M pkg/analyzer/lib/file_system/file_system.dart
M pkg/analyzer/lib/file_system/memory_file_system.dart
M pkg/analyzer/lib/file_system/overlay_file_system.dart
M pkg/analyzer/lib/file_system/physical_file_system.dart
M pkg/analyzer/lib/src/analysis_rule/rule_context.dart
M pkg/analyzer/lib/src/context/builder.dart
M pkg/analyzer/lib/src/context/packages.dart
M pkg/analyzer/lib/src/dart/analysis/context_locator.dart
M pkg/analyzer/lib/src/dart/analysis/file_state_filter.dart
M pkg/analyzer/lib/src/dart/sdk/sdk.dart
M pkg/analyzer/lib/src/pubspec/validators/flutter_validator.dart
M pkg/analyzer/lib/src/source/package_map_resolver.dart
M pkg/analyzer/lib/src/test_utilities/mock_packages.dart
M pkg/analyzer/lib/src/test_utilities/mock_sdk.dart
M pkg/analyzer/lib/src/utilities/extensions/file_system.dart
M pkg/analyzer/lib/src/workspace/blaze.dart
M pkg/analyzer/lib/src/workspace/gn.dart
M pkg/analyzer/lib/src/workspace/pub.dart
M pkg/analyzer/lib/src/workspace/workspace.dart
M pkg/analyzer/test/file_system/file_system_test_support.dart
M pkg/analyzer/test/file_system/overlay_file_system_test.dart
M pkg/analyzer/test/file_system/physical_file_system_test.dart
M pkg/analyzer/test/source/analysis_options_provider_test.dart
M pkg/analyzer/test/src/dart/analysis/context_builder_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart
M pkg/analyzer/test/src/options/options_provider_test.dart
M pkg/analyzer/test/src/workspace/gn_test.dart
M pkg/analyzer_plugin/lib/src/utilities/navigation/document_links.dart
M pkg/analyzer_testing/lib/mock_packages/mock_packages.dart
M pkg/analyzer_utilities/lib/verify_tests.dart
M pkg/dartpad_worker/lib/src/resource_provider/resource_provider_ext.dart
M pkg/dartpad_worker/lib/src/resource_provider/resource_provider_file.dart
M pkg/dartpad_worker/lib/src/resource_provider/resource_provider_wrap_cwd.dart
M pkg/dartpad_worker/lib/src/worker.dart
M pkg/dartpad_worker/test/checks_ext.dart
M pkg/dartpad_worker/test/resource_provider/test_resource_provider_ext.dart
M pkg/linter/lib/src/ast.dart
M pkg/linter/test/rules/analyzer_element_model_tracking_test.dart
M pkg/linter/test/verify_reflective_test_suites_test.dart

Log Message:
-----------
API. Add Folder.getFile/Folder, deprecate getChildAssumingFile/Folder

This aligns names with ResourceProvider.getFile/Folder.

Change-Id: I30383ef1fa6f7cbe60b187338e25b8ca75806730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511120
Reviewed-by: Johnni Winther <johnni...@google.com>
Reviewed-by: Jonas Jensen <jon...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/e171e636d508...be4df1a86900
Reply all
Reply to author
Forward
0 new messages