[dart-lang/sdk] f3d47a: [cfe][InternalNodes] Remove InternalVariable.initi...

0 views
Skip to first unread message

johnniwinther

unread,
9:13 AM (8 hours ago) 9:13 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: f3d47ab020a10305a64b1568e24c2ed7d2e77292
https://github.com/dart-lang/sdk/commit/f3d47ab020a10305a64b1568e24c2ed7d2e77292
Author: Johnni Winther <johnni...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
M pkg/front_end/lib/src/kernel/body_builder.dart
M pkg/front_end/lib/src/kernel/internal_ast.dart
M pkg/front_end/lib/src/kernel/resolver.dart
M pkg/front_end/lib/src/type_inference/inference_visitor.dart
M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart

Log Message:
-----------
[cfe][InternalNodes] Remove InternalVariable.initializer

This removes the initializer property on InternalVariable together with various other internal delegations to the astVariable to make sure the InternalVariable is behaving has a normal InternalTreeNode.

Change-Id: I1f8469eeb3f80d815f3bb5676bf43e66067b82ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510841
Commit-Queue: Johnni Winther <johnni...@google.com>
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

jensjoha

unread,
10:27 AM (6 hours ago) 10:27 AM
to com...@dartlang.org
Branch: refs/heads/lkgr
Home: https://github.com/dart-lang/sdk
Commit: f3d47ab020a10305a64b1568e24c2ed7d2e77292
https://github.com/dart-lang/sdk/commit/f3d47ab020a10305a64b1568e24c2ed7d2e77292
Author: Johnni Winther <johnni...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/front_end/lib/src/builder/formal_parameter_builder.dart
M pkg/front_end/lib/src/kernel/body_builder.dart
M pkg/front_end/lib/src/kernel/internal_ast.dart
M pkg/front_end/lib/src/kernel/resolver.dart
M pkg/front_end/lib/src/type_inference/inference_visitor.dart
M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart

Log Message:
-----------
[cfe][InternalNodes] Remove InternalVariable.initializer

This removes the initializer property on InternalVariable together with various other internal delegations to the astVariable to make sure the InternalVariable is behaving has a normal InternalTreeNode.

Change-Id: I1f8469eeb3f80d815f3bb5676bf43e66067b82ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510841
Commit-Queue: Johnni Winther <johnni...@google.com>
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>


Commit: b32e31362013fbd2169a8be9765ce23a34f63063
https://github.com/dart-lang/sdk/commit/b32e31362013fbd2169a8be9765ce23a34f63063
Author: Jens Johansen <je...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/dartdev/lib/src/commands/run.dart
M pkg/dartdev/lib/src/vm_interop_handler.dart
M pkg/dartdev/test/commands/run_test.dart
M runtime/bin/dartdev.cc
M runtime/bin/main_impl.cc
M runtime/bin/main_options.h

Log Message:
-----------
[vm] Introduce --script_uri_override to support Platform.script in dart run -r

If a script uses `Platform.script` running it with as `dart
<script.dart>` and `dart run <script.dart>` would give the correct
script ("<script.dart>"), but running it with `dart run -r
<script.dart>` would report a dill file in the temp directory which is
not only surprising, but also breaking and for instance running the CFEs
strong_suite.dart via `dart run -r` didn't work.

This CL introduces --script_uri_override to the VM and makes the
resident compiler setup pass it so that when running `dart run -r
<script.dart>`, even though the vm is actually launched from a dill file
that resides in temp, `Platform.script` will actually return
`<script.dart>` - and running the CFEs strong_suite.dart via `dart run
-r` now actually works.

Tested: Added pkg/dartdev/test/commands/run_test.dart and manual testing.
Change-Id: Ia65c01834485fe06af63584baf0448dd5b9ffdb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510343
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/f1fcecc81de3...b32e31362013
Reply all
Reply to author
Forward
0 new messages