[dart-lang/sdk] dc07f7: [record_use] Const instance recording classes must...

[Daco Harkes]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: dc07f7095661e7f817886fd41bf2904d3deb2f87
https://github.com/dart-lang/sdk/commit/dc07f7095661e7f817886fd41bf2904d3deb2f87
Author: Daco Harkes <dacoh...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M DEPS
M pkg/compiler/test/record_use/record_use_test.dart
M pkg/front_end/lib/src/codes/diagnostic.g.dart
M pkg/front_end/lib/src/kernel/constant_evaluator.dart
M pkg/front_end/lib/src/kernel/record_use.dart
M pkg/front_end/messages.status
M pkg/front_end/messages.yaml
M pkg/vm/test/transformations/record_use_test.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested.dart
M pkg/vm/testcases/transformations/record_use/lib/nested.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart.aot.expect
R pkg/vm/testcases/transformations/record_use/lib/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_final_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_extends_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_implements_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_mixin_throws.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart.aot.expect

Log Message:
-----------
[record_use] Const instance recording classes must be final

And they may not be extended, implemented and mixed in.

It would be cleaner if we test the static checks with the [cfe]
test expectations. However, those test suites are not set up to
run from a package context, which `@RecordUse` annotations must be.

TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart

Change-Id: Ia4e93a6f25ad4c246503ebf8ece67e7d4bca1410
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482220
Commit-Queue: Daco Harkes <dacoh...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Reviewed-by: Michael Goderbauer <goder...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[Daco Harkes]

Branch: refs/heads/lkgr