[dart-lang/sdk] 5a40aa: [analysis_server] Fix isAvailable check for "Remov...

[Danny Tuppeny]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 5a40aaaecca92b542d7bdf9e565156bc76509473
https://github.com/dart-lang/sdk/commit/5a40aaaecca92b542d7bdf9e565156bc76509473
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:
M pkg/analysis_server/lib/src/utilities/extensions/selection.dart
M pkg/analysis_server/test/src/services/refactoring/remove_constructor_name_test.dart

Log Message:
-----------
[analysis_server] Fix isAvailable check for "Remove constructor name" on unnamed constructor invocations

This code was checking the name of the type instead of the name of the constructor.

Fixes https://github.com/Dart-Code/Dart-Code/issues/6061

Change-Id: I180940162aa7ff12e4ec19aa002a188961d7aad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505684
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[copybara-service[bot]]

Branch: refs/heads/lkgr

Home: https://github.com/dart-lang/sdk
Commit: 5a40aaaecca92b542d7bdf9e565156bc76509473
https://github.com/dart-lang/sdk/commit/5a40aaaecca92b542d7bdf9e565156bc76509473
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:
M pkg/analysis_server/lib/src/utilities/extensions/selection.dart
M pkg/analysis_server/test/src/services/refactoring/remove_constructor_name_test.dart

Log Message:
-----------
[analysis_server] Fix isAvailable check for "Remove constructor name" on unnamed constructor invocations

This code was checking the name of the type instead of the name of the constructor.

Fixes https://github.com/Dart-Code/Dart-Code/issues/6061

Change-Id: I180940162aa7ff12e4ec19aa002a188961d7aad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505684
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>

Commit: f46967d5c41d69cb27225638f3616bd8a546dfea
https://github.com/dart-lang/sdk/commit/f46967d5c41d69cb27225638f3616bd8a546dfea
Author: Sam Rawlins <sraw...@google.com>

Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:

M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/lib/src/mock_packages/flutter/painting/text_span.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/widgets/media_query.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/widgets/scroll_delegate.dart

Log Message:
-----------
analyzer_testing: Fix some flutter mocks

Fixes https://github.com/dart-lang/sdk/issues/62559

Change-Id: I3866dd488132faf9946ca36fc32f38aa335cce3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505600
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>


Commit: 7df8468b52a287207869431fa62934a6086b0d53
https://github.com/dart-lang/sdk/commit/7df8468b52a287207869431fa62934a6086b0d53
Author: Paul Berry <paul...@google.com>

Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:

M pkg/heap_snapshot/lib/analysis.dart
M pkg/heap_snapshot/lib/intset.dart

Log Message:
-----------
Reformat some files in the heap_snapshot package.

This will avoid some merge conflicts in a follow-up CL I'm working on
that will enable the lints `unnecessary_type_name_in_constructor` and
`unnecessary_const_in_enum_constructor` (and will fix declarations
accordingly).

Change-Id: I0a8f660c3c4d722dbeda440009e565f96a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505047
Reviewed-by: Martin Kustermann <kuste...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Commit: 01ee1880aafdb6132b22e952682bc476980052b2
https://github.com/dart-lang/sdk/commit/01ee1880aafdb6132b22e952682bc476980052b2
Author: Lasse R.H. Nielsen <l...@google.com>

Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:

M pkg/analyzer/lib/src/generated/error_verifier.dart

Log Message:
-----------
Fix use of `ExperimentalFeature.featureFlag!` as feature name.

The `featureFlag` becomes `null` when the feature is expired,
the `featureString` is still available.

Code was added by https://dart-review.googlesource.com/c/sdk/+/470920 .

Change-Id: I5f19718d9431ff409907e82b2849d76415b739bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505440
Commit-Queue: Lasse Nielsen <l...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>


Commit: dfa447890236cf43666def796e2b9a56ae73e037
https://github.com/dart-lang/sdk/commit/dfa447890236cf43666def796e2b9a56ae73e037
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>

Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:

M DEPS

Log Message:
-----------
Roll gn from 068dd892acb2 to e44942b445d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@rotations.google.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in gn: https://bugs.chromium.org/p/gn/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: Iafb067fb2d76a298bf3fd30f94e6a8e2d04a0cdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505720
Reviewed-by: Nate Biggs <nate...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/70b8a7f49dd2...dfa447890236