[dart-lang/sdk] f7edf6: [flow analysis] Remove _flowAnalysisInfoMap from m...

0 views
Skip to first unread message

Paul Berry

unread,
Feb 23, 2026, 6:55:38 PM (6 hours ago) Feb 23
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: f7edf6a7f7fb6e45488ae2e0645579d25cc9e6dd
https://github.com/dart-lang/sdk/commit/f7edf6a7f7fb6e45488ae2e0645579d25cc9e6dd
Author: Paul Berry <paul...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M pkg/_fe_analyzer_shared/test/flow_analysis/flow_analysis_mini_ast.dart
M pkg/_fe_analyzer_shared/test/mini_ast.dart

Log Message:
-----------
[flow analysis] Remove _flowAnalysisInfoMap from mini_ast test harness.

Removes the `_flowAnalysisInfoMap` field from the `Harness` class,
which serves as the test harness for the mini_ast used in flow
analysis testing, along with the methods `getFlowAnalysisInfo` and
`storeFlowAnalysisInfo` that did map lookups. Calls to
`getFlowAnalysisInfo` are replaced with logic that pulls the flow
analysis expression info directly from the expression analysis result,
and calls to `storeFlowAnalysisInfo` are dropped (since they are no
longer needed).

Also, the assertion is dropped from `dispatchExpression` that used to
verify that the information stored in the map matched the information
stored in the expression analysis result.

Change-Id: I6a6a69643e0345a1f5ef84f09340119b56bfed12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482580
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Reply all
Reply to author
Forward
0 new messages