[dart-lang/sdk] 05dc1c: [flow analysis] Refactor unit tests to use their o...

[Paul Berry]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 05dc1ccbb7ff09fa907a81a3db1c925120ec60c7
https://github.com/dart-lang/sdk/commit/05dc1ccbb7ff09fa907a81a3db1c925120ec60c7
Author: Paul Berry <paul...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M pkg/_fe_analyzer_shared/test/flow_analysis/flow_analysis_mini_ast.dart
M pkg/_fe_analyzer_shared/test/flow_analysis/flow_analysis_test.dart
M pkg/_fe_analyzer_shared/test/mini_ast.dart

Log Message:
-----------
[flow analysis] Refactor unit tests to use their own expression info map.

Migrates the mini_ast used for flow analysis testing so that instead
of associating expressions with expression info objects using
`FlowAnalysis.getExpressionInfo` and
`FlowAnalysis.storeExpressionInfo`, it does so using its own private
map, which it accesses using the new methods `getFlowAnalysisInfo` and
`storeFlowAnalysisInfo`.

This paves the way for two independent arcs of work:

- Removing the `getExpressionInfo` and `storeExpressionInfo` methods
from `FlowAnalysis`.

- Simplifying mini_ast so that it tracks expression info objects using
`ExpressionTypeAnalysisResult.flowAnalysisInfo` rather than its own
private map.

A similar effort is underway for the analyzer and front_end, which
should carry the following benefits:

- It will make type analysis more performant by avoiding map lookups

- It will decrease the risk of subtle bugs when one expression is
changed into another.

Change-Id: I6a6a6964f0c41c62be21efc0fa16b22b10e85b34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482561
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Chloe Stefantsova <cstefa...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[Paul Berry]

Branch: refs/heads/lkgr