[dart-lang/sdk] 1b8887: [vm] Remove only use of Types of top level classes.

[Tess Strickland]

Branch: refs/heads/master
Home: https://github.com/dart-lang/sdk
Commit: 1b8887080ab0f71057391b3921813a26bbda101a
https://github.com/dart-lang/sdk/commit/1b8887080ab0f71057391b3921813a26bbda101a
Author: Tess Strickland <sstr...@google.com>
Date: 2021-10-20 (Wed, 20 Oct 2021)

Changed paths:
M runtime/lib/object.cc
M runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
M runtime/vm/compiler/frontend/kernel_binary_flowgraph.h
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/frontend/kernel_to_il.h
M runtime/vm/object.cc

Log Message:
-----------
[vm] Remove only use of Types of top level classes.

The only time we create a Type in the VM for a top level class is as the
"receiver" for a no such method error where the method was either not
found in the top level class or the found method had incompatible
arguments. Unlike other cases, the Dart implementation doesn't directly
use the InvocationMirror receiver for no such method errors at the top
level, but instead just passes it back to the VM.

Now, for the InvocationMirror receiver in the top level class case, we
either

* pass a null receiver if the method wasn't found, or

* pass the signature of the found method as a string, if the arguments
were incompatible, since the only use of the top level class was for
printing the signature.

TEST=vm/cc/DartAPI, service{_2}, vm/cc/Eval, lib{_2}/mirrors

Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64-try,vm-kernel-linux-product-x64-try,vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try
Change-Id: I1ac701b0be2aaebbc6163e644262c5f3ead656c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217220
Commit-Queue: Tess Strickland <sstr...@google.com>
Reviewed-by: Martin Kustermann <kuste...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>

[Tess Strickland]

Branch: refs/heads/main