[dart-lang/sdk] 66eb8b: Augment. Rename element model tests for class, enu...

0 views
Skip to first unread message

Konstantin Scheglov

unread,
10:49 AM (3 hours ago) 10:49 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 66eb8bde1b360c73e9d108a66d28ae38ba8e1bc0
https://github.com/dart-lang/sdk/commit/66eb8bde1b360c73e9d108a66d28ae38ba8e1bc0
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-29 (Wed, 29 Apr 2026)

Changed paths:
M pkg/analyzer/test/src/summary/elements/class_test.dart
M pkg/analyzer/test/src/summary/elements/enum_test.dart
M pkg/analyzer/test/src/summary/elements/extension_test.dart
M pkg/analyzer/test/src/summary/elements/extension_type_test.dart
M pkg/analyzer/test/src/summary/elements/mixin_test.dart

Log Message:
-----------
Augment. Rename element model tests for class, enum, extension, extension type, mixin.

Rename and regroup the element model tests for classes, enums,
extensions, extension types, and mixins. Fold augmentation cases into
the main keep-linking and from-bytes suites instead of maintaining
separate augmentation subclasses.

See https://paste.googleplex.com/6222325998551040 for removed duplicate
tests.

1. Merge augmentation tests into all tests.
2. Rename test methods and remove duplicates.
3. Sort.

Change-Id: I08ab299a301a8e27c0cdb0c40e74f63549f5d443
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499042
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Ryan Macnak

unread,
12:35 PM (1 hour ago) 12:35 PM
to com...@dartlang.org
Branch: refs/heads/lkgr
Commit: 8cbfb32907df8f5113469f3336a1393dad691c80
https://github.com/dart-lang/sdk/commit/8cbfb32907df8f5113469f3336a1393dad691c80
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-29 (Wed, 29 Apr 2026)

Changed paths:
M pkg/analyzer/lib/src/summary2/constructor_initializer_resolver.dart
M pkg/analyzer/lib/src/summary2/default_types_builder.dart
M pkg/analyzer/lib/src/summary2/element_builder.dart
M pkg/analyzer/lib/src/summary2/link.dart
M pkg/analyzer/lib/src/summary2/named_type_builder.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
M pkg/analyzer/lib/src/summary2/simply_bounded.dart
M pkg/analyzer/lib/src/summary2/super_constructor_resolver.dart
M pkg/analyzer/lib/src/summary2/top_level_inference.dart
M pkg/analyzer/lib/src/summary2/type_alias.dart
M pkg/analyzer/lib/src/summary2/types_builder.dart
M pkg/analyzer/lib/src/summary2/variance_builder.dart

Log Message:
-----------
CQ. Encapsulate and rename fragment to AST node mapping.

Make Linker own the mapping from declaration fragments to the AST nodes
that produced them. Replace direct writes and reads of the mapping with
setFragmentNode and getLinkingNode, and make the backing map private.

Remove the temporary getLinkingNode2 helper and update callers to use
the single accessor. Narrow related APIs to implementation types where
the lookup is only valid for fragments and elements that are currently
being linked.

This keeps the fragment-to-node association as a Linker implementation
detail and prevents unrelated element objects from being used as map
keys.

Change-Id: Ife5f1d1648c5726b9944d9946c2b71720965a724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499140
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>


Commit: 7012150dc7f3d9d5de1575116dc0da2123b7a9bb
https://github.com/dart-lang/sdk/commit/7012150dc7f3d9d5de1575116dc0da2123b7a9bb
Author: Ryan Macnak <rma...@google.com>
Date: 2026-04-29 (Wed, 29 Apr 2026)

Changed paths:
M runtime/vm/object.cc
M runtime/vm/roots.h

Log Message:
-----------
[vm] Hoist allocation of sentinel et al.

These will be base objects even for kFullAOT and kFullJIT snapshots, so their allocation needs to be separated from the rest of Object::Init.

TEST=ci
Change-Id: I1ad03cf9900a925d3b084843206bba7f67c5daa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499083
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>


Commit: e07f7eddd8b94f8fbbebc79843487da13eed2cff
https://github.com/dart-lang/sdk/commit/e07f7eddd8b94f8fbbebc79843487da13eed2cff
Author: Ryan Macnak <rma...@google.com>
Date: 2026-04-29 (Wed, 29 Apr 2026)

Changed paths:
M runtime/vm/heap/heap.cc
M runtime/vm/thread.h

Log Message:
-----------
[vm] Remove dead regexp code.

TEST=ci
Change-Id: I976bcb7bf24f4a8134d5c1c5e20e8f98dc85cfbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499082
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/b4254d0946f4...e07f7eddd8b9
Reply all
Reply to author
Forward
0 new messages