[dart-lang/sdk] c8a74e: [analysis_server] Add classes for processing inter...
0 views
Skip to first unread message
Danny Tuppeny
May 22, 2026, 3:46:28 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: c8a74e71efff507c889e85b88091e771367db7c3
https://github.com/dart-lang/sdk/commit/c8a74e71efff507c889e85b88091e771367db7c3
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
A pkg/analysis_server/lib/src/services/interactive_forms/interactive_forms.dart
A pkg/analysis_server/test/src/services/interactive_forms/interactive_forms_test.dart
A pkg/analysis_server/test/src/services/interactive_forms/test_all.dart
M pkg/analysis_server/test/src/services/test_all.dart
M pkg/analysis_server/tool/lsp_spec/custom/interactive_forms.dart
M third_party/pkg/language_server_protocol/lib/protocol_custom_generated.dart
Log Message:
-----------
[analysis_server] Add classes for processing interactive forms
This adds some classes for processing interactive forms (I'm splitting this from the CL that updates refactorings to simplify reviewing).
The `InteractiveForm` class managers a whole form (all fields), and processes a set of fields/answers that come back from the client (which may be the full set, or a subset). It produces a list of the outstanding fields (which need to be go back to the client) as well as maintaining the full set of answers for the master field list (to use as arguments for a command, for example).
I've also commented out enums/lists from the protocol code for now, because I made the field kinds `sealed` so we get exhaustiveness checking in the validation, but want to delay fully implementing those for now.
See https://github.com/dart-lang/sdk/issues/63371
Change-Id: Icc4dcea8c9eab20ffbdd19ebbc69e1285464f7ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505683
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: c8a74e71efff507c889e85b88091e771367db7c3
https://github.com/dart-lang/sdk/commit/c8a74e71efff507c889e85b88091e771367db7c3
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
A pkg/analysis_server/lib/src/services/interactive_forms/interactive_forms.dart
A pkg/analysis_server/test/src/services/interactive_forms/interactive_forms_test.dart
A pkg/analysis_server/test/src/services/interactive_forms/test_all.dart
M pkg/analysis_server/test/src/services/test_all.dart
M pkg/analysis_server/tool/lsp_spec/custom/interactive_forms.dart
M third_party/pkg/language_server_protocol/lib/protocol_custom_generated.dart
Log Message:
-----------
[analysis_server] Add classes for processing interactive forms
This adds some classes for processing interactive forms (I'm splitting this from the CL that updates refactorings to simplify reviewing).
The `InteractiveForm` class managers a whole form (all fields), and processes a set of fields/answers that come back from the client (which may be the full set, or a subset). It produces a list of the outstanding fields (which need to be go back to the client) as well as maintaining the full set of answers for the master field list (to use as arguments for a command, for example).
I've also commented out enums/lists from the protocol code for now, because I made the field kinds `sealed` so we get exhaustiveness checking in the validation, but want to delay fully implementing those for now.
See https://github.com/dart-lang/sdk/issues/63371
Change-Id: Icc4dcea8c9eab20ffbdd19ebbc69e1285464f7ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505683
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Danny Tuppeny
May 22, 2026, 4:23:49 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
May 22, 2026, 8:04:14 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/dev
Commit: 739826d041ddc2a72fd4c56a97d862a024eae264
https://github.com/dart-lang/sdk/commit/739826d041ddc2a72fd4c56a97d862a024eae264
Author: Brian Wilkerson <brianwi...@google.com>
M pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
Log Message:
-----------
Update ImportedElementsComputer for primary constructors
This CL is to resolve a TODO. I couldn't find a way to trigger any bugs
in the code, but I did add a test. I believe that the reason I couldn't
trigger a bug is because any constructor that has a null `typeName`
will not have a simple identifier in a place that would allow
`_isConstructorDeclarationReturnType` to be invoked.
I realized, while looking at the code, that the type check is
unnecessary. If the type name is null, then the test will somply return
`false`, which is what we'd expect it to do. Given that it isn't needed,
I decided to remove it.
Change-Id: Ib36aaf16475db0db5817e65a8b8bfbb8aa834dbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505501
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: fc7c53125356de53e89eb9bb2fee3a3f1d0495f0
https://github.com/dart-lang/sdk/commit/fc7c53125356de53e89eb9bb2fee3a3f1d0495f0
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/generated/non_error_resolver_test.dart
M pkg/analyzer/test/generated/non_hint_code_test.dart
M pkg/analyzer/test/generated/simple_resolver_test.dart
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/index_test.dart
M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
M pkg/analyzer/test/src/dart/analysis/search_test.dart
M pkg/analyzer/test/src/dart/ast/ast_test.dart
M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/element/display_string_test.dart
M pkg/analyzer/test/src/dart/element/inheritance_manager3_test.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/library_element_test.dart
M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/part_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
M pkg/analyzer/test/src/diagnostics/assignment_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_default_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_name_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_extended_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_implemented_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/import_internal_library_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_factory_name_not_a_class_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_internal_annotation_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_language_override_greater_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_use_of_internal_member_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_on_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/non_const_map_as_expression_statement_test.dart
M pkg/analyzer/test/src/diagnostics/return_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/unused_element_test.dart
M pkg/analyzer/test/src/diagnostics/uri_does_not_exist_test.dart
M pkg/analyzer/test/src/ignore_comments/ignore_info_test.dart
M pkg/analyzer/test/src/services/top_level_declarations_test.dart
M pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
M pkg/analyzer/test/src/workspace/blaze_test.dart
M pkg/analyzer/test/verify_diagnostics_test.dart
Log Message:
-----------
CQ. Remove result state from ResolutionTest.
Stop storing the most recently resolved unit in ResolutionTest. Make
test helpers operate on explicit result objects instead, so each
assertion uses the diagnostics, type provider, type system, and
inheritance manager from the result it is checking.
This makes the tests less order-dependent and easier to reason about. A
test can now resolve more than one file or unit without later assertions
implicitly depending on whichever result happened to be stored last. It
also makes helper APIs more local: the data needed by an assertion is
passed directly, rather than recovered from mutable test state.
Update tests to keep the returned result when they need access to the
resolved AST or result-derived utilities. Add convenience accessors on
the result wrappers to preserve common lookup patterns without
reintroducing shared mutable state.
Change-Id: Ib45c52f8fd104b668f9fdd1ec6b1442927cd7e61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505920
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 03a05b52d8d60c391ec01ee3405079e6f53c79d8
https://github.com/dart-lang/sdk/commit/03a05b52d8d60c391ec01ee3405079e6f53c79d8
Author: Brian Wilkerson <brianwi...@google.com>
M pkg/analysis_server/test/src/services/correction/fix/data_driven/element_matcher_test.dart
Log Message:
-----------
Fix a primary-constructors bug in ElementMatcher
The element matcher threw a null check exception when getting a matcher
in the argument list of a constructor redirect in a secondary
constructor declaration with no explicit type name. This fixes it so
that no exception will be thrown.
That said, it isn't clear to me that this code could ever be reached
outside of the tests. There might be a lot of unreachable code in
ElementMatcher. I just can't prove that this particular bug would never
have occurred.
Change-Id: I5adf9ab5d4f79686110099054902a28535483f4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505921
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 1121b4041fff4a100abd4305bdee452dea63be7a
https://github.com/dart-lang/sdk/commit/1121b4041fff4a100abd4305bdee452dea63be7a
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
M pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/comment_test.dart
M pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_override_test.dart
M pkg/analyzer/test/src/dart/resolution/field_promotion_test.dart
M pkg/analyzer/test/src/dart/resolution/for_element_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
M pkg/analyzer/test/src/dart/resolution/if_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/index_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/simple_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/extension_methods_test.dart
M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
M pkg/analyzer/test/src/diagnostics/private_setter_test.dart
M pkg/analyzer/test/src/diagnostics/receiver_of_type_never_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_setter_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
Log Message:
-----------
CQ. Consistently use 'var node =' before assertResolvedNodeText().
Change-Id: I2363c3fb724780ef31fa97b2d76988e21ef6c6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505922
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Commit: b162f6717d92f08641f53e637dd89c87360289dc
https://github.com/dart-lang/sdk/commit/b162f6717d92f08641f53e637dd89c87360289dc
Author: Nate Bosch <nbo...@google.com>
M tests/standalone/io/io_override_test.dart
Log Message:
-----------
[io] Fix FileSystemEntity.type and Link.exists with IOOverrides
Fixes #63418
When IOOverrides are active, `fseGetType` and `fseGetTypeSync` used
`utf8.encode(path)` which does not null-terminate the path. Native
APIs require null-terminated paths. Through luck the sync path worked
but the async path failed with `notFound`.
Update them to use `FileSystemEntity._toUtf8Array(path)` which correctly
null-terminates the path.
Tested: added a regression test to tests/standalone/io/io_override_test.dart
TAG=agy
CONV=ab6af504-d536-4a8d-88be-bc487b60e24d
R=bko...@google.com
CoreLibraryReviewExempt: No API changes.
Change-Id: I24e31efdcbecc703800b96a144e41a095a445cff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505201
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Nate Bosch <nbo...@google.com>
Auto-Submit: Nate Bosch <nbo...@google.com>
Commit: ca15e2cdd9bd0ac19742e9b2dbfa3aa788ccec1a
https://github.com/dart-lang/sdk/commit/ca15e2cdd9bd0ac19742e9b2dbfa3aa788ccec1a
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
Log Message:
-----------
CQ. Remove shallow abstractions in DeprecatedMemberUse_PackageConfigWorkspaceTest and ExperimentalMemberUseTest.
Change-Id: I7314f16e7b05316d9c2f47bbcb2805d41a9359a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506000
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8765d801775dc082be4ee2ca9256f219f31a5d43
https://github.com/dart-lang/sdk/commit/8765d801775dc082be4ee2ca9256f219f31a5d43
Author: Alexander Aprelev <a...@google.com>
M runtime/vm/bootstrap_natives.h
M runtime/vm/compiler/assembler/assembler_arm.cc
M runtime/vm/compiler/assembler/assembler_arm.h
M runtime/vm/compiler/assembler/assembler_arm64.h
M runtime/vm/compiler/assembler/assembler_arm64_test.cc
M runtime/vm/compiler/assembler/assembler_arm_test.cc
M runtime/vm/compiler/assembler/assembler_x64.h
M runtime/vm/compiler/assembler/assembler_x64_test.cc
M runtime/vm/compiler/assembler/disassembler_arm.cc
M runtime/vm/compiler/assembler/disassembler_arm64.cc
M runtime/vm/compiler/assembler/disassembler_x86.cc
M runtime/vm/compiler/backend/evaluator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/simulator_arm.cc
M runtime/vm/simulator_arm64.cc
M runtime/vm/token.h
M sdk/lib/_internal/vm/lib/integers.dart
Log Message:
-----------
Revert "[vm] Recognize int.trailingZeroBitCount/oneBitCount as graph-inlinable"
This reverts commit 0bef83781763b6987f1637c3b25a58edbb789f5e.
Reason for revert: simarm, xarm bot failures https://github.com/dart-lang/sdk/issues/63436
Original change's description:
> [vm] Recognize int.trailingZeroBitCount/oneBitCount as graph-inlinable
>
> Stacks on top of the int.{trailingZeroBitCount,oneBitCount} API CL
> (commit 754239b077e). Both getters route through OTHER_RECOGNIZED_LIST
> when a hardware fast path is available; otherwise the newly added
> Dart bodies inline at call sites via vm:prefer-inline. The C++
> natives are removed.
>
> Backend codegen
> ---------------
> ARM64: NEON CNT + UADDLV (popcount); RBIT + CLZ (ctz).
> ARM: NEON CNT + VPADDL chain (popcount); RBIT + CLZ on the
> register pair (ctz).
> x64: popcntq when TargetCPUFeatures::popcnt_supported();
> LoadImmediate(64) + rep_bsfq for ctz (decodes as tzcnt
> on BMI1+, preserves dest on zero otherwise).
> RISC-V 64: cpop / ctz when RV_baseline includes Zbb.
>
> Per-arch availability is encapsulated in
> UnaryInt64OpInstr::IsSupported(Token::Kind).
>
> Apple M-series ARM64, AOT (us/iter, lower is better):
> cardinality.swar 371
> cardinality.accelerated 154 (2.4x)
> forEachSetBit.swar 19031
> forEachSetBit.accelerated 4988 (3.8x)
> select.swar 199
> select.accelerated 77 (2.6x)
> complementCardinality.swar 399
> complementCardinality.accel 152 (2.6x)
>
> Work towards https://github.com/dart-lang/sdk/issues/6486 (popcount
> and ctz intrinsification).
>
> Work towards https://github.com/dart-lang/sdk/issues/1053 (efficient
> BitSet implementation).
>
> Fixes https://github.com/dart-lang/sdk/issues/52673
> Fixes https://github.com/dart-lang/sdk/issues/38346
> Issue https://github.com/dart-lang/sdk/issues/10212
> Issue https://github.com/dart-lang/sdk/issues/5798
> TEST=tests/corelib/int_bit_count_test
>
> Cq-Include-Trybots: luci.dart.try:vm-aot-linux-release-simarm_x64-try,vm-aot-linux-debug-simarm_x64-try,dart-sdk-linux-riscv64-try
> Change-Id: I9c2c4225fd63d54e190398a0fb6649366317dd17
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/504221
> Commit-Queue: Slava Egorov <veg...@google.com>
> Reviewed-by: Slava Egorov <veg...@google.com>
> Reviewed-by: Martin Kustermann <kuste...@google.com>
> Auto-Submit: Modestas Valauskas <valauska...@gmail.com>
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-release-simarm_x64-try,vm-aot-linux-debug-simarm_x64-try,dart-sdk-linux-riscv64-try
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4eaca9e25a919ba494f2e7e9819f1ea7d5a13078
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505941
Auto-Submit: Alexander Aprelev <a...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Slava Egorov <veg...@google.com>
Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
Commit: 7e0f28eb5315443c2d4d8909f3fe26824992e7aa
https://github.com/dart-lang/sdk/commit/7e0f28eb5315443c2d4d8909f3fe26824992e7aa
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
A pkg/analysis_server/lib/src/services/interactive_forms/interactive_forms.dart
M pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
M pkg/analysis_server/test/src/services/correction/fix/data_driven/element_matcher_test.dart
M pkg/analyzer/test/generated/non_error_resolver_test.dart
M pkg/analyzer/test/generated/non_hint_code_test.dart
M pkg/analyzer/test/generated/simple_resolver_test.dart
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/index_test.dart
M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
M pkg/analyzer/test/src/dart/analysis/search_test.dart
M pkg/analyzer/test/src/dart/ast/ast_test.dart
M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/element/display_string_test.dart
M pkg/analyzer/test/src/dart/element/inheritance_manager3_test.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
M pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/comment_test.dart
M pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_override_test.dart
M pkg/analyzer/test/src/dart/resolution/field_promotion_test.dart
M pkg/analyzer/test/src/dart/resolution/for_element_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
M pkg/analyzer/test/src/dart/resolution/if_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/index_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/library_element_test.dart
M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
M pkg/analyzer/test/src/dart/resolution/part_test.dart
M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
M pkg/analyzer/test/src/dart/resolution/simple_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/extension_methods_test.dart
M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
M pkg/analyzer/test/src/diagnostics/assignment_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_default_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_name_test.dart
M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_extended_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_implemented_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/import_internal_library_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_factory_name_not_a_class_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_internal_annotation_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_language_override_greater_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_use_of_internal_member_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_on_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/non_const_map_as_expression_statement_test.dart
M pkg/analyzer/test/src/diagnostics/private_setter_test.dart
M pkg/analyzer/test/src/diagnostics/receiver_of_type_never_test.dart
M pkg/analyzer/test/src/diagnostics/return_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_setter_test.dart
M pkg/analyzer/test/src/diagnostics/unused_element_test.dart
M pkg/analyzer/test/src/diagnostics/uri_does_not_exist_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
M pkg/analyzer/test/src/ignore_comments/ignore_info_test.dart
M pkg/analyzer/test/src/services/top_level_declarations_test.dart
M pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
M pkg/analyzer/test/src/workspace/blaze_test.dart
M pkg/analyzer/test/verify_diagnostics_test.dart
M runtime/lib/integers.cc
M runtime/vm/bootstrap_natives.h
M runtime/vm/compiler/assembler/assembler_arm.cc
M runtime/vm/compiler/assembler/assembler_arm.h
M runtime/vm/compiler/assembler/assembler_arm64.h
M runtime/vm/compiler/assembler/assembler_arm64_test.cc
M runtime/vm/compiler/assembler/assembler_arm_test.cc
M runtime/vm/compiler/assembler/assembler_x64.h
M runtime/vm/compiler/assembler/assembler_x64_test.cc
M runtime/vm/compiler/assembler/disassembler_arm.cc
M runtime/vm/compiler/assembler/disassembler_arm64.cc
M runtime/vm/compiler/assembler/disassembler_x86.cc
M runtime/vm/compiler/backend/evaluator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/simulator_arm.cc
M runtime/vm/simulator_arm64.cc
M runtime/vm/token.h
M sdk/lib/_internal/vm/lib/integers.dart
M sdk/lib/io/overrides.dart
M tests/standalone/io/io_override_test.dart
M third_party/pkg/language_server_protocol/lib/protocol_custom_generated.dart
M tools/VERSION
Log Message:
-----------
Version 3.13.0-133.0.dev
Merge 8765d801775dc082be4ee2ca9256f219f31a5d43 into dev
Compare: https://github.com/dart-lang/sdk/compare/90e55fa88456...7e0f28eb5315
https://github.com/dart-lang/sdk/commit/739826d041ddc2a72fd4c56a97d862a024eae264
Author: Brian Wilkerson <brianwi...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analysis_server/lib/src/computer/imported_elements_computer.dart
Changed paths:
M pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
Log Message:
-----------
Update ImportedElementsComputer for primary constructors
This CL is to resolve a TODO. I couldn't find a way to trigger any bugs
in the code, but I did add a test. I believe that the reason I couldn't
trigger a bug is because any constructor that has a null `typeName`
will not have a simple identifier in a place that would allow
`_isConstructorDeclarationReturnType` to be invoked.
I realized, while looking at the code, that the type check is
unnecessary. If the type name is null, then the test will somply return
`false`, which is what we'd expect it to do. Given that it isn't needed,
I decided to remove it.
Change-Id: Ib36aaf16475db0db5817e65a8b8bfbb8aa834dbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505501
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: fc7c53125356de53e89eb9bb2fee3a3f1d0495f0
https://github.com/dart-lang/sdk/commit/fc7c53125356de53e89eb9bb2fee3a3f1d0495f0
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analyzer/test/generated/invalid_code_test.dart
Changed paths:
M pkg/analyzer/test/generated/non_error_resolver_test.dart
M pkg/analyzer/test/generated/non_hint_code_test.dart
M pkg/analyzer/test/generated/simple_resolver_test.dart
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/index_test.dart
M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
M pkg/analyzer/test/src/dart/analysis/search_test.dart
M pkg/analyzer/test/src/dart/ast/ast_test.dart
M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/element/display_string_test.dart
M pkg/analyzer/test/src/dart/element/inheritance_manager3_test.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/library_element_test.dart
M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/part_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
M pkg/analyzer/test/src/diagnostics/assignment_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_default_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_name_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_extended_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_implemented_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/import_internal_library_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_factory_name_not_a_class_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_internal_annotation_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_language_override_greater_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_use_of_internal_member_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_on_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/non_const_map_as_expression_statement_test.dart
M pkg/analyzer/test/src/diagnostics/return_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/unused_element_test.dart
M pkg/analyzer/test/src/diagnostics/uri_does_not_exist_test.dart
M pkg/analyzer/test/src/ignore_comments/ignore_info_test.dart
M pkg/analyzer/test/src/services/top_level_declarations_test.dart
M pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
M pkg/analyzer/test/src/workspace/blaze_test.dart
M pkg/analyzer/test/verify_diagnostics_test.dart
Log Message:
-----------
CQ. Remove result state from ResolutionTest.
Stop storing the most recently resolved unit in ResolutionTest. Make
test helpers operate on explicit result objects instead, so each
assertion uses the diagnostics, type provider, type system, and
inheritance manager from the result it is checking.
This makes the tests less order-dependent and easier to reason about. A
test can now resolve more than one file or unit without later assertions
implicitly depending on whichever result happened to be stored last. It
also makes helper APIs more local: the data needed by an assertion is
passed directly, rather than recovered from mutable test state.
Update tests to keep the returned result when they need access to the
resolved AST or result-derived utilities. Add convenience accessors on
the result wrappers to preserve common lookup patterns without
reintroducing shared mutable state.
Change-Id: Ib45c52f8fd104b668f9fdd1ec6b1442927cd7e61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505920
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 03a05b52d8d60c391ec01ee3405079e6f53c79d8
https://github.com/dart-lang/sdk/commit/03a05b52d8d60c391ec01ee3405079e6f53c79d8
Author: Brian Wilkerson <brianwi...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/data_driven/element_matcher_test.dart
Log Message:
-----------
Fix a primary-constructors bug in ElementMatcher
The element matcher threw a null check exception when getting a matcher
in the argument list of a constructor redirect in a secondary
constructor declaration with no explicit type name. This fixes it so
that no exception will be thrown.
That said, it isn't clear to me that this code could ever be reached
outside of the tests. There might be a lot of unreachable code in
ElementMatcher. I just can't prove that this particular bug would never
have occurred.
Change-Id: I5adf9ab5d4f79686110099054902a28535483f4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505921
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 1121b4041fff4a100abd4305bdee452dea63be7a
https://github.com/dart-lang/sdk/commit/1121b4041fff4a100abd4305bdee452dea63be7a
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analyzer/test/generated/simple_resolver_test.dart
Changed paths:
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
M pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/comment_test.dart
M pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_override_test.dart
M pkg/analyzer/test/src/dart/resolution/field_promotion_test.dart
M pkg/analyzer/test/src/dart/resolution/for_element_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
M pkg/analyzer/test/src/dart/resolution/if_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/index_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/simple_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/extension_methods_test.dart
M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
M pkg/analyzer/test/src/diagnostics/private_setter_test.dart
M pkg/analyzer/test/src/diagnostics/receiver_of_type_never_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_setter_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
Log Message:
-----------
CQ. Consistently use 'var node =' before assertResolvedNodeText().
Change-Id: I2363c3fb724780ef31fa97b2d76988e21ef6c6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505922
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Commit: b162f6717d92f08641f53e637dd89c87360289dc
https://github.com/dart-lang/sdk/commit/b162f6717d92f08641f53e637dd89c87360289dc
Author: Nate Bosch <nbo...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M sdk/lib/io/overrides.dart
Changed paths:
M tests/standalone/io/io_override_test.dart
Log Message:
-----------
[io] Fix FileSystemEntity.type and Link.exists with IOOverrides
Fixes #63418
When IOOverrides are active, `fseGetType` and `fseGetTypeSync` used
`utf8.encode(path)` which does not null-terminate the path. Native
APIs require null-terminated paths. Through luck the sync path worked
but the async path failed with `notFound`.
Update them to use `FileSystemEntity._toUtf8Array(path)` which correctly
null-terminates the path.
Tested: added a regression test to tests/standalone/io/io_override_test.dart
TAG=agy
CONV=ab6af504-d536-4a8d-88be-bc487b60e24d
R=bko...@google.com
CoreLibraryReviewExempt: No API changes.
Change-Id: I24e31efdcbecc703800b96a144e41a095a445cff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505201
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Nate Bosch <nbo...@google.com>
Auto-Submit: Nate Bosch <nbo...@google.com>
Commit: ca15e2cdd9bd0ac19742e9b2dbfa3aa788ccec1a
https://github.com/dart-lang/sdk/commit/ca15e2cdd9bd0ac19742e9b2dbfa3aa788ccec1a
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
Changed paths:
M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
Log Message:
-----------
CQ. Remove shallow abstractions in DeprecatedMemberUse_PackageConfigWorkspaceTest and ExperimentalMemberUseTest.
Change-Id: I7314f16e7b05316d9c2f47bbcb2805d41a9359a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506000
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8765d801775dc082be4ee2ca9256f219f31a5d43
https://github.com/dart-lang/sdk/commit/8765d801775dc082be4ee2ca9256f219f31a5d43
Author: Alexander Aprelev <a...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M runtime/lib/integers.cc
Changed paths:
M runtime/vm/bootstrap_natives.h
M runtime/vm/compiler/assembler/assembler_arm.cc
M runtime/vm/compiler/assembler/assembler_arm.h
M runtime/vm/compiler/assembler/assembler_arm64.h
M runtime/vm/compiler/assembler/assembler_arm64_test.cc
M runtime/vm/compiler/assembler/assembler_arm_test.cc
M runtime/vm/compiler/assembler/assembler_x64.h
M runtime/vm/compiler/assembler/assembler_x64_test.cc
M runtime/vm/compiler/assembler/disassembler_arm.cc
M runtime/vm/compiler/assembler/disassembler_arm64.cc
M runtime/vm/compiler/assembler/disassembler_x86.cc
M runtime/vm/compiler/backend/evaluator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/simulator_arm.cc
M runtime/vm/simulator_arm64.cc
M runtime/vm/token.h
M sdk/lib/_internal/vm/lib/integers.dart
Log Message:
-----------
Revert "[vm] Recognize int.trailingZeroBitCount/oneBitCount as graph-inlinable"
This reverts commit 0bef83781763b6987f1637c3b25a58edbb789f5e.
Reason for revert: simarm, xarm bot failures https://github.com/dart-lang/sdk/issues/63436
Original change's description:
> [vm] Recognize int.trailingZeroBitCount/oneBitCount as graph-inlinable
>
> Stacks on top of the int.{trailingZeroBitCount,oneBitCount} API CL
> (commit 754239b077e). Both getters route through OTHER_RECOGNIZED_LIST
> when a hardware fast path is available; otherwise the newly added
> Dart bodies inline at call sites via vm:prefer-inline. The C++
> natives are removed.
>
> Backend codegen
> ---------------
> ARM64: NEON CNT + UADDLV (popcount); RBIT + CLZ (ctz).
> ARM: NEON CNT + VPADDL chain (popcount); RBIT + CLZ on the
> register pair (ctz).
> x64: popcntq when TargetCPUFeatures::popcnt_supported();
> LoadImmediate(64) + rep_bsfq for ctz (decodes as tzcnt
> on BMI1+, preserves dest on zero otherwise).
> RISC-V 64: cpop / ctz when RV_baseline includes Zbb.
>
> Per-arch availability is encapsulated in
> UnaryInt64OpInstr::IsSupported(Token::Kind).
>
> Apple M-series ARM64, AOT (us/iter, lower is better):
> cardinality.swar 371
> cardinality.accelerated 154 (2.4x)
> forEachSetBit.swar 19031
> forEachSetBit.accelerated 4988 (3.8x)
> select.swar 199
> select.accelerated 77 (2.6x)
> complementCardinality.swar 399
> complementCardinality.accel 152 (2.6x)
>
> Work towards https://github.com/dart-lang/sdk/issues/6486 (popcount
> and ctz intrinsification).
>
> Work towards https://github.com/dart-lang/sdk/issues/1053 (efficient
> BitSet implementation).
>
> Fixes https://github.com/dart-lang/sdk/issues/52673
> Fixes https://github.com/dart-lang/sdk/issues/38346
> Issue https://github.com/dart-lang/sdk/issues/10212
> Issue https://github.com/dart-lang/sdk/issues/5798
> TEST=tests/corelib/int_bit_count_test
>
> Cq-Include-Trybots: luci.dart.try:vm-aot-linux-release-simarm_x64-try,vm-aot-linux-debug-simarm_x64-try,dart-sdk-linux-riscv64-try
> Change-Id: I9c2c4225fd63d54e190398a0fb6649366317dd17
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/504221
> Commit-Queue: Slava Egorov <veg...@google.com>
> Reviewed-by: Slava Egorov <veg...@google.com>
> Reviewed-by: Martin Kustermann <kuste...@google.com>
> Auto-Submit: Modestas Valauskas <valauska...@gmail.com>
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-release-simarm_x64-try,vm-aot-linux-debug-simarm_x64-try,dart-sdk-linux-riscv64-try
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I4eaca9e25a919ba494f2e7e9819f1ea7d5a13078
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505941
Auto-Submit: Alexander Aprelev <a...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Slava Egorov <veg...@google.com>
Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
Commit: 7e0f28eb5315443c2d4d8909f3fe26824992e7aa
https://github.com/dart-lang/sdk/commit/7e0f28eb5315443c2d4d8909f3fe26824992e7aa
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analysis_server/lib/src/computer/imported_elements_computer.dart
Changed paths:
M pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
A pkg/analysis_server/lib/src/services/interactive_forms/interactive_forms.dart
M pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
M pkg/analysis_server/test/src/services/correction/fix/data_driven/element_matcher_test.dart
A pkg/analysis_server/test/src/services/interactive_forms/interactive_forms_test.dart
A pkg/analysis_server/test/src/services/interactive_forms/test_all.dart
M pkg/analysis_server/test/src/services/test_all.dart
M pkg/analysis_server/tool/lsp_spec/custom/interactive_forms.dart
M pkg/analyzer/test/generated/invalid_code_test.dart
A pkg/analysis_server/test/src/services/interactive_forms/test_all.dart
M pkg/analysis_server/test/src/services/test_all.dart
M pkg/analysis_server/tool/lsp_spec/custom/interactive_forms.dart
M pkg/analyzer/test/generated/non_error_resolver_test.dart
M pkg/analyzer/test/generated/non_hint_code_test.dart
M pkg/analyzer/test/generated/simple_resolver_test.dart
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/index_test.dart
M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
M pkg/analyzer/test/src/dart/analysis/search_test.dart
M pkg/analyzer/test/src/dart/ast/ast_test.dart
M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/element/display_string_test.dart
M pkg/analyzer/test/src/dart/element/inheritance_manager3_test.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
M pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/comment_test.dart
M pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_override_test.dart
M pkg/analyzer/test/src/dart/resolution/field_promotion_test.dart
M pkg/analyzer/test/src/dart/resolution/for_element_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
M pkg/analyzer/test/src/dart/resolution/if_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/index_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/library_element_test.dart
M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
M pkg/analyzer/test/src/dart/resolution/part_test.dart
M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
M pkg/analyzer/test/src/dart/resolution/simple_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/extension_methods_test.dart
M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
M pkg/analyzer/test/src/dart/resolver/exit_detector_test.dart
M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
M pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
M pkg/analyzer/test/src/diagnostics/assignment_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_default_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_constructor_name_test.dart
M pkg/analyzer/test/src/diagnostics/experimental_member_use_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_extended_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/final_class_implemented_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/import_internal_library_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_factory_name_not_a_class_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_internal_annotation_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_language_override_greater_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_use_of_internal_member_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_on_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/non_const_map_as_expression_statement_test.dart
M pkg/analyzer/test/src/diagnostics/private_setter_test.dart
M pkg/analyzer/test/src/diagnostics/receiver_of_type_never_test.dart
M pkg/analyzer/test/src/diagnostics/return_of_do_not_store_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_base_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_final_is_not_base_final_or_sealed_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_sealed_class_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_setter_test.dart
M pkg/analyzer/test/src/diagnostics/unused_element_test.dart
M pkg/analyzer/test/src/diagnostics/uri_does_not_exist_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
M pkg/analyzer/test/src/ignore_comments/ignore_info_test.dart
M pkg/analyzer/test/src/services/top_level_declarations_test.dart
M pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
M pkg/analyzer/test/src/workspace/blaze_test.dart
M pkg/analyzer/test/verify_diagnostics_test.dart
M runtime/lib/integers.cc
M runtime/vm/bootstrap_natives.h
M runtime/vm/compiler/assembler/assembler_arm.cc
M runtime/vm/compiler/assembler/assembler_arm.h
M runtime/vm/compiler/assembler/assembler_arm64.h
M runtime/vm/compiler/assembler/assembler_arm64_test.cc
M runtime/vm/compiler/assembler/assembler_arm_test.cc
M runtime/vm/compiler/assembler/assembler_x64.h
M runtime/vm/compiler/assembler/assembler_x64_test.cc
M runtime/vm/compiler/assembler/disassembler_arm.cc
M runtime/vm/compiler/assembler/disassembler_arm64.cc
M runtime/vm/compiler/assembler/disassembler_x86.cc
M runtime/vm/compiler/backend/evaluator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/simulator_arm.cc
M runtime/vm/simulator_arm64.cc
M runtime/vm/token.h
M sdk/lib/_internal/vm/lib/integers.dart
M sdk/lib/io/overrides.dart
M tests/standalone/io/io_override_test.dart
M third_party/pkg/language_server_protocol/lib/protocol_custom_generated.dart
M tools/VERSION
Log Message:
-----------
Version 3.13.0-133.0.dev
Merge 8765d801775dc082be4ee2ca9256f219f31a5d43 into dev
Compare: https://github.com/dart-lang/sdk/compare/90e55fa88456...7e0f28eb5315
copybara-service[bot]
May 22, 2026, 8:53:00 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages