[dart-lang/sdk] 1e1ecd: Fix code completion before keyword in constructor

0 views
Skip to first unread message

Brian Wilkerson

unread,
May 22, 2026, 1:26:07 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 1e1ecd8b41e22e11ad04a659fe5bcd6edc28d5f6
https://github.com/dart-lang/sdk/commit/1e1ecd8b41e22e11ad04a659fe5bcd6edc28d5f6
Author: Brian Wilkerson <brianwi...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:
M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
M pkg/analysis_server/test/services/completion/dart/location/constructor_declaration_test.dart

Log Message:
-----------
Fix code completion before keyword in constructor

This fixes an exeception when code completing before the `new` or
`factory` keyword in a constructor and the type name is not explicitly
used. The exception prevents any suggestions from being returned, so
it's fairly serious.

Change-Id: I2f5028812ee1945ac9635f55953fb800b19a48c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505620
Auto-Submit: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Reply all
Reply to author
Forward
0 new messages