[dart-lang/sdk] dcde34: CQ. Use DartType.withAlias() instead of two switch.
0 views
Skip to first unread message
Konstantin Scheglov
Apr 1, 2026, 4:19:51 PM (2 days ago) Apr 1
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: dcde342130f8fb8dfd0745c72c712126a87dea21
https://github.com/dart-lang/sdk/commit/dcde342130f8fb8dfd0745c72c712126a87dea21
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
Log Message:
-----------
CQ. Use DartType.withAlias() instead of two switch.
Change-Id: I6a80e3b7067a8f3a55a995fbb82179ef189bc61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491920
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: dcde342130f8fb8dfd0745c72c712126a87dea21
https://github.com/dart-lang/sdk/commit/dcde342130f8fb8dfd0745c72c712126a87dea21
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
Log Message:
-----------
CQ. Use DartType.withAlias() instead of two switch.
Change-Id: I6a80e3b7067a8f3a55a995fbb82179ef189bc61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491920
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Konstantin Scheglov
Apr 1, 2026, 5:16:32 PM (2 days ago) Apr 1
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
Apr 1, 2026, 8:10:34 PM (2 days ago) Apr 1
to com...@dartlang.org
Branch: refs/heads/dev
https://github.com/dart-lang/sdk/commit/0a24f3c4e08057873b7cd5b4e83b0c6946e9310a
Author: Ildeberto Vasconcelos <ildeb...@gmail.com>
Log Message:
-----------
[linter] Add diagnostic docs for annotate_redeclares
Closes https://github.com/dart-lang/sdk/pull/62965
GitOrigin-RevId: 8f6d258040d5ba97432d5bf33cc6a1786559fa8b
Change-Id: Iba2b1e2b2ea991bb02d9c7547797bcc15a002206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490500
Reviewed-by: Connie Ooi <conn...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 0d7653976bb5c5a2d27dd3c5b220bf0d7d66f08a
https://github.com/dart-lang/sdk/commit/0d7653976bb5c5a2d27dd3c5b220bf0d7d66f08a
Author: Danny Tuppeny <da...@tuppeny.com>
M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
Log Message:
-----------
[analysis_server] Handle inserting into empty bodies for create_extension_member, create_missing_overrides
Fixes https://github.com/dart-lang/sdk/issues/63051
Fixes https://github.com/dart-lang/sdk/issues/63056
Change-Id: Idfeb469fad62b090603e3f4a9657f6ee158f4bfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/492121
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit: d53518cba5cf6849f50b1c535ab9542bd0e056f4
https://github.com/dart-lang/sdk/commit/d53518cba5cf6849f50b1c535ab9542bd0e056f4
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/generated/simple_resolver_test.dart
A pkg/analyzer/test/src/diagnostics/class_used_as_mixin_declares_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
R pkg/analyzer/test/src/diagnostics/mixin_class_declares_constructor_test.dart
A pkg/analyzer/test/src/diagnostics/mixin_class_declares_non_trivial_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_inherits_from_not_object_test.dart
M pkg/analyzer/test/src/diagnostics/sealed_class_subtype_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_struct_class_test.dart
M pkg/analyzer/test/src/diagnostics/test_all.dart
M pkg/linter/test/rules/overridden_fields_test.dart
M tests/language/class_modifiers/mixin/mixin_class_generative_constructor_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_forward_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_reverse_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_no_modifier_old_version_generative_constructor_error_test.dart
M tests/language/mixin/illegal_constructor_test.dart
M tests/language/mixin/illegal_object_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_error_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_legacy_error_test.dart
M tests/language/mixin_legacy/illegal_constructor_test.dart
M tests/language/mixin_legacy/illegal_object_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_legacy_error_test.dart
Log Message:
-----------
Issue 62663. Split mixin_class_declares_constructor into class_used_as_mixin_declares_generative_constructor and mixin_class_declares_non_trivial_generative_constructor.
Bug: https://github.com/dart-lang/sdk/issues/62663
Change-Id: I7096923f139ed91451056066aa68965f1b821c5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491925
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 98e17a1e6770ed43d2c1e925e0865c0881984848
https://github.com/dart-lang/sdk/commit/98e17a1e6770ed43d2c1e925e0865c0881984848
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart
M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/generated/simple_resolver_test.dart
A pkg/analyzer/test/src/diagnostics/class_used_as_mixin_declares_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
R pkg/analyzer/test/src/diagnostics/mixin_class_declares_constructor_test.dart
A pkg/analyzer/test/src/diagnostics/mixin_class_declares_non_trivial_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_inherits_from_not_object_test.dart
M pkg/analyzer/test/src/diagnostics/sealed_class_subtype_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_struct_class_test.dart
M pkg/analyzer/test/src/diagnostics/test_all.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/linter/messages.yaml
M pkg/linter/test/rules/overridden_fields_test.dart
M tests/language/class_modifiers/mixin/mixin_class_generative_constructor_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_forward_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_reverse_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_no_modifier_old_version_generative_constructor_error_test.dart
M tests/language/mixin/illegal_constructor_test.dart
M tests/language/mixin/illegal_object_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_error_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_legacy_error_test.dart
M tests/language/mixin_legacy/illegal_constructor_test.dart
M tests/language/mixin_legacy/illegal_object_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_legacy_error_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-311.0.dev
Merge d53518cba5cf6849f50b1c535ab9542bd0e056f4 into dev
Compare: https://github.com/dart-lang/sdk/compare/d84bdfeb45eb...98e17a1e6770
Home: https://github.com/dart-lang/sdk
Commit: dcde342130f8fb8dfd0745c72c712126a87dea21
https://github.com/dart-lang/sdk/commit/dcde342130f8fb8dfd0745c72c712126a87dea21
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
Log Message:
-----------
CQ. Use DartType.withAlias() instead of two switch.
Change-Id: I6a80e3b7067a8f3a55a995fbb82179ef189bc61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491920
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 0a24f3c4e08057873b7cd5b4e83b0c6946e9310a
Commit: dcde342130f8fb8dfd0745c72c712126a87dea21
https://github.com/dart-lang/sdk/commit/dcde342130f8fb8dfd0745c72c712126a87dea21
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
Log Message:
-----------
CQ. Use DartType.withAlias() instead of two switch.
Change-Id: I6a80e3b7067a8f3a55a995fbb82179ef189bc61f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491920
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
https://github.com/dart-lang/sdk/commit/0a24f3c4e08057873b7cd5b4e83b0c6946e9310a
Author: Ildeberto Vasconcelos <ildeb...@gmail.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/linter/messages.yaml
Changed paths:
Log Message:
-----------
[linter] Add diagnostic docs for annotate_redeclares
Closes https://github.com/dart-lang/sdk/pull/62965
GitOrigin-RevId: 8f6d258040d5ba97432d5bf33cc6a1786559fa8b
Change-Id: Iba2b1e2b2ea991bb02d9c7547797bcc15a002206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490500
Reviewed-by: Connie Ooi <conn...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 0d7653976bb5c5a2d27dd3c5b220bf0d7d66f08a
https://github.com/dart-lang/sdk/commit/0d7653976bb5c5a2d27dd3c5b220bf0d7d66f08a
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
Log Message:
-----------
[analysis_server] Handle inserting into empty bodies for create_extension_member, create_missing_overrides
Fixes https://github.com/dart-lang/sdk/issues/63051
Fixes https://github.com/dart-lang/sdk/issues/63056
Change-Id: Idfeb469fad62b090603e3f4a9657f6ee158f4bfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/492121
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit: d53518cba5cf6849f50b1c535ab9542bd0e056f4
https://github.com/dart-lang/sdk/commit/d53518cba5cf6849f50b1c535ab9542bd0e056f4
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/generated/simple_resolver_test.dart
A pkg/analyzer/test/src/diagnostics/class_used_as_mixin_declares_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
R pkg/analyzer/test/src/diagnostics/mixin_class_declares_constructor_test.dart
A pkg/analyzer/test/src/diagnostics/mixin_class_declares_non_trivial_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_inherits_from_not_object_test.dart
M pkg/analyzer/test/src/diagnostics/sealed_class_subtype_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_struct_class_test.dart
M pkg/analyzer/test/src/diagnostics/test_all.dart
M pkg/linter/test/rules/overridden_fields_test.dart
M tests/language/class_modifiers/mixin/mixin_class_generative_constructor_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_forward_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_reverse_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_no_modifier_old_version_generative_constructor_error_test.dart
M tests/language/mixin/illegal_constructor_test.dart
M tests/language/mixin/illegal_object_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_error_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_legacy_error_test.dart
M tests/language/mixin_legacy/illegal_constructor_test.dart
M tests/language/mixin_legacy/illegal_object_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_legacy_error_test.dart
Log Message:
-----------
Issue 62663. Split mixin_class_declares_constructor into class_used_as_mixin_declares_generative_constructor and mixin_class_declares_non_trivial_generative_constructor.
Bug: https://github.com/dart-lang/sdk/issues/62663
Change-Id: I7096923f139ed91451056066aa68965f1b821c5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491925
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 98e17a1e6770ed43d2c1e925e0865c0881984848
https://github.com/dart-lang/sdk/commit/98e17a1e6770ed43d2c1e925e0865c0881984848
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-04-01 (Wed, 01 Apr 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart
M pkg/analysis_server/test/src/services/correction/fix/create_missing_overrides_test.dart
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_schema.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/generated/simple_resolver_test.dart
A pkg/analyzer/test/src/diagnostics/class_used_as_mixin_declares_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/class_used_as_mixin_test.dart
R pkg/analyzer/test/src/diagnostics/mixin_class_declares_constructor_test.dart
A pkg/analyzer/test/src/diagnostics/mixin_class_declares_non_trivial_generative_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_inherits_from_not_object_test.dart
M pkg/analyzer/test/src/diagnostics/sealed_class_subtype_outside_of_library_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
M pkg/analyzer/test/src/diagnostics/subtype_of_struct_class_test.dart
M pkg/analyzer/test/src/diagnostics/test_all.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/linter/messages.yaml
M pkg/linter/test/rules/overridden_fields_test.dart
M tests/language/class_modifiers/mixin/mixin_class_generative_constructor_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_forward_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_legacy_interactions_reverse_error_test.dart
M tests/language/class_modifiers/mixin/mixin_class_no_modifier_old_version_generative_constructor_error_test.dart
M tests/language/mixin/illegal_constructor_test.dart
M tests/language/mixin/illegal_object_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_error_test.dart
M tests/language/mixin_declaration/mixin_declaration_constructor_legacy_error_test.dart
M tests/language/mixin_legacy/illegal_constructor_test.dart
M tests/language/mixin_legacy/illegal_object_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/generic_usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_class_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_error_test.dart
M tests/language/nonfunction_type_aliases/usage_object_legacy_error_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-311.0.dev
Merge d53518cba5cf6849f50b1c535ab9542bd0e056f4 into dev
Compare: https://github.com/dart-lang/sdk/compare/d84bdfeb45eb...98e17a1e6770
copybara-service[bot]
Apr 1, 2026, 8:59:58 PM (2 days ago) Apr 1
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages