[dart-lang/sdk] 0c9e64: [beta] [ dart:io ] Fix bad type casts in network_p...

0 views
Skip to first unread message

Ben Konyi

unread,
Apr 28, 2026, 11:34:40 AM (yesterday) Apr 28
to com...@dartlang.org
Branch: refs/heads/beta
Home: https://github.com/dart-lang/sdk
Commit: 0c9e6415cfc4aa4a617093fd6e9ce2ecf542eaf1
https://github.com/dart-lang/sdk/commit/0c9e6415cfc4aa4a617093fd6e9ce2ecf542eaf1
Author: Ben Konyi <bko...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
A pkg/vm_service/test/http_profile_incomplete_request_integration_test.dart
M sdk/lib/io/network_profiling.dart

Log Message:
-----------
[beta] [ dart:io ] Fix bad type casts in network_profiling.dart

Issue description: In 32e45cf30031dd2466eaedbf5d98c457eff1bb61, types were updated from
Map<String, dynamic> to Map<String, Object> in some situations. These
two aren't compatible and can lead to runtime type cast failures.
What is the fix: update changes from Map<String, Object> to Map<String,
Object?>
Why cherry-pick: this can cause network profiling to stop working
seemingly randomly in DevTools.
Risk: Low, tests added to verify original behavior and validate fix
Issue link: https://github.com/dart-lang/sdk/issues/63156

CoreLibraryReviewExempt: Only internal dart:io details.
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/494680
Change-Id: Iaff6f1fbbb602d9f4a6e7873fc52c9a0cb078b22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/494980
Reviewed-by: Elliott Brooks <elliot...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Reply all
Reply to author
Forward
0 new messages