[dart-lang/sdk] 54e607: [modular_aot] Code generation for async/async*/syn...
0 views
Skip to first unread message
Alexander Markov
Apr 28, 2026, 8:48:30 AM (yesterday) Apr 28
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 54e607854a2c56fc42d042664306da2ca8f9944b
https://github.com/dart-lang/sdk/commit/54e607854a2c56fc42d042664306da2ca8f9944b
Author: Alexander Markov <alexm...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/flow_graph_checker.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/ir/types.dart
M pkg/cfg/lib/ir/visitor.dart
M pkg/cfg/lib/passes/constant_propagation.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/arm64/constraints.dart
M pkg/native_compiler/lib/back_end/arm64/stack_frame.dart
M pkg/native_compiler/lib/back_end/arm64/stub_code_generator.dart
M pkg/native_compiler/lib/back_end/assembler.dart
M pkg/native_compiler/lib/back_end/register_allocator.dart
M pkg/native_compiler/lib/back_end/stack_frame.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
Log Message:
-----------
[modular_aot] Code generation for async/async*/sync*/await/yield/yield*
TEST=ci
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: Ie8da89e09bfad68c65980abc1df69f9273bd6d00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497400
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: a585ead993cc602f322916cca025223d83183cd8
https://github.com/dart-lang/sdk/commit/a585ead993cc602f322916cca025223d83183cd8
Author: Alexander Markov <alexm...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
Log Message:
-----------
[modular_aot] Take FunctionNode of getters and setters into account
In addition to parameter variables, FunctionNode contains asyncMarker
(for example, getter can be sync*).
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I513425f9ffc4daa1cd48a5f8c8df594dea0c33d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498760
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/9e8fdef17c0a...a585ead993cc
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 54e607854a2c56fc42d042664306da2ca8f9944b
https://github.com/dart-lang/sdk/commit/54e607854a2c56fc42d042664306da2ca8f9944b
Author: Alexander Markov <alexm...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/flow_graph_checker.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/ir/types.dart
M pkg/cfg/lib/ir/visitor.dart
M pkg/cfg/lib/passes/constant_propagation.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/arm64/constraints.dart
M pkg/native_compiler/lib/back_end/arm64/stack_frame.dart
M pkg/native_compiler/lib/back_end/arm64/stub_code_generator.dart
M pkg/native_compiler/lib/back_end/assembler.dart
M pkg/native_compiler/lib/back_end/register_allocator.dart
M pkg/native_compiler/lib/back_end/stack_frame.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
Log Message:
-----------
[modular_aot] Code generation for async/async*/sync*/await/yield/yield*
TEST=ci
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: Ie8da89e09bfad68c65980abc1df69f9273bd6d00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/497400
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: a585ead993cc602f322916cca025223d83183cd8
https://github.com/dart-lang/sdk/commit/a585ead993cc602f322916cca025223d83183cd8
Author: Alexander Markov <alexm...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
Log Message:
-----------
[modular_aot] Take FunctionNode of getters and setters into account
In addition to parameter variables, FunctionNode contains asyncMarker
(for example, getter can be sync*).
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I513425f9ffc4daa1cd48a5f8c8df594dea0c33d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498760
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/9e8fdef17c0a...a585ead993cc
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Alexander Markov
Apr 28, 2026, 9:33:31 AM (yesterday) Apr 28
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
Apr 28, 2026, 12:05:18 PM (yesterday) Apr 28
to com...@dartlang.org
Branch: refs/heads/dev
Commit: 37de43c52fbeed0fb5cc89e2ded2dd0eb989eda1
https://github.com/dart-lang/sdk/commit/37de43c52fbeed0fb5cc89e2ded2dd0eb989eda1
Author: Jens Johansen <je...@google.com>
M pkg/testing/lib/src/chain.dart
M pkg/testing/lib/src/discover.dart
M pkg/testing/lib/src/error_handling.dart
M pkg/testing/lib/src/expectation.dart
M pkg/testing/lib/src/log.dart
M pkg/testing/lib/src/run.dart
M pkg/testing/lib/src/run_tests.dart
M pkg/testing/lib/src/status_file_parser.dart
M pkg/testing/lib/src/stdio_process.dart
M pkg/testing/lib/src/test_description.dart
M pkg/testing/lib/src/zone_helper.dart
M pkg/testing/test/analyze_test.dart
Log Message:
-----------
[testing] Format package testing
Change-Id: Ia4503844bcb6ea76627ab050ff198de2c14cb813
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498860
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>
Commit: d93e62b55075354767ad41dcd161e16433d7639f
https://github.com/dart-lang/sdk/commit/d93e62b55075354767ad41dcd161e16433d7639f
Author: Jens Johansen <je...@google.com>
M pkg/testing/lib/src/chain.dart
Log Message:
-----------
[CFE/testing] Faster listing of testcases, especially for spelling_test_not_src_suite
pkg/front_end/test/spelling_test_not_src_suite.dart:
Before: Returning 5503 results after 0:00:30.424831
Now: Returning 5503 results after 0:00:00.642866
pkg/front_end/test/textual_outline_suite.dart:
Before: Returning 3335 results after 0:00:01.340791
Now: Returning 3335 results after 0:00:00.950186
pkg/front_end/test/outline_suite.dart:
Before: Returning 3328 results after 0:00:01.698578
Now: Returning 3328 results after 0:00:00.908465
pkg/front_end/test/strong_suite.dart:
Before: Returning 3335 results after 0:00:01.719944
Now: Returning 3335 results after 0:00:00.819222
pkg/front_end/test/modular_suite.dart:
Before: Returning 3328 results after 0:00:01.777826
Now: Returning 3328 results after 0:00:00.887345
pkg/front_end/test/lint_suite.dart:
Before: Returning 600 results after 0:00:00.035862
Now: Returning 600 results after 0:00:00.016070
pkg/front_end/test/spelling_test_src_suite.dart:
Before: Returning 605 results after 0:00:00.027379
Now: Got list of size 605 in 0:00:00.019704
Change-Id: I422b6bd0a4aac6da3d94d500349c3d84bf88cffe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498880
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>
Commit: 6ebcada9ff1810974c56a4efcddbd79595084dcb
https://github.com/dart-lang/sdk/commit/6ebcada9ff1810974c56a4efcddbd79595084dcb
Author: Nate Biggs <nate...@google.com>
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.aot.expect
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.json.expect
Log Message:
-----------
[dart2wasm] Fix loading unit lookup for top-level constants.
Change-Id: Ia7de84a88efbc53f170ec156046a892310399f58
Tested: Added function_invocation.dart test
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498380
Commit-Queue: Nate Biggs <nate...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit: 4c2ffad5caf1df537228992d5e81f3f6e92e6119
https://github.com/dart-lang/sdk/commit/4c2ffad5caf1df537228992d5e81f3f6e92e6119
Author: kevmoo <kev...@google.com>
M pkg/analyzer/lib/src/error/element_usage_detector.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
Log Message:
-----------
analyzer: Fix missing `deprecated_member_use`
...on named parameters in annotations
The analyzer failed to report `deprecated_member_use` when using a deprecated named parameter in a constant constructor invocation used as an annotation (e.g., `@JsonKey(ignore: true)`).
This was because `ElementUsageDetector` lacked an `annotation` method to process arguments, and `BestPracticesVerifier` did not call it. This issue is similar to the one fixed for unused parameters in annotations in commit d8cfa31e03b.
This commit:
- Adds an `annotation` method to `ElementUsageDetector` to check arguments against parameters.
- Calls this method from `BestPracticesVerifier.visitAnnotation`.
- Adds a reproduction test in `pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart`.
Fixes https://github.com/dart-lang/sdk/issues/63259
Change-Id: I9e452ecad19c9cd6b0e5170233a313114e4d7c59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498480
Commit-Queue: Kevin Moore <kev...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Auto-Submit: Kevin Moore <kev...@google.com>
Commit: 5127f04ee19d646ea82c6376422999a5a6bead2e
https://github.com/dart-lang/sdk/commit/5127f04ee19d646ea82c6376422999a5a6bead2e
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/analyzer/lib/src/error/element_usage_detector.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
M pkg/front_end/testing.json
M pkg/testing/lib/src/chain.dart
M pkg/testing/lib/src/discover.dart
M pkg/testing/lib/src/error_handling.dart
M pkg/testing/lib/src/expectation.dart
M pkg/testing/lib/src/log.dart
M pkg/testing/lib/src/run.dart
M pkg/testing/lib/src/run_tests.dart
M pkg/testing/lib/src/status_file_parser.dart
M pkg/testing/lib/src/stdio_process.dart
M pkg/testing/lib/src/test_description.dart
M pkg/testing/lib/src/zone_helper.dart
M pkg/testing/test/analyze_test.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.aot.expect
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.json.expect
M runtime/vm/module_snapshot.cc
M tools/VERSION
Log Message:
-----------
Version 3.13.0-76.0.dev
Merge 4c2ffad5caf1df537228992d5e81f3f6e92e6119 into dev
Compare: https://github.com/dart-lang/sdk/compare/94a3b9f8dcd6...5127f04ee19d
https://github.com/dart-lang/sdk/commit/37de43c52fbeed0fb5cc89e2ded2dd0eb989eda1
Author: Jens Johansen <je...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/testing/lib/src/analyze.dart
Changed paths:
M pkg/testing/lib/src/chain.dart
M pkg/testing/lib/src/discover.dart
M pkg/testing/lib/src/error_handling.dart
M pkg/testing/lib/src/expectation.dart
M pkg/testing/lib/src/log.dart
M pkg/testing/lib/src/run.dart
M pkg/testing/lib/src/run_tests.dart
M pkg/testing/lib/src/status_file_parser.dart
M pkg/testing/lib/src/stdio_process.dart
M pkg/testing/lib/src/test_description.dart
M pkg/testing/lib/src/zone_helper.dart
M pkg/testing/test/analyze_test.dart
Log Message:
-----------
[testing] Format package testing
Change-Id: Ia4503844bcb6ea76627ab050ff198de2c14cb813
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498860
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>
Commit: d93e62b55075354767ad41dcd161e16433d7639f
https://github.com/dart-lang/sdk/commit/d93e62b55075354767ad41dcd161e16433d7639f
Author: Jens Johansen <je...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/front_end/testing.json
Changed paths:
M pkg/testing/lib/src/chain.dart
Log Message:
-----------
[CFE/testing] Faster listing of testcases, especially for spelling_test_not_src_suite
pkg/front_end/test/spelling_test_not_src_suite.dart:
Before: Returning 5503 results after 0:00:30.424831
Now: Returning 5503 results after 0:00:00.642866
pkg/front_end/test/textual_outline_suite.dart:
Before: Returning 3335 results after 0:00:01.340791
Now: Returning 3335 results after 0:00:00.950186
pkg/front_end/test/outline_suite.dart:
Before: Returning 3328 results after 0:00:01.698578
Now: Returning 3328 results after 0:00:00.908465
pkg/front_end/test/strong_suite.dart:
Before: Returning 3335 results after 0:00:01.719944
Now: Returning 3335 results after 0:00:00.819222
pkg/front_end/test/modular_suite.dart:
Before: Returning 3328 results after 0:00:01.777826
Now: Returning 3328 results after 0:00:00.887345
pkg/front_end/test/lint_suite.dart:
Before: Returning 600 results after 0:00:00.035862
Now: Returning 600 results after 0:00:00.016070
pkg/front_end/test/spelling_test_src_suite.dart:
Before: Returning 605 results after 0:00:00.027379
Now: Got list of size 605 in 0:00:00.019704
Change-Id: I422b6bd0a4aac6da3d94d500349c3d84bf88cffe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498880
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>
Commit: 6ebcada9ff1810974c56a4efcddbd79595084dcb
https://github.com/dart-lang/sdk/commit/6ebcada9ff1810974c56a4efcddbd79595084dcb
Author: Nate Biggs <nate...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/dart2wasm/lib/code_generator.dart
Changed paths:
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.aot.expect
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.json.expect
Log Message:
-----------
[dart2wasm] Fix loading unit lookup for top-level constants.
Change-Id: Ia7de84a88efbc53f170ec156046a892310399f58
Tested: Added function_invocation.dart test
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498380
Commit-Queue: Nate Biggs <nate...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit: 4c2ffad5caf1df537228992d5e81f3f6e92e6119
https://github.com/dart-lang/sdk/commit/4c2ffad5caf1df537228992d5e81f3f6e92e6119
Author: kevmoo <kev...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
Changed paths:
M pkg/analyzer/lib/src/error/element_usage_detector.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
Log Message:
-----------
analyzer: Fix missing `deprecated_member_use`
...on named parameters in annotations
The analyzer failed to report `deprecated_member_use` when using a deprecated named parameter in a constant constructor invocation used as an annotation (e.g., `@JsonKey(ignore: true)`).
This was because `ElementUsageDetector` lacked an `annotation` method to process arguments, and `BestPracticesVerifier` did not call it. This issue is similar to the one fixed for unused parameters in annotations in commit d8cfa31e03b.
This commit:
- Adds an `annotation` method to `ElementUsageDetector` to check arguments against parameters.
- Calls this method from `BestPracticesVerifier.visitAnnotation`.
- Adds a reproduction test in `pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart`.
Fixes https://github.com/dart-lang/sdk/issues/63259
Change-Id: I9e452ecad19c9cd6b0e5170233a313114e4d7c59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498480
Commit-Queue: Kevin Moore <kev...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Auto-Submit: Kevin Moore <kev...@google.com>
Commit: 5127f04ee19d646ea82c6376422999a5a6bead2e
https://github.com/dart-lang/sdk/commit/5127f04ee19d646ea82c6376422999a5a6bead2e
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)
Changed paths:
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
Changed paths:
M pkg/analyzer/lib/src/error/element_usage_detector.dart
M pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/flow_graph_checker.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/flow_graph_checker.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/ir/types.dart
M pkg/cfg/lib/ir/visitor.dart
M pkg/cfg/lib/passes/constant_propagation.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
M pkg/dart2wasm/lib/code_generator.dart
M pkg/cfg/lib/ir/types.dart
M pkg/cfg/lib/ir/visitor.dart
M pkg/cfg/lib/passes/constant_propagation.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/suspendable.dart
M pkg/cfg/testcases/suspendable.dart.expect
M pkg/front_end/testing.json
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/arm64/constraints.dart
M pkg/native_compiler/lib/back_end/arm64/stack_frame.dart
M pkg/native_compiler/lib/back_end/arm64/stub_code_generator.dart
M pkg/native_compiler/lib/back_end/assembler.dart
M pkg/native_compiler/lib/back_end/register_allocator.dart
M pkg/native_compiler/lib/back_end/stack_frame.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M pkg/testing/lib/src/analyze.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/arm64/constraints.dart
M pkg/native_compiler/lib/back_end/arm64/stack_frame.dart
M pkg/native_compiler/lib/back_end/arm64/stub_code_generator.dart
M pkg/native_compiler/lib/back_end/assembler.dart
M pkg/native_compiler/lib/back_end/register_allocator.dart
M pkg/native_compiler/lib/back_end/stack_frame.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M pkg/testing/lib/src/chain.dart
M pkg/testing/lib/src/discover.dart
M pkg/testing/lib/src/error_handling.dart
M pkg/testing/lib/src/expectation.dart
M pkg/testing/lib/src/log.dart
M pkg/testing/lib/src/run.dart
M pkg/testing/lib/src/run_tests.dart
M pkg/testing/lib/src/status_file_parser.dart
M pkg/testing/lib/src/stdio_process.dart
M pkg/testing/lib/src/test_description.dart
M pkg/testing/lib/src/zone_helper.dart
M pkg/testing/test/analyze_test.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.aot.expect
A pkg/vm/testcases/transformations/record_use/lib/function_invocation.dart.json.expect
M runtime/vm/module_snapshot.cc
M tools/VERSION
Log Message:
-----------
Version 3.13.0-76.0.dev
Merge 4c2ffad5caf1df537228992d5e81f3f6e92e6119 into dev
Compare: https://github.com/dart-lang/sdk/compare/94a3b9f8dcd6...5127f04ee19d
copybara-service[bot]
Apr 28, 2026, 1:48:11 PM (24 hours ago) Apr 28
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages