[dart-lang/sdk] 3ece23: DAS plugins: Catch when there is no state folder, ...

0 views
Skip to first unread message

Sam Rawlins

unread,
Jan 16, 2026, 11:31:54 AM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 3ece23ddc607d01d1e9061c77b953e85a33f0f31
https://github.com/dart-lang/sdk/commit/3ece23ddc607d01d1e9061c77b953e85a33f0f31
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/lib/src/analytics/plugin_data.dart

Log Message:
-----------
DAS plugins: Catch when there is no state folder, during analytics

Fixes https://github.com/dart-lang/sdk/issues/62420

Change-Id: I0c213b451a150abcc077b30277494357dd63508d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473440
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Bob Nystrom

unread,
Jan 16, 2026, 12:52:24 PM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/lkgr
Home: https://github.com/dart-lang/sdk
Commit: 3ece23ddc607d01d1e9061c77b953e85a33f0f31
https://github.com/dart-lang/sdk/commit/3ece23ddc607d01d1e9061c77b953e85a33f0f31
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/lib/src/analytics/plugin_data.dart

Log Message:
-----------
DAS plugins: Catch when there is no state folder, during analytics

Fixes https://github.com/dart-lang/sdk/issues/62420

Change-Id: I0c213b451a150abcc077b30277494357dd63508d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473440
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>


Commit: 2a395c1586b1b1a80509053b6e369f4cb2cba12c
https://github.com/dart-lang/sdk/commit/2a395c1586b1b1a80509053b6e369f4cb2cba12c
Author: DEPS Autoroller <dart-a...@skia-public.iam.gserviceaccount.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M DEPS

Log Message:
-----------
Roll BoringSSL from 78ab2c2774bc to 1ea3ce8c9fcd (61 revisions)

https://boringssl.googlesource.com/boringssl.git/+log/78ab2c2774bc..1ea3ce8c9fcd

2026-01-15 rpo...@google.com Namespace crypto/x509's internal symbols.
2026-01-15 rpo...@google.com Revert "Revert "Namespace crypto/trust_token's internal symbols.""
2026-01-14 xfd...@google.com Mark Prk as Send + Sync
2026-01-14 xfd...@google.com Add HMAC on SHA-384 for TLS 1.3 support
2026-01-14 davi...@google.com Narrow EVP_PKEY_cmp and EVP_PKEY_cmp_parameters return values
2026-01-14 davi...@google.com Fix typo in setting up CMAKE_CXX_FLAGS
2026-01-13 xfd...@google.com Use proper label type in TLS1.2 P-hash function
2026-01-13 rpo...@google.com Pregenerate: add a concept of tasks that can be waited upon.
2026-01-12 davi...@google.com Deflake DTLS12-SendExtraFinished-Reordered
2026-01-12 davi...@google.com The null parameter should be equal to itself
2026-01-12 davi...@google.com Stop reaching into TRUST_TOKEN_CLIENT internals in the benchmark
2026-01-12 davi...@google.com Move most DTLS 1.3 TODOs to child bugs
2026-01-12 davi...@google.com Test that DTLS 1.2 rejects renegotiation
2026-01-12 davi...@google.com bssl-sys: Remove unsupported_inline_wrappers
2026-01-12 davi...@google.com Raise the maximum RSA key size back to 16384
2026-01-12 davi...@google.com Also check OPENSSL_RSA_MAX_MODULUS_BITS in RSA keygen
2026-01-12 xfd...@google.com Rust: Move TLS1.2 PRF into public interface
2026-01-12 davi...@google.com Spanify a couple helper functions
2026-01-12 rpo...@google.com Namespace crypto/asn1's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/bcm_interface.h's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/bn's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/aes's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/ec's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/service_indicator's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/bytestring's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/bcm_support.h's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/evp's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/rsa's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/dh's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/keccak's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/rand's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/ecdsa's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/cipher's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/ec's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/dsa's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/fipsmodule/tls's internal symbols.
2026-01-12 rpo...@google.com Namespace crypto/conf's internal symbols.
2026-01-12 rpo...@google.com Revert "Revert "Namespace crypto/pkcs7's internal symbols.""
2026-01-09 awad...@google.com bssl-crypto: Add support for serializing and deserializing compressed points
2026-01-09 davi...@google.com Fix build with -Wheader-hygiene
2026-01-09 rpo...@google.com Revert "Namespace crypto/pkcs7's internal symbols."
2026-01-09 rpo...@google.com Namespace crypto/pkcs7's internal symbols.
2026-01-09 rpo...@google.com Namespace crypto/fipsmodule/slhdsa's internal symbols.
2026-01-09 rpo...@google.com Namespace crypto/pkcs8's internal symbols.
2026-01-09 rpo...@google.com Symbol prefixing: also include symbols that don't have C linkage.
2026-01-08 a...@chromium.org bssl-crypto: fix typo in error string
2026-01-08 a...@chromium.org bssl-crypto: run cargo fmt
2026-01-07 davi...@google.com Remove internal STACK_OF(X509V3_EXT_METHOD) symbols
2026-01-07 chl...@google.com Clean up no-op cipher aliases for legacy SHA-2 CBC ciphers
2026-01-07 chl...@google.com Add support for TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256
2026-01-07 rpo...@google.com Namespace all lhash internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/kyber's internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/hrss's internal symbols.
2026-01-07 rpo...@google.com Namespace decrepit/cast's internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/pem's internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/chacha's internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/curve25519's internal symbols.
2026-01-07 rpo...@google.com Namespace crypto/des's internal symbols.
2026-01-06 davi...@google.com Stop using sqrt(2) in RSA key generation
2026-01-05 davi...@google.com Update RSA-related citations from FIPS 186-4 to FIPS 186-5
2026-01-05 davi...@google.com Use consistent RSA keygen and import limits

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@grotations.appspotmail.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-...@grotations.appspotmail.com
Change-Id: I13ba95f9af39d8914b63cbce4dc5cb8957d297cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473400
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Alexander Markov <alexm...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>


Commit: 16c9a6eb1fbace5d536f9d9766f3465ebf4e22eb
https://github.com/dart-lang/sdk/commit/16c9a6eb1fbace5d536f9d9766f3465ebf4e22eb
Author: Martin Kamleithner <martin.ka...@gmail.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/linter/lib/src/rules/type_annotate_public_apis.dart
M pkg/linter/test/rules/type_annotate_public_apis_test.dart

Log Message:
-----------
[Linter] Flag untyped constructor params

Motivation:
- type_annotate_public_apis checks public methods/functions but skipped
constructors, leaving implicit dynamic in public APIs.

Current behavior:
class A {
A(dynamic_param); // not flagged

void foo(dynamic_param) {} // flagged, violates type_annotate_public_apis
}

New behavior: untyped public constructor parameters are flagged the same
as other public API parameters.

Pros:
- More consistent public API coverage.
- Prevents implicit dynamic from slipping into constructor signatures.

Cons:
- BREAKING CHANGE: untyped public constructor parameters now lint.

Closes https://github.com/dart-lang/sdk/issues/62241

R=elliot...@google.com, kee...@google.com

Change-Id: Ie892a24b1f49d69335d1af89b1e873268898165a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473040
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Martin Kamleithner <martin.ka...@gmail.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>


Commit: af99a79f3ce91b9fd4818c83007aa991ceea864b
https://github.com/dart-lang/sdk/commit/af99a79f3ce91b9fd4818c83007aa991ceea864b
Author: Robert Nystrom <rnys...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/lib/src/services/correction/dart/add_async.dart
M pkg/analysis_server/lib/src/services/correction/dart/remove_async.dart

Log Message:
-----------
Simplify return type.

I was learning my way around the assist code and stumbled onto a couple
of things that could be simpler.

I'm guessing the original code was written at a point in time when the
`element` getter was nullable but it isn't now, so the refactored code
here should be behaviorally equivalent to the original.

Change-Id: I6ee664024411ca7f95ff60091818bacaf88a8239
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473600
Commit-Queue: Bob Nystrom <rnys...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/2366fd740ee4...af99a79f3ce9
Reply all
Reply to author
Forward
0 new messages