[dart-lang/sdk] e9f6de: [messages] Use literate API for _CatchClausesVerif...

[Paul Berry]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: e9f6dedd319160050b0e33f66557d6d3c483c531
https://github.com/dart-lang/sdk/commit/e9f6dedd319160050b0e33f66557d6d3c483c531
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)

Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/dead_code_verifier.dart
M pkg/analyzer/messages.yaml

Log Message:
-----------
[messages] Use literate API for _CatchClausesVerifier._reportDiagnostic.

Changes the callback function
`_CatchClausesVerifier._reportDiagnostic` so that it uses the literate
diagnistic reporting API.

To avoid making use of temporary placeholder parameter names, I
modified the error code `deadCodeOnCatchSubtype` in the process,
assigning it reasonable parameter names.

Change-Id: I6a6a6964fe0c8c526585d39759451f4063d7426e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473923
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Commit: 26e03dcf8a7f8b4a07d93ffd42c0459cee3cd0ed
https://github.com/dart-lang/sdk/commit/26e03dcf8a7f8b4a07d93ffd42c0459cee3cd0ed
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)

Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart

Log Message:
-----------
[messages] Fix correction message for invalid_export_of_internal_element_indirectly.

Fixes the correction message for
`invalid_export_of_internal_element_indirectly` to properly suggest
that the user hide the exported element. (Previously it suggested that
the user hide the internal, non-exported name).

Also switches to using the literate diagnostic API for reporting the
error.

Fixes https://github.com/dart-lang/sdk/issues/62440.

Change-Id: I6a6a6964e31ff6d48327b3609b7681449ad386a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473980
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/06553e9687aa...26e03dcf8a7f

To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[Paul Berry]

Branch: refs/heads/lkgr