[dart-lang/sdk] 06553e: [messages] Fix message text for missingDependency.
0 views
Skip to first unread message
Paul Berry
Jan 17, 2026, 10:12:08 AM (19 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
https://github.com/dart-lang/sdk/commit/06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
Log Message:
-----------
[messages] Fix message text for missingDependency.
Reworks the logic for generating the text of `missingDependency`
messages so that they are clearer and easier to read.
Fixes https://github.com/dart-lang/sdk/issues/62431.
Change-Id: I6a6a69642714205332b5bfa824d5ba25480cbd98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473783
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
https://github.com/dart-lang/sdk/commit/06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
Log Message:
-----------
[messages] Fix message text for missingDependency.
Reworks the logic for generating the text of `missingDependency`
messages so that they are clearer and easier to read.
Fixes https://github.com/dart-lang/sdk/issues/62431.
Change-Id: I6a6a69642714205332b5bfa824d5ba25480cbd98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473783
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Paul Berry
Jan 17, 2026, 11:18:29 AM (18 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
Jan 17, 2026, 3:05:37 PM (14 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/dev
https://github.com/dart-lang/sdk/commit/e9f6dedd319160050b0e33f66557d6d3c483c531
M pkg/analyzer/messages.yaml
Log Message:
-----------
[messages] Use literate API for _CatchClausesVerifier._reportDiagnostic.
Changes the callback function
`_CatchClausesVerifier._reportDiagnostic` so that it uses the literate
diagnistic reporting API.
To avoid making use of temporary placeholder parameter names, I
modified the error code `deadCodeOnCatchSubtype` in the process,
assigning it reasonable parameter names.
Change-Id: I6a6a6964fe0c8c526585d39759451f4063d7426e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473923
https://github.com/dart-lang/sdk/commit/26e03dcf8a7f8b4a07d93ffd42c0459cee3cd0ed
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
Log Message:
-----------
[messages] Fix correction message for invalid_export_of_internal_element_indirectly.
Fixes the correction message for
`invalid_export_of_internal_element_indirectly` to properly suggest
that the user hide the exported element. (Previously it suggested that
the user hide the internal, non-exported name).
Also switches to using the literate diagnostic API for reporting the
error.
Fixes https://github.com/dart-lang/sdk/issues/62440.
Change-Id: I6a6a6964e31ff6d48327b3609b7681449ad386a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473980
https://github.com/dart-lang/sdk/commit/b42c00eaef900706dbd79b9c6208a6f3e5608ab6
M pkg/analyzer/lib/src/error/doc_comment_verifier.dart
Log Message:
-----------
[messages] Rework reporting of docDirectiveMissing{Two,Three}Arguments.
Changes the analyzer logic that reports the following errors:
- docDirectiveMissingTwoArguments
- docDirectiveMissingThreeArguments
So that a temporary `missingArguments` list is not used. This puts the
code in a form that the `use_literate_api_in_analyzer.dart` tool will
be able to automatically transform.
Change-Id: I6a6a69640847744cc9ec8fe57c346c9d6f52adfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473960
https://github.com/dart-lang/sdk/commit/1543c5b2d70f5d2ba6dfa7d45c93b0f55322ff3d
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart
M pkg/analyzer/lib/src/error/error_handler_verifier.dart
M pkg/analyzer/lib/src/error/imports_verifier.dart
M pkg/analyzer/lib/src/fasta/error_converter.dart
M pkg/analyzer/lib/src/generated/element_resolver.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/messages.yaml
Log Message:
-----------
[messages] Convert more diagnostics to literate diagnostic reporting API.
The only changes in this CL that were manually written are those in
`messages.yaml`. The others were produced by running the standard
diagnostic message code generator and then running the script
`use_literate_api_in_analyzer.dart`.
Change-Id: I6a6a69646968fcdc1922a477710964d948fd1e0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473941
https://github.com/dart-lang/sdk/commit/190cfb49ab70d0e30184321d4956aef74cc47b9d
Author: Robert Nystrom <rnys...@google.com>
M pkg/analysis_server/test/src/services/correction/assist/convert_field_formal_to_normal_test.dart
Log Message:
-----------
Update ConvertFieldFormalToNormal to handle private named parameters.
This does need an actual change in the implementation. It's pretty
simple. If we are converting a private named initializing formal to a
normal formal, then we:
- Change the parameter in the parameter list to the corresponding
public name.
- Use the same public name in the initializer.
Bug: https://github.com/dart-lang/sdk/issues/62436
Change-Id: I8c66ea02d0c6ceb870afd350fd6a1e6fc0b0f82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473943
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit: 1aa700abeec1408910bd19fc3fc807e290778cff
https://github.com/dart-lang/sdk/commit/1aa700abeec1408910bd19fc3fc807e290778cff
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/analysis_server/test/src/services/correction/assist/convert_field_formal_to_normal_test.dart
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
M pkg/analyzer/lib/src/error/dead_code_verifier.dart
M pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart
M pkg/analyzer/lib/src/error/doc_comment_verifier.dart
M pkg/analyzer/lib/src/error/error_handler_verifier.dart
M pkg/analyzer/lib/src/error/imports_verifier.dart
M pkg/analyzer/lib/src/fasta/error_converter.dart
M pkg/analyzer/lib/src/generated/element_resolver.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-41.0.dev
Merge 190cfb49ab70d0e30184321d4956aef74cc47b9d into dev
Compare: https://github.com/dart-lang/sdk/compare/c144fdb6b823...1aa700abeec1
Home: https://github.com/dart-lang/sdk
Commit: 06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
https://github.com/dart-lang/sdk/commit/06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
Log Message:
-----------
[messages] Fix message text for missingDependency.
Reworks the logic for generating the text of `missingDependency`
messages so that they are clearer and easier to read.
Fixes https://github.com/dart-lang/sdk/issues/62431.
Change-Id: I6a6a69642714205332b5bfa824d5ba25480cbd98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473783
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Commit: e9f6dedd319160050b0e33f66557d6d3c483c531
Commit: 06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
https://github.com/dart-lang/sdk/commit/06553e9687aaaaa833a4ad6592e97b4fc8f6fc7b
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
Log Message:
-----------
[messages] Fix message text for missingDependency.
Reworks the logic for generating the text of `missingDependency`
messages so that they are clearer and easier to read.
Fixes https://github.com/dart-lang/sdk/issues/62431.
Change-Id: I6a6a69642714205332b5bfa824d5ba25480cbd98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473783
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
https://github.com/dart-lang/sdk/commit/e9f6dedd319160050b0e33f66557d6d3c483c531
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/dead_code_verifier.dart
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/messages.yaml
Log Message:
-----------
[messages] Use literate API for _CatchClausesVerifier._reportDiagnostic.
Changes the callback function
`_CatchClausesVerifier._reportDiagnostic` so that it uses the literate
diagnistic reporting API.
To avoid making use of temporary placeholder parameter names, I
modified the error code `deadCodeOnCatchSubtype` in the process,
assigning it reasonable parameter names.
Change-Id: I6a6a6964fe0c8c526585d39759451f4063d7426e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473923
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Commit: 26e03dcf8a7f8b4a07d93ffd42c0459cee3cd0ed
Commit-Queue: Paul Berry <paul...@google.com>
https://github.com/dart-lang/sdk/commit/26e03dcf8a7f8b4a07d93ffd42c0459cee3cd0ed
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
Log Message:
-----------
[messages] Fix correction message for invalid_export_of_internal_element_indirectly.
Fixes the correction message for
`invalid_export_of_internal_element_indirectly` to properly suggest
that the user hide the exported element. (Previously it suggested that
the user hide the internal, non-exported name).
Also switches to using the literate diagnostic API for reporting the
error.
Fixes https://github.com/dart-lang/sdk/issues/62440.
Change-Id: I6a6a6964e31ff6d48327b3609b7681449ad386a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473980
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Commit: b42c00eaef900706dbd79b9c6208a6f3e5608ab6
Commit-Queue: Paul Berry <paul...@google.com>
https://github.com/dart-lang/sdk/commit/b42c00eaef900706dbd79b9c6208a6f3e5608ab6
M pkg/analyzer/lib/src/error/doc_comment_verifier.dart
Log Message:
-----------
[messages] Rework reporting of docDirectiveMissing{Two,Three}Arguments.
Changes the analyzer logic that reports the following errors:
- docDirectiveMissingTwoArguments
- docDirectiveMissingThreeArguments
So that a temporary `missingArguments` list is not used. This puts the
code in a form that the `use_literate_api_in_analyzer.dart` tool will
be able to automatically transform.
Change-Id: I6a6a69640847744cc9ec8fe57c346c9d6f52adfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473960
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Commit: 1543c5b2d70f5d2ba6dfa7d45c93b0f55322ff3d
Commit-Queue: Paul Berry <paul...@google.com>
https://github.com/dart-lang/sdk/commit/1543c5b2d70f5d2ba6dfa7d45c93b0f55322ff3d
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart
M pkg/analyzer/lib/src/error/error_handler_verifier.dart
M pkg/analyzer/lib/src/error/imports_verifier.dart
M pkg/analyzer/lib/src/fasta/error_converter.dart
M pkg/analyzer/lib/src/generated/element_resolver.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/messages.yaml
Log Message:
-----------
[messages] Convert more diagnostics to literate diagnostic reporting API.
The only changes in this CL that were manually written are those in
`messages.yaml`. The others were produced by running the standard
diagnostic message code generator and then running the script
`use_literate_api_in_analyzer.dart`.
Change-Id: I6a6a69646968fcdc1922a477710964d948fd1e0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473941
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>
Commit: 190cfb49ab70d0e30184321d4956aef74cc47b9d
Commit-Queue: Paul Berry <paul...@google.com>
https://github.com/dart-lang/sdk/commit/190cfb49ab70d0e30184321d4956aef74cc47b9d
Author: Robert Nystrom <rnys...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/dart/convert_field_formal_to_normal.dart
Changed paths:
M pkg/analysis_server/test/src/services/correction/assist/convert_field_formal_to_normal_test.dart
Log Message:
-----------
Update ConvertFieldFormalToNormal to handle private named parameters.
This does need an actual change in the implementation. It's pretty
simple. If we are converting a private named initializing formal to a
normal formal, then we:
- Change the parameter in the parameter list to the corresponding
public name.
- Use the same public name in the initializer.
Bug: https://github.com/dart-lang/sdk/issues/62436
Change-Id: I8c66ea02d0c6ceb870afd350fd6a1e6fc0b0f82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473943
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit: 1aa700abeec1408910bd19fc3fc807e290778cff
https://github.com/dart-lang/sdk/commit/1aa700abeec1408910bd19fc3fc807e290778cff
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/dart/convert_field_formal_to_normal.dart
Changed paths:
M pkg/analysis_server/test/src/services/correction/assist/convert_field_formal_to_normal_test.dart
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/best_practices_verifier.dart
M pkg/analyzer/lib/src/error/dead_code_verifier.dart
M pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart
M pkg/analyzer/lib/src/error/doc_comment_verifier.dart
M pkg/analyzer/lib/src/error/error_handler_verifier.dart
M pkg/analyzer/lib/src/error/imports_verifier.dart
M pkg/analyzer/lib/src/fasta/error_converter.dart
M pkg/analyzer/lib/src/generated/element_resolver.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/pubspec/validators/missing_dependency_validator.dart
M pkg/analyzer/messages.yaml
M pkg/analyzer/test/src/diagnostics/invalid_export_of_internal_element_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_dependency_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-41.0.dev
Merge 190cfb49ab70d0e30184321d4956aef74cc47b9d into dev
Compare: https://github.com/dart-lang/sdk/compare/c144fdb6b823...1aa700abeec1
copybara-service[bot]
Jan 17, 2026, 3:46:05 PM (13 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages