[dart-lang/sdk] cf1d8b: [messages] Make Scanner and Parser take a Diagnost...

[Paul Berry]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: cf1d8b96dba77f42ae5941d195c245d7c322809c
https://github.com/dart-lang/sdk/commit/cf1d8b96dba77f42ae5941d195c245d7c322809c
Author: Paul Berry <paul...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/lib/src/g3/utilities.dart
M pkg/analysis_server/lib/src/lsp/source_edits.dart
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
M pkg/analysis_server/test/stress/replay/replay.dart
M pkg/analysis_server_plugin/lib/edit/correction_utils.dart
M pkg/analyzer/lib/dart/analysis/utilities.dart
M pkg/analyzer/lib/src/dart/analysis/file_state.dart
M pkg/analyzer/lib/src/dart/scanner/scanner.dart
M pkg/analyzer/lib/src/generated/parser.dart
M pkg/analyzer/test/generated/parser_test_base.dart
M pkg/analyzer/test/generated/scanner_test.dart
M pkg/analyzer/test/src/dart/ast/parse_base.dart
M pkg/analyzer/test/src/summary/test_strategies.dart
M pkg/analyzer_cli/tool/perf.dart
M pkg/front_end/tool/perf.dart
M pkg/scrape/lib/scrape.dart

Log Message:
-----------
[messages] Make Scanner and Parser take a DiagnosticReporter.

Changes the signature of the following constructors:
- Scanner
- Scanner.fasta
- Parser

So that they accept a `DiagnosticReporter` object rather than a
`DiagnosticListener` object. This brings the scanner and the parser
into alignment with the majority of the rest of the analyzer (which
reports errors using `DiagnosticReporter` rather than by talking to
`DiagnosticListener` directly).

It also makes the `source` parameter of these constructors
unnecessary, because the `source` can be obtained from the
`DiagnosticReporter`.

Change-Id: I6a6a6964607ffb52a8332a6e618dc0c9a1e48c5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473442
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Bob Nystrom <rnys...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications