[dart-lang/sdk] 265b75: linter: leak_detectors: fix case for method invoca...

0 views
Skip to first unread message

Sam Rawlins

unread,
11:50 AM (8 hours ago) 11:50 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 265b75c74e46e1a6a1543f261633d92e264082e1
https://github.com/dart-lang/sdk/commit/265b75c74e46e1a6a1543f261633d92e264082e1
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M pkg/linter/lib/src/util/leak_detector_visitor.dart
M pkg/linter/test/rules/cancel_subscriptions_test.dart

Log Message:
-----------
linter: leak_detectors: fix case for method invocation with no target

Fixes new failures in flutter bot: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8689087561632725585/+/u/analyze_Flutter_repositories/stdout?format=raw

Regression introduced by https://dart-review.googlesource.com/c/sdk/+/482444

The bug was that we bailed out too early, when looking at a method
invocation, and we are deciding whether it might represent a valid
cancelation. There are some checks that are only valid if the invocation
has a real target. But there are other checks that should be made even
if the function has an implicit target.

Change-Id: Id67d381aa1f78de8bf0f264a962ee2bbbdc6a030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482860
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Reply all
Reply to author
Forward
0 new messages