[dart-lang/sdk] 9ad207: [analysis_server] Add tests for primary constructo...

0 views
Skip to first unread message

Danny Tuppeny

unread,
Jan 16, 2026, 1:08:12 PM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 9ad2074691796f3445773acbbd142e3a4aabbab9
https://github.com/dart-lang/sdk/commit/9ad2074691796f3445773acbbd142e3a4aabbab9
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/test/lsp/source_edits_test.dart
M pkg/analysis_server/test/lsp/workspace_symbols_test.dart
M pkg/analysis_server/test/utils/lsp_protocol_extensions.dart

Log Message:
-----------
[analysis_server] Add tests for primary constructors in LSP workspace symbols

Primary constructor bodies do not currently show up here. The primary constructor entry in the results navigates to the declaration.

Change-Id: I321bd4dfa5a98635987b165575d0f683a437e129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473340
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Konstantin Scheglov

unread,
Jan 16, 2026, 2:12:47 PM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/lkgr
Home: https://github.com/dart-lang/sdk
Commit: 9ad2074691796f3445773acbbd142e3a4aabbab9
https://github.com/dart-lang/sdk/commit/9ad2074691796f3445773acbbd142e3a4aabbab9
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/test/lsp/source_edits_test.dart
M pkg/analysis_server/test/lsp/workspace_symbols_test.dart
M pkg/analysis_server/test/utils/lsp_protocol_extensions.dart

Log Message:
-----------
[analysis_server] Add tests for primary constructors in LSP workspace symbols

Primary constructor bodies do not currently show up here. The primary constructor entry in the results navigates to the declaration.

Change-Id: I321bd4dfa5a98635987b165575d0f683a437e129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473340
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>


Commit: 238f7e0000fd7186496015834d2c5b820fbb76b8
https://github.com/dart-lang/sdk/commit/238f7e0000fd7186496015834d2c5b820fbb76b8
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analyzer/test/src/dart/resolution/class_test.dart

Log Message:
-----------
DeCo. Tests for arguments to super constructor invocation.

ClassDeclarationResolutionTest_constructor_super passes.

ClassDeclarationResolutionTest_primaryConstructor_super has many failing tests.
In a next CL I will update the implementation to make them pass, and
update diagnostics offsets where necessary.

Change-Id: Ife76d4cbbab5481af9763beed7ea17678ebbc674
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473520
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/f92ea3d58dbd...238f7e0000fd
Reply all
Reply to author
Forward
0 new messages