[dart-lang/sdk] 57cac8: CQ. Remove ResolutionTest type convenience getters.

0 views
Skip to first unread message

Konstantin Scheglov

unread,
May 22, 2026, 1:40:12 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 57cac82bb6a603970c157085eeca42dd69e28d76
https://github.com/dart-lang/sdk/commit/57cac82bb6a603970c157085eeca42dd69e28d76
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/src/dart/constant/potentially_constant_test.dart
M pkg/analyzer/test/src/dart/element/flatten_type_test.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart

Log Message:
-----------
CQ. Remove ResolutionTest type convenience getters.

Stop exposing common type and element shortcuts from ResolutionTest so
tests use the resolved unit's TypeProvider and library state directly.
This keeps the shared resolution test mixin focused on resolution
utilities instead of duplicating accessors for analyzer internals.

Move the affected flatten coverage out of StaticTypeAnalyzerTest and
into the dedicated built-type tests. This keeps flatten, futureType, and
unionFreeType behavior together in FlattenTypeTest and related test
classes, including coverage for recursive hierarchies and conflicting
Future interfaces.

Update remaining callers to read the library feature set from the
resolved result, and remove assertions that depended on the deleted
ResolutionTest element shortcuts.

Change-Id: I714aec736636500b293b547972a64dc0541172a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505500
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Reply all
Reply to author
Forward
0 new messages