[dart-lang/sdk] 026bb7: [vm/gardening] Handle child process racing to exit.

[Alexander Aprelev]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 026bb7cfeb2599fc37fa5a82714db25e6a7a4f28
https://github.com/dart-lang/sdk/commit/026bb7cfeb2599fc37fa5a82714db25e6a7a4f28
Author: Alexander Aprelev <a...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M tests/standalone/io/regress_flutter_57125_test.dart

Log Message:
-----------
[vm/gardening] Handle child process racing to exit.

Writing to stdin of already exited child process might not raise an error, will cause infinite loop in the test.

Fixes https://github.com/dart-lang/sdk/issues/56400
TEST=ci

Change-Id: I0100b5e5d782ae3682d634a47759b78146243274
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473821
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[Paul Berry]

Branch: refs/heads/lkgr

Home: https://github.com/dart-lang/sdk
Commit: 026bb7cfeb2599fc37fa5a82714db25e6a7a4f28
https://github.com/dart-lang/sdk/commit/026bb7cfeb2599fc37fa5a82714db25e6a7a4f28
Author: Alexander Aprelev <a...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M tests/standalone/io/regress_flutter_57125_test.dart

Log Message:
-----------
[vm/gardening] Handle child process racing to exit.

Writing to stdin of already exited child process might not raise an error, will cause infinite loop in the test.

Fixes https://github.com/dart-lang/sdk/issues/56400
TEST=ci

Change-Id: I0100b5e5d782ae3682d634a47759b78146243274
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473821
Reviewed-by: Alexander Markov <alexm...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>

Commit: 05ba29991e19e7d6fa15c94d7cc782493052de5d
https://github.com/dart-lang/sdk/commit/05ba29991e19e7d6fa15c94d7cc782493052de5d
Author: Paul Berry <paul...@google.com>

Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:

M pkg/analyzer/lib/src/dart/scanner/scanner.dart

Log Message:
-----------
[messages] Fix signature of Scanner.reportError.

Changes the signature of `Scanner.reportError` so that its `arguments`
parameter requires a `List<Object>?` rather than a
`List<Object?>?`. This is consistent with the call sites.

This paves the way for a follow-up CL that will change
`Scanner.reportError` to use the literate diagnostic API (which
requires arguments to never be `null`).

Change-Id: I6a6a6964073bf82d3fc889ece15dffe7fb0eb867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473441
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Commit: 61b86b94838afe104d4ceb79644aa046d7889f9f
https://github.com/dart-lang/sdk/commit/61b86b94838afe104d4ceb79644aa046d7889f9f
Author: Paul Berry <paul...@google.com>

Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:

M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/manifest/manifest_validator.dart
M pkg/analyzer/messages.yaml

Log Message:
-----------
[messages] Use literate API in _reportErrorForNode.

Changes `ManifestValidator._reportErrorForNode` to use the literate
diagnostic reporting API.

Change-Id: I6a6a6964944b19c6b83084183285e20102fd5f1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/472426
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Commit: cf1d8b96dba77f42ae5941d195c245d7c322809c
https://github.com/dart-lang/sdk/commit/cf1d8b96dba77f42ae5941d195c245d7c322809c
Author: Paul Berry <paul...@google.com>

Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:

M pkg/analysis_server/lib/src/g3/utilities.dart
M pkg/analysis_server/lib/src/lsp/source_edits.dart
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart
M pkg/analysis_server/test/stress/replay/replay.dart
M pkg/analysis_server_plugin/lib/edit/correction_utils.dart
M pkg/analyzer/lib/dart/analysis/utilities.dart
M pkg/analyzer/lib/src/dart/analysis/file_state.dart
M pkg/analyzer/lib/src/dart/scanner/scanner.dart
M pkg/analyzer/lib/src/generated/parser.dart
M pkg/analyzer/test/generated/parser_test_base.dart
M pkg/analyzer/test/generated/scanner_test.dart
M pkg/analyzer/test/src/dart/ast/parse_base.dart
M pkg/analyzer/test/src/summary/test_strategies.dart
M pkg/analyzer_cli/tool/perf.dart
M pkg/front_end/tool/perf.dart
M pkg/scrape/lib/scrape.dart

Log Message:
-----------
[messages] Make Scanner and Parser take a DiagnosticReporter.

Changes the signature of the following constructors:
- Scanner
- Scanner.fasta
- Parser

So that they accept a `DiagnosticReporter` object rather than a
`DiagnosticListener` object. This brings the scanner and the parser
into alignment with the majority of the rest of the analyzer (which
reports errors using `DiagnosticReporter` rather than by talking to
`DiagnosticListener` directly).

It also makes the `source` parameter of these constructors
unnecessary, because the `source` can be obtained from the
`DiagnosticReporter`.

Change-Id: I6a6a6964607ffb52a8332a6e618dc0c9a1e48c5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473442
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Bob Nystrom <rnys...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/bfe325b834b3...cf1d8b96dba7