[dart-lang/sdk] ced356: Use private named parameters in the core libraries.

0 views
Skip to first unread message

Lasse R.H. Nielsen

unread,
6:09 AM (14 hours ago) 6:09 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: ced356c76ec68bc699928b3944eaa69f34d1ee59
https://github.com/dart-lang/sdk/commit/ced356c76ec68bc699928b3944eaa69f34d1ee59
Author: Lasse R.H. Nielsen <l...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M sdk/lib/async/future_extensions.dart
M sdk/lib/convert/ascii.dart
M sdk/lib/convert/html_escape.dart
M sdk/lib/convert/json.dart
M sdk/lib/convert/latin1.dart
M sdk/lib/convert/utf.dart

Log Message:
-----------
Use private named parameters in the core libraries.

CoreLibraryReviewExempt: No API or implementation changes.
Change-Id: I056ddf937f9010979cbf4c99b8802a8c43ab5e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481820
Reviewed-by: Bob Nystrom <rnys...@google.com>
Commit-Queue: Lasse Nielsen <l...@google.com>
Reviewed-by: Nate Bosch <nbo...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Lasse R.H. Nielsen

unread,
7:10 AM (13 hours ago) 7:10 AM
to com...@dartlang.org
Branch: refs/heads/lkgr

copybara-service[bot]

unread,
11:05 AM (9 hours ago) 11:05 AM
to com...@dartlang.org
Branch: refs/heads/dev
Home: https://github.com/dart-lang/sdk
Commit: ced356c76ec68bc699928b3944eaa69f34d1ee59
https://github.com/dart-lang/sdk/commit/ced356c76ec68bc699928b3944eaa69f34d1ee59
Author: Lasse R.H. Nielsen <l...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M sdk/lib/async/future_extensions.dart
M sdk/lib/convert/ascii.dart
M sdk/lib/convert/html_escape.dart
M sdk/lib/convert/json.dart
M sdk/lib/convert/latin1.dart
M sdk/lib/convert/utf.dart

Log Message:
-----------
Use private named parameters in the core libraries.

CoreLibraryReviewExempt: No API or implementation changes.
Change-Id: I056ddf937f9010979cbf4c99b8802a8c43ab5e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481820
Reviewed-by: Bob Nystrom <rnys...@google.com>
Commit-Queue: Lasse Nielsen <l...@google.com>
Reviewed-by: Nate Bosch <nbo...@google.com>


Commit: 5792b6ecb73628888d249028a30958d39e0a601c
https://github.com/dart-lang/sdk/commit/5792b6ecb73628888d249028a30958d39e0a601c
Author: Tess Strickland <sstr...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M runtime/vm/compiler/assembler/disassembler_kbc.h
M runtime/vm/constants_kbc.h
M runtime/vm/interpreter.cc

Log Message:
-----------
[vm, dyn_modules] Fix tracing the original instruction at breakpoints.

https://dart-review.googlesource.com/c/sdk/+/481782 removed the tracing
of the original instruction for breakpoints. This CL adds it back.

Also increments icount_ before calling TraceInstruction in the dispatch
loop instead of afterwards so that breakpoint/single step tracing can
just use icount_ without adjusting it. In particular, this means tracing
the original instruction at a breakpoint can just use TraceInstruction
instead of duplicating it.

Also, now both the breakpoint instruction and the original instruction
are written to the instruction trace if requested, instead of only the
breakpoint instruction.

TEST=debugging only changes, so manually tested.

Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try
Change-Id: I1999f1d9e7ba55b950c508e848ff12db0c8d5cab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482320
Reviewed-by: Alexander Markov <alexm...@google.com>
Auto-Submit: Tess Strickland <sstr...@google.com>
Commit-Queue: Tess Strickland <sstr...@google.com>


Commit: 86880a4cabdb0feb0f45300377f447c6434e79cd
https://github.com/dart-lang/sdk/commit/86880a4cabdb0feb0f45300377f447c6434e79cd
Author: Daco Harkes <dacoh...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M pkg/vm/lib/modular/transformations/ffi/use_sites.dart
A tests/ffi/static_checks/regress_62693_test.dart

Log Message:
-----------
[cfe/ffi] Don't transform methods if wrong number of arguments

TEST=tests/ffi/static_checks/regress_62693_test.dart

Closes: https://github.com/dart-lang/sdk/issues/62693
Change-Id: Ifa9228568a4b01f162df727f80cbb923d148d043
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,analyzer-mac-release-try,analyzer-win-release-try,front-end-linux-release-x64-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482760
Reviewed-by: Michael Goderbauer <goder...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>


Commit: dc07f7095661e7f817886fd41bf2904d3deb2f87
https://github.com/dart-lang/sdk/commit/dc07f7095661e7f817886fd41bf2904d3deb2f87
Author: Daco Harkes <dacoh...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M DEPS
M pkg/compiler/test/record_use/record_use_test.dart
M pkg/front_end/lib/src/codes/diagnostic.g.dart
M pkg/front_end/lib/src/kernel/constant_evaluator.dart
M pkg/front_end/lib/src/kernel/record_use.dart
M pkg/front_end/messages.status
M pkg/front_end/messages.yaml
M pkg/vm/test/transformations/record_use_test.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested.dart
M pkg/vm/testcases/transformations/record_use/lib/nested.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart.aot.expect
R pkg/vm/testcases/transformations/record_use/lib/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_final_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_extends_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_implements_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_mixin_throws.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart.aot.expect

Log Message:
-----------
[record_use] Const instance recording classes must be final

And they may not be extended, implemented and mixed in.

It would be cleaner if we test the static checks with the [cfe]
test expectations. However, those test suites are not set up to
run from a package context, which `@RecordUse` annotations must be.

TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart

Change-Id: Ia4e93a6f25ad4c246503ebf8ece67e7d4bca1410
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482220
Commit-Queue: Daco Harkes <dacoh...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Reviewed-by: Michael Goderbauer <goder...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>


Commit: 2ec10d2611c0621e7e2ed66e97e39ad98c52f4d6
https://github.com/dart-lang/sdk/commit/2ec10d2611c0621e7e2ed66e97e39ad98c52f4d6
Author: Daco Harkes <dacoh...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M DEPS

Log Message:
-----------
[deps] Roll dart-lang/native

Rolls in support for enum consts and record consts, but doesn't
start using them yet.

TEST=pkg/compiler/test/record_use/record_use_test.dart
TEST=pkg/dart2wasm/test/record_use_test.dart
TEST=pkg/vm/test/transformations/record_use_test.dart

Change-Id: Ia161e41e401b051a59976be6225570a6c2dd09ad
Cq-Include-Trybots: luci.dart.try:dart2wasm-asserts-linux-chrome-try,dart2wasm-asserts-minified-linux-d8-try,dart2wasm-linux-chrome-try,dart2wasm-linux-d8-try,dart2wasm-linux-firefox-try,dart2wasm-linux-jscm-chrome-try,dart2wasm-linux-optimized-jsc-try,pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try,dart2js-canary-linux-try,dart2js-hostasserts-linux-d8-try,dart2js-linux-chrome-try,dart2js-linux-firefox-try,dart2js-mac-chrome-try,dart2js-mac-safari-try,dart2js-minified-csp-linux-chrome-try,dart2js-minified-linux-d8-try,dart2js-unit-linux-x64-release-try,dart2js-win-chrome-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482800
Reviewed-by: Michael Goderbauer <goder...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>


Commit: d23cf6c0d633fc1e486a8b02bdc861eb97cf487a
https://github.com/dart-lang/sdk/commit/d23cf6c0d633fc1e486a8b02bdc861eb97cf487a
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)

Changed paths:
M DEPS
M pkg/compiler/test/record_use/record_use_test.dart
M pkg/front_end/lib/src/codes/diagnostic.g.dart
M pkg/front_end/lib/src/kernel/constant_evaluator.dart
M pkg/front_end/lib/src/kernel/record_use.dart
M pkg/front_end/messages.status
M pkg/front_end/messages.yaml
M pkg/vm/lib/modular/transformations/ffi/use_sites.dart
M pkg/vm/test/transformations/record_use_test.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_class.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_complex.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_duplicates.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_method.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart
M pkg/vm/testcases/transformations/record_use/lib/instance_not_annotation.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested.dart
M pkg/vm/testcases/transformations/record_use/lib/nested.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart
M pkg/vm/testcases/transformations/record_use/lib/nested_instance_constant.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart
M pkg/vm/testcases/transformations/record_use/lib/record_enum.dart.aot.expect
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart
M pkg/vm/testcases/transformations/record_use/lib/record_instance_constant_empty.dart.aot.expect
R pkg/vm/testcases/transformations/record_use/lib/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_final_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_invalid_location_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_extends_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_implements_throws.dart
A pkg/vm/testcases/transformations/record_use/lib/static_checks/record_use_subtyping_mixin_throws.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart
M pkg/vm/testcases/transformations/record_use/lib/unsupported_instance.dart.aot.expect
M runtime/vm/compiler/assembler/disassembler_kbc.h
M runtime/vm/constants_kbc.h
M runtime/vm/interpreter.cc
M sdk/lib/async/future_extensions.dart
M sdk/lib/convert/ascii.dart
M sdk/lib/convert/html_escape.dart
M sdk/lib/convert/json.dart
M sdk/lib/convert/latin1.dart
M sdk/lib/convert/utf.dart
A tests/ffi/static_checks/regress_62693_test.dart
M tools/VERSION

Log Message:
-----------
Version 3.12.0-175.0.dev

Merge 2ec10d2611c0621e7e2ed66e97e39ad98c52f4d6 into dev


Compare: https://github.com/dart-lang/sdk/compare/1002263b1f0d...d23cf6c0d633

copybara-service[bot]

unread,
11:54 AM (8 hours ago) 11:54 AM
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages