[dart-lang/sdk] 2a3753: [analysis_server] Deprecate HighlightRegionType.BU...
0 views
Skip to first unread message
Danny Tuppeny
10:46 AM (9 hours ago) 10:46 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 2a375317f4bc378003b9dc64c0cd1379e926bc5e
https://github.com/dart-lang/sdk/commit/2a375317f4bc378003b9dc64c0cd1379e926bc5e
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server/doc/api.html
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
Log Message:
-----------
[analysis_server] Deprecate HighlightRegionType.BUILT_IN and always use KEYWORD
Change-Id: I86ff7edc2b4de5910b19f6bdb0d4422b7546897a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482820
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 2a375317f4bc378003b9dc64c0cd1379e926bc5e
https://github.com/dart-lang/sdk/commit/2a375317f4bc378003b9dc64c0cd1379e926bc5e
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server/doc/api.html
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
Log Message:
-----------
[analysis_server] Deprecate HighlightRegionType.BUILT_IN and always use KEYWORD
Change-Id: I86ff7edc2b4de5910b19f6bdb0d4422b7546897a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482820
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Alexander Markov
12:22 PM (8 hours ago) 12:22 PM
to com...@dartlang.org
Branch: refs/heads/lkgr
Commit: 45ab768bf571e0186100f147e002d08151fe19dd
https://github.com/dart-lang/sdk/commit/45ab768bf571e0186100f147e002d08151fe19dd
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
Log Message:
-----------
DeCo. Pass LocalScope to ScopeContext.withLocalScope
Change ScopeContext.withLocalScope to pass the created LocalScope to the
callback, and add LocalScope helpers for bulk insertion of declared
elements.
Refactor resolution/scoping visitors to use the provided LocalScope
rather than downcasting nameScope or relying on ad-hoc predeclaration:
- Predeclare local functions, local variables, and pattern variables in the
correct enclosing scope before visiting initializers/bodies, so lexical
lookup binds to loop/local elements consistently (including in implicit
block scopes for control-flow sub-statements).
- Centralize for-loop-parts handling (declarations, identifiers, patterns)
so each part is visited in the required order while installing the right
loop-local bindings.
- Compute and store declared pattern-variable elements directly on the
relevant AST nodes, and update ForEachPartsWithPattern to carry variable
elements (so flow analysis can declare them without extra indirection).
Also ensure metadata on pattern variable declarations and pattern-for
parts is visited in the same scope model as other declarations.
Change-Id: I35d52860b6816196085d79979cda861583c850be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482540
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7f32691a95b5e34aa7e8157e6f57c3e4b010460b
https://github.com/dart-lang/sdk/commit/7f32691a95b5e34aa7e8157e6f57c3e4b010460b
Author: Konstantin Shcheglov <sche...@google.com>
Log Message:
-----------
CQ. Make ErrorVerifier._featureSet non-nullable.
Change-Id: I14db847fda69f6fd690b02290d71600e237d2373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482700
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7eb7da68904821623ef10a24f20cba2adb216cbc
https://github.com/dart-lang/sdk/commit/7eb7da68904821623ef10a24f20cba2adb216cbc
Author: Alexander Markov <alexm...@google.com>
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
M runtime/vm/object.h
M runtime/vm/raw_object.h
Log Message:
-----------
[vm,modular_aot] Initial code generation for interface calls
Also:
* Support arguments descriptors.
* Fix order of ClosureCall inputs in local function invocations.
* Fix order of passing arguments in all Dart calls.
* Fix handling of fields in InstanceSerializationCluster.
* Do not compile abstract methods and fields.
* Do not generate initializer functions for fields with trivial
initializers.
* Initialize Code::code_source_map to an empty CodeSourceMap
(in order to avoid failed assertions).
TEST=tools/test.py -n vm-modaot-mac-debug-arm64 language
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I40ff1b8234c32c41e08f3288a23e4abc173efcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480020
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: ba4bfeabdadec1de2320f3982035f9056ef93856
https://github.com/dart-lang/sdk/commit/ba4bfeabdadec1de2320f3982035f9056ef93856
Author: Alexander Markov <alexm...@google.com>
M pkg/native_compiler/lib/snapshot/snapshot.dart
Log Message:
-----------
[vm,modular_aot] Support getter and setter selector names
Add 'get:' and 'set:' prefixes to getter and setter selectors.
Also revise snapshot serialization of private names to support
private getter and setter names. ast.Name is replaced with
VM-specific PrivateName as private getter/setter names
such as get:_foo are considered public by ast.Name
(as they don't start with '_').
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I7447cb457aa2463836c8cf6af3d12e1998fe325c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481441
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/39c5a61f8967...ba4bfeabdade
https://github.com/dart-lang/sdk/commit/45ab768bf571e0186100f147e002d08151fe19dd
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/ast/ast.dart
Changed paths:
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
Log Message:
-----------
DeCo. Pass LocalScope to ScopeContext.withLocalScope
Change ScopeContext.withLocalScope to pass the created LocalScope to the
callback, and add LocalScope helpers for bulk insertion of declared
elements.
Refactor resolution/scoping visitors to use the provided LocalScope
rather than downcasting nameScope or relying on ad-hoc predeclaration:
- Predeclare local functions, local variables, and pattern variables in the
correct enclosing scope before visiting initializers/bodies, so lexical
lookup binds to loop/local elements consistently (including in implicit
block scopes for control-flow sub-statements).
- Centralize for-loop-parts handling (declarations, identifiers, patterns)
so each part is visited in the required order while installing the right
loop-local bindings.
- Compute and store declared pattern-variable elements directly on the
relevant AST nodes, and update ForEachPartsWithPattern to carry variable
elements (so flow analysis can declare them without extra indirection).
Also ensure metadata on pattern variable declarations and pattern-for
parts is visited in the same scope model as other declarations.
Change-Id: I35d52860b6816196085d79979cda861583c850be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482540
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7f32691a95b5e34aa7e8157e6f57c3e4b010460b
https://github.com/dart-lang/sdk/commit/7f32691a95b5e34aa7e8157e6f57c3e4b010460b
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/generated/error_verifier.dart
Changed paths:
Log Message:
-----------
CQ. Make ErrorVerifier._featureSet non-nullable.
Change-Id: I14db847fda69f6fd690b02290d71600e237d2373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482700
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7eb7da68904821623ef10a24f20cba2adb216cbc
https://github.com/dart-lang/sdk/commit/7eb7da68904821623ef10a24f20cba2adb216cbc
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/cfg/lib/front_end/ast_to_ir.dart
Changed paths:
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
M runtime/vm/object.h
M runtime/vm/raw_object.h
Log Message:
-----------
[vm,modular_aot] Initial code generation for interface calls
Also:
* Support arguments descriptors.
* Fix order of ClosureCall inputs in local function invocations.
* Fix order of passing arguments in all Dart calls.
* Fix handling of fields in InstanceSerializationCluster.
* Do not compile abstract methods and fields.
* Do not generate initializer functions for fields with trivial
initializers.
* Initialize Code::code_source_map to an empty CodeSourceMap
(in order to avoid failed assertions).
TEST=tools/test.py -n vm-modaot-mac-debug-arm64 language
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I40ff1b8234c32c41e08f3288a23e4abc173efcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480020
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: ba4bfeabdadec1de2320f3982035f9056ef93856
https://github.com/dart-lang/sdk/commit/ba4bfeabdadec1de2320f3982035f9056ef93856
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/native_compiler/lib/back_end/object_pool.dart
Changed paths:
M pkg/native_compiler/lib/snapshot/snapshot.dart
Log Message:
-----------
[vm,modular_aot] Support getter and setter selector names
Add 'get:' and 'set:' prefixes to getter and setter selectors.
Also revise snapshot serialization of private names to support
private getter and setter names. ast.Name is replaced with
VM-specific PrivateName as private getter/setter names
such as get:_foo are considered public by ast.Name
(as they don't start with '_').
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I7447cb457aa2463836c8cf6af3d12e1998fe325c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481441
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/39c5a61f8967...ba4bfeabdade
Reply all
Reply to author
Forward
0 new messages