[dart-lang/sdk] 2a93a2: Revert "Switch on building devtools from source wh...

0 views
Skip to first unread message

Liam Appelbe

unread,
Apr 28, 2026, 9:14:07 PM (16 hours ago) Apr 28
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 2a93a26d91b62b34e2697c2db11033b912545f19
https://github.com/dart-lang/sdk/commit/2a93a26d91b62b34e2697c2db11033b912545f19
Author: Liam Appelbe <li...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M sdk/BUILD.gn
M tools/build_devtools.py

Log Message:
-----------
Revert "Switch on building devtools from source when building the Dart SDK"

This reverts commit d0d8184d1afb5b1db49c9b57bc7e2bd069f30c1d.

Reason for revert: Doesn't build in Flutter
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8683246937886984145/+/u/gn_--target-dir_ci_host_debug_--runtime-mode_debug_--no-prebuilt-dart-sdk_--build-embedder-examples_--no-lto_--rbe_--no-goma_--rbe-server-address_unix:___b_s_w_ir_x_w_rc_rbebn74b14k_reproxy.sock/stdout

Original change's description:
> Switch on building devtools from source when building the Dart SDK
>
> Fixes https://github.com/flutter/devtools/issues/9786
>
> See go/moving-devtools-to-dart-sdk-2025.
>
> In this change, we make the source of devtools be configurable, in
> actions like build_sdk.
>
> If `build_devtools_from_sources` is true, we build local devtools,
> and if false, we continue to use the prebuilt sources.
>
> This may be an intermediate step, while we test out building devtools
> from source. Or it may be permanently be a choice, if we keep building
> with CIPD.
>
> Change-Id: I7b46d6359c69b34f316e59dccc475e211a18f965
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498640
> Reviewed-by: Alexander Aprelev <a...@google.com>
> Commit-Queue: Samuel Rawlins <sraw...@google.com>

Change-Id: I20381d6bf1d9cba192c46efde99cb57dc75e7cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499160
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Liam Appelbe <li...@google.com>
Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Nate Biggs <nate...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Liam Appelbe

unread,
Apr 28, 2026, 9:50:21 PM (16 hours ago) Apr 28
to com...@dartlang.org
Branch: refs/heads/lkgr
Reply all
Reply to author
Forward
0 new messages