[dart-lang/sdk] d22b56: CQ. Migrate ManifestValidatorTest to inline expect...

0 views
Skip to first unread message

Konstantin Scheglov

unread,
10:54 AM (12 hours ago) 10:54 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: d22b566c31f67da2e4dbfbd76f5b26e93e537a20
https://github.com/dart-lang/sdk/commit/d22b566c31f67da2e4dbfbd76f5b26e93e537a20
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/analyzer/test/src/manifest/manifest_validator_test.dart

Log Message:
-----------
CQ. Migrate ManifestValidatorTest to inline expected diagnostics.

Change-Id: I499057965ea93aae9f550b9a383033ea6072db41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511140
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Alexander Markov

unread,
11:56 AM (11 hours ago) 11:56 AM
to com...@dartlang.org
Branch: refs/heads/lkgr
Home: https://github.com/dart-lang/sdk
Commit: d22b566c31f67da2e4dbfbd76f5b26e93e537a20
https://github.com/dart-lang/sdk/commit/d22b566c31f67da2e4dbfbd76f5b26e93e537a20
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/analyzer/test/src/manifest/manifest_validator_test.dart

Log Message:
-----------
CQ. Migrate ManifestValidatorTest to inline expected diagnostics.

Change-Id: I499057965ea93aae9f550b9a383033ea6072db41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511140
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>


Commit: 8e0ba59c7aad8b0f3a780ed79967b870a869d047
https://github.com/dart-lang/sdk/commit/8e0ba59c7aad8b0f3a780ed79967b870a869d047
Author: Alexander Markov <alexm...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M runtime/vm/os_win.cc

Log Message:
-----------
[vm,gardening] Possible fix for build failure on Flutter bots

This is an attempt to fix the following build failure which appears
on Flutter bots but not Dart CI bots:

```
../../../flutter/third_party/dart/runtime/vm/os_win.cc(260,13): error: no matching function for call to 'ReadProcessMemory'
260 | BOOL ok = ReadProcessMemory(GetCurrentProcess(), address, buffer,
| ^~~~~~~~~~~~~~~~~
../../../flutter/third_party/depot_tools/win_toolchain/vs_files/27370823e7\Windows Kits\10\Include\10.0.22621.0\um\memoryapi.h(152,1): note: candidate function not viable: no known conversion from 'size_t *' (aka 'unsigned int *') to 'SIZE_T *' (aka 'unsigned long *') for 5th argument
152 | ReadProcessMemory(
| ^
153 | _In_ HANDLE hProcess,
154 | _In_ LPCVOID lpBaseAddress,
155 | _Out_writes_bytes_to_(nSize,*lpNumberOfBytesRead) LPVOID lpBuffer,
156 | _In_ SIZE_T nSize,
157 | _Out_opt_ SIZE_T* lpNumberOfBytesRead
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```

TEST=ci

Change-Id: Ic32a5f7750c92850e23c7a8e0e77b1d385e8fc17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511440
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>


Commit: 9297d718a16b80efad8d89708a4773c3321dd9f8
https://github.com/dart-lang/sdk/commit/9297d718a16b80efad8d89708a4773c3321dd9f8
Author: Alexander Markov <alexm...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)

Changed paths:
M pkg/test_runner/lib/src/command_output.dart
M pkg/test_runner/lib/src/compiler_configuration.dart
M pkg/test_runner/lib/src/configuration.dart
M pkg/test_runner/lib/src/multitest.dart
M pkg/test_runner/lib/src/test_file.dart
M pkg/test_runner/lib/src/test_suite.dart
M pkg/test_runner/lib/src/testing_servers.dart
M tests/standalone/io/process_non_ascii_test.dart
M tests/standalone/io/regress_7679_test.dart

Log Message:
-----------
Revert "[test_runner] Invoke tests with relative paths."

This reverts commit b5294b97538cc8d4f221d1306874dfc259c435bc.

Reason for revert: many failures on appjit, reload and fuchsia bots

Failure Link: <LINK TO FAILURE>

Original change's description:
> [test_runner] Invoke tests with relative paths.
>
> This makes tests more reproducible, and makes it easier to copy commands between workspaces, or between a failing bot and a local workspace.
>
> Change-Id: Ic8dd10a3540f314a406e5c5b0a23d97032e5d01d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508364
> Reviewed-by: Alexander Aprelev <a...@google.com>
> Commit-Queue: Ryan Macnak <rma...@google.com>

Change-Id: Id7aa668c0609df65a5f622ae73013a15e7f9200e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511400
Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/be4df1a86900...9297d718a16b
Reply all
Reply to author
Forward
0 new messages