[dart-lang/sdk] 4f3f25: [_fe_analyzer_shared] Move analysis of yield state...

[Paul Berry]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 4f3f25269ce5478d629287c430adecbfaa1b009b
https://github.com/dart-lang/sdk/commit/4f3f25269ce5478d629287c430adecbfaa1b009b
Author: Paul Berry <paul...@google.com>
Date: 2026-04-02 (Thu, 02 Apr 2026)

Changed paths:
A pkg/_fe_analyzer_shared/lib/src/type_inference/body_inference_context.dart
M pkg/_fe_analyzer_shared/lib/src/type_inference/type_analysis_result.dart
M pkg/_fe_analyzer_shared/lib/src/type_inference/type_analyzer.dart
M pkg/_fe_analyzer_shared/test/mini_ast.dart
M pkg/_fe_analyzer_shared/test/type_inference/type_inference_test.dart
M pkg/analyzer/lib/src/dart/resolver/body_inference_context.dart
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/front_end/lib/src/type_inference/closure_context.dart
M pkg/front_end/lib/src/type_inference/inference_visitor.dart

Log Message:
-----------
[_fe_analyzer_shared] Move analysis of yield statements to shared logic.

Moves some of the business logic for type analyzing yield statements
from the analyzer and front_end codebases into the shared
`TypeAnalyzer` class. There is no functional change.

This paves the way for fixing
https://github.com/dart-lang/sdk/issues/62889 (Unsound type promotion
in inner async/generator functions), which will require the type
analysis of yield statements to be integrated more closely with flow
analysis. Sharing the type analysis logic will avoid the need to do
that integration twice.

Change-Id: I36c1f5e45e33d9e46dc934fb71bc634d6a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491260
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

[Brian Wilkerson]

Branch: refs/heads/lkgr

Commit: 931a3ff671385b0495045935004306dc4a870a63
https://github.com/dart-lang/sdk/commit/931a3ff671385b0495045935004306dc4a870a63
Author: Danny Tuppeny <da...@tuppeny.com>

Date: 2026-04-02 (Thu, 02 Apr 2026)

Changed paths:

M pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
M pkg/analysis_server/test/lsp/completion_dart_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/local_library_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/local_reference_test.dart

Log Message:
-----------
[analysis_server] Fix type name for constructors from type aliases in completion

We were adding constructors to completion for type aliases, but not using the type alias in the completion, which mean a lot of duplicates against the target class (see https://github.com/Dart-Code/Dart-Code/issues/6003).

I don't know if this got lost in one of the completion refactors, as there didn't seem to be support in `ConstructorSuggestion` for this, so I've added an `alias` field to it to override the name.

Fixes https://github.com/Dart-Code/Dart-Code/issues/6003

Change-Id: I06c073b1a9cae012c5bdf0fb8a3aa22f8fed728c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/491880
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>


Commit: adefb1050e465ebd82cba3758d862a9e7a91d759
https://github.com/dart-lang/sdk/commit/adefb1050e465ebd82cba3758d862a9e7a91d759
Author: Danny Tuppeny <da...@tuppeny.com>

Date: 2026-04-02 (Thu, 02 Apr 2026)

Changed paths:

M pkg/analysis_server/lib/src/services/correction/dart/create_no_such_method.dart
M pkg/analysis_server/test/src/services/correction/fix/create_no_such_method_test.dart

Log Message:
-----------
[analysis_server] Handle empty bodies in create_no_such_method

Fixes https://github.com/dart-lang/sdk/issues/63057

Change-Id: I07d2c097edab70b88ee69ed02d080ee5118a5169
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/492460
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>


Commit: b43eb3883398d7b1f7978e953e701e9457840b7c
https://github.com/dart-lang/sdk/commit/b43eb3883398d7b1f7978e953e701e9457840b7c
Author: Danny Tuppeny <da...@tuppeny.com>

Date: 2026-04-02 (Thu, 02 Apr 2026)

Changed paths:

M pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart
M pkg/analysis_server/test/src/services/correction/assist/convert_class_to_enum_test.dart
M pkg/analysis_server/test/src/services/correction/fix/add_enum_constant_test.dart

Log Message:
-----------
[analysis_server] Add tests for convert_class_to_enum and add_enum_constant with empty bodies

Fixes https://github.com/dart-lang/sdk/issues/63028
Fixes https://github.com/dart-lang/sdk/issues/63036

Change-Id: I18396adddcf03f6d7b3d36a41ad44e9236a2fde2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/492440
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>


Commit: d554776a6431f263549cf7cee36edff77bec1925
https://github.com/dart-lang/sdk/commit/d554776a6431f263549cf7cee36edff77bec1925
Author: Brian Wilkerson <brianwi...@google.com>

Date: 2026-04-02 (Thu, 02 Apr 2026)

Changed paths:

M pkg/linter/test/rules/avoid_redundant_argument_values_test.dart

Log Message:
-----------
Test that avoid_redundant_argument_values works with primary constructors

Closes https://github.com/dart-lang/sdk/issues/63023

Change-Id: I061481347a6b7080815d6441bdd762faf33c57bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/492620
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/2568d6938bc6...d554776a6431