[dart-lang/sdk] 7c3c71: Don't lint on raw types in constant patterns if th...
0 views
Skip to first unread message
Jacob MacDonald
Jun 10, 2026, 11:25:10 AM (yesterday) Jun 10
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
https://github.com/dart-lang/sdk/commit/7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
Author: Jake Macdonald <jak...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
Log Message:
-----------
Don't lint on raw types in constant patterns if the matched type is of type Type.
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Bug: https://github.com/dart-lang/sdk/issues/59334
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jak...@google.com>
Commit-Queue: Jake Macdonald <jak...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
https://github.com/dart-lang/sdk/commit/7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
Author: Jake Macdonald <jak...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
Log Message:
-----------
Don't lint on raw types in constant patterns if the matched type is of type Type.
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Bug: https://github.com/dart-lang/sdk/issues/59334
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jak...@google.com>
Commit-Queue: Jake Macdonald <jak...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Jacob MacDonald
Jun 10, 2026, 12:20:14 PM (yesterday) Jun 10
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
Jun 10, 2026, 4:04:28 PM (23 hours ago) Jun 10
to com...@dartlang.org
Branch: refs/heads/dev
https://github.com/dart-lang/sdk/commit/44bb92f49ab90de40c7e227655b6e19af540efdf
Author: Parker Lougheed <parl...@gmail.com>
M pkg/dartdev/test/native_assets/install_test.dart
Log Message:
-----------
[dartdev] Provide no installation feedback in `dart installed`
Updates `dart installed` to provide feedback if nothing is installed. If they didn't specify `--all` but there are inactive tools, provide a suggestion to specify the `--all` flag as well.
Resolves https://github.com/dart-lang/sdk/issues/61626
Change-Id: I7d68fe91a29650c113047065e673e7a1139df847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510020
Reviewed-by: Daco Harkes <dacoh...@google.com>
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>
Commit: eb979c2f0c7ad8f60e6cbbad0905539b6bcede88
https://github.com/dart-lang/sdk/commit/eb979c2f0c7ad8f60e6cbbad0905539b6bcede88
Author: Danny Tuppeny <da...@tuppeny.com>
M pkg/analysis_server/test/lsp/signature_help_test.dart
Log Message:
-----------
[analysis_server] Don't show field modifiers in signature help for primary constructors
Fixes https://github.com/dart-lang/sdk/issues/63560
Change-Id: I2c93e4a1011075e103d9165d0664f588f3109c40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510821
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 4f2ee94e201d7b65ea6a3f065f5514eecdfd1fd3
https://github.com/dart-lang/sdk/commit/4f2ee94e201d7b65ea6a3f065f5514eecdfd1fd3
Author: Alexander Aprelev <a...@google.com>
Log Message:
-----------
[vm/isolate_api] Fix thread-starting race in threading_test.
Fixes https://github.com/dart-lang/sdk/issues/63526
TEST=ci
Change-Id: I7e0a52d3c5a7c04c1d853f769544547758c49545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509541
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Commit: 088614d11b176a68fadae55fc50aea1e18158912
https://github.com/dart-lang/sdk/commit/088614d11b176a68fadae55fc50aea1e18158912
Author: Sam Rawlins <sraw...@google.com>
M pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_generator.dart
M pkg/analysis_server/test/src/cider/assists_test.dart
M pkg/analysis_server/test/src/cider/fixes_test.dart
M pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/pubspec/test_support.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/api.txt
M pkg/analysis_server_plugin/lib/edit/assist/assist.dart
A pkg/analysis_server_plugin/lib/edit/change_builder/change_builder.dart
M pkg/analysis_server_plugin/lib/edit/fix/fix.dart
A pkg/analysis_server_plugin/lib/edit/range_factory.dart
M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
Log Message:
-----------
DAS plugins: Export types from analyzer_plugin for convenience
Fixes https://github.com/dart-lang/sdk/issues/61821
Change-Id: Ibb2737553de713aeef725a19417e09202bee8ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509543
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit: 93ca44b0484dd692bc14961a2b6a564d9f2ab852
https://github.com/dart-lang/sdk/commit/93ca44b0484dd692bc14961a2b6a564d9f2ab852
Author: Shikhar Soni <shikh...@google.com>
M runtime/lib/ffi_dynamic_library.cc
M runtime/vm/bootstrap_natives.h
M sdk/lib/_internal/js_dev_runtime/patch/ffi_patch.dart
M sdk/lib/_internal/vm/lib/ffi_dynamic_library_patch.dart
M sdk/lib/ffi/dynamic_library.dart
M tests/ffi/native_assets/asset_absolute_test.dart
M tests/ffi/native_assets/asset_executable_test.dart
M tests/ffi/native_assets/asset_library_annotation_test.dart
M tests/ffi/native_assets/asset_process_test.dart
M tests/ffi/native_assets/asset_relative_test.dart
M tests/ffi/native_assets/asset_system_test.dart
M tests/ffi/native_assets/helpers.dart
Log Message:
-----------
[ffi] Add DynamicLibrary.openFromAssetId
Adds a new API `DynamicLibrary.openFromAssetId` to `dart:ffi` that
allows opening dynamically loaded libraries using their native asset IDs
instead of physical file paths.
Closes https://github.com/dart-lang/sdk/issues/63295
TEST=./tools/test.py -n vm-aot-linux-debug-x64 'ffi/native_assets/asset_*'
Cq-Include-Trybots: dart/try:vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-debug-arm64-try,vm-aot-mac-debug-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-asan-mac-release-arm64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try,vm-ffi-dyn-mac-debug-simarm64_arm64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-mac-release-arm64-try,vm-ubsan-win-release-x64-try
R=veg...@google.com
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
CoreLibraryReviewExempt: VM-only
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507180
Auto-Submit: Shikhar Soni <shikh...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Commit: 24cf34371a10300e8720d90c929cc437f2b107b6
https://github.com/dart-lang/sdk/commit/24cf34371a10300e8720d90c929cc437f2b107b6
Author: Konstantin Shcheglov <sche...@google.com>
Log Message:
-----------
CQ. Stop using assertErrorsInList() in AnalysisDriverCachingTest.
Change-Id: Icac933eb6cfd61798a163daa906348f68b7c2616
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510441
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8f1a38f07b2a6705c92adf194af81e280f4fff56
https://github.com/dart-lang/sdk/commit/8f1a38f07b2a6705c92adf194af81e280f4fff56
Author: Alexander Aprelev <a...@google.com>
M runtime/vm/isolate.cc
M runtime/vm/isolate.h
M runtime/vm/message_handler.cc
M runtime/vm/message_handler.h
M runtime/vm/port.cc
M runtime/vm/port.h
M tests/ffi/threading_test.dart
Log Message:
-----------
[vm/isolate_api] Ensure isolate acquisition fails gracefully when target isolate is exiting.
Introduce `is_acquirable` isolate property that tracks whether isolate can be entered, avoid a `pool_` check that does not work correctly as isolate being shutdown.
BUG=https://github.com/dart-lang/sdk/issues/63515
BUG=https://github.com/dart-lang/sdk/issues/63514
TEST=ci
Change-Id: I84577ad082d87ead8cdb9f591fabdf918e2f4bd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509221
Reviewed-by: Slava Egorov <veg...@google.com>
Commit: 6d86b39595b03d72e4489468cb510c96555ac34d
https://github.com/dart-lang/sdk/commit/6d86b39595b03d72e4489468cb510c96555ac34d
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/lib/src/fine/manifest_ast.dart
M pkg/analyzer/lib/src/fine/manifest_item.dart
M pkg/analyzer/lib/src/fine/manifest_type.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/result_printer.dart
Log Message:
-----------
Fine. Store formal parameter default values separately from FunctionType(s).
A type is just a type, it should not attempt to carry element semantics.
Bug: https://github.com/dart-lang/sdk/issues/63555
Change-Id: I9dacc4f5cc4060d862f7e1bb1ececdd9dc1a303c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510420
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: e4ef831dfc76813b98f19672c5a0b29e8ee13396
https://github.com/dart-lang/sdk/commit/e4ef831dfc76813b98f19672c5a0b29e8ee13396
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/pubspec.yaml
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/dartdev/test/native_assets/helpers.dart
Log Message:
-----------
Prepare to publish analyzer 13.2.0, _fe_analyzer_shared 102.0.0, analysis_server_plugin 0.3.17, analyzer_plugin 0.14.11, analyzer_testing 0.3.1
Change-Id: I534e30c37570cf5fdc194eb9668d37747823aa82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510480
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8267ce6fff71442417bc8dc5bc7aeaf8252646b2
https://github.com/dart-lang/sdk/commit/8267ce6fff71442417bc8dc5bc7aeaf8252646b2
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
Log Message:
-----------
CQ. Use more inline expected diagnostics.
Change-Id: I83743fee43718133df71dd33093056543dc83094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510482
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: db905b9711ee37d09b5ec1203eb0c44c1f707b9d
https://github.com/dart-lang/sdk/commit/db905b9711ee37d09b5ec1203eb0c44c1f707b9d
Author: Nourhan Hasan <nourhan...@gmail.com>
M runtime/vm/os.h
M runtime/vm/os_android.cc
M runtime/vm/os_linux.cc
M runtime/vm/os_win.cc
M runtime/vm/service.cc
Log Message:
-----------
[vm/service]: Add OS::SafeReadMemory for Windows using ReadProcessMemory
TEST=runtime/vm/service_test.cc
Cq-Include-Trybots: dart/try:vm-asan-linux-release-x64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-arm64-try,vm-linux-debug-ia32-try,vm-linux-debug-simriscv32-try,vm-linux-debug-simriscv64-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-linux-release-simarm-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-tsan-linux-release-x64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-win-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try
Change-Id: I7afabe66211657139981e18d8b1a14c2081d3f5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506640
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit: 6c3cf9ea517860b8703286c274df78cf02fd611f
https://github.com/dart-lang/sdk/commit/6c3cf9ea517860b8703286c274df78cf02fd611f
Author: Ryan Macnak <rma...@google.com>
M runtime/vm/constants_arm64.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/object.h
M runtime/vm/regexp/regexp-interpreter.cc
Log Message:
-----------
Roll Clang from a3f244e2d555 to deb6854eec93
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@rotations.google.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TEST=ci
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try;luci.dart.try:vm-asan-mac-release-arm64-try
Change-Id: Iddd7439c096af8c37076756330a067ccb7d10a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510520
Reviewed-by: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Commit: 573983c2a7dd03bc0f5dffc57a8a31b57acbad11
https://github.com/dart-lang/sdk/commit/573983c2a7dd03bc0f5dffc57a8a31b57acbad11
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/_fe_analyzer_shared/pubspec.yaml
M pkg/analysis_server/lib/src/lsp/mapping.dart
M pkg/analysis_server/lib/src/services/correction/fix/analysis_options/fix_generator.dart
M pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_generator.dart
M pkg/analysis_server/test/lsp/signature_help_test.dart
M pkg/analysis_server/test/src/cider/assists_test.dart
M pkg/analysis_server/test/src/cider/fixes_test.dart
M pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/pubspec/test_support.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/api.txt
M pkg/analysis_server_plugin/lib/edit/assist/assist.dart
A pkg/analysis_server_plugin/lib/edit/change_builder/change_builder.dart
M pkg/analysis_server_plugin/lib/edit/fix/fix.dart
A pkg/analysis_server_plugin/lib/edit/range_factory.dart
M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/lib/src/dart/analysis/driver.dart
M pkg/analyzer/lib/src/fine/manifest_ast.dart
M pkg/analyzer/lib/src/fine/manifest_item.dart
M pkg/analyzer/lib/src/fine/manifest_type.dart
M pkg/analyzer/pubspec.yaml
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/result_printer.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/dartdev/lib/src/commands/installed.dart
M pkg/dartdev/test/native_assets/helpers.dart
M pkg/dartdev/test/native_assets/install_test.dart
M runtime/lib/ffi_dynamic_library.cc
M runtime/lib/isolate.cc
M runtime/tests/vm/vm.status
M runtime/vm/bootstrap_natives.h
M runtime/vm/constants_arm64.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/isolate.cc
M runtime/vm/isolate.h
M runtime/vm/message_handler.cc
M runtime/vm/message_handler.h
M runtime/vm/object.h
M runtime/vm/os.h
M runtime/vm/os_android.cc
M runtime/vm/os_linux.cc
M runtime/vm/os_win.cc
M runtime/vm/port.cc
M runtime/vm/port.h
M runtime/vm/regexp/regexp-interpreter.cc
M runtime/vm/service.cc
M sdk/lib/_internal/js_dev_runtime/patch/ffi_patch.dart
M sdk/lib/_internal/vm/lib/ffi_dynamic_library_patch.dart
M sdk/lib/ffi/dynamic_library.dart
M tests/ffi/native_assets/asset_absolute_test.dart
M tests/ffi/native_assets/asset_executable_test.dart
M tests/ffi/native_assets/asset_library_annotation_test.dart
M tests/ffi/native_assets/asset_process_test.dart
M tests/ffi/native_assets/asset_relative_test.dart
M tests/ffi/native_assets/asset_system_test.dart
M tests/ffi/native_assets/helpers.dart
M tests/ffi/threading_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.13.0-194.0.dev
Merge 6c3cf9ea517860b8703286c274df78cf02fd611f into dev
Compare: https://github.com/dart-lang/sdk/compare/cf8759a6b880...573983c2a7dd
Home: https://github.com/dart-lang/sdk
Commit: 7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
https://github.com/dart-lang/sdk/commit/7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
Author: Jake Macdonald <jak...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
Log Message:
-----------
Don't lint on raw types in constant patterns if the matched type is of type Type.
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Bug: https://github.com/dart-lang/sdk/issues/59334
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jak...@google.com>
Commit-Queue: Jake Macdonald <jak...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
Commit: 44bb92f49ab90de40c7e227655b6e19af540efdf
Commit: 7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
https://github.com/dart-lang/sdk/commit/7c3c71ae4d0fd1390c381f52864adf7c30b8c1c8
Author: Jake Macdonald <jak...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
Log Message:
-----------
Don't lint on raw types in constant patterns if the matched type is of type Type.
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Bug: https://github.com/dart-lang/sdk/issues/59334
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jak...@google.com>
Commit-Queue: Jake Macdonald <jak...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
https://github.com/dart-lang/sdk/commit/44bb92f49ab90de40c7e227655b6e19af540efdf
Author: Parker Lougheed <parl...@gmail.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/dartdev/lib/src/commands/installed.dart
Changed paths:
M pkg/dartdev/test/native_assets/install_test.dart
Log Message:
-----------
[dartdev] Provide no installation feedback in `dart installed`
Updates `dart installed` to provide feedback if nothing is installed. If they didn't specify `--all` but there are inactive tools, provide a suggestion to specify the `--all` flag as well.
Resolves https://github.com/dart-lang/sdk/issues/61626
Change-Id: I7d68fe91a29650c113047065e673e7a1139df847
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510020
Reviewed-by: Daco Harkes <dacoh...@google.com>
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>
Commit: eb979c2f0c7ad8f60e6cbbad0905539b6bcede88
https://github.com/dart-lang/sdk/commit/eb979c2f0c7ad8f60e6cbbad0905539b6bcede88
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/lib/src/lsp/mapping.dart
Changed paths:
M pkg/analysis_server/test/lsp/signature_help_test.dart
Log Message:
-----------
[analysis_server] Don't show field modifiers in signature help for primary constructors
Fixes https://github.com/dart-lang/sdk/issues/63560
Change-Id: I2c93e4a1011075e103d9165d0664f588f3109c40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510821
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 4f2ee94e201d7b65ea6a3f065f5514eecdfd1fd3
https://github.com/dart-lang/sdk/commit/4f2ee94e201d7b65ea6a3f065f5514eecdfd1fd3
Author: Alexander Aprelev <a...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M tests/ffi/threading_test.dart
Changed paths:
Log Message:
-----------
[vm/isolate_api] Fix thread-starting race in threading_test.
Fixes https://github.com/dart-lang/sdk/issues/63526
TEST=ci
Change-Id: I7e0a52d3c5a7c04c1d853f769544547758c49545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509541
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Commit: 088614d11b176a68fadae55fc50aea1e18158912
https://github.com/dart-lang/sdk/commit/088614d11b176a68fadae55fc50aea1e18158912
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/correction/fix/analysis_options/fix_generator.dart
Changed paths:
M pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_generator.dart
M pkg/analysis_server/test/src/cider/assists_test.dart
M pkg/analysis_server/test/src/cider/fixes_test.dart
M pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/pubspec/test_support.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/api.txt
M pkg/analysis_server_plugin/lib/edit/assist/assist.dart
A pkg/analysis_server_plugin/lib/edit/change_builder/change_builder.dart
M pkg/analysis_server_plugin/lib/edit/fix/fix.dart
A pkg/analysis_server_plugin/lib/edit/range_factory.dart
M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
Log Message:
-----------
DAS plugins: Export types from analyzer_plugin for convenience
Fixes https://github.com/dart-lang/sdk/issues/61821
Change-Id: Ibb2737553de713aeef725a19417e09202bee8ac3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509543
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit: 93ca44b0484dd692bc14961a2b6a564d9f2ab852
https://github.com/dart-lang/sdk/commit/93ca44b0484dd692bc14961a2b6a564d9f2ab852
Author: Shikhar Soni <shikh...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M runtime/bin/native_assets_api_impl.cc
Changed paths:
M runtime/lib/ffi_dynamic_library.cc
M runtime/vm/bootstrap_natives.h
M sdk/lib/_internal/js_dev_runtime/patch/ffi_patch.dart
M sdk/lib/_internal/vm/lib/ffi_dynamic_library_patch.dart
M sdk/lib/ffi/dynamic_library.dart
M tests/ffi/native_assets/asset_absolute_test.dart
M tests/ffi/native_assets/asset_executable_test.dart
M tests/ffi/native_assets/asset_library_annotation_test.dart
M tests/ffi/native_assets/asset_process_test.dart
M tests/ffi/native_assets/asset_relative_test.dart
M tests/ffi/native_assets/asset_system_test.dart
M tests/ffi/native_assets/helpers.dart
Log Message:
-----------
[ffi] Add DynamicLibrary.openFromAssetId
Adds a new API `DynamicLibrary.openFromAssetId` to `dart:ffi` that
allows opening dynamically loaded libraries using their native asset IDs
instead of physical file paths.
Closes https://github.com/dart-lang/sdk/issues/63295
TEST=./tools/test.py -n vm-aot-linux-debug-x64 'ffi/native_assets/asset_*'
Cq-Include-Trybots: dart/try:vm-aot-linux-debug-arm64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-debug-arm64-try,vm-aot-mac-debug-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-asan-linux-release-arm64-try,vm-asan-linux-release-x64-try,vm-asan-mac-release-arm64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try,vm-ffi-dyn-mac-debug-simarm64_arm64-try,vm-msan-linux-release-arm64-try,vm-msan-linux-release-x64-try,vm-tsan-linux-release-arm64-try,vm-tsan-linux-release-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-linux-release-arm64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-mac-release-arm64-try,vm-ubsan-win-release-x64-try
R=veg...@google.com
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
CoreLibraryReviewExempt: VM-only
Change-Id: Ic617cb0906d1688d2d080dae7d1e08ee58b4c8d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507180
Auto-Submit: Shikhar Soni <shikh...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Commit: 24cf34371a10300e8720d90c929cc437f2b107b6
https://github.com/dart-lang/sdk/commit/24cf34371a10300e8720d90c929cc437f2b107b6
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
Changed paths:
Log Message:
-----------
CQ. Stop using assertErrorsInList() in AnalysisDriverCachingTest.
Change-Id: Icac933eb6cfd61798a163daa906348f68b7c2616
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510441
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8f1a38f07b2a6705c92adf194af81e280f4fff56
https://github.com/dart-lang/sdk/commit/8f1a38f07b2a6705c92adf194af81e280f4fff56
Author: Alexander Aprelev <a...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M runtime/lib/isolate.cc
Changed paths:
M runtime/vm/isolate.cc
M runtime/vm/isolate.h
M runtime/vm/message_handler.cc
M runtime/vm/message_handler.h
M runtime/vm/port.cc
M runtime/vm/port.h
M tests/ffi/threading_test.dart
Log Message:
-----------
[vm/isolate_api] Ensure isolate acquisition fails gracefully when target isolate is exiting.
Introduce `is_acquirable` isolate property that tracks whether isolate can be entered, avoid a `pool_` check that does not work correctly as isolate being shutdown.
BUG=https://github.com/dart-lang/sdk/issues/63515
BUG=https://github.com/dart-lang/sdk/issues/63514
TEST=ci
Change-Id: I84577ad082d87ead8cdb9f591fabdf918e2f4bd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/509221
Reviewed-by: Slava Egorov <veg...@google.com>
Commit: 6d86b39595b03d72e4489468cb510c96555ac34d
https://github.com/dart-lang/sdk/commit/6d86b39595b03d72e4489468cb510c96555ac34d
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/analysis/driver.dart
Changed paths:
M pkg/analyzer/lib/src/fine/manifest_ast.dart
M pkg/analyzer/lib/src/fine/manifest_item.dart
M pkg/analyzer/lib/src/fine/manifest_type.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/result_printer.dart
Log Message:
-----------
Fine. Store formal parameter default values separately from FunctionType(s).
A type is just a type, it should not attempt to carry element semantics.
Bug: https://github.com/dart-lang/sdk/issues/63555
Change-Id: I9dacc4f5cc4060d862f7e1bb1ececdd9dc1a303c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510420
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: e4ef831dfc76813b98f19672c5a0b29e8ee13396
https://github.com/dart-lang/sdk/commit/e4ef831dfc76813b98f19672c5a0b29e8ee13396
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/_fe_analyzer_shared/pubspec.yaml
Changed paths:
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/pubspec.yaml
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/dartdev/test/native_assets/helpers.dart
Log Message:
-----------
Prepare to publish analyzer 13.2.0, _fe_analyzer_shared 102.0.0, analysis_server_plugin 0.3.17, analyzer_plugin 0.14.11, analyzer_testing 0.3.1
Change-Id: I534e30c37570cf5fdc194eb9668d37747823aa82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510480
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 8267ce6fff71442417bc8dc5bc7aeaf8252646b2
https://github.com/dart-lang/sdk/commit/8267ce6fff71442417bc8dc5bc7aeaf8252646b2
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
Changed paths:
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
Log Message:
-----------
CQ. Use more inline expected diagnostics.
Change-Id: I83743fee43718133df71dd33093056543dc83094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510482
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: db905b9711ee37d09b5ec1203eb0c44c1f707b9d
https://github.com/dart-lang/sdk/commit/db905b9711ee37d09b5ec1203eb0c44c1f707b9d
Author: Nourhan Hasan <nourhan...@gmail.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M runtime/tests/vm/vm.status
Changed paths:
M runtime/vm/os.h
M runtime/vm/os_android.cc
M runtime/vm/os_linux.cc
M runtime/vm/os_win.cc
M runtime/vm/service.cc
Log Message:
-----------
[vm/service]: Add OS::SafeReadMemory for Windows using ReadProcessMemory
TEST=runtime/vm/service_test.cc
Cq-Include-Trybots: dart/try:vm-asan-linux-release-x64-try,vm-asan-win-release-x64-try,vm-dyn-linux-debug-x64-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-linux-debug-arm64-try,vm-linux-debug-ia32-try,vm-linux-debug-simriscv32-try,vm-linux-debug-simriscv64-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-linux-release-simarm-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-tsan-linux-release-x64-try,vm-ubsan-linux-release-x64-try,vm-ubsan-win-release-x64-try,vm-win-debug-arm64-try,vm-win-debug-x64-try,vm-win-debug-x64c-try
Change-Id: I7afabe66211657139981e18d8b1a14c2081d3f5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506640
Reviewed-by: Ben Konyi <bko...@google.com>
Commit-Queue: Ben Konyi <bko...@google.com>
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit: 6c3cf9ea517860b8703286c274df78cf02fd611f
https://github.com/dart-lang/sdk/commit/6c3cf9ea517860b8703286c274df78cf02fd611f
Author: Ryan Macnak <rma...@google.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M DEPS
Changed paths:
M runtime/vm/constants_arm64.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/object.h
M runtime/vm/regexp/regexp-interpreter.cc
Log Message:
-----------
Roll Clang from a3f244e2d555 to deb6854eec93
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@rotations.google.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TEST=ci
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try;luci.dart.try:vm-asan-mac-release-arm64-try
Change-Id: Iddd7439c096af8c37076756330a067ccb7d10a35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510520
Reviewed-by: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Commit: 573983c2a7dd03bc0f5dffc57a8a31b57acbad11
https://github.com/dart-lang/sdk/commit/573983c2a7dd03bc0f5dffc57a8a31b57acbad11
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M DEPS
Changed paths:
M pkg/_fe_analyzer_shared/pubspec.yaml
M pkg/analysis_server/lib/src/lsp/mapping.dart
M pkg/analysis_server/lib/src/services/correction/fix/analysis_options/fix_generator.dart
M pkg/analysis_server/lib/src/services/correction/fix/pubspec/fix_generator.dart
M pkg/analysis_server/test/lsp/signature_help_test.dart
M pkg/analysis_server/test/src/cider/assists_test.dart
M pkg/analysis_server/test/src/cider/fixes_test.dart
M pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
M pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
M pkg/analysis_server/test/src/services/correction/fix/pubspec/test_support.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/api.txt
M pkg/analysis_server_plugin/lib/edit/assist/assist.dart
A pkg/analysis_server_plugin/lib/edit/change_builder/change_builder.dart
M pkg/analysis_server_plugin/lib/edit/fix/fix.dart
A pkg/analysis_server_plugin/lib/edit/range_factory.dart
M pkg/analysis_server_plugin/lib/src/correction/fix_in_file_processor.dart
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/lib/src/dart/analysis/driver.dart
M pkg/analyzer/lib/src/fine/manifest_ast.dart
M pkg/analyzer/lib/src/fine/manifest_item.dart
M pkg/analyzer/lib/src/fine/manifest_type.dart
M pkg/analyzer/pubspec.yaml
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_test.dart
M pkg/analyzer/test/src/dart/analysis/result_printer.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/diagnostics/const_eval_throws_exception_test.dart
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/dartdev/lib/src/commands/installed.dart
M pkg/dartdev/test/native_assets/helpers.dart
M pkg/dartdev/test/native_assets/install_test.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
M runtime/bin/native_assets_api_impl.cc
M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
M runtime/lib/ffi_dynamic_library.cc
M runtime/lib/isolate.cc
M runtime/tests/vm/vm.status
M runtime/vm/bootstrap_natives.h
M runtime/vm/constants_arm64.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/isolate.cc
M runtime/vm/isolate.h
M runtime/vm/message_handler.cc
M runtime/vm/message_handler.h
M runtime/vm/object.h
M runtime/vm/os.h
M runtime/vm/os_android.cc
M runtime/vm/os_linux.cc
M runtime/vm/os_win.cc
M runtime/vm/port.cc
M runtime/vm/port.h
M runtime/vm/regexp/regexp-interpreter.cc
M runtime/vm/service.cc
M sdk/lib/_internal/js_dev_runtime/patch/ffi_patch.dart
M sdk/lib/_internal/vm/lib/ffi_dynamic_library_patch.dart
M sdk/lib/ffi/dynamic_library.dart
M tests/ffi/native_assets/asset_absolute_test.dart
M tests/ffi/native_assets/asset_executable_test.dart
M tests/ffi/native_assets/asset_library_annotation_test.dart
M tests/ffi/native_assets/asset_process_test.dart
M tests/ffi/native_assets/asset_relative_test.dart
M tests/ffi/native_assets/asset_system_test.dart
M tests/ffi/native_assets/helpers.dart
M tests/ffi/threading_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.13.0-194.0.dev
Merge 6c3cf9ea517860b8703286c274df78cf02fd611f into dev
Compare: https://github.com/dart-lang/sdk/compare/cf8759a6b880...573983c2a7dd
copybara-service[bot]
Jun 10, 2026, 5:22:46 PM (22 hours ago) Jun 10
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages