[dart-lang/sdk] 560f44: CQ. Switch clients to default constructor of `Func...

0 views
Skip to first unread message

Konstantin Scheglov

unread,
Apr 28, 2026, 8:14:53 PM (17 hours ago) Apr 28
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 560f44af01de2be9e2702843c22a183dd2276af6
https://github.com/dart-lang/sdk/commit/560f44af01de2be9e2702843c22a183dd2276af6
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
M pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart
M pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart
M pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
M pkg/analyzer/lib/src/dart/element/element.dart
M pkg/analyzer/lib/src/dart/element/generic_inferrer.dart
M pkg/analyzer/lib/src/dart/element/greatest_lower_bound.dart
M pkg/analyzer/lib/src/dart/element/least_upper_bound.dart
M pkg/analyzer/lib/src/dart/element/normalize.dart
M pkg/analyzer/lib/src/dart/element/replace_top_bottom_visitor.dart
M pkg/analyzer/lib/src/dart/element/replacement_visitor.dart
M pkg/analyzer/lib/src/dart/element/top_merge.dart
M pkg/analyzer/lib/src/dart/element/type.dart
M pkg/analyzer/lib/src/dart/element/type_algebra.dart
M pkg/analyzer/lib/src/dart/resolver/invocation_inference_helper.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/error/correct_override.dart
M pkg/analyzer/lib/src/generated/ffi_verifier.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/bundle_reader.dart
M pkg/analyzer/lib/src/summary2/function_type_builder.dart
M pkg/analyzer/lib/src/summary2/named_type_builder.dart
M pkg/analyzer/lib/src/summary2/types_builder.dart
M pkg/analyzer/lib/src/test_utilities/test_library_builder.dart

Log Message:
-----------
CQ. Switch clients to default constructor of `FunctionTypeImpl`.

Also rename the public `FunctionTypeImpl` constructor formal parameter
from `parameters` to `formalParameters`, matching the API exposed by
`FunctionType`.

Change-Id: I6f9bbeed06cee708f78bb7127843222db08e1d52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499040
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Konstantin Scheglov

unread,
Apr 28, 2026, 9:13:38 PM (16 hours ago) Apr 28
to com...@dartlang.org
Branch: refs/heads/lkgr

copybara-service[bot]

unread,
12:06 AM (13 hours ago) 12:06 AM
to com...@dartlang.org
Branch: refs/heads/dev
Commit: 2a93a26d91b62b34e2697c2db11033b912545f19
https://github.com/dart-lang/sdk/commit/2a93a26d91b62b34e2697c2db11033b912545f19
Author: Liam Appelbe <li...@google.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M sdk/BUILD.gn
M tools/build_devtools.py

Log Message:
-----------
Revert "Switch on building devtools from source when building the Dart SDK"

This reverts commit d0d8184d1afb5b1db49c9b57bc7e2bd069f30c1d.

Reason for revert: Doesn't build in Flutter
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8683246937886984145/+/u/gn_--target-dir_ci_host_debug_--runtime-mode_debug_--no-prebuilt-dart-sdk_--build-embedder-examples_--no-lto_--rbe_--no-goma_--rbe-server-address_unix:___b_s_w_ir_x_w_rc_rbebn74b14k_reproxy.sock/stdout

Original change's description:
> Switch on building devtools from source when building the Dart SDK
>
> Fixes https://github.com/flutter/devtools/issues/9786
>
> See go/moving-devtools-to-dart-sdk-2025.
>
> In this change, we make the source of devtools be configurable, in
> actions like build_sdk.
>
> If `build_devtools_from_sources` is true, we build local devtools,
> and if false, we continue to use the prebuilt sources.
>
> This may be an intermediate step, while we test out building devtools
> from source. Or it may be permanently be a choice, if we keep building
> with CIPD.
>
> Change-Id: I7b46d6359c69b34f316e59dccc475e211a18f965
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498640
> Reviewed-by: Alexander Aprelev <a...@google.com>
> Commit-Queue: Samuel Rawlins <sraw...@google.com>

Change-Id: I20381d6bf1d9cba192c46efde99cb57dc75e7cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499160
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Liam Appelbe <li...@google.com>
Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Nate Biggs <nate...@google.com>


Commit: 224333acc20c6827d3c35d94e2dcf15a560720c6
https://github.com/dart-lang/sdk/commit/224333acc20c6827d3c35d94e2dcf15a560720c6
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M DEPS

Log Message:
-----------
Roll gn from dcc5e98fbd10 to fa9dacd8eff0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@rotations.google.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in gn: https://bugs.chromium.org/p/gn/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: I568178ab8e987e08bcb8a8c95a4d1afabaac2355
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499120
Reviewed-by: Ryan Macnak <rma...@google.com>
Reviewed-by: Liam Appelbe <li...@google.com>
Commit-Queue: Liam Appelbe <li...@google.com>


Commit: 5fb2054a09a94cd5620b6a5a79f51b1966b45978
https://github.com/dart-lang/sdk/commit/5fb2054a09a94cd5620b6a5a79f51b1966b45978
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M DEPS

Log Message:
-----------
Roll BoringSSL from 439e53783a5f to 8415495eff36 (30 revisions)

https://boringssl.googlesource.com/boringssl.git/+log/439e53783a5f..8415495eff36

2026-04-27 davi...@google.com Unwind EC_FELEM hooks on EC_METHOD
2026-04-27 chl...@google.com Add an EVP adapter for KEM encap/decap
2026-04-27 davi...@google.com Add sk_FOO_sort_and_dedup
2026-04-27 chl...@google.com Update documentation for ML-KEM
2026-04-27 rpo...@google.com pregenerate: Compile public headers entirely as C.
2026-04-27 davi...@google.com Reject trailing data in ClientHello and EncryptedExtensions trust_anchors
2026-04-27 davi...@google.com Test trailing data in OCSP staple parsing
2026-04-27 davi...@google.com Test trailing data for SNI parsing
2026-04-27 davi...@google.com Remove the OPENSSL_NO_ASM gate in OPENSSL_cleanse
2026-04-27 davi...@google.com Add tests for X509_get1_email and friends
2026-04-27 davi...@google.com pregenerate: Collect symbols with -DBORINGSSL_NO_CXX
2026-04-27 davi...@google.com pregenerate: Don't process libpki headers for symbols
2026-04-26 chl...@google.com EVP_PKEY: Treat pss_params as params for RSA-PSS keys
2026-04-26 davi...@google.com Allow no-op EVP_CTRL_AEAD_SET_IVLEN calls to keep the IV set
2026-04-25 davi...@google.com slhdsa: Reorder a BSSL_CHECK with its shift
2026-04-25 davi...@google.com Fix some unreachable code in curve25519_64_adx.h's fiat_addcarryx_u64
2026-04-25 xfd...@google.com rust: bssl-tls: Introduce basic session controls on context level
2026-04-25 xfd...@google.com rust: bssl-tls: More advanced controls over certificate verification
2026-04-25 xfd...@google.com rust: bssl-tls: More advanced control over IO transport
2026-04-25 xfd...@google.com rust: bssl-tls: Introduce TLS alerts
2026-04-25 davi...@google.com Don't skip calling the cleanup hook in EVP_PKEY_CTX when the copy hook fails
2026-04-25 davi...@google.com Check for invalid certificate_authorities extensions
2026-04-25 davi...@google.com Remove p224-64.cc.inc
2026-04-24 davi...@google.com pki: Check for unused bits when verifying MTC proofs
2026-04-24 xfd...@google.com rust: bssl-tls: Reinstate preshared key tests
2026-04-24 xfd...@google.com rust: bssl-x509: Stop reporting partially constructed cert chain
2026-04-24 xfd...@google.com rust: bssl-x509: proper serialisation of X.509 certificate serial number
2026-04-24 davi...@google.com Test 0 * P + 0 * G in ec_point_mul_scalar_public
2026-04-24 davi...@google.com Cut down on test-only OPENSSL_EXPORTs
2026-04-24 xfd...@google.com rust: bssl-rustls-adapters: Mask the content type and protocol

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-dart-sdk
Please CC dart-e...@google.com,dart-vm-...@rotations.google.com,dart-v...@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-vm-...@rotations.google.com
Change-Id: If96384336fc4d861a0d64f187272b984770266e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498741
Reviewed-by: Liam Appelbe <li...@google.com>
Commit-Queue: Liam Appelbe <li...@google.com>
Reviewed-by: Ryan Macnak <rma...@google.com>


Commit: 1e46f62954eb2036d2a53cb87e842e81eb5ee2a8
https://github.com/dart-lang/sdk/commit/1e46f62954eb2036d2a53cb87e842e81eb5ee2a8
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M DEPS

Log Message:
-----------
Roll Fuchsia SDK from 31.20260424.5.1 to 31.20260427.7.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3...@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ia55ed85caa22ea6dace429054f56ef6882acd52c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/498780
Reviewed-by: Liam Appelbe <li...@google.com>
Reviewed-by: Ryan Macnak <rma...@google.com>
Commit-Queue: Liam Appelbe <li...@google.com>


Commit: d41c994623cf6be66be842b5541017489a9885f5
https://github.com/dart-lang/sdk/commit/d41c994623cf6be66be842b5541017489a9885f5
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-04-28 (Tue, 28 Apr 2026)

Changed paths:
M DEPS
M sdk/BUILD.gn
M tools/VERSION
M tools/build_devtools.py

Log Message:
-----------
Version 3.13.0-78.0.dev

Merge 1e46f62954eb2036d2a53cb87e842e81eb5ee2a8 into dev


Compare: https://github.com/dart-lang/sdk/compare/df0101feb73f...d41c994623cf

copybara-service[bot]

unread,
1:05 AM (12 hours ago) 1:05 AM
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages