[dart-lang/sdk] b42c00: [messages] Rework reporting of docDirectiveMissing...

0 views
Skip to first unread message

Paul Berry

unread,
Jan 17, 2026, 12:20:35 PM (19 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: b42c00eaef900706dbd79b9c6208a6f3e5608ab6
https://github.com/dart-lang/sdk/commit/b42c00eaef900706dbd79b9c6208a6f3e5608ab6
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)

Changed paths:
M pkg/analyzer/lib/src/error/doc_comment_verifier.dart

Log Message:
-----------
[messages] Rework reporting of docDirectiveMissing{Two,Three}Arguments.

Changes the analyzer logic that reports the following errors:
- docDirectiveMissingTwoArguments
- docDirectiveMissingThreeArguments

So that a temporary `missingArguments` list is not used. This puts the
code in a form that the `use_literate_api_in_analyzer.dart` tool will
be able to automatically transform.

Change-Id: I6a6a69640847744cc9ec8fe57c346c9d6f52adfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473960
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Commit: 1543c5b2d70f5d2ba6dfa7d45c93b0f55322ff3d
https://github.com/dart-lang/sdk/commit/1543c5b2d70f5d2ba6dfa7d45c93b0f55322ff3d
Author: Paul Berry <paul...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)

Changed paths:
M pkg/analyzer/lib/src/dart/resolver/yield_statement_resolver.dart
M pkg/analyzer/lib/src/diagnostic/diagnostic.g.dart
M pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart
M pkg/analyzer/lib/src/error/error_handler_verifier.dart
M pkg/analyzer/lib/src/error/imports_verifier.dart
M pkg/analyzer/lib/src/fasta/error_converter.dart
M pkg/analyzer/lib/src/generated/element_resolver.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/messages.yaml

Log Message:
-----------
[messages] Convert more diagnostics to literate diagnostic reporting API.

The only changes in this CL that were manually written are those in
`messages.yaml`. The others were produced by running the standard
diagnostic message code generator and then running the script
`use_literate_api_in_analyzer.dart`.

Change-Id: I6a6a69646968fcdc1922a477710964d948fd1e0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473941
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Paul Berry <paul...@google.com>


Compare: https://github.com/dart-lang/sdk/compare/26e03dcf8a7f...1543c5b2d70f

To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Paul Berry

unread,
Jan 17, 2026, 1:20:45 PM (18 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/lkgr
Reply all
Reply to author
Forward
0 new messages