[dart-lang/sdk] f92ea3: Update the relevance table generator to support ne...

0 views
Skip to first unread message

Brian Wilkerson

unread,
Jan 16, 2026, 1:05:38 PM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: f92ea3d58dbddc39f90f239e09c465168f189ca9
https://github.com/dart-lang/sdk/commit/f92ea3d58dbddc39f90f239e09c465168f189ca9
Author: Brian Wilkerson <brianwi...@google.com>
Date: 2026-01-16 (Fri, 16 Jan 2026)

Changed paths:
M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart

Log Message:
-----------
Update the relevance table generator to support newer language features

I don't have a lot of confidence that the data being collected is what
needs to be collected in each of these cases, but I believe that I've
correctly identified the visit methods that need to be collecting data.

I think we need to have a test that ensures that the keys being used in
this table generator are the same as the keys being used by the
relevance feature computer (as computed by the in-scope pass). I don't
know exactly what that test would look like, but that would ensure that
(a) the keys are the same and (b) the table generator isn't missing
keys being used by the completion engine or collecting data that isn't
being used.

I also fixed a bug that prevented this generator from running and tested
to ensure that it could run over several example packages.

Change-Id: I0c0cff148d288942e39ee876e89cdf9d1468f59d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473780
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Brian Wilkerson

unread,
Jan 16, 2026, 1:40:12 PM (2 days ago) Jan 16
to com...@dartlang.org
Branch: refs/heads/lkgr
Reply all
Reply to author
Forward
0 new messages