[dart-lang/sdk] 39c5a6: [vm] Check covariance of type parameters of a forw...
0 views
Skip to first unread message
Alexander Markov
10:28 AM (10 hours ago) 10:28 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 39c5a61f89673f4511f65482e9a5192992ad3863
https://github.com/dart-lang/sdk/commit/39c5a61f89673f4511f65482e9a5192992ad3863
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M runtime/vm/compiler/frontend/kernel_to_il.cc
A tests/language/regress/regress62664_test.dart
Log Message:
-----------
[vm] Check covariance of type parameters of a forwarding stub instead of its target
A forwarding stub can have a covariant type parameter while the same
type parameter in its forwarding stub target is non-covariant.
We should still check bounds of such type parameters
(the bound to check is taken from the forwarding stub target).
TEST=tests/language/regress/regress62664_test.dart
Fixes https://github.com/dart-lang/sdk/issues/62664
Change-Id: I86eeb9f8a537c22fb473388f9b17f55084af6366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482480
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 39c5a61f89673f4511f65482e9a5192992ad3863
https://github.com/dart-lang/sdk/commit/39c5a61f89673f4511f65482e9a5192992ad3863
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M runtime/vm/compiler/frontend/kernel_to_il.cc
A tests/language/regress/regress62664_test.dart
Log Message:
-----------
[vm] Check covariance of type parameters of a forwarding stub instead of its target
A forwarding stub can have a covariant type parameter while the same
type parameter in its forwarding stub target is non-covariant.
We should still check bounds of such type parameters
(the bound to check is taken from the forwarding stub target).
TEST=tests/language/regress/regress62664_test.dart
Fixes https://github.com/dart-lang/sdk/issues/62664
Change-Id: I86eeb9f8a537c22fb473388f9b17f55084af6366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482480
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Alexander Markov
11:09 AM (9 hours ago) 11:09 AM
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
3:05 PM (5 hours ago) 3:05 PM
to com...@dartlang.org
Branch: refs/heads/dev
https://github.com/dart-lang/sdk/commit/2a375317f4bc378003b9dc64c0cd1379e926bc5e
Author: Danny Tuppeny <da...@tuppeny.com>
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
Log Message:
-----------
[analysis_server] Deprecate HighlightRegionType.BUILT_IN and always use KEYWORD
Change-Id: I86ff7edc2b4de5910b19f6bdb0d4422b7546897a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482820
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit: 45ab768bf571e0186100f147e002d08151fe19dd
https://github.com/dart-lang/sdk/commit/45ab768bf571e0186100f147e002d08151fe19dd
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
Log Message:
-----------
DeCo. Pass LocalScope to ScopeContext.withLocalScope
Change ScopeContext.withLocalScope to pass the created LocalScope to the
callback, and add LocalScope helpers for bulk insertion of declared
elements.
Refactor resolution/scoping visitors to use the provided LocalScope
rather than downcasting nameScope or relying on ad-hoc predeclaration:
- Predeclare local functions, local variables, and pattern variables in the
correct enclosing scope before visiting initializers/bodies, so lexical
lookup binds to loop/local elements consistently (including in implicit
block scopes for control-flow sub-statements).
- Centralize for-loop-parts handling (declarations, identifiers, patterns)
so each part is visited in the required order while installing the right
loop-local bindings.
- Compute and store declared pattern-variable elements directly on the
relevant AST nodes, and update ForEachPartsWithPattern to carry variable
elements (so flow analysis can declare them without extra indirection).
Also ensure metadata on pattern variable declarations and pattern-for
parts is visited in the same scope model as other declarations.
Change-Id: I35d52860b6816196085d79979cda861583c850be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482540
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7f32691a95b5e34aa7e8157e6f57c3e4b010460b
https://github.com/dart-lang/sdk/commit/7f32691a95b5e34aa7e8157e6f57c3e4b010460b
Author: Konstantin Shcheglov <sche...@google.com>
Log Message:
-----------
CQ. Make ErrorVerifier._featureSet non-nullable.
Change-Id: I14db847fda69f6fd690b02290d71600e237d2373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482700
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7eb7da68904821623ef10a24f20cba2adb216cbc
https://github.com/dart-lang/sdk/commit/7eb7da68904821623ef10a24f20cba2adb216cbc
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
M runtime/vm/object.h
M runtime/vm/raw_object.h
Log Message:
-----------
[vm,modular_aot] Initial code generation for interface calls
Also:
* Support arguments descriptors.
* Fix order of ClosureCall inputs in local function invocations.
* Fix order of passing arguments in all Dart calls.
* Fix handling of fields in InstanceSerializationCluster.
* Do not compile abstract methods and fields.
* Do not generate initializer functions for fields with trivial
initializers.
* Initialize Code::code_source_map to an empty CodeSourceMap
(in order to avoid failed assertions).
TEST=tools/test.py -n vm-modaot-mac-debug-arm64 language
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I40ff1b8234c32c41e08f3288a23e4abc173efcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480020
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: ba4bfeabdadec1de2320f3982035f9056ef93856
https://github.com/dart-lang/sdk/commit/ba4bfeabdadec1de2320f3982035f9056ef93856
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
Log Message:
-----------
[vm,modular_aot] Support getter and setter selector names
Add 'get:' and 'set:' prefixes to getter and setter selectors.
Also revise snapshot serialization of private names to support
private getter and setter names. ast.Name is replaced with
VM-specific PrivateName as private getter/setter names
such as get:_foo are considered public by ast.Name
(as they don't start with '_').
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I7447cb457aa2463836c8cf6af3d12e1998fe325c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481441
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: f2de280b40e903ff6eaa2108f0eba8a84efcef16
https://github.com/dart-lang/sdk/commit/f2de280b40e903ff6eaa2108f0eba8a84efcef16
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
Log Message:
-----------
DeCo. Report initializingFormalForNonExistentField for primary constructors.
Change-Id: I42d2516902a0d7c2a3eb914d39afe01a10d4bf86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482640
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: e8df76286e8a958da6253a0623738a6bea2750c1
https://github.com/dart-lang/sdk/commit/e8df76286e8a958da6253a0623738a6bea2750c1
Author: FMorschel <g...@fmorschel.dev>
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
Log Message:
-----------
[analysis_server_plugin] Skips files that are analyzer excluded.
Fixes: https://github.com/dart-lang/sdk/issues/62729
Change-Id: I4b60ad02b10009decfa091d8dce84a0e765a7b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482460
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 265b75c74e46e1a6a1543f261633d92e264082e1
https://github.com/dart-lang/sdk/commit/265b75c74e46e1a6a1543f261633d92e264082e1
Author: Sam Rawlins <sraw...@google.com>
M pkg/linter/test/rules/cancel_subscriptions_test.dart
Log Message:
-----------
linter: leak_detectors: fix case for method invocation with no target
Fixes new failures in flutter bot: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8689087561632725585/+/u/analyze_Flutter_repositories/stdout?format=raw
Regression introduced by https://dart-review.googlesource.com/c/sdk/+/482444
The bug was that we bailed out too early, when looking at a method
invocation, and we are deciding whether it might represent a valid
cancelation. There are some checks that are only valid if the invocation
has a real target. But there are other checks that should be made even
if the function has an implicit target.
Change-Id: Id67d381aa1f78de8bf0f264a962ee2bbbdc6a030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482860
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: 94c31ded4ab1f7f9379d9148b1a93666a3a904be
https://github.com/dart-lang/sdk/commit/94c31ded4ab1f7f9379d9148b1a93666a3a904be
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
Log Message:
-----------
DeCo. Extract visitClassDeclaration, visitExtensionDeclaration, visitExtensionTypeDeclaration into ScopeContext.
Change-Id: Ic9c15bfe66326625a91b1cc813204251b6eb36a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482620
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
https://github.com/dart-lang/sdk/commit/1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
Author: FMorschel <g...@fmorschel.dev>
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
Log Message:
-----------
[analyzer_plugin] Fixes recursive type writing on `DartEditBuilder.writeType`
Fixes: https://github.com/dart-lang/sdk/issues/62549
Change-Id: Ia5f8b7cf7f923d63a73a9b155d1590052a61eaa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476800
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 5b44ac37e5c2d5b07cfcb106ce28f4e4b901cef7
https://github.com/dart-lang/sdk/commit/5b44ac37e5c2d5b07cfcb106ce28f4e4b901cef7
Author: Sam Rawlins <sraw...@google.com>
M pkg/linter/test/rules/unreachable_from_main_test.dart
Log Message:
-----------
linter: Support extension types in unreachable_from_main
Work towards https://github.com/dart-lang/sdk/issues/58838
Change-Id: I0964ca3d78dde02507672b517671b63444f68891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482542
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: e443b89f238cf97b7d33eb54ca34fc19ef44f52f
https://github.com/dart-lang/sdk/commit/e443b89f238cf97b7d33eb54ca34fc19ef44f52f
Author: Ryan Macnak <rma...@google.com>
M build/config/BUILDCONFIG.gn
M build/config/compiler/BUILD.gn
M pkg/native_compiler/lib/runtime/vm_offsets.g.dart
M runtime/PRESUBMIT.py
M runtime/lib/regexp.cc
M runtime/platform/globals.h
M runtime/platform/unicode.h
M runtime/platform/utils.h
M runtime/tests/vm/dart/regress_big_regexp_test.dart
M runtime/tools/run_clang_tidy.dart
M runtime/vm/BUILD.gn
M runtime/vm/app_snapshot.cc
M runtime/vm/canonical_tables.cc
M runtime/vm/canonical_tables.h
M runtime/vm/compiler/aot/precompiler.cc
M runtime/vm/compiler/asm_intrinsifier.cc
M runtime/vm/compiler/asm_intrinsifier.h
M runtime/vm/compiler/asm_intrinsifier_arm.cc
M runtime/vm/compiler/asm_intrinsifier_arm64.cc
M runtime/vm/compiler/asm_intrinsifier_ia32.cc
M runtime/vm/compiler/asm_intrinsifier_riscv.cc
M runtime/vm/compiler/asm_intrinsifier_x64.cc
M runtime/vm/compiler/backend/constant_propagator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_ia32.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/backend/type_propagator.cc
M runtime/vm/compiler/jit/compiler.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/compiler/runtime_offsets_extracted.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/flag_list.h
M runtime/vm/object.cc
M runtime/vm/object.h
M runtime/vm/object_service.cc
M runtime/vm/parser.cc
M runtime/vm/parser.h
M runtime/vm/raw_object.h
A runtime/vm/regexp/README.md
A runtime/vm/regexp/base.h
A runtime/vm/regexp/char-predicates-inl.h
A runtime/vm/regexp/char-predicates.cc
A runtime/vm/regexp/char-predicates.h
A runtime/vm/regexp/flags.h
A runtime/vm/regexp/gen-regexp-special-case.cc
A runtime/vm/regexp/label.h
A runtime/vm/regexp/memcopy.h
A runtime/vm/regexp/regexp-ast.cc
A runtime/vm/regexp/regexp-ast.h
A runtime/vm/regexp/regexp-bytecode-generator-inl.h
A runtime/vm/regexp/regexp-bytecode-generator.cc
A runtime/vm/regexp/regexp-bytecode-generator.h
A runtime/vm/regexp/regexp-bytecodes-inl.h
A runtime/vm/regexp/regexp-bytecodes.h
A runtime/vm/regexp/regexp-compiler-tonode.cc
A runtime/vm/regexp/regexp-compiler.cc
A runtime/vm/regexp/regexp-compiler.h
A runtime/vm/regexp/regexp-error.cc
A runtime/vm/regexp/regexp-error.h
A runtime/vm/regexp/regexp-flags.h
A runtime/vm/regexp/regexp-interpreter.cc
A runtime/vm/regexp/regexp-interpreter.h
A runtime/vm/regexp/regexp-macro-assembler.cc
A runtime/vm/regexp/regexp-macro-assembler.h
A runtime/vm/regexp/regexp-nodes.h
A runtime/vm/regexp/regexp-parser.cc
A runtime/vm/regexp/regexp-parser.h
M runtime/vm/regexp/regexp.cc
M runtime/vm/regexp/regexp.h
R runtime/vm/regexp/regexp_assembler.cc
R runtime/vm/regexp/regexp_assembler.h
R runtime/vm/regexp/regexp_assembler_bytecode.cc
R runtime/vm/regexp/regexp_assembler_bytecode.h
R runtime/vm/regexp/regexp_assembler_bytecode_inl.h
R runtime/vm/regexp/regexp_assembler_ir.cc
R runtime/vm/regexp/regexp_assembler_ir.h
R runtime/vm/regexp/regexp_ast.cc
R runtime/vm/regexp/regexp_ast.h
R runtime/vm/regexp/regexp_bytecodes.h
R runtime/vm/regexp/regexp_interpreter.cc
R runtime/vm/regexp/regexp_interpreter.h
R runtime/vm/regexp/regexp_parser.cc
R runtime/vm/regexp/regexp_parser.h
M runtime/vm/regexp/regexp_sources.gni
M runtime/vm/regexp/regexp_test.cc
A runtime/vm/regexp/small-vector.h
A runtime/vm/regexp/special-case.cc
A runtime/vm/regexp/special-case.h
M runtime/vm/regexp/unibrow-inl.h
M runtime/vm/regexp/unibrow.cc
M runtime/vm/regexp/unibrow.h
A runtime/vm/regexp/vector.h
A runtime/vm/regexp/zone-containers.h
A runtime/vm/regexp/zone-list-inl.h
A runtime/vm/regexp/zone-list.h
M runtime/vm/runtime_entry.cc
M runtime/vm/runtime_entry.h
M runtime/vm/runtime_entry_list.h
M runtime/vm/symbols.h
M runtime/vm/zone.h
M sdk/lib/_internal/vm/lib/regexp_patch.dart
A tests/corelib/regexp/duplicate_named_capture_group_test.dart
A tests/corelib/regexp/group_modifier_test.dart
M tests/corelib/regexp/named_captures_2_test.dart
M tests/standalone/regress_52691_test.dart
Log Message:
-----------
[vm] Update Irregexp to V8 commit 254cc758346f10be2a7e22e55d90d4defe9cad74.
Includes support for modifier spans and duplicate named capture groups.
Drops the flow graph implementation to ease maintenance.
TEST=corelib/regexp
Bug: https://github.com/dart-lang/sdk/issues/56573
Bug: https://github.com/dart-lang/sdk/issues/61337
Bug: https://github.com/dart-lang/sdk/issues/62349
Bug: https://github.com/dart-lang/sdk/issues/62708
Change-Id: I05640ba945a4fa5476e7ad463738f4f39d842c14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480121
Reviewed-by: Lasse Nielsen <l...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Commit: 51cdf271def6d95750eb1b1a44c72154d61f6dd8
https://github.com/dart-lang/sdk/commit/51cdf271def6d95750eb1b1a44c72154d61f6dd8
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart
M tests/language/primary_constructors/wildcard_declaring_parameters_error_test.dart
Log Message:
-----------
DeCo. Report diag.duplicateDefinition for defining formal parameters with name '_'.
Change-Id: I6c8d9cbacb78efb17fd5b8603263deb3d65e6335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482660
Reviewed-by: Bob Nystrom <rnys...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 0ec34ebde6ff5f0308335a39077790ca05c4270c
https://github.com/dart-lang/sdk/commit/0ec34ebde6ff5f0308335a39077790ca05c4270c
Author: Erik Ernst <eer...@google.com>
Log Message:
-----------
Mark the ..obvious.. lints as having `state: stable`
This CL changes the `state:` field of the lint documentation records in
pkg/linter/messages.yaml from `experimental` to `stable`.
The CL https://dart-review.googlesource.com/c/sdk/+/479841 was intended
to change the status, and it did remove a paragraph from the
documentation about the lints being experimental, but it was complete in
that it did not change the `state:` fields.
Change-Id: I986dfc28dc6a6943c760cbe129ee619d8162a613
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482785
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: c2ef934eb893be28f7bfbf9c2e7d81ba55a4f776
https://github.com/dart-lang/sdk/commit/c2ef934eb893be28f7bfbf9c2e7d81ba55a4f776
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M build/config/BUILDCONFIG.gn
M build/config/compiler/BUILD.gn
M pkg/analysis_server/doc/api.html
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
M pkg/analyzer/lib/src/dart/ast/ast.dart
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/analyzer/test/util/feature_sets.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/linter/lib/src/rules/unreachable_from_main.dart
M pkg/linter/lib/src/util/leak_detector_visitor.dart
M pkg/linter/messages.yaml
M pkg/linter/test/rules/cancel_subscriptions_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/unreachable_from_main_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/runtime/vm_offsets.g.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/PRESUBMIT.py
M runtime/lib/regexp.cc
M runtime/platform/globals.h
M runtime/platform/unicode.h
M runtime/platform/utils.h
M runtime/tests/vm/dart/regress_big_regexp_test.dart
M runtime/tools/run_clang_tidy.dart
M runtime/vm/BUILD.gn
M runtime/vm/app_snapshot.cc
M runtime/vm/canonical_tables.cc
M runtime/vm/canonical_tables.h
M runtime/vm/compiler/aot/precompiler.cc
M runtime/vm/compiler/asm_intrinsifier.cc
M runtime/vm/compiler/asm_intrinsifier.h
M runtime/vm/compiler/asm_intrinsifier_arm.cc
M runtime/vm/compiler/asm_intrinsifier_arm64.cc
M runtime/vm/compiler/asm_intrinsifier_ia32.cc
M runtime/vm/compiler/asm_intrinsifier_riscv.cc
M runtime/vm/compiler/asm_intrinsifier_x64.cc
M runtime/vm/compiler/backend/constant_propagator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_ia32.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/backend/type_propagator.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/jit/compiler.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/compiler/runtime_offsets_extracted.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/flag_list.h
M runtime/vm/module_snapshot.cc
M runtime/vm/object.cc
M runtime/vm/object.h
M runtime/vm/object_service.cc
M runtime/vm/parser.cc
M runtime/vm/parser.h
M runtime/vm/raw_object.h
A runtime/vm/regexp/README.md
A runtime/vm/regexp/base.h
A runtime/vm/regexp/char-predicates-inl.h
A runtime/vm/regexp/char-predicates.cc
A runtime/vm/regexp/char-predicates.h
A runtime/vm/regexp/flags.h
A runtime/vm/regexp/gen-regexp-special-case.cc
A runtime/vm/regexp/label.h
A runtime/vm/regexp/memcopy.h
A runtime/vm/regexp/regexp-ast.cc
A runtime/vm/regexp/regexp-ast.h
A runtime/vm/regexp/regexp-bytecode-generator-inl.h
A runtime/vm/regexp/regexp-bytecode-generator.cc
A runtime/vm/regexp/regexp-bytecode-generator.h
A runtime/vm/regexp/regexp-bytecodes-inl.h
A runtime/vm/regexp/regexp-bytecodes.h
A runtime/vm/regexp/regexp-compiler-tonode.cc
A runtime/vm/regexp/regexp-compiler.cc
A runtime/vm/regexp/regexp-compiler.h
A runtime/vm/regexp/regexp-error.cc
A runtime/vm/regexp/regexp-error.h
A runtime/vm/regexp/regexp-flags.h
A runtime/vm/regexp/regexp-interpreter.cc
A runtime/vm/regexp/regexp-interpreter.h
A runtime/vm/regexp/regexp-macro-assembler.cc
A runtime/vm/regexp/regexp-macro-assembler.h
A runtime/vm/regexp/regexp-nodes.h
A runtime/vm/regexp/regexp-parser.cc
A runtime/vm/regexp/regexp-parser.h
M runtime/vm/regexp/regexp.cc
M runtime/vm/regexp/regexp.h
R runtime/vm/regexp/regexp_assembler.cc
R runtime/vm/regexp/regexp_assembler.h
R runtime/vm/regexp/regexp_assembler_bytecode.cc
R runtime/vm/regexp/regexp_assembler_bytecode.h
R runtime/vm/regexp/regexp_assembler_bytecode_inl.h
R runtime/vm/regexp/regexp_assembler_ir.cc
R runtime/vm/regexp/regexp_assembler_ir.h
R runtime/vm/regexp/regexp_ast.cc
R runtime/vm/regexp/regexp_ast.h
R runtime/vm/regexp/regexp_bytecodes.h
R runtime/vm/regexp/regexp_interpreter.cc
R runtime/vm/regexp/regexp_interpreter.h
R runtime/vm/regexp/regexp_parser.cc
R runtime/vm/regexp/regexp_parser.h
M runtime/vm/regexp/regexp_sources.gni
M runtime/vm/regexp/regexp_test.cc
A runtime/vm/regexp/small-vector.h
A runtime/vm/regexp/special-case.cc
A runtime/vm/regexp/special-case.h
M runtime/vm/regexp/unibrow-inl.h
M runtime/vm/regexp/unibrow.cc
M runtime/vm/regexp/unibrow.h
A runtime/vm/regexp/vector.h
A runtime/vm/regexp/zone-containers.h
A runtime/vm/regexp/zone-list-inl.h
A runtime/vm/regexp/zone-list.h
M runtime/vm/runtime_entry.cc
M runtime/vm/runtime_entry.h
M runtime/vm/runtime_entry_list.h
M runtime/vm/symbols.h
M runtime/vm/zone.h
M sdk/lib/_internal/vm/lib/regexp_patch.dart
A tests/corelib/regexp/duplicate_named_capture_group_test.dart
A tests/corelib/regexp/group_modifier_test.dart
M tests/corelib/regexp/named_captures_2_test.dart
M tests/language/primary_constructors/wildcard_declaring_parameters_error_test.dart
A tests/language/regress/regress62664_test.dart
M tests/standalone/regress_52691_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-176.0.dev
Merge 0ec34ebde6ff5f0308335a39077790ca05c4270c into dev
Compare: https://github.com/dart-lang/sdk/compare/d23cf6c0d633...c2ef934eb893
Home: https://github.com/dart-lang/sdk
Commit: 39c5a61f89673f4511f65482e9a5192992ad3863
https://github.com/dart-lang/sdk/commit/39c5a61f89673f4511f65482e9a5192992ad3863
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M runtime/vm/compiler/frontend/kernel_to_il.cc
A tests/language/regress/regress62664_test.dart
Log Message:
-----------
[vm] Check covariance of type parameters of a forwarding stub instead of its target
A forwarding stub can have a covariant type parameter while the same
type parameter in its forwarding stub target is non-covariant.
We should still check bounds of such type parameters
(the bound to check is taken from the forwarding stub target).
TEST=tests/language/regress/regress62664_test.dart
Fixes https://github.com/dart-lang/sdk/issues/62664
Change-Id: I86eeb9f8a537c22fb473388f9b17f55084af6366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482480
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Commit: 2a375317f4bc378003b9dc64c0cd1379e926bc5e
Commit: 39c5a61f89673f4511f65482e9a5192992ad3863
https://github.com/dart-lang/sdk/commit/39c5a61f89673f4511f65482e9a5192992ad3863
Author: Alexander Markov <alexm...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M runtime/vm/compiler/frontend/kernel_to_il.cc
A tests/language/regress/regress62664_test.dart
Log Message:
-----------
[vm] Check covariance of type parameters of a forwarding stub instead of its target
A forwarding stub can have a covariant type parameter while the same
type parameter in its forwarding stub target is non-covariant.
We should still check bounds of such type parameters
(the bound to check is taken from the forwarding stub target).
TEST=tests/language/regress/regress62664_test.dart
Fixes https://github.com/dart-lang/sdk/issues/62664
Change-Id: I86eeb9f8a537c22fb473388f9b17f55084af6366
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482480
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
https://github.com/dart-lang/sdk/commit/2a375317f4bc378003b9dc64c0cd1379e926bc5e
Author: Danny Tuppeny <da...@tuppeny.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server/doc/api.html
Changed paths:
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
Log Message:
-----------
[analysis_server] Deprecate HighlightRegionType.BUILT_IN and always use KEYWORD
Change-Id: I86ff7edc2b4de5910b19f6bdb0d4422b7546897a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482820
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit: 45ab768bf571e0186100f147e002d08151fe19dd
https://github.com/dart-lang/sdk/commit/45ab768bf571e0186100f147e002d08151fe19dd
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/ast/ast.dart
Changed paths:
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
Log Message:
-----------
DeCo. Pass LocalScope to ScopeContext.withLocalScope
Change ScopeContext.withLocalScope to pass the created LocalScope to the
callback, and add LocalScope helpers for bulk insertion of declared
elements.
Refactor resolution/scoping visitors to use the provided LocalScope
rather than downcasting nameScope or relying on ad-hoc predeclaration:
- Predeclare local functions, local variables, and pattern variables in the
correct enclosing scope before visiting initializers/bodies, so lexical
lookup binds to loop/local elements consistently (including in implicit
block scopes for control-flow sub-statements).
- Centralize for-loop-parts handling (declarations, identifiers, patterns)
so each part is visited in the required order while installing the right
loop-local bindings.
- Compute and store declared pattern-variable elements directly on the
relevant AST nodes, and update ForEachPartsWithPattern to carry variable
elements (so flow analysis can declare them without extra indirection).
Also ensure metadata on pattern variable declarations and pattern-for
parts is visited in the same scope model as other declarations.
Change-Id: I35d52860b6816196085d79979cda861583c850be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482540
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7f32691a95b5e34aa7e8157e6f57c3e4b010460b
https://github.com/dart-lang/sdk/commit/7f32691a95b5e34aa7e8157e6f57c3e4b010460b
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/generated/error_verifier.dart
Changed paths:
Log Message:
-----------
CQ. Make ErrorVerifier._featureSet non-nullable.
Change-Id: I14db847fda69f6fd690b02290d71600e237d2373
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482700
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 7eb7da68904821623ef10a24f20cba2adb216cbc
https://github.com/dart-lang/sdk/commit/7eb7da68904821623ef10a24f20cba2adb216cbc
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/vm/module_snapshot.cc
M runtime/vm/object.h
M runtime/vm/raw_object.h
Log Message:
-----------
[vm,modular_aot] Initial code generation for interface calls
Also:
* Support arguments descriptors.
* Fix order of ClosureCall inputs in local function invocations.
* Fix order of passing arguments in all Dart calls.
* Fix handling of fields in InstanceSerializationCluster.
* Do not compile abstract methods and fields.
* Do not generate initializer functions for fields with trivial
initializers.
* Initialize Code::code_source_map to an empty CodeSourceMap
(in order to avoid failed assertions).
TEST=tools/test.py -n vm-modaot-mac-debug-arm64 language
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I40ff1b8234c32c41e08f3288a23e4abc173efcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480020
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Commit: ba4bfeabdadec1de2320f3982035f9056ef93856
https://github.com/dart-lang/sdk/commit/ba4bfeabdadec1de2320f3982035f9056ef93856
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
Log Message:
-----------
[vm,modular_aot] Support getter and setter selector names
Add 'get:' and 'set:' prefixes to getter and setter selectors.
Also revise snapshot serialization of private names to support
private getter and setter names. ast.Name is replaced with
VM-specific PrivateName as private getter/setter names
such as get:_foo are considered public by ast.Name
(as they don't start with '_').
Issue: https://github.com/dart-lang/sdk/issues/61635
Change-Id: I7447cb457aa2463836c8cf6af3d12e1998fe325c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/481441
Commit: b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
https://github.com/dart-lang/sdk/commit/b18b1c598a38743798ec3cc7e92b88d5e6d44b9e
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
Changed paths:
M pkg/analyzer/test/util/feature_sets.dart
Log Message:
-----------
CQ. Remove FeatureSets.latestWithVariance, already included in latestWithExperiments.
Change-Id: Ibb914ca13048a2734426d1e89efe1d13eafe4fb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482680
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: f2de280b40e903ff6eaa2108f0eba8a84efcef16
https://github.com/dart-lang/sdk/commit/f2de280b40e903ff6eaa2108f0eba8a84efcef16
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/generated/error_verifier.dart
Changed paths:
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
Log Message:
-----------
DeCo. Report initializingFormalForNonExistentField for primary constructors.
Change-Id: I42d2516902a0d7c2a3eb914d39afe01a10d4bf86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482640
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: e8df76286e8a958da6253a0623738a6bea2750c1
https://github.com/dart-lang/sdk/commit/e8df76286e8a958da6253a0623738a6bea2750c1
Author: FMorschel <g...@fmorschel.dev>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
Changed paths:
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
Log Message:
-----------
[analysis_server_plugin] Skips files that are analyzer excluded.
Fixes: https://github.com/dart-lang/sdk/issues/62729
Change-Id: I4b60ad02b10009decfa091d8dce84a0e765a7b6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482460
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 265b75c74e46e1a6a1543f261633d92e264082e1
https://github.com/dart-lang/sdk/commit/265b75c74e46e1a6a1543f261633d92e264082e1
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/linter/lib/src/util/leak_detector_visitor.dart
Changed paths:
M pkg/linter/test/rules/cancel_subscriptions_test.dart
Log Message:
-----------
linter: leak_detectors: fix case for method invocation with no target
Fixes new failures in flutter bot: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8689087561632725585/+/u/analyze_Flutter_repositories/stdout?format=raw
Regression introduced by https://dart-review.googlesource.com/c/sdk/+/482444
The bug was that we bailed out too early, when looking at a method
invocation, and we are deciding whether it might represent a valid
cancelation. There are some checks that are only valid if the invocation
has a real target. But there are other checks that should be made even
if the function has an implicit target.
Change-Id: Id67d381aa1f78de8bf0f264a962ee2bbbdc6a030
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482860
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: 94c31ded4ab1f7f9379d9148b1a93666a3a904be
https://github.com/dart-lang/sdk/commit/94c31ded4ab1f7f9379d9148b1a93666a3a904be
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
Changed paths:
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
Log Message:
-----------
DeCo. Extract visitClassDeclaration, visitExtensionDeclaration, visitExtensionTypeDeclaration into ScopeContext.
Change-Id: Ic9c15bfe66326625a91b1cc813204251b6eb36a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482620
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
https://github.com/dart-lang/sdk/commit/1f8861f4f972e996ddd43b6a883bb5eedcfd62b3
Author: FMorschel <g...@fmorschel.dev>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
Changed paths:
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
Log Message:
-----------
[analyzer_plugin] Fixes recursive type writing on `DartEditBuilder.writeType`
Fixes: https://github.com/dart-lang/sdk/issues/62549
Change-Id: Ia5f8b7cf7f923d63a73a9b155d1590052a61eaa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/476800
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 5b44ac37e5c2d5b07cfcb106ce28f4e4b901cef7
https://github.com/dart-lang/sdk/commit/5b44ac37e5c2d5b07cfcb106ce28f4e4b901cef7
Author: Sam Rawlins <sraw...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/linter/lib/src/rules/unreachable_from_main.dart
Changed paths:
M pkg/linter/test/rules/unreachable_from_main_test.dart
Log Message:
-----------
linter: Support extension types in unreachable_from_main
Work towards https://github.com/dart-lang/sdk/issues/58838
Change-Id: I0964ca3d78dde02507672b517671b63444f68891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482542
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: e443b89f238cf97b7d33eb54ca34fc19ef44f52f
https://github.com/dart-lang/sdk/commit/e443b89f238cf97b7d33eb54ca34fc19ef44f52f
Author: Ryan Macnak <rma...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M CHANGELOG.md
Changed paths:
M build/config/BUILDCONFIG.gn
M build/config/compiler/BUILD.gn
M pkg/native_compiler/lib/runtime/vm_offsets.g.dart
M runtime/PRESUBMIT.py
M runtime/lib/regexp.cc
M runtime/platform/globals.h
M runtime/platform/unicode.h
M runtime/platform/utils.h
M runtime/tests/vm/dart/regress_big_regexp_test.dart
M runtime/tools/run_clang_tidy.dart
M runtime/vm/BUILD.gn
M runtime/vm/app_snapshot.cc
M runtime/vm/canonical_tables.cc
M runtime/vm/canonical_tables.h
M runtime/vm/compiler/aot/precompiler.cc
M runtime/vm/compiler/asm_intrinsifier.cc
M runtime/vm/compiler/asm_intrinsifier.h
M runtime/vm/compiler/asm_intrinsifier_arm.cc
M runtime/vm/compiler/asm_intrinsifier_arm64.cc
M runtime/vm/compiler/asm_intrinsifier_ia32.cc
M runtime/vm/compiler/asm_intrinsifier_riscv.cc
M runtime/vm/compiler/asm_intrinsifier_x64.cc
M runtime/vm/compiler/backend/constant_propagator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_ia32.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/backend/type_propagator.cc
M runtime/vm/compiler/jit/compiler.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/compiler/runtime_offsets_extracted.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/flag_list.h
M runtime/vm/object.cc
M runtime/vm/object.h
M runtime/vm/object_service.cc
M runtime/vm/parser.cc
M runtime/vm/parser.h
M runtime/vm/raw_object.h
A runtime/vm/regexp/README.md
A runtime/vm/regexp/base.h
A runtime/vm/regexp/char-predicates-inl.h
A runtime/vm/regexp/char-predicates.cc
A runtime/vm/regexp/char-predicates.h
A runtime/vm/regexp/flags.h
A runtime/vm/regexp/gen-regexp-special-case.cc
A runtime/vm/regexp/label.h
A runtime/vm/regexp/memcopy.h
A runtime/vm/regexp/regexp-ast.cc
A runtime/vm/regexp/regexp-ast.h
A runtime/vm/regexp/regexp-bytecode-generator-inl.h
A runtime/vm/regexp/regexp-bytecode-generator.cc
A runtime/vm/regexp/regexp-bytecode-generator.h
A runtime/vm/regexp/regexp-bytecodes-inl.h
A runtime/vm/regexp/regexp-bytecodes.h
A runtime/vm/regexp/regexp-compiler-tonode.cc
A runtime/vm/regexp/regexp-compiler.cc
A runtime/vm/regexp/regexp-compiler.h
A runtime/vm/regexp/regexp-error.cc
A runtime/vm/regexp/regexp-error.h
A runtime/vm/regexp/regexp-flags.h
A runtime/vm/regexp/regexp-interpreter.cc
A runtime/vm/regexp/regexp-interpreter.h
A runtime/vm/regexp/regexp-macro-assembler.cc
A runtime/vm/regexp/regexp-macro-assembler.h
A runtime/vm/regexp/regexp-nodes.h
A runtime/vm/regexp/regexp-parser.cc
A runtime/vm/regexp/regexp-parser.h
M runtime/vm/regexp/regexp.cc
M runtime/vm/regexp/regexp.h
R runtime/vm/regexp/regexp_assembler.cc
R runtime/vm/regexp/regexp_assembler.h
R runtime/vm/regexp/regexp_assembler_bytecode.cc
R runtime/vm/regexp/regexp_assembler_bytecode.h
R runtime/vm/regexp/regexp_assembler_bytecode_inl.h
R runtime/vm/regexp/regexp_assembler_ir.cc
R runtime/vm/regexp/regexp_assembler_ir.h
R runtime/vm/regexp/regexp_ast.cc
R runtime/vm/regexp/regexp_ast.h
R runtime/vm/regexp/regexp_bytecodes.h
R runtime/vm/regexp/regexp_interpreter.cc
R runtime/vm/regexp/regexp_interpreter.h
R runtime/vm/regexp/regexp_parser.cc
R runtime/vm/regexp/regexp_parser.h
M runtime/vm/regexp/regexp_sources.gni
M runtime/vm/regexp/regexp_test.cc
A runtime/vm/regexp/small-vector.h
A runtime/vm/regexp/special-case.cc
A runtime/vm/regexp/special-case.h
M runtime/vm/regexp/unibrow-inl.h
M runtime/vm/regexp/unibrow.cc
M runtime/vm/regexp/unibrow.h
A runtime/vm/regexp/vector.h
A runtime/vm/regexp/zone-containers.h
A runtime/vm/regexp/zone-list-inl.h
A runtime/vm/regexp/zone-list.h
M runtime/vm/runtime_entry.cc
M runtime/vm/runtime_entry.h
M runtime/vm/runtime_entry_list.h
M runtime/vm/symbols.h
M runtime/vm/zone.h
M sdk/lib/_internal/vm/lib/regexp_patch.dart
A tests/corelib/regexp/duplicate_named_capture_group_test.dart
A tests/corelib/regexp/group_modifier_test.dart
M tests/corelib/regexp/named_captures_2_test.dart
M tests/standalone/regress_52691_test.dart
Log Message:
-----------
[vm] Update Irregexp to V8 commit 254cc758346f10be2a7e22e55d90d4defe9cad74.
Includes support for modifier spans and duplicate named capture groups.
Drops the flow graph implementation to ease maintenance.
TEST=corelib/regexp
Bug: https://github.com/dart-lang/sdk/issues/56573
Bug: https://github.com/dart-lang/sdk/issues/61337
Bug: https://github.com/dart-lang/sdk/issues/62349
Bug: https://github.com/dart-lang/sdk/issues/62708
Change-Id: I05640ba945a4fa5476e7ad463738f4f39d842c14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480121
Reviewed-by: Lasse Nielsen <l...@google.com>
Commit-Queue: Ryan Macnak <rma...@google.com>
Commit: 51cdf271def6d95750eb1b1a44c72154d61f6dd8
https://github.com/dart-lang/sdk/commit/51cdf271def6d95750eb1b1a44c72154d61f6dd8
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart
Changed paths:
M pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart
M tests/language/primary_constructors/wildcard_declaring_parameters_error_test.dart
Log Message:
-----------
DeCo. Report diag.duplicateDefinition for defining formal parameters with name '_'.
Change-Id: I6c8d9cbacb78efb17fd5b8603263deb3d65e6335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482660
Reviewed-by: Bob Nystrom <rnys...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: 0ec34ebde6ff5f0308335a39077790ca05c4270c
https://github.com/dart-lang/sdk/commit/0ec34ebde6ff5f0308335a39077790ca05c4270c
Author: Erik Ernst <eer...@google.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M pkg/linter/messages.yaml
Changed paths:
Log Message:
-----------
Mark the ..obvious.. lints as having `state: stable`
This CL changes the `state:` field of the lint documentation records in
pkg/linter/messages.yaml from `experimental` to `stable`.
The CL https://dart-review.googlesource.com/c/sdk/+/479841 was intended
to change the status, and it did remove a paragraph from the
documentation about the lints being experimental, but it was complete in
that it did not change the `state:` fields.
Change-Id: I986dfc28dc6a6943c760cbe129ee619d8162a613
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/482785
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Commit: c2ef934eb893be28f7bfbf9c2e7d81ba55a4f776
https://github.com/dart-lang/sdk/commit/c2ef934eb893be28f7bfbf9c2e7d81ba55a4f776
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-02-23 (Mon, 23 Feb 2026)
Changed paths:
M CHANGELOG.md
Changed paths:
M build/config/BUILDCONFIG.gn
M build/config/compiler/BUILD.gn
M pkg/analysis_server/doc/api.html
M pkg/analysis_server/integration_test/analysis/highlights_test.dart
M pkg/analysis_server/lib/src/computer/computer_highlights.dart
M pkg/analysis_server/lib/src/lsp/semantic_tokens/mapping.dart
M pkg/analysis_server/test/analysis/notification_highlights2_test.dart
M pkg/analysis_server/test/lsp/semantic_tokens_test.dart
M pkg/analysis_server/test/src/computer/highlights_computer_test.dart
M pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
M pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analysis_server_plugin/test/src/plugin_server_test.dart
M pkg/analyzer/lib/src/dart/ast/ast.dart
M pkg/analyzer/lib/src/dart/element/scope.dart
M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/for_resolver.dart
M pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
M pkg/analyzer/lib/src/dart/resolver/scope_context.dart
M pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart
M pkg/analyzer/lib/src/generated/error_verifier.dart
M pkg/analyzer/lib/src/generated/resolver.dart
M pkg/analyzer/lib/src/summary2/reference_resolver.dart
M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart
M pkg/analyzer/test/src/diagnostics/initializer_for_static_field_test.dart
M pkg/analyzer/test/src/diagnostics/initializing_formal_for_non_existent_field_test.dart
M pkg/analyzer/test/util/feature_sets.dart
M pkg/analyzer_plugin/doc/api.html
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart
M pkg/analyzer_plugin/tool/spec/common_types_spec.html
M pkg/cfg/lib/front_end/ast_to_ir.dart
M pkg/cfg/lib/ir/flow_graph_builder.dart
M pkg/cfg/lib/ir/functions.dart
M pkg/cfg/lib/ir/instructions.dart
M pkg/cfg/lib/passes/simplification.dart
M pkg/cfg/testcases/calls.dart
M pkg/cfg/testcases/calls.dart.expect
M pkg/linter/lib/src/rules/unreachable_from_main.dart
M pkg/linter/lib/src/util/leak_detector_visitor.dart
M pkg/linter/messages.yaml
M pkg/linter/test/rules/cancel_subscriptions_test.dart
M pkg/linter/test/rules/type_init_formals_test.dart
M pkg/linter/test/rules/unreachable_from_main_test.dart
M pkg/linter/test/rules/use_late_for_private_fields_and_variables_test.dart
M pkg/native_compiler/lib/back_end/arm64/assembler.dart
M pkg/native_compiler/lib/back_end/arm64/code_generator.dart
M pkg/native_compiler/lib/back_end/object_pool.dart
M pkg/native_compiler/lib/compilation_set.dart
M pkg/native_compiler/lib/passes/lowering.dart
M pkg/native_compiler/lib/runtime/type_utils.dart
M pkg/native_compiler/lib/runtime/vm_offsets.g.dart
M pkg/native_compiler/lib/snapshot/snapshot.dart
M runtime/PRESUBMIT.py
M runtime/lib/regexp.cc
M runtime/platform/globals.h
M runtime/platform/unicode.h
M runtime/platform/utils.h
M runtime/tests/vm/dart/regress_big_regexp_test.dart
M runtime/tools/run_clang_tidy.dart
M runtime/vm/BUILD.gn
M runtime/vm/app_snapshot.cc
M runtime/vm/canonical_tables.cc
M runtime/vm/canonical_tables.h
M runtime/vm/compiler/aot/precompiler.cc
M runtime/vm/compiler/asm_intrinsifier.cc
M runtime/vm/compiler/asm_intrinsifier.h
M runtime/vm/compiler/asm_intrinsifier_arm.cc
M runtime/vm/compiler/asm_intrinsifier_arm64.cc
M runtime/vm/compiler/asm_intrinsifier_ia32.cc
M runtime/vm/compiler/asm_intrinsifier_riscv.cc
M runtime/vm/compiler/asm_intrinsifier_x64.cc
M runtime/vm/compiler/backend/constant_propagator.cc
M runtime/vm/compiler/backend/il.cc
M runtime/vm/compiler/backend/il.h
M runtime/vm/compiler/backend/il_arm.cc
M runtime/vm/compiler/backend/il_arm64.cc
M runtime/vm/compiler/backend/il_ia32.cc
M runtime/vm/compiler/backend/il_riscv.cc
M runtime/vm/compiler/backend/il_x64.cc
M runtime/vm/compiler/backend/type_propagator.cc
M runtime/vm/compiler/frontend/kernel_to_il.cc
M runtime/vm/compiler/jit/compiler.cc
M runtime/vm/compiler/recognized_methods_list.h
M runtime/vm/compiler/runtime_offsets_extracted.h
M runtime/vm/dart_api_impl.cc
M runtime/vm/flag_list.h
M runtime/vm/module_snapshot.cc
M runtime/vm/object.cc
M runtime/vm/object.h
M runtime/vm/object_service.cc
M runtime/vm/parser.cc
M runtime/vm/parser.h
M runtime/vm/raw_object.h
A runtime/vm/regexp/README.md
A runtime/vm/regexp/base.h
A runtime/vm/regexp/char-predicates-inl.h
A runtime/vm/regexp/char-predicates.cc
A runtime/vm/regexp/char-predicates.h
A runtime/vm/regexp/flags.h
A runtime/vm/regexp/gen-regexp-special-case.cc
A runtime/vm/regexp/label.h
A runtime/vm/regexp/memcopy.h
A runtime/vm/regexp/regexp-ast.cc
A runtime/vm/regexp/regexp-ast.h
A runtime/vm/regexp/regexp-bytecode-generator-inl.h
A runtime/vm/regexp/regexp-bytecode-generator.cc
A runtime/vm/regexp/regexp-bytecode-generator.h
A runtime/vm/regexp/regexp-bytecodes-inl.h
A runtime/vm/regexp/regexp-bytecodes.h
A runtime/vm/regexp/regexp-compiler-tonode.cc
A runtime/vm/regexp/regexp-compiler.cc
A runtime/vm/regexp/regexp-compiler.h
A runtime/vm/regexp/regexp-error.cc
A runtime/vm/regexp/regexp-error.h
A runtime/vm/regexp/regexp-flags.h
A runtime/vm/regexp/regexp-interpreter.cc
A runtime/vm/regexp/regexp-interpreter.h
A runtime/vm/regexp/regexp-macro-assembler.cc
A runtime/vm/regexp/regexp-macro-assembler.h
A runtime/vm/regexp/regexp-nodes.h
A runtime/vm/regexp/regexp-parser.cc
A runtime/vm/regexp/regexp-parser.h
M runtime/vm/regexp/regexp.cc
M runtime/vm/regexp/regexp.h
R runtime/vm/regexp/regexp_assembler.cc
R runtime/vm/regexp/regexp_assembler.h
R runtime/vm/regexp/regexp_assembler_bytecode.cc
R runtime/vm/regexp/regexp_assembler_bytecode.h
R runtime/vm/regexp/regexp_assembler_bytecode_inl.h
R runtime/vm/regexp/regexp_assembler_ir.cc
R runtime/vm/regexp/regexp_assembler_ir.h
R runtime/vm/regexp/regexp_ast.cc
R runtime/vm/regexp/regexp_ast.h
R runtime/vm/regexp/regexp_bytecodes.h
R runtime/vm/regexp/regexp_interpreter.cc
R runtime/vm/regexp/regexp_interpreter.h
R runtime/vm/regexp/regexp_parser.cc
R runtime/vm/regexp/regexp_parser.h
M runtime/vm/regexp/regexp_sources.gni
M runtime/vm/regexp/regexp_test.cc
A runtime/vm/regexp/small-vector.h
A runtime/vm/regexp/special-case.cc
A runtime/vm/regexp/special-case.h
M runtime/vm/regexp/unibrow-inl.h
M runtime/vm/regexp/unibrow.cc
M runtime/vm/regexp/unibrow.h
A runtime/vm/regexp/vector.h
A runtime/vm/regexp/zone-containers.h
A runtime/vm/regexp/zone-list-inl.h
A runtime/vm/regexp/zone-list.h
M runtime/vm/runtime_entry.cc
M runtime/vm/runtime_entry.h
M runtime/vm/runtime_entry_list.h
M runtime/vm/symbols.h
M runtime/vm/zone.h
M sdk/lib/_internal/vm/lib/regexp_patch.dart
A tests/corelib/regexp/duplicate_named_capture_group_test.dart
A tests/corelib/regexp/group_modifier_test.dart
M tests/corelib/regexp/named_captures_2_test.dart
M tests/language/primary_constructors/wildcard_declaring_parameters_error_test.dart
A tests/language/regress/regress62664_test.dart
M tests/standalone/regress_52691_test.dart
M tools/VERSION
Log Message:
-----------
Version 3.12.0-176.0.dev
Merge 0ec34ebde6ff5f0308335a39077790ca05c4270c into dev
Compare: https://github.com/dart-lang/sdk/compare/d23cf6c0d633...c2ef934eb893
copybara-service[bot]
4:05 PM (4 hours ago) 4:05 PM
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages