[dart-lang/sdk] 809d8a: CQ. Start removing resolution state from Resolutio...

[Konstantin Scheglov]

Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 809d8a778a3d9861bed36874d11990818d13cfe5
https://github.com/dart-lang/sdk/commit/809d8a778a3d9861bed36874d11990818d13cfe5
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)

Changed paths:
M pkg/analyzer/test/dart/element/fragment_offset_test.dart
M pkg/analyzer/test/error/error_reporter_test.dart
M pkg/analyzer/test/generated/invalid_code_test.dart
M pkg/analyzer/test/generated/issues_test.dart
M pkg/analyzer/test/generated/non_error_resolver_test.dart
M pkg/analyzer/test/generated/resolver_test.dart
M pkg/analyzer/test/generated/resolver_test_case.dart
M pkg/analyzer/test/generated/simple_resolver_test.dart
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
M pkg/analyzer/test/generated/strong_mode_test.dart
M pkg/analyzer/test/src/dart/analysis/driver_caching_test.dart
M pkg/analyzer/test/src/dart/analysis/index_test.dart
M pkg/analyzer/test/src/dart/analysis/results/get_element_declaration_test.dart
M pkg/analyzer/test/src/dart/analysis/search_test.dart
M pkg/analyzer/test/src/dart/analysis/session_helper_test.dart
M pkg/analyzer/test/src/dart/ast/ast_test.dart
M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart
M pkg/analyzer/test/src/dart/constant/potentially_constant_test.dart
M pkg/analyzer/test/src/dart/element/class_element_test.dart
M pkg/analyzer/test/src/dart/element/display_string_test.dart
M pkg/analyzer/test/src/dart/element/element_test.dart
M pkg/analyzer/test/src/dart/element/inheritance_manager3_test.dart
M pkg/analyzer/test/src/dart/micro/file_resolution.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/adjacent_strings_test.dart
M pkg/analyzer/test/src/dart/resolution/as_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/ast_rewrite_test.dart
M pkg/analyzer/test/src/dart/resolution/await_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/binary_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/cascade_expression_resolution_test.dart
M pkg/analyzer/test/src/dart/resolution/cast_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/class_alias_test.dart
M pkg/analyzer/test/src/dart/resolution/class_test.dart
M pkg/analyzer/test/src/dart/resolution/comment_test.dart
M pkg/analyzer/test/src/dart/resolution/conditional_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/constant_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/constant_test.dart
M pkg/analyzer/test/src/dart/resolution/constructor_field_initializer_test.dart
M pkg/analyzer/test/src/dart/resolution/constructor_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/constructor_test.dart
M pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart
M pkg/analyzer/test/src/dart/resolution/declared_variable_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/dot_shorthand_property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/enum_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_override_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_test.dart
M pkg/analyzer/test/src/dart/resolution/extension_type_test.dart
M pkg/analyzer/test/src/dart/resolution/field_formal_parameter_test.dart
M pkg/analyzer/test/src/dart/resolution/field_promotion_test.dart
M pkg/analyzer/test/src/dart/resolution/field_test.dart
M pkg/analyzer/test/src/dart/resolution/for_element_test.dart
M pkg/analyzer/test/src/dart/resolution/for_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/function_body_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/function_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/function_expression_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/function_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
M pkg/analyzer/test/src/dart/resolution/function_type_alias_test.dart
M pkg/analyzer/test/src/dart/resolution/function_typed_formal_parameter_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_function_type_test.dart
M pkg/analyzer/test/src/dart/resolution/generic_type_alias_test.dart
M pkg/analyzer/test/src/dart/resolution/if_element_test.dart
M pkg/analyzer/test/src/dart/resolution/if_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/index_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart
M pkg/analyzer/test/src/dart/resolution/instance_member_inference_class_test.dart
M pkg/analyzer/test/src/dart/resolution/instance_member_inference_mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/interpolation_string_test.dart
M pkg/analyzer/test/src/dart/resolution/is_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/library_directive_test.dart
M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_prefix_test.dart
M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
M pkg/analyzer/test/src/dart/resolution/list_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/list_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/local_function_test.dart
M pkg/analyzer/test/src/dart/resolution/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/logical_and_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/logical_or_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/map_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/metadata_test.dart
M pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart
M pkg/analyzer/test/src/dart/resolution/method_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/mixin_test.dart
M pkg/analyzer/test/src/dart/resolution/named_type_test.dart
M pkg/analyzer/test/src/dart/resolution/non_nullable_test.dart
M pkg/analyzer/test/src/dart/resolution/null_assert_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/null_check_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/object_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/optional_const_test.dart
M pkg/analyzer/test/src/dart/resolution/parenthesized_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/parenthesized_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/part_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_assignment_test.dart
M pkg/analyzer/test/src/dart/resolution/pattern_variable_declaration_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefix_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/property_access_test.dart
M pkg/analyzer/test/src/dart/resolution/record_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/record_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/record_type_annotation_test.dart
M pkg/analyzer/test/src/dart/resolution/redirecting_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/relational_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
M pkg/analyzer/test/src/dart/resolution/scope_test.dart
M pkg/analyzer/test/src/dart/resolution/set_or_map_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/simple_identifier_test.dart
M pkg/analyzer/test/src/dart/resolution/super_constructor_invocation_test.dart
M pkg/analyzer/test/src/dart/resolution/super_formal_parameter_test.dart
M pkg/analyzer/test/src/dart/resolution/switch_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/switch_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/this_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/top_level_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/top_type_inference_test.dart
M pkg/analyzer/test/src/dart/resolution/try_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/collection_elements_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/equality_expressions_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/extension_methods_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/function_expression_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/function_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/inference_update_1_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/list_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/local_variable_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/logical_boolean_expressions_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/map_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/set_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/statements_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/tear_off_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/throw_test.dart
M pkg/analyzer/test/src/dart/resolution/type_inference/type_test_expressions_test.dart
M pkg/analyzer/test/src/dart/resolution/type_literal_test.dart
M pkg/analyzer/test/src/dart/resolution/variable_declaration_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/variance_test.dart
M pkg/analyzer/test/src/dart/resolution/while_statement_test.dart
M pkg/analyzer/test/src/dart/resolution/wildcard_pattern_test.dart
M pkg/analyzer/test/src/dart/resolution/yield_statement_test.dart
M pkg/analyzer/test/src/diagnostics/abstract_super_member_reference_test.dart
M pkg/analyzer/test/src/diagnostics/ambiguous_extension_member_access_test.dart
M pkg/analyzer/test/src/diagnostics/augmentation_type_parameter_count_test.dart
M pkg/analyzer/test/src/diagnostics/const_with_non_const_test.dart
M pkg/analyzer/test/src/diagnostics/constant_pattern_with_non_constant_expression_test.dart
M pkg/analyzer/test/src/diagnostics/default_value_in_function_type_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_rest_element_in_pattern_test.dart
M pkg/analyzer/test/src/diagnostics/duplicate_variable_pattern_test.dart
M pkg/analyzer/test/src/diagnostics/extends_non_class_test.dart
M pkg/analyzer/test/src/diagnostics/extension_as_expression_test.dart
M pkg/analyzer/test/src/diagnostics/extension_override_access_to_static_member_test.dart
M pkg/analyzer/test/src/diagnostics/extension_override_with_cascade_test.dart
M pkg/analyzer/test/src/diagnostics/extension_override_without_access_test.dart
M pkg/analyzer/test/src/diagnostics/extension_type_constructor_with_super_formal_parameter_test.dart
M pkg/analyzer/test/src/diagnostics/extension_type_constructor_with_super_invocation_test.dart
M pkg/analyzer/test/src/diagnostics/extra_positional_arguments_test.dart
M pkg/analyzer/test/src/diagnostics/implements_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/implements_disallowed_class_test.dart
M pkg/analyzer/test/src/diagnostics/implements_repeated_test.dart
M pkg/analyzer/test/src/diagnostics/implements_type_alias_expands_to_type_parameter_test.dart
M pkg/analyzer/test/src/diagnostics/instance_access_to_static_member_test.dart
M pkg/analyzer/test/src/diagnostics/instantiate_abstract_class_test.dart
M pkg/analyzer/test/src/diagnostics/instantiate_type_alias_expands_to_type_parameter_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_extension_argument_count_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_null_aware_operator_test.dart
M pkg/analyzer/test/src/diagnostics/invalid_uri_test.dart
M pkg/analyzer/test/src/diagnostics/invocation_of_non_function_expression_test.dart
M pkg/analyzer/test/src/diagnostics/missing_variable_pattern_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_declares_constructor_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_inference_no_possible_substitution_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_instantiate_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_super_class_constraint_deferred_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_super_class_constraint_disallowed_class_test.dart
M pkg/analyzer/test/src/diagnostics/mixin_super_class_constraint_non_interface_test.dart
M pkg/analyzer/test/src/diagnostics/new_with_non_type_test.dart
M pkg/analyzer/test/src/diagnostics/not_a_type_test.dart
M pkg/analyzer/test/src/diagnostics/null_safety_read_write_test.dart
M pkg/analyzer/test/src/diagnostics/pattern_assignment_not_local_variable_test.dart
M pkg/analyzer/test/src/diagnostics/private_setter_test.dart
M pkg/analyzer/test/src/diagnostics/receiver_of_type_never_test.dart
M pkg/analyzer/test/src/diagnostics/referenced_before_declaration_test.dart
M pkg/analyzer/test/src/diagnostics/refutable_pattern_in_irrefutable_context_test.dart
M pkg/analyzer/test/src/diagnostics/rethrow_outside_catch_test.dart
M pkg/analyzer/test/src/diagnostics/sdk_version_since_test.dart
M pkg/analyzer/test/src/diagnostics/super_in_extension_type_test.dart
M pkg/analyzer/test/src/diagnostics/super_in_invalid_context_test.dart
M pkg/analyzer/test/src/diagnostics/top_level_instance_getter_test.dart
M pkg/analyzer/test/src/diagnostics/type_argument_not_matching_bounds_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_extension_method_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_extension_operator_test.dart
M pkg/analyzer/test/src/diagnostics/undefined_setter_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
M pkg/analyzer/test/src/diagnostics/use_of_void_result_test.dart
M pkg/analyzer/test/src/diagnostics/void_with_type_arguments_test.dart
M pkg/analyzer/test/src/diagnostics/wrong_number_of_type_arguments_extension_test.dart
M pkg/analyzer/test/src/diagnostics/wrong_number_of_type_arguments_test.dart
M pkg/analyzer/test/src/lint/linter/linter_context_impl_test.dart
M pkg/analyzer/test/src/services/top_level_declarations_test.dart
M pkg/analyzer/test/src/summary/top_level_inference_test.dart
M pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart
M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
M pkg/analyzer/test/utilities/dot_shorthands_test.dart

Log Message:
-----------
CQ. Start removing resolution state from ResolutionTest.

We still have `late ResolvedUnitResultImpl result` for now, but many
tests migrated to explicit `TestResolvedUnitResult` and its getters.

Start migrating analyzer resolution tests away from the implicit
ResolutionTest state. Store the TestResolvedUnitResult returned by
resolve helpers in local variables, then read nodes and elements through
that result.

Update helper methods to take the resolved result explicitly when they
need access to findNode or findElement. Also return resolved results
from small wrapper helpers so their callers do not have to depend on
shared state.

This keeps each test tied to the unit it resolved and prepares the test
harness for removing the remaining stored resolution result.

Change-Id: I5e9331fb574d962473e5d36922107f674d7340cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505621
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications