[dart-lang/sdk] 96c0be: CQ. Simplify LineInfoTest, stop using GatheringDia...
0 views
Skip to first unread message
Konstantin Scheglov
11:56 AM (8 hours ago) 11:56 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 96c0be6601d1e9db1763ce45e104194db398fcd1
https://github.com/dart-lang/sdk/commit/96c0be6601d1e9db1763ce45e104194db398fcd1
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/generated/scanner_test.dart
Log Message:
-----------
CQ. Simplify LineInfoTest, stop using GatheringDiagnosticListener.
Change-Id: I7d859f80eb36b9d2e29ccdd013bcdc4c04ed8219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511141
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 96c0be6601d1e9db1763ce45e104194db398fcd1
https://github.com/dart-lang/sdk/commit/96c0be6601d1e9db1763ce45e104194db398fcd1
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/generated/scanner_test.dart
Log Message:
-----------
CQ. Simplify LineInfoTest, stop using GatheringDiagnosticListener.
Change-Id: I7d859f80eb36b9d2e29ccdd013bcdc4c04ed8219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511141
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Konstantin Scheglov
12:33 PM (7 hours ago) 12:33 PM
to com...@dartlang.org
Branch: refs/heads/lkgr
copybara-service[bot]
4:10 PM (3 hours ago) 4:10 PM
to com...@dartlang.org
Branch: refs/heads/dev
https://github.com/dart-lang/sdk/commit/c3c2986b82e473cce7216fb7c56032e6c199a251
M pkg/analyzer/test/src/lint/test_all.dart
Log Message:
-----------
CQ. Remove low value test/src/lint/lint_rule_test.dart
These tests only checked that MultiAnalysisRule.reportAtNode / reportAtToken
forward the supplied DiagnosticCode into DiagnosticReporter.
Change-Id: Iade193431ab28ff4c2ac5f9f77874f1dd3c821cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511200
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 84088f6a8b393cf81204c9b29e2b800e782f2776
https://github.com/dart-lang/sdk/commit/84088f6a8b393cf81204c9b29e2b800e782f2776
Author: Parker Lougheed <parl...@gmail.com>
M pkg/dev_compiler/web/stack_trace_mapper.dart
Log Message:
-----------
[ddc] Migrate stack_trace_mapper to static JS interop
Also removes the dependency on `package:js` as this was the only remaining usage.
Fixes https://github.com/dart-lang/sdk/issues/54574
Change-Id: Icba5bce7fbc087ed2284754656bf06493c516009
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510100
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Commit-Queue: Srujan Gaddam <sru...@google.com>
Reviewed-by: Srujan Gaddam <sru...@google.com>
Commit: 4473de2a5dd987ffd4193dcdb8b086bb4fbb6597
https://github.com/dart-lang/sdk/commit/4473de2a5dd987ffd4193dcdb8b086bb4fbb6597
M pkg/analyzer/test/src/pubspec/diagnostics/asset_directory_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_field_not_list_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_missing_path_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_not_string_or_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_path_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/dependencies_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/deprecated_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/flutter_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/ignore_diagnostic_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_platforms_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_name_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/name_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_not_posix_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_pubspec_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/platform_value_disallowed_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unknown_platforms_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unnecessary_dev_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/workspace_field_test.dart
M pkg/analyzer/test/src/pubspec/pubspec_test_support.dart
Log Message:
-----------
CQ. Use inline expected diagnostics in PubspecDiagnosticTest(s).
Change-Id: Id6f8305c0f5e92ee48cf9c0ac1adc5c2e3a2d490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511240
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 47ba94ebeaeb4b9d6b9e5837d390a339635e7b6a
https://github.com/dart-lang/sdk/commit/47ba94ebeaeb4b9d6b9e5837d390a339635e7b6a
Log Message:
-----------
CQ. Switch ErrorReporterTest to simpler RecordingDiagnosticListener.
Change-Id: Iaf5a243ed0b35c369e254e5541448aab06c48b6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511280
Reviewed-by: Jake Macdonald <jak...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 4b10d3e1d3f258c4823b0966b2a7bf4ea165c8ec
https://github.com/dart-lang/sdk/commit/4b10d3e1d3f258c4823b0966b2a7bf4ea165c8ec
Log Message:
-----------
CQ. Remove GatheringDiagnosticListener.
Change-Id: I1d45d3ea4bf0e556851bf943b95076c11158d9cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511300
https://github.com/dart-lang/sdk/commit/dbeb7e1e5b7c6e23ff7a253f12607edad5129512
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/pubspec.yaml
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
Log Message:
-----------
Prepare to publish analyzer 13.3.0, _fe_analyzer_shared 103.0.0, analysis_server_plugin 0.3.18, analyzer_plugin 0.14.12, analyzer_testing 0.3.2
Change-Id: I0a5bf96733f2908160a6ef2ee99f54ef25f11547
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511480
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 69ed86fda65577f45941619adaf2ceb59749f2c5
https://github.com/dart-lang/sdk/commit/69ed86fda65577f45941619adaf2ceb59749f2c5
Author: Parker Lougheed <parl...@gmail.com>
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/diagnostic.g.dart
M pkg/linter/lib/src/rules/async_return_with_no_await.dart
M pkg/linter/lib/src/rules/empty_container_bodies.dart
M pkg/linter/lib/src/rules/initialize_in_field_declaration.dart
M pkg/linter/lib/src/rules/no_dynamic_casts.dart
M pkg/linter/lib/src/rules/no_raw_types.dart
M pkg/linter/lib/src/rules/simple_directive_paths.dart
M pkg/linter/lib/src/rules/unnecessary_const_in_enum_constructor.dart
M pkg/linter/lib/src/rules/unnecessary_primary_constructor_body.dart
M pkg/linter/lib/src/rules/unnecessary_type_name_in_constructor.dart
M pkg/linter/lib/src/rules/use_declaring_parameters.dart
M pkg/linter/lib/src/rules/use_primary_constructors.dart
M pkg/linter/lib/src/rules/var_with_no_type_annotation.dart
M pkg/linter/messages.yaml
M pkg/linter/tool/machine/rules.json
Log Message:
-----------
[linter] Update docs and state status for latest lints
Change-Id: If6006f5df03f90c50eb2860a3fa17118c8941b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510820
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 916afe3219380c98167f999d238aa25d6585a802
https://github.com/dart-lang/sdk/commit/916afe3219380c98167f999d238aa25d6585a802
Author: Brian Wilkerson <brianwi...@google.com>
A pkg/analysis_server/test/services/completion/dart/declaration/declaring_parameter_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/test_all.dart
Log Message:
-----------
Suggest fields from declaring parameters in completions
This was preventing suggesting fields from declaring parameters
everywhere.
Closes https://github.com/dart-lang/sdk/issues/63537
Change-Id: I552f85275c6a1aebaa4a50af88d661bc7e3d6492
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511040
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 0f9e6da04454017f61e96532772ecee4df4238f7
https://github.com/dart-lang/sdk/commit/0f9e6da04454017f61e96532772ecee4df4238f7
Author: Kallen Tu <kall...@google.com>
M pkg/analysis_server/test/verify_sorted_test.dart
M pkg/analysis_server/tool/code_completion/code_metrics.dart
M pkg/analysis_server/tool/code_completion/completion_metrics_base.dart
M pkg/analysis_server/tool/code_completion/flutter_metrics.dart
M pkg/analysis_server/tool/code_completion/implicit_type_declarations.dart
M pkg/analysis_server/tool/code_completion/relevance_metrics.dart
M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/api.txt
M pkg/analyzer/lib/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart
M pkg/analyzer_utilities/lib/verify_tests.dart
Log Message:
-----------
API - Deprecate the `excludedPaths` parameter in `AnalysisContextCollection`.
Path exclusions should ideally be defined inside a project's
`analysis_options.yaml` file, rather than being added programatically.
Plus, there's a bug with the constructor that causes this parameter to
be completely ignored anyways, so it's been obsolete and non-functional
for a while now. `getExcludedGlobs` in the `_ContextLocator` handles
parsing and adding excluded paths from the analysis server already, so
we should look into deprecating and removing this parameter.
Change-Id: I6c023041c7bb5fa4cb9dedc629afa4ea6ecb63d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511160
Commit-Queue: Kallen Tu <kall...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit: bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc
https://github.com/dart-lang/sdk/commit/bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc
Author: Nourhan Hasan <nourhan...@gmail.com>
M runtime/vm/os_macos.cc
M runtime/vm/service.cc
M runtime/vm/service_test.cc
Log Message:
-----------
[vm/service]: Add OS::SafeReadMemory for macOS using mach_vm_read_overwrite
TEST=runtime/vm/service_test.cc
Cq-Include-Trybots: dart/try:vm-asan-mac-release-arm64-try,vm-dyn-mac-debug-arm64-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-mac-release-arm64-try
Change-Id: I1be990f3debb7e0b7102f54e8c5bec25252756d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507040
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Reviewed-by: Ben Konyi <bko...@google.com>
Commit: 43e22158f7590fd9e3def8b4819afa7728886487
https://github.com/dart-lang/sdk/commit/43e22158f7590fd9e3def8b4819afa7728886487
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
M pkg/_fe_analyzer_shared/pubspec.yaml
M pkg/analysis_server/lib/src/context_manager.dart
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
A pkg/analysis_server/test/services/completion/dart/declaration/declaring_parameter_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/test_all.dart
M pkg/analysis_server/test/verify_sorted_test.dart
M pkg/analysis_server/tool/code_completion/code_metrics.dart
M pkg/analysis_server/tool/code_completion/completion_metrics_base.dart
M pkg/analysis_server/tool/code_completion/flutter_metrics.dart
M pkg/analysis_server/tool/code_completion/implicit_type_declarations.dart
M pkg/analysis_server/tool/code_completion/relevance_metrics.dart
M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/api.txt
M pkg/analyzer/lib/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/pubspec.yaml
M pkg/analyzer/test/error/error_reporter_test.dart
M pkg/analyzer/test/generated/scanner_test.dart
R pkg/analyzer/test/generated/test_support.dart
M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
R pkg/analyzer/test/src/lint/lint_rule_test.dart
M pkg/analyzer/test/src/lint/test_all.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_directory_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_field_not_list_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_missing_path_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_not_string_or_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_path_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/dependencies_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/deprecated_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/flutter_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/ignore_diagnostic_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_platforms_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_name_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/name_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_not_posix_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_pubspec_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/platform_value_disallowed_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unknown_platforms_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unnecessary_dev_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/workspace_field_test.dart
M pkg/analyzer/test/src/pubspec/pubspec_test_support.dart
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/analyzer_utilities/lib/verify_tests.dart
M pkg/dev_compiler/pubspec.yaml
M pkg/dev_compiler/web/stack_trace_mapper.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/diagnostic.g.dart
M pkg/linter/lib/src/rules/async_return_with_no_await.dart
M pkg/linter/lib/src/rules/empty_container_bodies.dart
M pkg/linter/lib/src/rules/initialize_in_field_declaration.dart
M pkg/linter/lib/src/rules/no_dynamic_casts.dart
M pkg/linter/lib/src/rules/no_raw_types.dart
M pkg/linter/lib/src/rules/simple_directive_paths.dart
M pkg/linter/lib/src/rules/unnecessary_const_in_enum_constructor.dart
M pkg/linter/lib/src/rules/unnecessary_primary_constructor_body.dart
M pkg/linter/lib/src/rules/unnecessary_type_name_in_constructor.dart
M pkg/linter/lib/src/rules/use_declaring_parameters.dart
M pkg/linter/lib/src/rules/use_primary_constructors.dart
M pkg/linter/lib/src/rules/var_with_no_type_annotation.dart
M pkg/linter/messages.yaml
M pkg/linter/tool/machine/rules.json
M runtime/tests/vm/vm.status
M runtime/vm/os_macos.cc
M runtime/vm/service.cc
M runtime/vm/service_test.cc
M tools/VERSION
Log Message:
-----------
Version 3.13.0-199.0.dev
Merge bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc into dev
Compare: https://github.com/dart-lang/sdk/compare/85575e357568...43e22158f759
Home: https://github.com/dart-lang/sdk
Commit: 96c0be6601d1e9db1763ce45e104194db398fcd1
https://github.com/dart-lang/sdk/commit/96c0be6601d1e9db1763ce45e104194db398fcd1
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/generated/scanner_test.dart
Log Message:
-----------
CQ. Simplify LineInfoTest, stop using GatheringDiagnosticListener.
Change-Id: I7d859f80eb36b9d2e29ccdd013bcdc4c04ed8219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511141
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: c3c2986b82e473cce7216fb7c56032e6c199a251
Commit: 96c0be6601d1e9db1763ce45e104194db398fcd1
https://github.com/dart-lang/sdk/commit/96c0be6601d1e9db1763ce45e104194db398fcd1
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/generated/scanner_test.dart
Log Message:
-----------
CQ. Simplify LineInfoTest, stop using GatheringDiagnosticListener.
Change-Id: I7d859f80eb36b9d2e29ccdd013bcdc4c04ed8219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511141
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
https://github.com/dart-lang/sdk/commit/c3c2986b82e473cce7216fb7c56032e6c199a251
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
R pkg/analyzer/test/src/lint/lint_rule_test.dart
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/src/lint/test_all.dart
Log Message:
-----------
CQ. Remove low value test/src/lint/lint_rule_test.dart
These tests only checked that MultiAnalysisRule.reportAtNode / reportAtToken
forward the supplied DiagnosticCode into DiagnosticReporter.
Change-Id: Iade193431ab28ff4c2ac5f9f77874f1dd3c821cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511200
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 84088f6a8b393cf81204c9b29e2b800e782f2776
https://github.com/dart-lang/sdk/commit/84088f6a8b393cf81204c9b29e2b800e782f2776
Author: Parker Lougheed <parl...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/dev_compiler/pubspec.yaml
Changed paths:
M pkg/dev_compiler/web/stack_trace_mapper.dart
Log Message:
-----------
[ddc] Migrate stack_trace_mapper to static JS interop
Also removes the dependency on `package:js` as this was the only remaining usage.
Fixes https://github.com/dart-lang/sdk/issues/54574
Change-Id: Icba5bce7fbc087ed2284754656bf06493c516009
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510100
Reviewed-by: Nicholas Shahan <nsh...@google.com>
Commit-Queue: Srujan Gaddam <sru...@google.com>
Reviewed-by: Srujan Gaddam <sru...@google.com>
Commit: 4473de2a5dd987ffd4193dcdb8b086bb4fbb6597
https://github.com/dart-lang/sdk/commit/4473de2a5dd987ffd4193dcdb8b086bb4fbb6597
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/src/pubspec/diagnostics/asset_directory_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_field_not_list_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_missing_path_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_not_string_or_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_path_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/dependencies_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/deprecated_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/flutter_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/ignore_diagnostic_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_platforms_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_name_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/name_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_not_posix_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_pubspec_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/platform_value_disallowed_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unknown_platforms_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unnecessary_dev_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/workspace_field_test.dart
M pkg/analyzer/test/src/pubspec/pubspec_test_support.dart
Log Message:
-----------
CQ. Use inline expected diagnostics in PubspecDiagnosticTest(s).
Change-Id: Id6f8305c0f5e92ee48cf9c0ac1adc5c2e3a2d490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511240
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 47ba94ebeaeb4b9d6b9e5837d390a339635e7b6a
https://github.com/dart-lang/sdk/commit/47ba94ebeaeb4b9d6b9e5837d390a339635e7b6a
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analyzer/test/error/error_reporter_test.dart
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
Log Message:
-----------
CQ. Switch ErrorReporterTest to simpler RecordingDiagnosticListener.
Change-Id: Iaf5a243ed0b35c369e254e5541448aab06c48b6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511280
Reviewed-by: Jake Macdonald <jak...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: 4b10d3e1d3f258c4823b0966b2a7bf4ea165c8ec
https://github.com/dart-lang/sdk/commit/4b10d3e1d3f258c4823b0966b2a7bf4ea165c8ec
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
R pkg/analyzer/test/generated/test_support.dart
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
Log Message:
-----------
CQ. Remove GatheringDiagnosticListener.
Change-Id: I1d45d3ea4bf0e556851bf943b95076c11158d9cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511300
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit: dbeb7e1e5b7c6e23ff7a253f12607edad5129512
Reviewed-by: Johnni Winther <johnni...@google.com>
https://github.com/dart-lang/sdk/commit/dbeb7e1e5b7c6e23ff7a253f12607edad5129512
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/_fe_analyzer_shared/pubspec.yaml
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/pubspec.yaml
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
Log Message:
-----------
Prepare to publish analyzer 13.3.0, _fe_analyzer_shared 103.0.0, analysis_server_plugin 0.3.18, analyzer_plugin 0.14.12, analyzer_testing 0.3.2
Change-Id: I0a5bf96733f2908160a6ef2ee99f54ef25f11547
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511480
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 69ed86fda65577f45941619adaf2ceb59749f2c5
https://github.com/dart-lang/sdk/commit/69ed86fda65577f45941619adaf2ceb59749f2c5
Author: Parker Lougheed <parl...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M CHANGELOG.md
Changed paths:
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/diagnostic.g.dart
M pkg/linter/lib/src/rules/async_return_with_no_await.dart
M pkg/linter/lib/src/rules/empty_container_bodies.dart
M pkg/linter/lib/src/rules/initialize_in_field_declaration.dart
M pkg/linter/lib/src/rules/no_dynamic_casts.dart
M pkg/linter/lib/src/rules/no_raw_types.dart
M pkg/linter/lib/src/rules/simple_directive_paths.dart
M pkg/linter/lib/src/rules/unnecessary_const_in_enum_constructor.dart
M pkg/linter/lib/src/rules/unnecessary_primary_constructor_body.dart
M pkg/linter/lib/src/rules/unnecessary_type_name_in_constructor.dart
M pkg/linter/lib/src/rules/use_declaring_parameters.dart
M pkg/linter/lib/src/rules/use_primary_constructors.dart
M pkg/linter/lib/src/rules/var_with_no_type_annotation.dart
M pkg/linter/messages.yaml
M pkg/linter/tool/machine/rules.json
Log Message:
-----------
[linter] Update docs and state status for latest lints
Change-Id: If6006f5df03f90c50eb2860a3fa17118c8941b36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510820
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 916afe3219380c98167f999d238aa25d6585a802
https://github.com/dart-lang/sdk/commit/916afe3219380c98167f999d238aa25d6585a802
Author: Brian Wilkerson <brianwi...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
Changed paths:
A pkg/analysis_server/test/services/completion/dart/declaration/declaring_parameter_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/test_all.dart
Log Message:
-----------
Suggest fields from declaring parameters in completions
This was preventing suggesting fields from declaring parameters
everywhere.
Closes https://github.com/dart-lang/sdk/issues/63537
Change-Id: I552f85275c6a1aebaa4a50af88d661bc7e3d6492
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511040
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Commit: 0f9e6da04454017f61e96532772ecee4df4238f7
https://github.com/dart-lang/sdk/commit/0f9e6da04454017f61e96532772ecee4df4238f7
Author: Kallen Tu <kall...@google.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M pkg/analysis_server/lib/src/context_manager.dart
Changed paths:
M pkg/analysis_server/test/verify_sorted_test.dart
M pkg/analysis_server/tool/code_completion/code_metrics.dart
M pkg/analysis_server/tool/code_completion/completion_metrics_base.dart
M pkg/analysis_server/tool/code_completion/flutter_metrics.dart
M pkg/analysis_server/tool/code_completion/implicit_type_declarations.dart
M pkg/analysis_server/tool/code_completion/relevance_metrics.dart
M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/api.txt
M pkg/analyzer/lib/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart
M pkg/analyzer_utilities/lib/verify_tests.dart
Log Message:
-----------
API - Deprecate the `excludedPaths` parameter in `AnalysisContextCollection`.
Path exclusions should ideally be defined inside a project's
`analysis_options.yaml` file, rather than being added programatically.
Plus, there's a bug with the constructor that causes this parameter to
be completely ignored anyways, so it's been obsolete and non-functional
for a while now. `getExcludedGlobs` in the `_ContextLocator` handles
parsing and adding excluded paths from the analysis server already, so
we should look into deprecating and removing this parameter.
Change-Id: I6c023041c7bb5fa4cb9dedc629afa4ea6ecb63d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/511160
Commit-Queue: Kallen Tu <kall...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit: bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc
https://github.com/dart-lang/sdk/commit/bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc
Author: Nourhan Hasan <nourhan...@gmail.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M runtime/tests/vm/vm.status
Changed paths:
M runtime/vm/os_macos.cc
M runtime/vm/service.cc
M runtime/vm/service_test.cc
Log Message:
-----------
[vm/service]: Add OS::SafeReadMemory for macOS using mach_vm_read_overwrite
TEST=runtime/vm/service_test.cc
Cq-Include-Trybots: dart/try:vm-asan-mac-release-arm64-try,vm-dyn-mac-debug-arm64-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-tsan-mac-release-arm64-try,vm-ubsan-mac-release-arm64-try
Change-Id: I1be990f3debb7e0b7102f54e8c5bec25252756d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507040
Reviewed-by: Daco Harkes <dacoh...@google.com>
Commit-Queue: Daco Harkes <dacoh...@google.com>
Reviewed-by: Ben Konyi <bko...@google.com>
Commit: 43e22158f7590fd9e3def8b4819afa7728886487
https://github.com/dart-lang/sdk/commit/43e22158f7590fd9e3def8b4819afa7728886487
Author: Dart CI <dart-inte...@dart-ci-internal.iam.gserviceaccount.com>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
M CHANGELOG.md
Changed paths:
M pkg/_fe_analyzer_shared/pubspec.yaml
M pkg/analysis_server/lib/src/context_manager.dart
M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
A pkg/analysis_server/test/services/completion/dart/declaration/declaring_parameter_test.dart
M pkg/analysis_server/test/services/completion/dart/declaration/test_all.dart
M pkg/analysis_server/test/verify_sorted_test.dart
M pkg/analysis_server/tool/code_completion/code_metrics.dart
M pkg/analysis_server/tool/code_completion/completion_metrics_base.dart
M pkg/analysis_server/tool/code_completion/flutter_metrics.dart
M pkg/analysis_server/tool/code_completion/implicit_type_declarations.dart
M pkg/analysis_server/tool/code_completion/relevance_metrics.dart
M pkg/analysis_server/tool/code_completion/relevance_table_generator.dart
M pkg/analysis_server_plugin/CHANGELOG.md
M pkg/analysis_server_plugin/lib/src/plugin_server.dart
M pkg/analysis_server_plugin/pubspec.yaml
M pkg/analyzer/CHANGELOG.md
M pkg/analyzer/api.txt
M pkg/analyzer/lib/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart
M pkg/analyzer/pubspec.yaml
M pkg/analyzer/test/error/error_reporter_test.dart
M pkg/analyzer/test/generated/scanner_test.dart
R pkg/analyzer/test/generated/test_support.dart
M pkg/analyzer/test/src/dart/resolution/node_text_expectations.dart
R pkg/analyzer/test/src/lint/lint_rule_test.dart
M pkg/analyzer/test/src/lint/test_all.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_directory_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_field_not_list_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_missing_path_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_not_string_or_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/asset_path_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/dependencies_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/deprecated_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/flutter_field_not_map_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/ignore_diagnostic_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/invalid_platforms_field_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/missing_name_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/name_not_string_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_not_posix_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/path_pubspec_does_not_exist_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/platform_value_disallowed_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unknown_platforms_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/unnecessary_dev_dependency_test.dart
M pkg/analyzer/test/src/pubspec/diagnostics/workspace_field_test.dart
M pkg/analyzer/test/src/pubspec/pubspec_test_support.dart
M pkg/analyzer_plugin/CHANGELOG.md
M pkg/analyzer_plugin/pubspec.yaml
M pkg/analyzer_testing/CHANGELOG.md
M pkg/analyzer_testing/pubspec.yaml
M pkg/analyzer_utilities/lib/verify_tests.dart
M pkg/dev_compiler/pubspec.yaml
M pkg/dev_compiler/web/stack_trace_mapper.dart
M pkg/linter/CHANGELOG.md
M pkg/linter/lib/src/diagnostic.g.dart
M pkg/linter/lib/src/rules/async_return_with_no_await.dart
M pkg/linter/lib/src/rules/empty_container_bodies.dart
M pkg/linter/lib/src/rules/initialize_in_field_declaration.dart
M pkg/linter/lib/src/rules/no_dynamic_casts.dart
M pkg/linter/lib/src/rules/no_raw_types.dart
M pkg/linter/lib/src/rules/simple_directive_paths.dart
M pkg/linter/lib/src/rules/unnecessary_const_in_enum_constructor.dart
M pkg/linter/lib/src/rules/unnecessary_primary_constructor_body.dart
M pkg/linter/lib/src/rules/unnecessary_type_name_in_constructor.dart
M pkg/linter/lib/src/rules/use_declaring_parameters.dart
M pkg/linter/lib/src/rules/use_primary_constructors.dart
M pkg/linter/lib/src/rules/var_with_no_type_annotation.dart
M pkg/linter/messages.yaml
M pkg/linter/tool/machine/rules.json
M runtime/tests/vm/vm.status
M runtime/vm/os_macos.cc
M runtime/vm/service.cc
M runtime/vm/service_test.cc
M tools/VERSION
Log Message:
-----------
Version 3.13.0-199.0.dev
Merge bd5ccf95d11dec6c4bbf52e1996a364ec9c785bc into dev
Compare: https://github.com/dart-lang/sdk/compare/85575e357568...43e22158f759
copybara-service[bot]
5:07 PM (3 hours ago) 5:07 PM
to com...@dartlang.org
Branch: refs/heads/lkgr-dev
Reply all
Reply to author
Forward
0 new messages