[dart-lang/sdk] 643733: [analyzer etc] Add ignores for codegen to prepare ...
0 views
Skip to first unread message
Paul Berry
May 22, 2026, 1:31:18 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 643733b42eef0b803d404c43a6f3934346889c32
https://github.com/dart-lang/sdk/commit/643733b42eef0b803d404c43a6f3934346889c32
Author: Paul Berry <paul...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analysis_server/integration_test/support/integration_test_methods.dart
M pkg/analysis_server/integration_test/support/protocol_matchers.dart
M pkg/analysis_server/lib/protocol/protocol_constants.dart
M pkg/analysis_server/lib/protocol/protocol_generated.dart
M pkg/analysis_server_client/lib/handler/notification_handler.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_constants.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart
M pkg/analyzer_utilities/lib/tools.dart
Log Message:
-----------
[analyzer etc] Add ignores for codegen to prepare for new syntax.
(Part of https://github.com/dart-lang/sdk/issues/63288)
Updates the `CodeGenerator` mixin so that it outputs `ignore_for_file`
comments to ignore the following lints:
- unnecessary_type_name_in_constructor
- unnecessary_ignore
- duplicate_ignore
This mixin is used by the code generators that produce the Dart
wrappers for the analysis server and analyzer plugin wire protocols.
This is a first step towards migrating the packages `analysis_server`,
`analysis_server_client`, and `analyzer_plugin` packages to use the
new constructor declaration syntax, since it will allow the
`unnecessary_type_name_in_constructor` lint to be enabled without
breaking generated code.
Once all the packages have had their SDK constraints bumped to a
language version that supports the new syntax, I'll update the code
generator to use the new syntax, and remove the ignores.
For more information about the new constructor declaration syntax, see
https://github.com/dart-lang/language/blob/main/accepted/future-releases/primary-constructors/feature-specification.md#abbreviations-of-in-body-constructor-declarations.
Change-Id: Ied17e3ea772546675aad48efc324f6f16a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505521
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Home: https://github.com/dart-lang/sdk
Commit: 643733b42eef0b803d404c43a6f3934346889c32
https://github.com/dart-lang/sdk/commit/643733b42eef0b803d404c43a6f3934346889c32
Author: Paul Berry <paul...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analysis_server/integration_test/support/integration_test_methods.dart
M pkg/analysis_server/integration_test/support/protocol_matchers.dart
M pkg/analysis_server/lib/protocol/protocol_constants.dart
M pkg/analysis_server/lib/protocol/protocol_generated.dart
M pkg/analysis_server_client/lib/handler/notification_handler.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_constants.dart
M pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart
M pkg/analyzer_plugin/lib/protocol/protocol_common.dart
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart
M pkg/analyzer_utilities/lib/tools.dart
Log Message:
-----------
[analyzer etc] Add ignores for codegen to prepare for new syntax.
(Part of https://github.com/dart-lang/sdk/issues/63288)
Updates the `CodeGenerator` mixin so that it outputs `ignore_for_file`
comments to ignore the following lints:
- unnecessary_type_name_in_constructor
- unnecessary_ignore
- duplicate_ignore
This mixin is used by the code generators that produce the Dart
wrappers for the analysis server and analyzer plugin wire protocols.
This is a first step towards migrating the packages `analysis_server`,
`analysis_server_client`, and `analyzer_plugin` packages to use the
new constructor declaration syntax, since it will allow the
`unnecessary_type_name_in_constructor` lint to be enabled without
breaking generated code.
Once all the packages have had their SDK constraints bumped to a
language version that supports the new syntax, I'll update the code
generator to use the new syntax, and remove the ignores.
For more information about the new constructor declaration syntax, see
https://github.com/dart-lang/language/blob/main/accepted/future-releases/primary-constructors/feature-specification.md#abbreviations-of-in-body-constructor-declarations.
Change-Id: Ied17e3ea772546675aad48efc324f6f16a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505521
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications
Kevin Moore
May 22, 2026, 2:57:45 PM (2 days ago) May 22
to com...@dartlang.org
Branch: refs/heads/lkgr
Commit: 3fd2becefd22be97ad8a6dffa70ec89666bc6595
https://github.com/dart-lang/sdk/commit/3fd2becefd22be97ad8a6dffa70ec89666bc6595
M pkg/analysis_server_client/lib/src/protocol/protocol_base.dart
M pkg/telemetry/lib/crash_reporting.dart
M pkg/telemetry/lib/src/pii_regexp.dart
Log Message:
-----------
Reformat some files owned by the developer experience team.
This will avoid some merge conflicts in a follow-up CL I'm working on
that will enable the lints `unnecessary_type_name_in_constructor` and
`unnecessary_const_in_enum_constructor` (and will fix declarations
accordingly).
Change-Id: Ib8be02dc241732a0eb50727618bb2dda6a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505043
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 57cac82bb6a603970c157085eeca42dd69e28d76
https://github.com/dart-lang/sdk/commit/57cac82bb6a603970c157085eeca42dd69e28d76
Author: Konstantin Shcheglov <sche...@google.com>
M pkg/analyzer/test/src/dart/constant/potentially_constant_test.dart
M pkg/analyzer/test/src/dart/element/flatten_type_test.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
Log Message:
-----------
CQ. Remove ResolutionTest type convenience getters.
Stop exposing common type and element shortcuts from ResolutionTest so
tests use the resolved unit's TypeProvider and library state directly.
This keeps the shared resolution test mixin focused on resolution
utilities instead of duplicating accessors for analyzer internals.
Move the affected flatten coverage out of StaticTypeAnalyzerTest and
into the dedicated built-type tests. This keeps flatten, futureType, and
unionFreeType behavior together in FlattenTypeTest and related test
classes, including coverage for recursive hierarchies and conflicting
Future interfaces.
Update remaining callers to read the library feature set from the
resolved result, and remove assertions that depended on the deleted
ResolutionTest element shortcuts.
Change-Id: I714aec736636500b293b547972a64dc0541172a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505500
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: db8ee607eec87118a7d9dcd6163a9b435df5b706
https://github.com/dart-lang/sdk/commit/db8ee607eec87118a7d9dcd6163a9b435df5b706
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>
Log Message:
-----------
Roll Fuchsia SDK from 32.20260514.4.1 to 32.20260521.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3...@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ic93803fa6aa7dafed6046f0f16bcaf2667cfe8af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505420
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit: 7679be813fc4453c7a87e221a1c8cdfed844e69d
https://github.com/dart-lang/sdk/commit/7679be813fc4453c7a87e221a1c8cdfed844e69d
Author: kevmoo <kev...@google.com>
Log Message:
-----------
[dart2wasm] cleanup owners
Change-Id: I63e9b69a07471641aaf32f7d0cdbbc4cd73877ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502260
Auto-Submit: Kevin Moore <kev...@google.com>
Commit-Queue: Nate Biggs <nate...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/1e1ecd8b41e2...7679be813fc4
https://github.com/dart-lang/sdk/commit/3fd2becefd22be97ad8a6dffa70ec89666bc6595
M pkg/analysis_server_client/lib/src/protocol/protocol_base.dart
M pkg/telemetry/lib/crash_reporting.dart
M pkg/telemetry/lib/src/pii_regexp.dart
Log Message:
-----------
Reformat some files owned by the developer experience team.
This will avoid some merge conflicts in a follow-up CL I'm working on
that will enable the lints `unnecessary_type_name_in_constructor` and
`unnecessary_const_in_enum_constructor` (and will fix declarations
accordingly).
Change-Id: Ib8be02dc241732a0eb50727618bb2dda6a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505043
Commit-Queue: Paul Berry <paul...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit: 57cac82bb6a603970c157085eeca42dd69e28d76
https://github.com/dart-lang/sdk/commit/57cac82bb6a603970c157085eeca42dd69e28d76
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M pkg/analyzer/test/generated/static_type_analyzer_test.dart
Changed paths:
M pkg/analyzer/test/src/dart/constant/potentially_constant_test.dart
M pkg/analyzer/test/src/dart/element/flatten_type_test.dart
M pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart
M pkg/analyzer/test/src/dart/resolution/resolution.dart
Log Message:
-----------
CQ. Remove ResolutionTest type convenience getters.
Stop exposing common type and element shortcuts from ResolutionTest so
tests use the resolved unit's TypeProvider and library state directly.
This keeps the shared resolution test mixin focused on resolution
utilities instead of duplicating accessors for analyzer internals.
Move the affected flatten coverage out of StaticTypeAnalyzerTest and
into the dedicated built-type tests. This keeps flatten, futureType, and
unionFreeType behavior together in FlattenTypeTest and related test
classes, including coverage for recursive hierarchies and conflicting
Future interfaces.
Update remaining callers to read the library feature set from the
resolved result, and remove assertions that depended on the deleted
ResolutionTest element shortcuts.
Change-Id: I714aec736636500b293b547972a64dc0541172a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505500
Reviewed-by: Paul Berry <paul...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Commit: db8ee607eec87118a7d9dcd6163a9b435df5b706
https://github.com/dart-lang/sdk/commit/db8ee607eec87118a7d9dcd6163a9b435df5b706
Author: dart-a...@skia-public.iam.gserviceaccount.com <dart-a...@skia-public.iam.gserviceaccount.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M DEPS
Changed paths:
Log Message:
-----------
Roll Fuchsia SDK from 32.20260514.4.1 to 32.20260521.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC fuchsia-3...@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try;luci.dart.try:vm-fuchsia-release-arm64-try
Change-Id: Ic93803fa6aa7dafed6046f0f16bcaf2667cfe8af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/505420
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Alexander Aprelev <a...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Commit: 7679be813fc4453c7a87e221a1c8cdfed844e69d
https://github.com/dart-lang/sdk/commit/7679be813fc4453c7a87e221a1c8cdfed844e69d
Author: kevmoo <kev...@google.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M tools/OWNERS_WASM
Changed paths:
Log Message:
-----------
[dart2wasm] cleanup owners
Change-Id: I63e9b69a07471641aaf32f7d0cdbbc4cd73877ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502260
Auto-Submit: Kevin Moore <kev...@google.com>
Commit-Queue: Nate Biggs <nate...@google.com>
Reviewed-by: Nate Biggs <nate...@google.com>
Compare: https://github.com/dart-lang/sdk/compare/1e1ecd8b41e2...7679be813fc4
Reply all
Reply to author
Forward
0 new messages