[dart-lang/sdk] b4254d: CQ. Change _isTopGetter to check for GetterElement.

0 views
Skip to first unread message

Konstantin Scheglov

unread,
10:46 AM (3 hours ago) 10:46 AM
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: b4254d0946f4a960347cc7f836701e636ee735cd
https://github.com/dart-lang/sdk/commit/b4254d0946f4a960347cc7f836701e636ee735cd
Author: Konstantin Shcheglov <sche...@google.com>
Date: 2026-04-29 (Wed, 29 Apr 2026)

Changed paths:
M pkg/analyzer/lib/src/dart/element/element.dart

Log Message:
-----------
CQ. Change _isTopGetter to check for GetterElement.

We want a getter, we now check that it is really a getter, and not a
setter. Theoretically a bug, but libraries that are tested had only
getters.

Change-Id: Ie0e76dd2c72c63619f94fb24929942fba2d14b30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499020
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Konstantin Scheglov

unread,
11:25 AM (2 hours ago) 11:25 AM
to com...@dartlang.org
Branch: refs/heads/lkgr
Reply all
Reply to author
Forward
0 new messages