[dart-lang/sdk] 190cfb: Update ConvertFieldFormalToNormal to handle privat...

0 views
Skip to first unread message

Bob Nystrom

unread,
Jan 17, 2026, 2:05:53 PM (15 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/main
Home: https://github.com/dart-lang/sdk
Commit: 190cfb49ab70d0e30184321d4956aef74cc47b9d
https://github.com/dart-lang/sdk/commit/190cfb49ab70d0e30184321d4956aef74cc47b9d
Author: Robert Nystrom <rnys...@google.com>
Date: 2026-01-17 (Sat, 17 Jan 2026)

Changed paths:
M pkg/analysis_server/lib/src/services/correction/dart/convert_field_formal_to_normal.dart
M pkg/analysis_server/test/src/services/correction/assist/convert_field_formal_to_normal_test.dart

Log Message:
-----------
Update ConvertFieldFormalToNormal to handle private named parameters.

This does need an actual change in the implementation. It's pretty
simple. If we are converting a private named initializing formal to a
normal formal, then we:

- Change the parameter in the parameter list to the corresponding
public name.

- Use the same public name in the initializer.

Bug: https://github.com/dart-lang/sdk/issues/62436
Change-Id: I8c66ea02d0c6ceb870afd350fd6a1e6fc0b0f82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/473943
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/dart-lang/sdk/settings/notifications

Bob Nystrom

unread,
Jan 17, 2026, 3:02:33 PM (14 hours ago) Jan 17
to com...@dartlang.org
Branch: refs/heads/lkgr
Reply all
Reply to author
Forward
0 new messages