Issue 23336 in dart: Emit more detailed source map identifiers

5 views
Skip to first unread message

da...@googlecode.com

unread,
Apr 28, 2015, 3:47:34 PM4/28/15
to bu...@dartlang.org
Status: Triaged
Owner: ----
Labels: Type-Enhancement Priority-Unassigned Area-Dart2JS

New issue 23336 by nw...@google.com: Emit more detailed source map
identifiers
https://code.google.com/p/dart/issues/detail?id=23336

I'm working on some code to convert dart2js stack traces to traces that
look like native Dart code using source maps, but I'm running into a tricky
situation. I'd like to use the source map's provided identifiers for
indicating where in the program a given stack frame came from, but they're
very coarse-grained. They don't have any information about the containing
classes, and closures are usually just the identifier "call".

It would be great if these could be as detailed as the VM's stack trace
frames. For example, instead of "_propagateToListeners", it would
be "Future._propagateToListeners". Instead of "call", it would
be "main.<anonymous function>".

This is important for running and debugging browser tests.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

da...@googlecode.com

unread,
May 6, 2015, 5:44:24 PM5/6/15
to bu...@dartlang.org
Updates:
Owner: johnniwi...@google.com

Comment #1 on issue 23336 by floi...@google.com: Emit more detailed source
map identifiers
https://code.google.com/p/dart/issues/detail?id=23336

(No comment was entered for this change.)

da...@googlecode.com

unread,
May 6, 2015, 5:45:24 PM5/6/15
to bu...@dartlang.org

Comment #2 on issue 23336 by floi...@google.com: Emit more detailed source
map identifiers
https://code.google.com/p/dart/issues/detail?id=23336

If sourcemaps don't allow us to provide enough information we should
consider emitting a different file.

da...@googlecode.com

unread,
May 6, 2015, 5:46:24 PM5/6/15
to bu...@dartlang.org

Comment #3 on issue 23336 by floi...@google.com: Emit more detailed source
map identifiers
https://code.google.com/p/dart/issues/detail?id=23336

Pressed "save changes" too fast.

... or add the information to the dump-info file.

da...@googlecode.com

unread,
May 7, 2015, 2:51:42 AM5/7/15
to bu...@dartlang.org
Updates:
Status: Started

Comment #4 on issue 23336 by johnniwi...@google.com: Emit more detailed
(No comment was entered for this change.)

da...@googlecode.com

unread,
Jun 2, 2015, 8:25:19 AM6/2/15
to bu...@dartlang.org
Updates:
Status: Fixed

Comment #5 on issue 23336 by johnniwi...@google.com: Emit more detailed
Fixed in https://codereview.chromium.org/1139693002/
Reply all
Reply to author
Forward
0 new messages