Issue 6569 in dart: String.trim doesn't remove non-ascii whitespace

[da...@googlecode.com]

Status: Triaged
Owner: ----
Labels: Type-Defect Priority-Medium Area-Library

New issue 6569 by floi...@google.com: String.trim doesn't remove non-ascii
whitespace
http://code.google.com/p/dart/issues/detail?id=6569

From bug 6499:
there is way to get from DOM node a string with 'NO-BREAK SPACE' (U+00A0)
and current string methods do not account for it as a whitespace.

[da...@googlecode.com]

Updates:
Owner: csha...@google.com

Comment #1 on issue 6569 by erik...@google.com: String.trim doesn't

remove non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

(No comment was entered for this change.)

[da...@googlecode.com]

Updates:
Owner: erik...@google.com

Comment #2 on issue 6569 by csha...@google.com: String.trim doesn't remove
non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

This is labeled as a library issue so I am unsure why this is assigned to
me.

[da...@googlecode.com]

Updates:
Owner: as...@google.com

Comment #3 on issue 6569 by erik...@google.com: String.trim doesn't

remove non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

The implementation is in the VM in C++

[da...@googlecode.com]

Updates:
Status: NeedsInfo
Owner: erik...@google.com

Comment #4 on issue 6569 by csha...@google.com: String.trim doesn't remove
non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

The String.trim method I know of in runtime/vm/lib/string_base.dart. This
is dart code, not C++ code.

We might be talking about different implementations of String.trim. If so,
a pointer would be helpful.

[da...@googlecode.com]

Updates:
Owner: kas...@google.com

Comment #5 on issue 6569 by erik...@google.com: String.trim doesn't

remove non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

You are right, it is dart code. The real issue is with string_base.dart's
_isWhitespace functions.

Assigning to Kasper for triage. I'm working on dart2js and this is not my
area. I took the bug because I thought I could fix it as part of another
change, but that did not work out and I am not eager to return to
unicode-related work, especially not stuff that is near the VM, where
transatlantic code review frustrations are likely to arise.

[da...@googlecode.com]

Updates:
Status: Triaged
Owner: ---
Cc: floi...@google.com

Comment #6 on issue 6569 by kas...@google.com: String.trim doesn't remove
non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

[da...@googlecode.com]

Updates:
Status: Fixed

Comment #7 on issue 6569 by l...@google.com: String.trim doesn't remove
non-ascii whitespace
http://code.google.com/p/dart/issues/detail?id=6569

Appears fixed.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings