Default GitHub gitignore additions for dart2js, and ??

276 views
Skip to first unread message

John McCutchan

unread,
Dec 20, 2012, 12:18:13 PM12/20/12
to General Dart Discussion
Hey Dartisans,

I'm putting together a second pull request for GitHub and want to make sure I have the perfect .gitignore:

packages
.project
*.iml
*.ipr
*.iws
.idea/
.DS_Store

What else is missing, what shouldn't we include?

--
John McCutchan <jo...@johnmccutchan.com>

Justin Fagnani

unread,
Dec 20, 2012, 12:20:47 PM12/20/12
to General Dart Discussion
Possibly .buildlock and .buildlog too.

-Justin



--
Consider asking HOWTO questions at Stack Overflow: http://stackoverflow.com/tags/dart
 
 

Adam Gray

unread,
Dec 20, 2012, 12:56:49 PM12/20/12
to General Dart Discussion
If you include .project for eclipse, you should probably include .settings as well.

Bluenuance

unread,
Dec 20, 2012, 1:30:45 PM12/20/12
to mi...@dartlang.org
is excluding ".children" still necessary (was created some time ago), if so this should be added
probably also
*.dart.js
*.js_
*.js.deps
but i'm not sure about those

Devon Carew

unread,
Dec 20, 2012, 1:39:56 PM12/20/12
to General Dart Discussion
The editor no longer creates ".children" files in with user code. These are safe to delete -

Devon


--
Consider asking HOWTO questions at Stack Overflow: http://stackoverflow.com/tags/dart
 
 



--
Devon Carew
Software Engineer
Google, Inc.

John McCutchan

unread,
Jan 4, 2013, 11:30:00 AM1/4/13
to General Dart Discussion
Hi All,

The following is what I'm submitting to GitHub:

packages
.project
*.iml
*.ipr
*.iws
.idea/
*.dart.js
*.js_
*.js.deps

Please let me know if I've made a mistake.

Thanks,
John
John McCutchan <jo...@johnmccutchan.com>

James Wendel

unread,
Jan 4, 2013, 12:03:50 PM1/4/13
to mi...@dartlang.org
Would you want to include this as well?
*.js.map
Message has been deleted

Don Olmstead

unread,
Jan 4, 2013, 1:13:55 PM1/4/13
to mi...@dartlang.org
That's really a separate use case. Whenever I've done any github page hosting I modify the .gitignore accordingly.


On Fri, Jan 4, 2013 at 10:03 AM, Ross Smith <ross.m...@gmail.com> wrote:
> *.dart.js
> *.js.deps

Are you sure about that?  Normally, I am very much against submitting generated code into a code repository.  But in this case, if you want to be able to let's say host an /example on Github pages in a modern browser (other than Dartium) you'll need to submit those I believe.

Andrei Mouravski

unread,
Jan 4, 2013, 1:14:06 PM1/4/13
to General Dart Discussion
Remember that you can always force a file to be added to the repository with git add -f my_ignored_file.dart.js

Github pages use a different branch anyway and so you'll keep your main branch free of generated code.


On Fri, Jan 4, 2013 at 10:03 AM, Ross Smith <ross.m...@gmail.com> wrote:
> *.dart.js
> *.js.deps

Are you sure about that?  Normally, I am very much against submitting generated code into a code repository.  But in this case, if you want to be able to let's say host an /example on Github pages in a modern browser (other than Dartium) you'll need to submit those I believe.

On Friday, January 4, 2013 9:03:50 AM UTC-8, James Wendel wrote:
Message has been deleted

John McCutchan

unread,
Jan 4, 2013, 1:44:00 PM1/4/13
to General Dart Discussion
The default .gitignore gives us the opportunity to guide users towards the best practice. Exceptions like GitHub pages aside, you shouldn't check generated source files into source control.  Here is the final list:

packages
.project
*.iml
*.ipr
*.iws
.idea/
*.dart.js
*.js_
*.js.deps
*.js.map

John


On Fri, Jan 4, 2013 at 10:40 AM, Ross Smith <ross.m...@gmail.com> wrote:
Yeah.  I guess as long as you can always modify your own .gitignore this is all sort of bike shedding anyways :)   I'd say less is more in a default .gitignore



--
John McCutchan <jo...@johnmccutchan.com>
Reply all
Reply to author
Forward
0 new messages