Dart Code Reviews - Google Groups

Groups

1–30 of 125156

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Shikhar Soni (Gerrit), … Daco Harkes (Gerrit)10

6:53 AM

[L] Change in dart/sdk[main]: [ffi] Reland: Add DynamicLibrary.openFromAssetId

Attention needed from Shikhar Soni Daco Harkes added 3 comments Patchset-level comments File-level

unread,

[L] Change in dart/sdk[main]: [ffi] Reland: Add DynamicLibrary.openFromAssetId

Attention needed from Shikhar Soni Daco Harkes added 3 comments Patchset-level comments File-level

6:53 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)7

5:54 AM

[M] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound arguments to FfiCalls.

Tess Strickland added 1 comment File runtime/vm/runtime_entry.cc Line 1300, Patchset 20: intptr_t

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound arguments to FfiCalls.

Tess Strickland added 1 comment File runtime/vm/runtime_entry.cc Line 1300, Patchset 20: intptr_t

5:54 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)6

5:46 AM

[L] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound returns from FfiCalls.

Attention needed from Alexander Markov Tess Strickland added 9 comments Patchset-level comments File-

unread,

[L] Change in dart/sdk[main]: [vm,dyn_modules] Handle compound returns from FfiCalls.

Attention needed from Alexander Markov Tess Strickland added 9 comments Patchset-level comments File-

5:46 AM

Daco Harkes (Gerrit), Liam Appelbe (Gerrit)3

4:54 AM

[M] Change in dart/sdk[main]: [vm/ffi] FFI static type checks to handle invalid function types

Attention needed from Liam Appelbe Daco Harkes voted and added 1 comment Votes added by Daco Harkes

unread,

[M] Change in dart/sdk[main]: [vm/ffi] FFI static type checks to handle invalid function types

Attention needed from Liam Appelbe Daco Harkes voted and added 1 comment Votes added by Daco Harkes

4:54 AM

Jens Johansen (Gerrit)

4:42 AM

[XS] Change in dart/sdk[main]: [vm][bytecode] Don't hide initializing formals - have them in scope i...

Attention needed from Alexander Markov and Jens Johansen Jens Johansen voted Commit-Queue+1 Commit-

unread,

[XS] Change in dart/sdk[main]: [vm][bytecode] Don't hide initializing formals - have them in scope i...

Attention needed from Alexander Markov and Jens Johansen Jens Johansen voted Commit-Queue+1 Commit-

4:42 AM

Lasse Nielsen (Gerrit), … Nate Bosch (Gerrit)7

4:34 AM

[L] Change in dart/sdk[main]: Make concrete `_ZoneFunction`s not generic.

Attention needed from Martin Kustermann and Nate Bosch Lasse Nielsen added 4 comments Patchset-level

unread,

[L] Change in dart/sdk[main]: Make concrete `_ZoneFunction`s not generic.

Attention needed from Martin Kustermann and Nate Bosch Lasse Nielsen added 4 comments Patchset-level

4:34 AM

Jonas Jensen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:16 AM

[S] Change in dart/sdk[main]: Do not forward `Proxy-Authorization` to the proxied request.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Do not forward `Proxy-Authorization` to the proxied request.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:16 AM

Ryan Macnak (Gerrit), Daco Harkes (Gerrit)4

3:57 AM

[M] Change in dart/sdk[main]: Fix depfile generation.

Attention needed from Ryan Macnak Daco Harkes added 1 comment Commit Message Line 9, Patchset 7 (

unread,

[M] Change in dart/sdk[main]: Fix depfile generation.

Attention needed from Ryan Macnak Daco Harkes added 1 comment Commit Message Line 9, Patchset 7 (

3:57 AM

Johnni Winther (Gerrit)

3:55 AM

[M] Change in dart/sdk[main]: CQ. Use stored FormalParameterElementImpl.isCovariant instead of inhe...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment

unread,

[M] Change in dart/sdk[main]: CQ. Use stored FormalParameterElementImpl.isCovariant instead of inhe...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted and added 1 comment

3:55 AM

FMorschel (Gerrit), Johnni Winther (Gerrit)2

3:44 AM

[M] Change in dart/sdk[main]: Record ConstructorElement references from metadata annotations.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: Record ConstructorElement references from metadata annotations.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:44 AM

Srujan Gaddam (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

3:28 AM

[M] Change in dart/sdk[main]: [dart2wasm] Separate concept of minification from omitting error details

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Separate concept of minification from omitting error details

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:28 AM

Bob Nystrom (Gerrit), … Jens Johansen (Gerrit)32

2:08 AM

[M] Change in dart/sdk[main]: Roll the latest dart_style into the SDK.

Jens Johansen added 1 comment File pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional.

unread,

[M] Change in dart/sdk[main]: Roll the latest dart_style into the SDK.

Jens Johansen added 1 comment File pkg/front_end/parser_testcases/also-nnbd/issue_40267_conditional.

2:08 AM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

Jun 23

[L] Change in dart/sdk[main]: Ensure that default type of type parameters is not modified by augmen...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Ensure that default type of type parameters is not modified by augmen...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Konstantin Shcheglov (Gerrit)

Jun 23

[M] Change in dart/sdk[main]: Ensure that augmentation parameter types check for structural equalit...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: Ensure that augmentation parameter types check for structural equalit...

Attention needed from Fedor Shcheglov Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

Jun 23

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[XS] Change in dart/sdk[main]: Fix Fuchsia build.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Fix Fuchsia build.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[S] Change in dart/sdk[main]: Reduce build set for isolate stress testing.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Reduce build set for isolate stress testing.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Alexander Markov (Gerrit)

Jun 23

[M] Change in dart/sdk[main]: [modular_aot] Reuse class and function type arguments when instantiating

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [modular_aot] Reuse class and function type arguments when instantiating

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jun 23

Kallen Tu (Gerrit), Brian Wilkerson (Gerrit)2

Jun 23

[M] Change in dart/sdk[main]: [migrate] Allow the tool to perform dry runs.

Attention needed from Kallen Tu Brian Wilkerson voted and added 2 comments Votes added by Brian

unread,

[M] Change in dart/sdk[main]: [migrate] Allow the tool to perform dry runs.

Attention needed from Kallen Tu Brian Wilkerson voted and added 2 comments Votes added by Brian

Jun 23

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jun 23

[L] Change in dart/sdk[main]: Infer field / super formal parameter element type only if the first f...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Infer field / super formal parameter element type only if the first f...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 23

[M] Change in dart/sdk[main]: Replace skipped with failing for tests

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Replace skipped with failing for tests

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jun 23

[XL] Change in dart/sdk[main]: linter: Rename "markdown" APIs to "markup"

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: linter: Rename "markdown" APIs to "markup"

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[M] Change in dart/sdk[main]: [dart:io, fuchsia] Fix use-after-free when closing a server socket on...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [dart:io, fuchsia] Fix use-after-free when closing a server socket on...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[M] Change in dart/sdk[main]: [migrate] Print details for the fixes applied.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [migrate] Print details for the fixes applied.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

Konstantin Shcheglov (Gerrit), Fedor Shcheglov (Gerrit)2

Jun 23

[XL] Change in dart/sdk[main]: Report missingFunctionBody or alreadyCompleteSemanticEntity for augme...

Fedor Shcheglov abandoned this change. View Change Abandoned Change already made. Fedor Shcheglov

unread,

[XL] Change in dart/sdk[main]: Report missingFunctionBody or alreadyCompleteSemanticEntity for augme...

Fedor Shcheglov abandoned this change. View Change Abandoned Change already made. Fedor Shcheglov

Jun 23

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jun 23

[L] Change in dart/sdk[main]: [vm] Allocate separate cages for each isolate group under compressed ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: [vm] Allocate separate cages for each isolate group under compressed ...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

FMorschel (Gerrit), … Brian Wilkerson (Gerrit)7

Jun 23

[M] Change in dart/sdk[main]: [DAS] Fixes renaming constructor invocation on annotation

Attention needed from FMorschel Brian Wilkerson added 1 comment File pkg/analyzer/test/src/dart/

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes renaming constructor invocation on annotation

Attention needed from FMorschel Brian Wilkerson added 1 comment File pkg/analyzer/test/src/dart/

Jun 23

Brian Quinlan (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[XS] Change in dart/sdk[main]: [frontend_server_client] Copy changes from github

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [frontend_server_client] Copy changes from github

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jun 23

Kevin Moore (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)10

Jun 23

[M] Change in dart/sdk[main]: [vm/io] leaf cert in badCertificateCallback

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 6

unread,

[M] Change in dart/sdk[main]: [vm/io] leaf cert in badCertificateCallback

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 6

Jun 23

Alexander Markov (Gerrit)

Jun 23

[XS] Change in dart/sdk[main]: [modular_aot] Fixes for TypeCast slow path

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XS] Change in dart/sdk[main]: [modular_aot] Fixes for TypeCast slow path

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jun 23

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jun 23

[M] Change in dart/sdk[main]: CQ. Store FormalParameterElementImpl flags.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: CQ. Store FormalParameterElementImpl flags.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jun 23

Search

Clear search

Close search

Google apps

Main menu