Dart Code Reviews - Google Groups

Groups

1–30 of 125771

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ivan Inozemtsev (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

2:17 AM

[XS] Change in dart/sdk[main]: Fix DART_TARGET_OS_WINDOWS define

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

unread,

[XS] Change in dart/sdk[main]: Fix DART_TARGET_OS_WINDOWS define

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

2:17 AM

Konstantin Shcheglov (Gerrit)

1:17 AM

[XL] Change in dart/sdk[main]: AST. Implement PropertyAssignmentTarget.

Attention needed from Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[XL] Change in dart/sdk[main]: AST. Implement PropertyAssignmentTarget.

Attention needed from Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-Queue +1 Open in

1:17 AM

Konstantin Shcheglov (Gerrit), … Paul Berry (Gerrit)6

Aug 5

[S] Change in dart/sdk[main]: Issue 63972. Fix recovery when missing class body after primary const...

Attention needed from Brian Wilkerson Konstantin Shcheglov voted Commit-Queue+2 Commit-Queue +2 Open

unread,

[S] Change in dart/sdk[main]: Issue 63972. Fix recovery when missing class body after primary const...

Attention needed from Brian Wilkerson Konstantin Shcheglov voted Commit-Queue+2 Commit-Queue +2 Open

Aug 5

Nate Bosch (Gerrit), Brian Quinlan (Gerrit)2

Aug 5

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools, web

Attention needed from Nate Bosch Brian Quinlan voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools, web

Attention needed from Nate Bosch Brian Quinlan voted Code-Review+1 Code-Review +1 Open in Gerrit

Aug 5

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Aug 5

[XL] Change in dart/sdk[main]: AST. Implement CompoundAssignment.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XL] Change in dart/sdk[main]: AST. Implement CompoundAssignment.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Aug 5

Stephen Adams (Gerrit)2

Aug 5

[S] Change in dart/sdk[main]: [pkg/wasm_builder, pkg/dart2wasm] Enable primary constructors.

Stephen Adams submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

unread,

[S] Change in dart/sdk[main]: [pkg/wasm_builder, pkg/dart2wasm] Enable primary constructors.

Stephen Adams submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

Aug 5

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Aug 5

[XL] Change in dart/sdk[main]: AST. Implement IfNullAssignment.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XL] Change in dart/sdk[main]: AST. Implement IfNullAssignment.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Aug 5

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Aug 5

[L] Change in dart/sdk[main]: Add a lint to flag local variables created to promote `this`.

Brian Wilkerson added 1 comment File pkg/linter/lib/src/rules/unnecessary_this_alias.dart Line 63,

unread,

[L] Change in dart/sdk[main]: Add a lint to flag local variables created to promote `this`.

Brian Wilkerson added 1 comment File pkg/linter/lib/src/rules/unnecessary_this_alias.dart Line 63,

Aug 5

Brian Wilkerson (Gerrit)

Aug 5

[M] Change in dart/sdk[main]: Update unnecessary_this_alias to catch more cases

Attention needed from Paul Berry New activity on the change Open in Gerrit Related details Attention

unread,

[M] Change in dart/sdk[main]: Update unnecessary_this_alias to catch more cases

Attention needed from Paul Berry New activity on the change Open in Gerrit Related details Attention

Aug 5

Ryan Macnak (Gerrit)

Aug 5

[M] Change in dart/sdk[main]: [vm, arm64] Leave CSP near the stack limit during leaf runtime calls.

Attention needed from Alexander Markov Ryan Macnak added 1 comment Patchset-level comments File-level

unread,

[M] Change in dart/sdk[main]: [vm, arm64] Leave CSP near the stack limit during leaf runtime calls.

Attention needed from Alexander Markov Ryan Macnak added 1 comment Patchset-level comments File-level

Aug 5

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)18

Aug 5

[L] Change in dart/sdk[main]: [DAS] Adds more information to type parameter hovers

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[L] Change in dart/sdk[main]: [DAS] Adds more information to type parameter hovers

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

Aug 5

Alexander Aprelev (Gerrit), Ryan Macnak (Gerrit)3

Aug 5

[XS] Change in dart/sdk[main]: [gardening] Skip http_request_pipelining_test on Fuchsia.

Ryan Macnak submitted the change Change information Commit message: [gardening] Skip

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip http_request_pipelining_test on Fuchsia.

Ryan Macnak submitted the change Change information Commit message: [gardening] Skip

Aug 5

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[XS] Change in dart/sdk[main]: [gardening] Skip least_and_greatest_closure_A09_t01 on AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip least_and_greatest_closure_A09_t01 on AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Arnav Arora (Gerrit), Srujan Gaddam (Gerrit)5

Aug 5

[S] Change in dart/sdk[main]: [dart:js_interop] Support extension types on generic type parameters

Attention needed from Nate Biggs and Srujan Gaddam Arnav Arora voted and added 3 comments Votes added

unread,

[S] Change in dart/sdk[main]: [dart:js_interop] Support extension types on generic type parameters

Attention needed from Nate Biggs and Srujan Gaddam Arnav Arora voted and added 3 comments Votes added

Aug 5

Paul Berry (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)11

Aug 5

[XL] Change in dart/sdk[main]: AST. Implement DirectAssignment and UnqualifiedNameAssignmentTarget.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: AST. Implement DirectAssignment and UnqualifiedNameAssignmentTarget.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Ryan Macnak (Gerrit)

Aug 5

[S] Change in dart/sdk[main]: [build] Update sysroot to Jammy.

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [build] Update sysroot to Jammy.

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Aug 5

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[M] Change in dart/sdk[main]: [modular_aot] _List default factory constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [modular_aot] _List default factory constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[S] Change in dart/sdk[main]: [vm, arm64] Don't generate push sp.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [vm, arm64] Don't generate push sp.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[L] Change in dart/sdk[main]: [modular_aot] Typed data factory constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [modular_aot] Typed data factory constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[M] Change in dart/sdk[main]: Enable recommended lints when verifying diagnostic documentation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Enable recommended lints when verifying diagnostic documentation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

FMorschel (Gerrit), Brian Wilkerson (Gerrit)3

Aug 5

[S] Change in dart/sdk[main]: [DAS] Bump tools and fix linter rules completion case

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[S] Change in dart/sdk[main]: [DAS] Bump tools and fix linter rules completion case

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

Aug 5

Keerti Parthasarathy (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Aug 5

[M] Change in dart/sdk[main]: Look at export statements too for replaceBy transform

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Look at export statements too for replaceBy transform

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Kallen Tu (Gerrit), Brian Wilkerson (Gerrit)2

Aug 5

[M] Change in dart/sdk[main]: [dartdev][migrate] Allow multiple target packages.

Attention needed from Kallen Tu Brian Wilkerson voted and added 1 comment Votes added by Brian

unread,

[M] Change in dart/sdk[main]: [dartdev][migrate] Allow multiple target packages.

Attention needed from Kallen Tu Brian Wilkerson voted and added 1 comment Votes added by Brian

Aug 5

Ryan Macnak (Gerrit)

Aug 5

[M] Change in dart/sdk[main]: [vm, arm64e] Authenticate pointers for image header access.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm, arm64e] Authenticate pointers for image header access.

Attention needed from Tess Strickland New activity on the change Open in Gerrit Related details

Aug 5

Ben Konyi (Gerrit), … Mark Zhou (Gerrit)6

Aug 5

[S] Change in dart/sdk[main]: [Service] dap_adapters: Add LICENSE and rename main library

Ben Konyi submitted the change Change information Commit message: [Service] dap_adapters: Add LICENSE

unread,

[S] Change in dart/sdk[main]: [Service] dap_adapters: Add LICENSE and rename main library

Ben Konyi submitted the change Change information Commit message: [Service] dap_adapters: Add LICENSE

Aug 5

Ben Konyi (Gerrit), Helin Shiah (Gerrit)5

Aug 5

[XL] Change in dart/sdk[main]: [vm/service] Remove Java implementation and code generator

Ben Konyi submitted the change Change information Commit message: [vm/service] Remove Java

unread,

[XL] Change in dart/sdk[main]: [vm/service] Remove Java implementation and code generator

Ben Konyi submitted the change Change information Commit message: [vm/service] Remove Java

Aug 5

Daco Harkes (Gerrit), Ryan Macnak (Gerrit)2

Aug 5

[XL] Change in dart/sdk[main]: [vm/service]: Add _getFfiStructLayout RPC for FFI struct field layout

Attention needed from Ben Konyi and Nourhan Hasan Ryan Macnak added 1 comment Patchset-level comments

unread,

[XL] Change in dart/sdk[main]: [vm/service]: Add _getFfiStructLayout RPC for FFI struct field layout

Attention needed from Ben Konyi and Nourhan Hasan Ryan Macnak added 1 comment Patchset-level comments

Aug 5

FMorschel (Gerrit), … Brian Wilkerson (Gerrit)8

Aug 5

[M] Change in dart/sdk[main]: [DAS] Adds `Remove async` fix for `async_return_with_no_await`

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

unread,

[M] Change in dart/sdk[main]: [DAS] Adds `Remove async` fix for `async_return_with_no_await`

Attention needed from FMorschel and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1 Commit-

Aug 5

Martin Kustermann (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Aug 5

[XS] Change in dart/sdk[main]: [wasm] add sra@ as owner

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [wasm] add sra@ as owner

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

FMorschel (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

Aug 5

[M] Change in dart/sdk[main]: [DAS] Fixes primary constructor body completion

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes primary constructor body completion

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Aug 5

Search

Clear search

Close search

Google apps

Main menu