Dart Code Reviews - Google Groups

Groups

1–30 of 125477

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Samuel Rawlins (Gerrit), … Konstantin Shcheglov (Gerrit)4

6:18 PM

[M] Change in dart/sdk[main]: analyzer: Deprecate legacy analyzer plugins

Attention needed from Brian Wilkerson Samuel Rawlins added 1 comment File pkg/analyzer/messages.yaml

unread,

[M] Change in dart/sdk[main]: analyzer: Deprecate legacy analyzer plugins

Attention needed from Brian Wilkerson Samuel Rawlins added 1 comment File pkg/analyzer/messages.yaml

6:18 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

6:17 PM

[L] Change in dart/sdk[main]: Parse and validate analyzer plugins in "inner" options files

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Parse and validate analyzer plugins in "inner" options files

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

6:17 PM

Modestas Valauskas (Gerrit), Stephen Adams (Gerrit)3

6:14 PM

[XL] Change in dart/sdk[main]: Share SIMD value operations via a dart._simd part

Attention needed from Johnni Winther, Martin Kustermann and Modestas Valauskas Stephen Adams added 3

unread,

[XL] Change in dart/sdk[main]: Share SIMD value operations via a dart._simd part

Attention needed from Johnni Winther, Martin Kustermann and Modestas Valauskas Stephen Adams added 3

6:14 PM

Alexander Markov (Gerrit)

5:52 PM

[S] Change in dart/sdk[main]: [modular_aot] Fix object size in tags

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix object size in tags

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

5:52 PM

Konstantin Shcheglov (Gerrit), Paul Berry (Gerrit)3

5:49 PM

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to _withUnpromotedThisType().

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to _withUnpromotedThisType().

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov added 1 comment File pkg/

5:49 PM

Ryan Macnak (Gerrit), Alexander Markov (Gerrit)2

5:43 PM

[XS] Change in dart/sdk[main]: Follow up for "[vm] Don't double initialize length fields during obje...

Attention needed from Ryan Macnak Alexander Markov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[XS] Change in dart/sdk[main]: Follow up for "[vm] Don't double initialize length fields during obje...

Attention needed from Ryan Macnak Alexander Markov voted Code-Review+1 Code-Review +1 Open in Gerrit

5:43 PM

Paul Berry (Gerrit)

5:42 PM

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

5:42 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

5:41 PM

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to single enclosingInstanceElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to single enclosingInstanceElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

5:41 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

5:40 PM

[M] Change in dart/sdk[main]: [vm] Don't double initialize length fields during object graph copying.

Ryan Macnak added 2 comments File runtime/vm/object_graph_copy.cc Line 1835, Patchset 3: Base::

unread,

[M] Change in dart/sdk[main]: [vm] Don't double initialize length fields during object graph copying.

Ryan Macnak added 2 comments File runtime/vm/object_graph_copy.cc Line 1835, Patchset 3: Base::

5:40 PM

Konstantin Shcheglov (Gerrit), Paul Berry (Gerrit)2

5:37 PM

[S] Change in dart/sdk[main]: CQ. Recover in invalid ThisExpression with InvalidTypeImpl.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

unread,

[S] Change in dart/sdk[main]: CQ. Recover in invalid ThisExpression with InvalidTypeImpl.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

5:37 PM

Kevin Moore (Gerrit)

5:33 PM

[L] Change in dart/sdk[main]: [dart:io] Coalesce HTTP response headers and body into one socket write

Attention needed from Brian Quinlan and Lasse Nielsen Kevin Moore voted Auto-Submit+1 Auto-Submit +1

unread,

[L] Change in dart/sdk[main]: [dart:io] Coalesce HTTP response headers and body into one socket write

Attention needed from Brian Quinlan and Lasse Nielsen Kevin Moore voted Auto-Submit+1 Auto-Submit +1

5:33 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:57 PM

[XS] Change in dart/sdk[main]: [vm, arm64e] Fix size of kPlatformDillSize.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [vm, arm64e] Fix size of kPlatformDillSize.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:57 PM

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

4:52 PM

[S] Change in dart/sdk[main]: Start analyzer 14.2.0-dev, analyzer_plugin 0.14.15-dev, analyzer_test...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Start analyzer 14.2.0-dev, analyzer_plugin 0.14.15-dev, analyzer_test...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:52 PM

Konstantin Shcheglov (Gerrit)

4:41 PM

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement..

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement..

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

4:41 PM

Modestas Valauskas (Gerrit)

4:37 PM

[M] Change in dart/sdk[main]: [dart2wasm] Unify unmodifiable typed data mixins

Attention needed from Lasse Nielsen Modestas Valauskas voted and added 1 comment Votes added by

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Unify unmodifiable typed data mixins

Attention needed from Lasse Nielsen Modestas Valauskas voted and added 1 comment Votes added by

4:37 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:21 PM

[M] Change in dart/sdk[main]: [vm/io] Signal to fork()ed child only in non detached mode

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 4

unread,

[M] Change in dart/sdk[main]: [vm/io] Signal to fork()ed child only in non detached mode

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 4

4:21 PM

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:06 PM

[M] Change in dart/sdk[main]: [migrate] Support Dart 3 backwards compatibility.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [migrate] Support Dart 3 backwards compatibility.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

4:06 PM

Lasse Nielsen (Gerrit), Martin Kustermann (Gerrit)2

3:47 PM

[M] Change in dart/sdk[main]: Extra testing of inet_pton.

Attention needed from Lasse Nielsen Martin Kustermann voted and added 2 comments Votes added by

unread,

[M] Change in dart/sdk[main]: Extra testing of inet_pton.

Attention needed from Lasse Nielsen Martin Kustermann voted and added 2 comments Votes added by

3:47 PM

Konstantin Shcheglov (Gerrit), … Danny Tuppeny (Gerrit)7

3:40 PM

[M] Change in dart/sdk[main]: TestCode: handle an escaped shorthand

Attention needed from Samuel Rawlins Danny Tuppeny added 1 comment File pkg/analyzer/lib/src/

unread,

[M] Change in dart/sdk[main]: TestCode: handle an escaped shorthand

Attention needed from Samuel Rawlins Danny Tuppeny added 1 comment File pkg/analyzer/lib/src/

3:40 PM

Daco Harkes (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)16

3:20 PM

[S] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:20 PM

Danny Tuppeny (Gerrit), Brian Wilkerson (Gerrit)2

3:15 PM

[L] Change in dart/sdk[main]: [analysis_server] Add Dart-Code's current client capabilities

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted and added 1

unread,

[L] Change in dart/sdk[main]: [analysis_server] Add Dart-Code's current client capabilities

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted and added 1

3:15 PM

Jaime Wren (Gerrit), Daco Harkes (Gerrit)2

3:01 PM

[S] Change in dart/sdk[main]: [dartdev] Remove resolved TODO for DynamicLibrary.openFromAssetId in ...

Attention needed from Jaime Wren Daco Harkes added 1 comment File pkg/dartdev/test/native_assets/

unread,

[S] Change in dart/sdk[main]: [dartdev] Remove resolved TODO for DynamicLibrary.openFromAssetId in ...

Attention needed from Jaime Wren Daco Harkes added 1 comment File pkg/dartdev/test/native_assets/

3:01 PM

Alexander Markov (Gerrit)

2:59 PM

[XL] Change in dart/sdk[main]: [modular_aot] Generate stack maps for GC

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XL] Change in dart/sdk[main]: [modular_aot] Generate stack maps for GC

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

2:59 PM

Ben Konyi (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

2:38 PM

[XS] Change in dart/sdk[main]: Remove stale TODO comment in `flag_test.dart`.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Remove stale TODO comment in `flag_test.dart`.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:38 PM

Alexander Markov (Gerrit)

2:16 PM

[M] Change in dart/sdk[main]: [modular_aot] Use int.trailingZeroBitCount/oneBitCount

Attention needed from Modestas Valauskas and Slava Egorov Alexander Markov voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: [modular_aot] Use int.trailingZeroBitCount/oneBitCount

Attention needed from Modestas Valauskas and Slava Egorov Alexander Markov voted Code-Review+1 Code-

2:16 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:37 PM

[XS] Change in dart/sdk[main]: [vm, arm64e] Don't try to use icf with ld.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [vm, arm64e] Don't try to use icf with ld.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:37 PM

Ben Konyi (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

1:34 PM

[M] Change in dart/sdk[main]: [dartdev] Validate command names and check subcommands recursively

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [dartdev] Validate command names and check subcommands recursively

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:34 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:47 PM

[M] Change in dart/sdk[main]: [analysis_server] Add client-side validation for Add Import Prefix

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [analysis_server] Add client-side validation for Add Import Prefix

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:47 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

12:45 PM

[L] Change in dart/sdk[main]: CQ. AST. Mark visitors and related as ToBeDeprecated.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

unread,

[L] Change in dart/sdk[main]: CQ. AST. Mark visitors and related as ToBeDeprecated.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

12:45 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:39 PM

[M] Change in dart/sdk[main]: CQ. Make thisType the type of 'this', replacing effectiveThisType.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: CQ. Make thisType the type of 'this', replacing effectiveThisType.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:39 PM

Search

Clear search

Close search

Google apps

Main menu