Dart Code Reviews - Google Groups

Groups

1–30 of 126181

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Alexander Markov (Gerrit)

5:13 PM

[M] Change in dart/sdk[main]: [modular_aot] More recognized methods from dart:typed_data

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [modular_aot] More recognized methods from dart:typed_data

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

5:13 PM

Keerti Parthasarathy (Gerrit), Brian Wilkerson (Gerrit)4

4:56 PM

[XS] Change in dart/sdk[main]: [DEPS] Bump tools to 441ff2986fd495c88b59bb15dd6b35904ad329b7

Keerti Parthasarathy voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention

unread,

[XS] Change in dart/sdk[main]: [DEPS] Bump tools to 441ff2986fd495c88b59bb15dd6b35904ad329b7

Keerti Parthasarathy voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention

4:56 PM

Konstantin Shcheglov (Gerrit)

4:49 PM

[XL] Change in dart/sdk[main]: CQ. Move ContextLocatorImplTest tests into AnalysisContextCollectionT...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[XL] Change in dart/sdk[main]: CQ. Move ContextLocatorImplTest tests into AnalysisContextCollectionT...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

4:49 PM

Brian Wilkerson (Gerrit), … Konstantin Shcheglov (Gerrit)3

4:36 PM

[S] Change in dart/sdk[main]: DAS testing: Convert contextFor to accept a "String path" instead of ...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

unread,

[S] Change in dart/sdk[main]: DAS testing: Convert contextFor to accept a "String path" instead of ...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

4:36 PM

Nicholas Shahan (Gerrit), Mark Zhou (Gerrit)2

3:46 PM

[L] Change in dart/sdk[main]: [ddc] Add caches to RTI and LibraryCompiler operations shared across ...

Attention needed from Nicholas Shahan Mark Zhou added 9 comments Patchset-level comments File-level

unread,

[L] Change in dart/sdk[main]: [ddc] Add caches to RTI and LibraryCompiler operations shared across ...

Attention needed from Nicholas Shahan Mark Zhou added 9 comments Patchset-level comments File-level

3:46 PM

Bob Nystrom (Gerrit)

2:13 PM

[M] Change in dart/sdk[main]: Perf. Optimize context root discovery with PackageConfigWorkspace and...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Bob Nystrom added 2

unread,

[M] Change in dart/sdk[main]: Perf. Optimize context root discovery with PackageConfigWorkspace and...

Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry Bob Nystrom added 2

2:13 PM

Alexander Markov (Gerrit)

1:44 PM

[M] Change in dart/sdk[main]: [modular_aot] Use platform snapshot when running tests

Alexander Markov restored this change Open in Gerrit Related details Attention set is empty Submit

unread,

[M] Change in dart/sdk[main]: [modular_aot] Use platform snapshot when running tests

Alexander Markov restored this change Open in Gerrit Related details Attention set is empty Submit

1:44 PM

Nicholas Shahan (Gerrit), … Ben Konyi (Gerrit)4

12:40 PM

[L] Change in dart/sdk[main]: [Service] Add DDS isolate manager

Ben Konyi added 2 comments File pkg/dart_runtime_service_dds/lib/src/dds_isolate_manager.dart Line

unread,

[L] Change in dart/sdk[main]: [Service] Add DDS isolate manager

Ben Konyi added 2 comments File pkg/dart_runtime_service_dds/lib/src/dds_isolate_manager.dart Line

12:40 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:34 PM

[M] Change in dart/sdk[main]: DAS: Document AbstractContextTest API

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: DAS: Document AbstractContextTest API

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

12:34 PM

Alexander Markov (Gerrit)

12:34 PM

[M] Change in dart/sdk[main]: [vm,modular_aot] Canonicalize type arguments in constant instances wh...

Attention needed from Ryan Macnak and Slava Egorov New activity on the change Open in Gerrit Related

unread,

[M] Change in dart/sdk[main]: [vm,modular_aot] Canonicalize type arguments in constant instances wh...

Attention needed from Ryan Macnak and Slava Egorov New activity on the change Open in Gerrit Related

12:34 PM

Alexander Markov (Gerrit)

11:39 AM

[S] Change in dart/sdk[main]: [modular_aot] Code generation for int abs and sign

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [modular_aot] Code generation for int abs and sign

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

11:39 AM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

10:48 AM

[L] Change in dart/sdk[main]: Perf. Update discoverAvailableFiles() to discover files in small chucks.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Perf. Update discoverAvailableFiles() to discover files in small chucks.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

10:48 AM

Lasse Nielsen (Gerrit)2

10:47 AM

[M] Change in dart/sdk[main]: [dart:io] Refactor _HttpOutgoing byte routing and GZip buffering

Attention needed from Kevin Moore Lasse Nielsen added 1 comment File sdk/lib/_http/http_impl.dart

unread,

[M] Change in dart/sdk[main]: [dart:io] Refactor _HttpOutgoing byte routing and GZip buffering

Attention needed from Kevin Moore Lasse Nielsen added 1 comment File sdk/lib/_http/http_impl.dart

10:47 AM

Parker Lougheed (Gerrit), … Brian Wilkerson (Gerrit)7

10:45 AM

[S] Change in dart/sdk[main]: [linter] Add diagnostic doc for eol_at_end_of_file lint

Attention needed from Connie Ooi and Parker Lougheed Brian Wilkerson voted Code-Review +1 Commit-

unread,

[S] Change in dart/sdk[main]: [linter] Add diagnostic doc for eol_at_end_of_file lint

Attention needed from Connie Ooi and Parker Lougheed Brian Wilkerson voted Code-Review +1 Commit-

10:45 AM

Brian Quinlan (Gerrit)

10:23 AM

[M] Change in dart/sdk[main]: [frontend_server_client] Support standalone CLI executables

Attention needed from Moritz Sümmermann Brian Quinlan voted and added 1 comment Votes added by Brian

unread,

[M] Change in dart/sdk[main]: [frontend_server_client] Support standalone CLI executables

Attention needed from Moritz Sümmermann Brian Quinlan voted and added 1 comment Votes added by Brian

10:23 AM

Simon Binder (Gerrit)

10:14 AM

[L] Change in dart/sdk[main]: [dartdev] Add `dart build web-bundle` command

Attention needed from Daco Harkes New activity on the change Open in Gerrit Related details Attention

unread,

[L] Change in dart/sdk[main]: [dartdev] Add `dart build web-bundle` command

Attention needed from Daco Harkes New activity on the change Open in Gerrit Related details Attention

10:14 AM

Kevin Moore (Gerrit), Michael Thomsen (Gerrit)3

9:52 AM

[XS] Change in dart/sdk[main]: [corelib] Mark dart:mirrors as @deprecated

Attention needed from Kevin Moore and Ryan Macnak Michael Thomsen added 1 comment File CHANGELOG.md

unread,

[XS] Change in dart/sdk[main]: [corelib] Mark dart:mirrors as @deprecated

Attention needed from Kevin Moore and Ryan Macnak Michael Thomsen added 1 comment File CHANGELOG.md

9:52 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:51 AM

[S] Change in dart/sdk[main]: [modular_aot] Fix access to optional named parameters when type argum...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix access to optional named parameters when type argum...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

9:51 AM

Johnni Winther (Gerrit), Alexander Markov (Gerrit)2

9:48 AM

[L] Change in dart/sdk[main]: [kernel/frontend_server] Add fileUri to LibraryPart; fix invalidation...

Attention needed from Jens Johansen Alexander Markov voted Code-Review+1 Code-Review +1 Open in

unread,

[L] Change in dart/sdk[main]: [kernel/frontend_server] Add fileUri to LibraryPart; fix invalidation...

Attention needed from Jens Johansen Alexander Markov voted Code-Review+1 Code-Review +1 Open in

9:48 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:44 AM

[S] Change in dart/sdk[main]: [modular_aot] Fix NativeFieldWrapperClass{1,2,3,4} instance size

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix NativeFieldWrapperClass{1,2,3,4} instance size

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

9:44 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:43 AM

[L] Change in dart/sdk[main]: [modular_aot] Recognized methods for copying typed data lists

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 3

unread,

[L] Change in dart/sdk[main]: [modular_aot] Recognized methods for copying typed data lists

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 3

9:43 AM

Modestas Valauskas (Gerrit), … Martin Kustermann (Gerrit)4

9:39 AM

[S] Change in dart/sdk[main]: [vm] Bound the Simd sign mask result range

Modestas Valauskas voted and added 1 comment Votes added by Modestas Valauskas Auto-Submit +1 1

unread,

[S] Change in dart/sdk[main]: [vm] Bound the Simd sign mask result range

Modestas Valauskas voted and added 1 comment Votes added by Modestas Valauskas Auto-Submit +1 1

9:39 AM

Konstantin Shcheglov (Gerrit)

9:36 AM

[L] Change in dart/sdk[main]: Use C++ hashing with BLAKE3 to speed up Dart analyze.

Attention needed from Brian Wilkerson, Fedor Shcheglov, Martin Kustermann and Samuel Rawlins

unread,

[L] Change in dart/sdk[main]: Use C++ hashing with BLAKE3 to speed up Dart analyze.

Attention needed from Brian Wilkerson, Fedor Shcheglov, Martin Kustermann and Samuel Rawlins

9:36 AM

Søren Pedersen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

9:25 AM

[L] Change in dart/sdk[main]: [dart2wasm] Stop reusing temporary variables in await transformer

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Stop reusing temporary variables in await transformer

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

9:25 AM

Modestas Valauskas (Gerrit), … Martin Kustermann (Gerrit)5

9:17 AM

[S] Change in dart/sdk[main]: [vm] Add vsshr_4s to the arm64 assembler

Attention needed from Modestas Valauskas and Slava Egorov Martin Kustermann voted Code-Review +1

unread,

[S] Change in dart/sdk[main]: [vm] Add vsshr_4s to the arm64 assembler

Attention needed from Modestas Valauskas and Slava Egorov Martin Kustermann voted Code-Review +1

9:17 AM

Sergey Grekhov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

8:19 AM

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 5f2a1632af9509358d1325e546f47d3a0a22b912

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 5f2a1632af9509358d1325e546f47d3a0a22b912

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

8:19 AM

Chloe Stefantsova (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

7:40 AM

[M] Change in dart/sdk[main]: [cfe] Put joint variables into contexts in switch expressions

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [cfe] Put joint variables into contexts in switch expressions

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

7:40 AM

Modestas Valauskas (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

7:25 AM

[S] Change in dart/sdk[main]: [benchmark] Add Int32x4.signMask cases to SimdInt32x4

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [benchmark] Add Int32x4.signMask cases to SimdInt32x4

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

7:25 AM

Modestas Valauskas (Gerrit), … Martin Kustermann (Gerrit)5

7:09 AM

[M] Change in dart/sdk[main]: [vm] Use an SSHR-based sign mask on arm64

Attention needed from Modestas Valauskas Martin Kustermann voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: [vm] Use an SSHR-based sign mask on arm64

Attention needed from Modestas Valauskas Martin Kustermann voted Code-Review+1 Code-Review +1 Open in

7:09 AM

Daco Harkes (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

6:42 AM

[M] Change in dart/sdk[main]: [dartdev] Delete temp directory in outer process on Windows

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [dartdev] Delete temp directory in outer process on Windows

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

6:42 AM

Search

Clear search

Close search

Google apps

Main menu