Groups

Dart Code Reviews

1–30 of 122425

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Konstantin Shcheglov (Gerrit)

Dec 30

[M] Change in dart/sdk[main]: analyzer: Report inference failure warning on primary parameters

Attention needed from Samuel Rawlins Konstantin Shcheglov voted and added 1 comment Votes added by

unread,

[M] Change in dart/sdk[main]: analyzer: Report inference failure warning on primary parameters

Attention needed from Samuel Rawlins Konstantin Shcheglov voted and added 1 comment Votes added by

Dec 30

Konstantin Shcheglov (Gerrit), Samuel Rawlins (Gerrit)5

Dec 30

[M] Change in dart/sdk[main]: Fix a crash resulting from synthetic named formal parameters inside r...

Konstantin Shcheglov submitted the change Change information Commit message: Fix a crash resulting

unread,

[M] Change in dart/sdk[main]: Fix a crash resulting from synthetic named formal parameters inside r...

Konstantin Shcheglov submitted the change Change information Commit message: Fix a crash resulting

Dec 30

Samuel Rawlins (Gerrit), Konstantin Shcheglov (Gerrit)4

Dec 30

[M] Change in dart/sdk[main]: analyzer: Add tests for strict-raw-type and other parameter types

Samuel Rawlins submitted the change Change information Commit message: analyzer: Add tests for strict

unread,

[M] Change in dart/sdk[main]: analyzer: Add tests for strict-raw-type and other parameter types

Samuel Rawlins submitted the change Change information Commit message: analyzer: Add tests for strict

Dec 30

Samuel Rawlins (Gerrit), Konstantin Shcheglov (Gerrit)2

Dec 30

[XS] Change in dart/sdk[main]: DeCo. Increment DATA_VERSION.

Konstantin Shcheglov submitted the change Change information Commit message: DeCo. Increment

unread,

[XS] Change in dart/sdk[main]: DeCo. Increment DATA_VERSION.

Konstantin Shcheglov submitted the change Change information Commit message: DeCo. Increment

Dec 30

Konstantin Shcheglov (Gerrit), Samuel Rawlins (Gerrit)4

Dec 30

[M] Change in dart/sdk[main]: Fix case and default not appearing as suggestions inside a switch sta...

Konstantin Shcheglov submitted the change Change information Commit message: Fix case and default not

unread,

[M] Change in dart/sdk[main]: Fix case and default not appearing as suggestions inside a switch sta...

Konstantin Shcheglov submitted the change Change information Commit message: Fix case and default not

Dec 30

Konstantin Shcheglov (Gerrit), Samuel Rawlins (Gerrit)6

Dec 30

[L] Change in dart/sdk[main]: DeCo. Support for PrimaryConstructorBodyImpl.

Konstantin Shcheglov submitted the change with unreviewed changes Unreviewed changes 9 is the latest

unread,

[L] Change in dart/sdk[main]: DeCo. Support for PrimaryConstructorBodyImpl.

Konstantin Shcheglov submitted the change with unreviewed changes Unreviewed changes 9 is the latest

Dec 30

Fedor Shcheglov (Gerrit)

Dec 30

[M] Change in dart/sdk[main]: deduplicate bundle_reader

Fedor Shcheglov abandoned this change Related details Attention set is empty Submit Requirements:

unread,

[M] Change in dart/sdk[main]: deduplicate bundle_reader

Fedor Shcheglov abandoned this change Related details Attention set is empty Submit Requirements:

Dec 30

Konstantin Shcheglov (Gerrit), Samuel Rawlins (Gerrit)4

Dec 30

[S] Change in dart/sdk[main]: meta: Annotate _Literal with TargetKind.constructor

Samuel Rawlins submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[S] Change in dart/sdk[main]: meta: Annotate _Literal with TargetKind.constructor

Samuel Rawlins submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

Dec 30

Ömer Ağacan (Gerrit)2

Dec 30

[XS] Change in dart/sdk[main]: [dart2wasm] Don't clone async function contexts

Attention needed from Martin Kustermann Ömer Ağacan added 1 comment File pkg/dart2wasm/lib/async.dart

unread,

[XS] Change in dart/sdk[main]: [dart2wasm] Don't clone async function contexts

Attention needed from Martin Kustermann Ömer Ağacan added 1 comment File pkg/dart2wasm/lib/async.dart

Dec 30

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)6

Dec 29

[S] Change in dart/sdk[main]: Fix a crash resulting from attempting to access a null URI when runni...

Commit Queue submitted the change Change information Commit message: Fix a crash resulting from

unread,

[S] Change in dart/sdk[main]: Fix a crash resulting from attempting to access a null URI when runni...

Commit Queue submitted the change Change information Commit message: Fix a crash resulting from

Dec 29

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)7

Dec 29

[XL] Change in dart/sdk[main]: Renamed variables, formal parameters, and declared identifiers that w...

Commit Queue submitted the change Change information Commit message: Renamed variables, formal

unread,

[XL] Change in dart/sdk[main]: Renamed variables, formal parameters, and declared identifiers that w...

Commit Queue submitted the change Change information Commit message: Renamed variables, formal

Dec 29

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Dec 29

[M] Change in dart/sdk[main]: Greatly simplify _readFormalParameters and _writeFormalParameters

Commit Queue submitted the change Change information Commit message: Greatly simplify

unread,

[M] Change in dart/sdk[main]: Greatly simplify _readFormalParameters and _writeFormalParameters

Commit Queue submitted the change Change information Commit message: Greatly simplify

Dec 29

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)7

Dec 29

[L] Change in dart/sdk[main]: Remove TypeAliasFragmentImpl.aliasedElement and related simplifications.

Commit Queue submitted the change Change information Commit message: Remove TypeAliasFragmentImpl.

unread,

[L] Change in dart/sdk[main]: Remove TypeAliasFragmentImpl.aliasedElement and related simplifications.

Commit Queue submitted the change Change information Commit message: Remove TypeAliasFragmentImpl.

Dec 29

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)7

Dec 29

[XS] Change in dart/sdk[main]: Remove misleading comment.

Commit Queue submitted the change Change information Commit message: Remove misleading comment.

unread,

[XS] Change in dart/sdk[main]: Remove misleading comment.

Commit Queue submitted the change Change information Commit message: Remove misleading comment.

Dec 29

Simon Binder (Gerrit)

Dec 29

[XL] Change in dart/sdk[main]: [dart2wasm] Interfaces for accessing memories

Attention needed from Nate Biggs Simon Binder added 2 comments File sdk/lib/wasm/wasm.dart Line 114,

unread,

[XL] Change in dart/sdk[main]: [dart2wasm] Interfaces for accessing memories

Attention needed from Nate Biggs Simon Binder added 2 comments File sdk/lib/wasm/wasm.dart Line 114,

Dec 29

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)7

Dec 29

[S] Change in dart/sdk[main]: [dart2wasm] Fix --strip-wasm handling in dart compile CLI

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix --strip-wasm

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix --strip-wasm handling in dart compile CLI

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix --strip-wasm

Dec 29

Parker Lougheed (Gerrit)

Dec 28

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in `dart:core` doc comments

Attention needed from Lasse Nielsen and Slava Egorov Parker Lougheed added 1 comment File sdk/lib/

unread,

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in `dart:core` doc comments

Attention needed from Lasse Nielsen and Slava Egorov Parker Lougheed added 1 comment File sdk/lib/

Dec 28

Parker Lougheed (Gerrit), Lasse Nielsen (Gerrit)2

Dec 28

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Attention needed from Parker Lougheed and Slava Egorov Lasse Nielsen voted and added 1 comment Votes

unread,

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Attention needed from Parker Lougheed and Slava Egorov Lasse Nielsen voted and added 1 comment Votes

Dec 28

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Dec 27

[S] Change in dart/sdk[main]: DeCo. Check default values of formal parameters of primary constructors.

Commit Queue submitted the change Change information Commit message: DeCo. Check default values of

unread,

[S] Change in dart/sdk[main]: DeCo. Check default values of formal parameters of primary constructors.

Commit Queue submitted the change Change information Commit message: DeCo. Check default values of

Dec 27

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)16

Dec 26

[L] Change in dart/sdk[main]: Implement lazy reading/writing of EnumElement and EnumFragment.

Commit Queue submitted the change Change information Commit message: Implement lazy reading/writing

unread,

[L] Change in dart/sdk[main]: Implement lazy reading/writing of EnumElement and EnumFragment.

Commit Queue submitted the change Change information Commit message: Implement lazy reading/writing

Dec 26

Johnni Winther (Gerrit), Chloe Stefantsova (Gerrit)3

Dec 26

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Add Argument nodes

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

unread,

[XL] Change in dart/sdk[main]: [cfe][InternalNodes] Add Argument nodes

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

Dec 26

Konstantin Shcheglov (Gerrit)

Dec 24

[XL] Change in dart/sdk[main]: DeCo. Parse extension type primary constructor as is, recover during ...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

unread,

[XL] Change in dart/sdk[main]: DeCo. Parse extension type primary constructor as is, recover during ...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

Dec 24

Kallen Tu (Gerrit), … Konstantin Shcheglov (Gerrit)5

Dec 24

[XS] Change in dart/sdk[main]: DeCo. Remove variants without representation type from tests/language...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

unread,

[XS] Change in dart/sdk[main]: DeCo. Remove variants without representation type from tests/language...

Konstantin Shcheglov abandoned this change Related details Attention set is empty Submit Requirements

Dec 24

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)4

Dec 23

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File pkg/vm/lib/modular/

unread,

[XL] Change in dart/sdk[main]: [vm/shared] Perform deeply-immutable initialization runtime check.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File pkg/vm/lib/modular/

Dec 23

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)6

Dec 23

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Commit Queue submitted the change Change information Commit message: meta: Annotate nonVirtual with

unread,

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Commit Queue submitted the change Change information Commit message: meta: Annotate nonVirtual with

Dec 23

Daco Harkes (Gerrit), … Commit Queue (Gerrit)4

Dec 23

[M] Change in dart/sdk[main]: [test] Change the `record_use` tests to semantic equality

Commit Queue submitted the change Change information Commit message: [test] Change the `record_use`

unread,

[M] Change in dart/sdk[main]: [test] Change the `record_use` tests to semantic equality

Commit Queue submitted the change Change information Commit message: [test] Change the `record_use`

Dec 23

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)6

Dec 23

[S] Change in dart/sdk[main]: [dart2wasm] compile_benchmark: always run wasm-opt when optimizations...

Commit Queue submitted the change Change information Commit message: [dart2wasm] compile_benchmark:

unread,

[S] Change in dart/sdk[main]: [dart2wasm] compile_benchmark: always run wasm-opt when optimizations...

Commit Queue submitted the change Change information Commit message: [dart2wasm] compile_benchmark:

Dec 23

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Dec 23

[XS] Change in dart/sdk[main]: DeCo. Remove duplicate filtering for ExtensionTypeElement interfaces.

Commit Queue submitted the change Change information Commit message: DeCo. Remove duplicate filtering

unread,

[XS] Change in dart/sdk[main]: DeCo. Remove duplicate filtering for ExtensionTypeElement interfaces.

Commit Queue submitted the change Change information Commit message: DeCo. Remove duplicate filtering

Dec 23

Johnni Winther (Gerrit), … Daco Harkes (Gerrit)14

Dec 23

[XL] Change in dart/sdk[main]: [dart2js] Migrate resource identifiers output to record use

Daco Harkes added 1 comment File pkg/compiler/lib/src/ir/annotations.dart Line 428, Patchset 31:

unread,

[XL] Change in dart/sdk[main]: [dart2js] Migrate resource identifiers output to record use

Daco Harkes added 1 comment File pkg/compiler/lib/src/ir/annotations.dart Line 428, Patchset 31:

Dec 23

Johnni Winther (Gerrit)

Dec 23

[XL] Change in dart/sdk[main]: [parser][InternalNodes] Add handlePositionalArgument and handlePositi...

Attention needed from Jens Johansen Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[XL] Change in dart/sdk[main]: [parser][InternalNodes] Add handlePositionalArgument and handlePositi...

Attention needed from Jens Johansen Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

Dec 23

Search

Clear search

Close search

Google apps

Main menu