Groups

Dart Code Reviews

1–30 of 122160

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Johnni Winther (Gerrit), Chloe Stefantsova (Gerrit)2

3:34 AM

[M] Change in dart/sdk[main]: [kerne] Add verification of annotation nodes

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: [kerne] Add verification of annotation nodes

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

3:34 AM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)2

Nov 28

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted and added 5 comments

unread,

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted and added 5 comments

Nov 28

Felipe Morschel (Gerrit), … Samuel Rawlins (Gerrit)34

Nov 28

[M] Change in dart/sdk[main]: [analyzer] Fixes `initializing_formals` false-positive

Attention needed from Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: [analyzer] Fixes `initializing_formals` false-positive

Attention needed from Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-Review +1 Open in

Nov 28

Erik Ernst (Gerrit), Johnni Winther (Gerrit)4

Nov 28

[L] Change in dart/sdk[main]: Transfer parser updates of CL449821 into this CL

Attention needed from Brian Wilkerson and Johnni Winther Erik Ernst added 2 comments Patchset-level

unread,

[L] Change in dart/sdk[main]: Transfer parser updates of CL449821 into this CL

Attention needed from Brian Wilkerson and Johnni Winther Erik Ernst added 2 comments Patchset-level

Nov 28

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)8

Nov 28

[XL] Change in dart/sdk[main]: [vm] Add graph intrinsics for ThreadLocal hasValue and getValue methods.

Attention needed from Slava Egorov Alexander Aprelev voted and added 1 comment Votes added by

unread,

[XL] Change in dart/sdk[main]: [vm] Add graph intrinsics for ThreadLocal hasValue and getValue methods.

Attention needed from Slava Egorov Alexander Aprelev voted and added 1 comment Votes added by

Nov 28

Ben Konyi (Gerrit)2

Nov 28

[XL] Change in dart/sdk[main]: [ SDK ] Add `js_runtime` and `js_dev_runtime` stubs for `dart:ffi`

Attention needed from Daco Harkes and Mark Zhou Ben Konyi added 2 comments File sdk/lib/ffi/ffi.dart

unread,

[XL] Change in dart/sdk[main]: [ SDK ] Add `js_runtime` and `js_dev_runtime` stubs for `dart:ffi`

Attention needed from Daco Harkes and Mark Zhou Ben Konyi added 2 comments File sdk/lib/ffi/ffi.dart

Nov 28

Erik Ernst (Gerrit), Paul Berry (Gerrit)3

Nov 28

[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer.

Attention needed from Johnni Winther and Paul Berry Erik Ernst added 4 comments Patchset-level

unread,

[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer.

Attention needed from Johnni Winther and Paul Berry Erik Ernst added 4 comments Patchset-level

Nov 28

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Nov 28

[XS] Change in dart/sdk[main]: [analysis_server] Use `sdk.dart` instead of `Platform.resolvedExecuta...

Commit Queue submitted the change Change information Commit message: [analysis_server] Use `sdk.dart`

unread,

[XS] Change in dart/sdk[main]: [analysis_server] Use `sdk.dart` instead of `Platform.resolvedExecuta...

Commit Queue submitted the change Change information Commit message: [analysis_server] Use `sdk.dart`

Nov 28

Tess Strickland (Gerrit)

Nov 28

[S] Change in dart/sdk[main]: [vm,dyn_modules] Handle evaluation in extensions/extension type members.

Attention needed from Alexander Markov Tess Strickland added 1 comment Patchset-level comments File-

unread,

[S] Change in dart/sdk[main]: [vm,dyn_modules] Handle evaluation in extensions/extension type members.

Attention needed from Alexander Markov Tess Strickland added 1 comment Patchset-level comments File-

Nov 28

Daco Harkes (Gerrit), … Commit Queue (Gerrit)3

Nov 28

[XS] Change in dart/sdk[main]: [gardening] Skip vm/dart/use_macho_reduce_padding_flag_test on reload...

Commit Queue submitted the change Change information Commit message: [gardening] Skip vm/dart/

unread,

[XS] Change in dart/sdk[main]: [gardening] Skip vm/dart/use_macho_reduce_padding_flag_test on reload...

Commit Queue submitted the change Change information Commit message: [gardening] Skip vm/dart/

Nov 28

Johnni Winther (Gerrit), … Commit Queue (Gerrit)6

Nov 28

[S] Change in dart/sdk[stable]: [stable] [CFE/kernel] Clear invalidated ClassHierarchySubtypes

Commit Queue submitted the change Change information Commit message: [stable] [CFE/kernel] Clear

unread,

[S] Change in dart/sdk[stable]: [stable] [CFE/kernel] Clear invalidated ClassHierarchySubtypes

Commit Queue submitted the change Change information Commit message: [stable] [CFE/kernel] Clear

Nov 28

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)3

Nov 28

[M] Change in dart/sdk[main]: [dart2wasm] Fix access of constants under deferred load guard

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix access of

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Fix access of constants under deferred load guard

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix access of

Nov 28

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)5

Nov 28

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 37c5e43f9cc4ebc67422cc5c27cf2b84919a5a71

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 37c5e43f9cc4ebc67422cc5c27cf2b84919a5a71

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

Nov 28

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)3

Nov 28

[S] Change in dart/sdk[main]: [dart2wasm] Avoid O(n) scan to find module for a [Library].

Commit Queue submitted the change Change information Commit message: [dart2wasm] Avoid O(n) scan to

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Avoid O(n) scan to find module for a [Library].

Commit Queue submitted the change Change information Commit message: [dart2wasm] Avoid O(n) scan to

Nov 28

Simon Binder (Gerrit), Daco Harkes (Gerrit)5

Nov 28

[L] Change in dart/sdk[main]: [vm/ffi] Allow closing callables natively

Attention needed from Liam Appelbe and Simon Binder Daco Harkes added 1 comment File runtime/lib/ffi.

unread,

[L] Change in dart/sdk[main]: [vm/ffi] Allow closing callables natively

Attention needed from Liam Appelbe and Simon Binder Daco Harkes added 1 comment File runtime/lib/ffi.

Nov 28

Johnni Winther (Gerrit), … Commit Queue (Gerrit)4

Nov 27

[M] Change in dart/sdk[main]: Issue 61565. Use most nested package in PackageMapUriResolver. Use an...

Commit Queue submitted the change Change information Commit message: Issue 61565. Use most nested

unread,

[M] Change in dart/sdk[main]: Issue 61565. Use most nested package in PackageMapUriResolver. Use an...

Commit Queue submitted the change Change information Commit message: Issue 61565. Use most nested

Nov 27

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Nov 27

[S] Change in dart/sdk[main]: DeCo. Tests for parsing factoryHead nad newHead named explicitly 'new'.

Commit Queue submitted the change Change information Commit message: DeCo. Tests for parsing

unread,

[S] Change in dart/sdk[main]: DeCo. Tests for parsing factoryHead nad newHead named explicitly 'new'.

Commit Queue submitted the change Change information Commit message: DeCo. Tests for parsing

Nov 27

Rohit Saily (Gerrit), … Commit Queue (Gerrit)9

Nov 27

[S] Change in dart/sdk[main]: Fix `literal_only_boolean_expressions` `is` False-Positive

Commit Queue submitted the change Change information Commit message: Fix `

unread,

[S] Change in dart/sdk[main]: Fix `literal_only_boolean_expressions` `is` False-Positive

Commit Queue submitted the change Change information Commit message: Fix `

Nov 27

Felipe Morschel (Gerrit), … Samuel Rawlins (Gerrit)5

Nov 27

[S] Change in dart/sdk[main]: [DAS] Fixes false-positive on comment references for `unnecessary_und...

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-

unread,

[S] Change in dart/sdk[main]: [DAS] Fixes false-positive on comment references for `unnecessary_und...

Attention needed from Brian Wilkerson and Felipe Morschel Samuel Rawlins voted Code-Review+1 Code-

Nov 27

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Nov 27

[M] Change in dart/sdk[main]: Code cleanup in log player and server driver

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[M] Change in dart/sdk[main]: Code cleanup in log player and server driver

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Nov 27

Jens Johansen (Gerrit), … Commit Queue (Gerrit)3

Nov 27

[XL] Change in dart/sdk[main]: [cfe] Use InvalidInitializer

Commit Queue submitted the change Change information Commit message: [cfe] Use InvalidInitializer

unread,

[XL] Change in dart/sdk[main]: [cfe] Use InvalidInitializer

Commit Queue submitted the change Change information Commit message: [cfe] Use InvalidInitializer

Nov 27

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Nov 27

[M] Change in dart/sdk[main]: [kernel] Make InvalidExpression.message non-nullable

Commit Queue submitted the change Change information Commit message: [kernel] Make InvalidExpression.

unread,

[M] Change in dart/sdk[main]: [kernel] Make InvalidExpression.message non-nullable

Commit Queue submitted the change Change information Commit message: [kernel] Make InvalidExpression.

Nov 27

Felipe Morschel (Gerrit)

Nov 27

[S] Change in dart/sdk[main]: [DAS] Makes `Convert to wildcard` fix apply automatically for `unnece...

Felipe Morschel has uploaded the change for review Commit message [DAS] Makes `Convert to wildcard`

unread,

[S] Change in dart/sdk[main]: [DAS] Makes `Convert to wildcard` fix apply automatically for `unnece...

Felipe Morschel has uploaded the change for review Commit message [DAS] Makes `Convert to wildcard`

Nov 27

Nate Biggs (Gerrit), … Commit Queue (Gerrit)7

Nov 27

[M] Change in dart/sdk[main]: [kernel] Remove unused Target.instantiateNoSuchMethodError

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

unread,

[M] Change in dart/sdk[main]: [kernel] Remove unused Target.instantiateNoSuchMethodError

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

Nov 27

Johnni Winther (Gerrit), … Commit Queue (Gerrit)8

Nov 27

[L] Change in dart/sdk[main]: [kernel] Implement InvalidInitializer

Commit Queue submitted the change Change information Commit message: [kernel] Implement

unread,

[L] Change in dart/sdk[main]: [kernel] Implement InvalidInitializer

Commit Queue submitted the change Change information Commit message: [kernel] Implement

Nov 27

Kallen Tu (Gerrit), … Johnni Winther (Gerrit)6

Nov 27

[XL] Change in dart/sdk[main]: Rename 'declaring-constructors' to 'primary-constructors' experiment ...

Attention needed from Kallen Tu Johnni Winther voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[XL] Change in dart/sdk[main]: Rename 'declaring-constructors' to 'primary-constructors' experiment ...

Attention needed from Kallen Tu Johnni Winther voted Code-Review+1 Code-Review +1 Open in Gerrit

Nov 27

Kallen Tu (Gerrit)

Nov 26

[M] Change in dart/sdk[main]: [analyzer] Dot shorthands: Tests with abstract classes, factory const...

Attention needed from Paul Berry Kallen Tu added 1 comment Patchset-level comments File-level comment

unread,

[M] Change in dart/sdk[main]: [analyzer] Dot shorthands: Tests with abstract classes, factory const...

Attention needed from Paul Berry Kallen Tu added 1 comment Patchset-level comments File-level comment

Nov 26

Bob Nystrom (Gerrit), … Connie Ooi (Gerrit)13

Nov 26

[L] Change in dart/sdk[main]: [private-named-parameters] Report error if the public name collides w...

Attention needed from Bob Nystrom Connie Ooi added 2 comments File pkg/analyzer/messages.yaml Line

unread,

[L] Change in dart/sdk[main]: [private-named-parameters] Report error if the public name collides w...

Attention needed from Bob Nystrom Connie Ooi added 2 comments File pkg/analyzer/messages.yaml Line

Nov 26

Brian Wilkerson (Gerrit), … Connie Ooi (Gerrit)3

Nov 26

[XL] Change in dart/sdk[main]: Add documentation for most of the errors and warnings in analysis opt...

Attention needed from Brian Wilkerson Connie Ooi added 21 comments File pkg/analyzer/messages.yaml

unread,

[XL] Change in dart/sdk[main]: Add documentation for most of the errors and warnings in analysis opt...

Attention needed from Brian Wilkerson Connie Ooi added 21 comments File pkg/analyzer/messages.yaml

Nov 26

Felipe Morschel (Gerrit)

Nov 26

[L] Change in dart/sdk[main]: [DAS] Fixes create member fixes to correctly infer types from patterns

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes create member fixes to

unread,

[L] Change in dart/sdk[main]: [DAS] Fixes create member fixes to correctly infer types from patterns

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes create member fixes to

Nov 26

Search

Clear search

Close search

Google apps

Main menu