Groups

Dart Code Reviews

1–30 of 123767

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit)

6:35 PM

[M] Change in dart/sdk[main]: [vm] Flatten stub code handle list.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm] Flatten stub code handle list.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

6:35 PM

Ben Konyi (Gerrit), … Jaime Wren (Gerrit)3

6:12 PM

[M] Change in dart/sdk[main]: This change introduces the _findWorkspaceRoot method to locate a proj...

Jaime Wren abandoned this change. View Change Abandoned Jaime Wren abandoned this change Related

unread,

[M] Change in dart/sdk[main]: This change introduces the _findWorkspaceRoot method to locate a proj...

Jaime Wren abandoned this change. View Change Abandoned Jaime Wren abandoned this change Related

6:12 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)5

6:06 PM

[L] Change in dart/sdk[main]: Elements. Issue 62826. Support aliases for DynamicType, NeverType, Vo...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[L] Change in dart/sdk[main]: Elements. Issue 62826. Support aliases for DynamicType, NeverType, Vo...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

6:06 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)5

5:53 PM

[M] Change in dart/sdk[main]: Update the prefer-initializing-formals lint for primary constructors

Commit Queue submitted the change Change information Commit message: Update the prefer-initializing-

unread,

[M] Change in dart/sdk[main]: Update the prefer-initializing-formals lint for primary constructors

Commit Queue submitted the change Change information Commit message: Update the prefer-initializing-

5:53 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

5:03 PM

[M] Change in dart/sdk[main]: analyzer: Cache analysis options during _ContextLocator tasks

Commit Queue submitted the change Change information Commit message: analyzer: Cache analysis options

unread,

[M] Change in dart/sdk[main]: analyzer: Cache analysis options during _ContextLocator tasks

Commit Queue submitted the change Change information Commit message: analyzer: Cache analysis options

5:03 PM

Jake Macdonald (Gerrit), Ben Konyi (Gerrit)8

4:53 PM

[S] Change in dart/sdk[main]: add appName to startDartDevelopmentService, forward to DTD

Attention needed from Ben Konyi and Ryan Macnak Jake Macdonald added 1 comment File tools/bots/

unread,

[S] Change in dart/sdk[main]: add appName to startDartDevelopmentService, forward to DTD

Attention needed from Ben Konyi and Ryan Macnak Jake Macdonald added 1 comment File tools/bots/

4:53 PM

Paul Berry (Gerrit), Konstantin Shcheglov (Gerrit)2

4:07 PM

[M] Change in dart/sdk[main]: Issue 54820. Fixes for neverOrNull?.foo() resolution and 'null as Nev...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: Issue 54820. Fixes for neverOrNull?.foo() resolution and 'null as Nev...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov added 1 comment File pkg/

4:07 PM

Ben Konyi (Gerrit), … Nicholas Shahan (Gerrit)3

2:17 PM

[M] Change in dart/sdk[main]: [ Service ] Add support for binary events in package:dart_runtime_ser...

Attention needed from Ben Konyi Nicholas Shahan added 1 comment File pkg/dart_runtime_service/lib/src

unread,

[M] Change in dart/sdk[main]: [ Service ] Add support for binary events in package:dart_runtime_ser...

Attention needed from Ben Konyi Nicholas Shahan added 1 comment File pkg/dart_runtime_service/lib/src

2:17 PM

Ben Konyi (Gerrit), Nicholas Shahan (Gerrit)2

2:16 PM

[M] Change in dart/sdk[main]: [ Service ] Cleanup dart_runtime_service* logging and DDS state

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan added 4 comments File pkg/

unread,

[M] Change in dart/sdk[main]: [ Service ] Cleanup dart_runtime_service* logging and DDS state

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan added 4 comments File pkg/

2:16 PM

Keerti Parthasarathy (Gerrit), … Commit Queue (Gerrit)5

2:15 PM

[M] Change in dart/sdk[main]: Add more fine grained timings while computing fixes

Commit Queue submitted the change Change information Commit message: Add more fine grained timings

unread,

[M] Change in dart/sdk[main]: Add more fine grained timings while computing fixes

Commit Queue submitted the change Change information Commit message: Add more fine grained timings

2:15 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

2:11 PM

[XS] Change in dart/sdk[main]: DDS: Use named parameters in a few missed places

Commit Queue submitted the change Change information Commit message: DDS: Use named parameters in a

unread,

[XS] Change in dart/sdk[main]: DDS: Use named parameters in a few missed places

Commit Queue submitted the change Change information Commit message: DDS: Use named parameters in a

2:11 PM

Ben Konyi (Gerrit), Nicholas Shahan (Gerrit)2

2:01 PM

[S] Change in dart/sdk[main]: [ Service ] Fix various tests for package:dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

unread,

[S] Change in dart/sdk[main]: [ Service ] Fix various tests for package:dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

2:01 PM

Ben Konyi (Gerrit), Nicholas Shahan (Gerrit)2

1:59 PM

[M] Change in dart/sdk[main]: [ Service ] Add support for ID zones to package:dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

unread,

[M] Change in dart/sdk[main]: [ Service ] Add support for ID zones to package:dart_runtime_service_vm

Attention needed from Ben Konyi and Jessy Yameogo Nicholas Shahan voted and added 1 comment Votes

1:59 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

1:13 PM

[XS] Change in dart/sdk[main]: [vm, profiler] Don't attempt a Dart stack walk during FFI leaf calls.

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[XS] Change in dart/sdk[main]: [vm, profiler] Don't attempt a Dart stack walk during FFI leaf calls.

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

1:13 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)5

12:30 PM

[M] Change in dart/sdk[main]: Update the documentation on refactors to be more clear

Commit Queue submitted the change Change information Commit message: Update the documentation on

unread,

[M] Change in dart/sdk[main]: Update the documentation on refactors to be more clear

Commit Queue submitted the change Change information Commit message: Update the documentation on

12:30 PM

Kevin Moore (Gerrit), … Commit Queue (Gerrit)7

12:15 PM

[L] Change in dart/sdk[main]: Fix simple_directive_paths violations in compiler

Commit Queue submitted the change Change information Commit message: Fix simple_directive_paths

unread,

[L] Change in dart/sdk[main]: Fix simple_directive_paths violations in compiler

Commit Queue submitted the change Change information Commit message: Fix simple_directive_paths

12:15 PM

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)2

11:57 AM

[L] Change in dart/sdk[main]: analyzer: New warning for deprecated directive configurations

Attention needed from Samuel Rawlins Brian Wilkerson voted and added 7 comments Votes added by Brian

unread,

[L] Change in dart/sdk[main]: analyzer: New warning for deprecated directive configurations

Attention needed from Samuel Rawlins Brian Wilkerson voted and added 7 comments Votes added by Brian

11:57 AM

Brian Wilkerson (Gerrit), … Danny Tuppeny (Gerrit)12

11:47 AM

[L] Change in dart/sdk[main]: Add a refactor to remove a name from a constructor

Danny Tuppeny added 1 comment File pkg/analysis_server/lib/src/services/refactoring/

unread,

[L] Change in dart/sdk[main]: Add a refactor to remove a name from a constructor

Danny Tuppeny added 1 comment File pkg/analysis_server/lib/src/services/refactoring/

11:47 AM

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

11:22 AM

[XS] Change in dart/sdk[main]: [_fe_analyzer_shared] Use named super parameters in a few missed cases.

Commit Queue submitted the change Change information Commit message: [_fe_analyzer_shared] Use named

unread,

[XS] Change in dart/sdk[main]: [_fe_analyzer_shared] Use named super parameters in a few missed cases.

Commit Queue submitted the change Change information Commit message: [_fe_analyzer_shared] Use named

11:22 AM

Danny Tuppeny (Gerrit), … Brian Wilkerson (Gerrit)5

11:10 AM

[M] Change in dart/sdk[main]: [analysis_server] Fix nested paths in log normalization

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson added 1 comment File pkg

unread,

[M] Change in dart/sdk[main]: [analysis_server] Fix nested paths in log normalization

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson added 1 comment File pkg

11:10 AM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

11:01 AM

[M] Change in dart/sdk[main]: [DAS] Use named super parameters in a few missed cases.

Commit Queue submitted the change Change information Commit message: [DAS] Use named super parameters

unread,

[M] Change in dart/sdk[main]: [DAS] Use named super parameters in a few missed cases.

Commit Queue submitted the change Change information Commit message: [DAS] Use named super parameters

11:01 AM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

10:48 AM

[M] Change in dart/sdk[main]: Update RenameExtensionMethod to use a ChangeBuilder

Commit Queue submitted the change Change information Commit message: Update RenameExtensionMethod to

unread,

[M] Change in dart/sdk[main]: Update RenameExtensionMethod to use a ChangeBuilder

Commit Queue submitted the change Change information Commit message: Update RenameExtensionMethod to

10:48 AM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Mar 29

[XS] Change in dart/sdk[main]: [analysis_server] Improve error when tests fail to get a reverse-requ...

Commit Queue submitted the change Change information Commit message: [analysis_server] Improve error

unread,

[XS] Change in dart/sdk[main]: [analysis_server] Improve error when tests fail to get a reverse-requ...

Commit Queue submitted the change Change information Commit message: [analysis_server] Improve error

Mar 29

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Mar 28

[M] Change in dart/sdk[main]: Update prefer-final-fields for primary constructors

Commit Queue submitted the change Change information Commit message: Update prefer-final-fields for

unread,

[M] Change in dart/sdk[main]: Update prefer-final-fields for primary constructors

Commit Queue submitted the change Change information Commit message: Update prefer-final-fields for

Mar 28

Konstantin Shcheglov (Gerrit), Fedor Shcheglov (Gerrit)7

Mar 28

[XL] Change in dart/sdk[main]: Do not report missingFunctionBody when augmentation flag is set.

Fedor Shcheglov added 3 comments File pkg/analyzer/test/src/dart/parser/class_test.dart Line 1419,

unread,

[XL] Change in dart/sdk[main]: Do not report missingFunctionBody when augmentation flag is set.

Fedor Shcheglov added 3 comments File pkg/analyzer/test/src/dart/parser/class_test.dart Line 1419,

Mar 28

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)11

Mar 28

[S] Change in dart/sdk[main]: [analysis_server] Include declaring parameters in member declarations...

Commit Queue submitted the change Change information Commit message: [analysis_server] Include

unread,

[S] Change in dart/sdk[main]: [analysis_server] Include declaring parameters in member declarations...

Commit Queue submitted the change Change information Commit message: [analysis_server] Include

Mar 28

Johnni Winther (Gerrit), Konstantin Shcheglov (Gerrit)2

Mar 28

[XS] Change in dart/sdk[main]: [analyzer] Let scanner skip comments in outline

Attention needed from Jens Johansen Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[XS] Change in dart/sdk[main]: [analyzer] Let scanner skip comments in outline

Attention needed from Jens Johansen Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

Mar 28

Nourhan Hasan (Gerrit)

Mar 28

[M] Change in dart/sdk[main]: [vm/service]: use a map for service ID zones to avoid ID reuse and un...

Attention needed from Ben Konyi and Ryan Macnak Nourhan Hasan voted and added 1 comment Votes added

unread,

[M] Change in dart/sdk[main]: [vm/service]: use a map for service ID zones to avoid ID reuse and un...

Attention needed from Ben Konyi and Ryan Macnak Nourhan Hasan voted and added 1 comment Votes added

Mar 28

Nourhan Hasan (Gerrit), … Ben Konyi (Gerrit)6

Mar 28

[S] Change in dart/sdk[main]: [vm/service]: reuse deleted ID zone slots to bound array growth (#62205)

Attention needed from Ben Konyi and Ryan Macnak Nourhan Hasan removed Liam Appelbe from this change

unread,

[S] Change in dart/sdk[main]: [vm/service]: reuse deleted ID zone slots to bound array growth (#62205)

Attention needed from Ben Konyi and Ryan Macnak Nourhan Hasan removed Liam Appelbe from this change

Mar 28

Nicholas Shahan (Gerrit), … Oscar García Pineda (Gerrit)3

Mar 28

[XL] Change in dart/sdk[main]: [dwds_test_common] Migrate package to the SDK repository

Attention needed from Ben Konyi, Jessy Yameogo, Mark Zhou and Nicholas Shahan Oscar García Pineda

unread,

[XL] Change in dart/sdk[main]: [dwds_test_common] Migrate package to the SDK repository

Attention needed from Ben Konyi, Jessy Yameogo, Mark Zhou and Nicholas Shahan Oscar García Pineda

Mar 28

Search

Clear search

Close search

Google apps

Main menu