Groups

Dart Code Reviews

1–30 of 123141

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit)

6:13 PM

[M] Change in dart/sdk[main]: [vm] Use /Zc:preprocessor to get __VA_OPT__ under MSVC.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [vm] Use /Zc:preprocessor to get __VA_OPT__ under MSVC.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

6:13 PM

Samuel Rawlins (Gerrit), … Brian Wilkerson (Gerrit)5

5:50 PM

[M] Change in dart/sdk[main]: Add AnalysisRule.reportAtSourceRange

Attention needed from Brian Wilkerson and Konstantin Shcheglov Samuel Rawlins added 1 comment

unread,

[M] Change in dart/sdk[main]: Add AnalysisRule.reportAtSourceRange

Attention needed from Brian Wilkerson and Konstantin Shcheglov Samuel Rawlins added 1 comment

5:50 PM

Erik Ernst (Gerrit), … Paul Berry (Gerrit)4

5:28 PM

[L] Change in dart/sdk[main]: Implement analyzer support for `=>` anonymous methods

Attention needed from Brian Wilkerson and Erik Ernst Paul Berry added 4 comments File pkg/analyzer/

unread,

[L] Change in dart/sdk[main]: Implement analyzer support for `=>` anonymous methods

Attention needed from Brian Wilkerson and Erik Ernst Paul Berry added 4 comments File pkg/analyzer/

5:28 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

5:25 PM

[M] Change in dart/sdk[main]: [vm] Replace GCC __builtin_expect with C++20 [[likely]] attributes.

Commit Queue submitted the change Change information Commit message: [vm] Replace GCC

unread,

[M] Change in dart/sdk[main]: [vm] Replace GCC __builtin_expect with C++20 [[likely]] attributes.

Commit Queue submitted the change Change information Commit message: [vm] Replace GCC

5:25 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

5:15 PM

[M] Change in dart/sdk[main]: [vm] Remove helpers for pre-C++11 64-bit literals.

Commit Queue submitted the change Change information Commit message: [vm] Remove helpers for pre-C++

unread,

[M] Change in dart/sdk[main]: [vm] Remove helpers for pre-C++11 64-bit literals.

Commit Queue submitted the change Change information Commit message: [vm] Remove helpers for pre-C++

5:15 PM

Lasse Nielsen (Gerrit), … Nate Bosch (Gerrit)6

5:03 PM

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `pkg/`.

Attention needed from Johnni Winther, Lasse Nielsen and Mayank Patke Nate Bosch voted Code-Review+1

unread,

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `pkg/`.

Attention needed from Johnni Winther, Lasse Nielsen and Mayank Patke Nate Bosch voted Code-Review+1

5:03 PM

Kevin Moore (Gerrit), … Nate Bosch (Gerrit)7

5:00 PM

[L] Change in dart/sdk[main]: [dart2wasm] Simd for vector math

Attention needed from Kevin Moore and Nate Biggs Nate Bosch added 1 comment Patchset-level comments

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Simd for vector math

Attention needed from Kevin Moore and Nate Biggs Nate Bosch added 1 comment Patchset-level comments

5:00 PM

Bob Nystrom (Gerrit), … Konstantin Shcheglov (Gerrit)3

4:53 PM

[M] Change in dart/sdk[main]: Enable "private-named-parameters" experiment flag.

Attention needed from Bob Nystrom, Morgan :) and Ryan Macnak Konstantin Shcheglov voted Code-Review+1

unread,

[M] Change in dart/sdk[main]: Enable "private-named-parameters" experiment flag.

Attention needed from Bob Nystrom, Morgan :) and Ryan Macnak Konstantin Shcheglov voted Code-Review+1

4:53 PM

Keerti Parthasarathy (Gerrit), … Commit Queue (Gerrit)5

4:48 PM

[S] Change in dart/sdk[main]: Keep track of all congiguration messages

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[S] Change in dart/sdk[main]: Keep track of all congiguration messages

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

4:48 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

1:59 PM

[M] Change in dart/sdk[main]: analyzer: Mark types specified in type arguments and variable declara...

Commit Queue submitted the change Change information Commit message: analyzer: Mark types specified

unread,

[M] Change in dart/sdk[main]: analyzer: Mark types specified in type arguments and variable declara...

Commit Queue submitted the change Change information Commit message: analyzer: Mark types specified

1:59 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

1:53 PM

[S] Change in dart/sdk[main]: Start analyzer 10.2.0-dev, analyzer_plugin 0.14.4-dev, analyzer_testi...

Commit Queue submitted the change Change information Commit message: Start analyzer 10.2.0-dev,

unread,

[S] Change in dart/sdk[main]: Start analyzer 10.2.0-dev, analyzer_plugin 0.14.4-dev, analyzer_testi...

Commit Queue submitted the change Change information Commit message: Start analyzer 10.2.0-dev,

1:53 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

1:41 PM

[XS] Change in dart/sdk[main]: Update icu to a86a32e67b8d1384b33f8fa48c83a6079b86f8cd.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[XS] Change in dart/sdk[main]: Update icu to a86a32e67b8d1384b33f8fa48c83a6079b86f8cd.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

1:41 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)9

1:32 PM

[M] Change in dart/sdk[main]: linter: Support primary constructors in sort{,_unnamed}_constructors_...

Commit Queue submitted the change Change information Commit message: linter: Support primary

unread,

[M] Change in dart/sdk[main]: linter: Support primary constructors in sort{,_unnamed}_constructors_...

Commit Queue submitted the change Change information Commit message: linter: Support primary

1:32 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

1:31 PM

[L] Change in dart/sdk[main]: [vm] Remove CallLeafRuntimeStubCode test.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[L] Change in dart/sdk[main]: [vm] Remove CallLeafRuntimeStubCode test.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

1:31 PM

Danny Tuppeny (Gerrit), … Samuel Rawlins (Gerrit)8

1:26 PM

[XS] Change in dart/sdk[main]: [deps] rev tools to 119a499068a903222fbbefdea18ea59efdd417b9

Attention needed from Brian Wilkerson and Samuel Rawlins Danny Tuppeny added 1 comment Patchset-level

unread,

[XS] Change in dart/sdk[main]: [deps] rev tools to 119a499068a903222fbbefdea18ea59efdd417b9

Attention needed from Brian Wilkerson and Samuel Rawlins Danny Tuppeny added 1 comment Patchset-level

1:26 PM

Daco Harkes (Gerrit), … Samuel Rawlins (Gerrit)16

1:25 PM

[L] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest):

unread,

[L] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest):

1:25 PM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

1:09 PM

[S] Change in dart/sdk[main]: DAS: Test that unused parameters can be removed from primary construc...

Commit Queue submitted the change Change information Commit message: DAS: Test that unused parameters

unread,

[S] Change in dart/sdk[main]: DAS: Test that unused parameters can be removed from primary construc...

Commit Queue submitted the change Change information Commit message: DAS: Test that unused parameters

1:09 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

1:05 PM

[M] Change in dart/sdk[main]: [DAS] Fixes some `Replace 'final' with 'var'` false-negatives

Commit Queue submitted the change Change information Commit message: [DAS] Fixes some `Replace '

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes some `Replace 'final' with 'var'` false-negatives

Commit Queue submitted the change Change information Commit message: [DAS] Fixes some `Replace '

1:05 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)6

12:46 PM

[M] Change in dart/sdk[main]: analyzer: Implement "do not tear-off function with @mustBeConst param...

Commit Queue submitted the change Change information Commit message: analyzer: Implement "do not

unread,

[M] Change in dart/sdk[main]: analyzer: Implement "do not tear-off function with @mustBeConst param...

Commit Queue submitted the change Change information Commit message: analyzer: Implement "do not

12:46 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

12:20 PM

[S] Change in dart/sdk[main]: Prepare to publish analyzer 10.1.0, _fe_analyzer_shared 95.0.0, analy...

Commit Queue submitted the change Change information Commit message: Prepare to publish analyzer 10.1

unread,

[S] Change in dart/sdk[main]: Prepare to publish analyzer 10.1.0, _fe_analyzer_shared 95.0.0, analy...

Commit Queue submitted the change Change information Commit message: Prepare to publish analyzer 10.1

12:20 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

12:13 PM

[XS] Change in dart/sdk[main]: CQ. Remove GenericFunctionTypeImpl type not set workaround from Scope...

Commit Queue submitted the change Change information Commit message: CQ. Remove

unread,

[XS] Change in dart/sdk[main]: CQ. Remove GenericFunctionTypeImpl type not set workaround from Scope...

Commit Queue submitted the change Change information Commit message: CQ. Remove

12:13 PM

Elliott Brooks (Gerrit), … Nate Biggs (Gerrit)5

12:08 PM

[XS] Change in dart/sdk[beta]: [beta] Cherry-pick DevTools 2.55.0

Attention needed from Kenzie Davisson Elliott Brooks voted Commit-Queue+2 Commit-Queue +2 Open in

unread,

[XS] Change in dart/sdk[beta]: [beta] Cherry-pick DevTools 2.55.0

Attention needed from Kenzie Davisson Elliott Brooks voted Commit-Queue+2 Commit-Queue +2 Open in

12:08 PM

Daco Harkes (Gerrit), Nate Biggs (Gerrit)3

11:45 AM

[L] Change in dart/sdk[main]: [record_use] Record kinds and disambiguators

Attention needed from Daco Harkes and Johnni Winther Nate Biggs added 4 comments File pkg/compiler/

unread,

[L] Change in dart/sdk[main]: [record_use] Record kinds and disambiguators

Attention needed from Daco Harkes and Johnni Winther Nate Biggs added 4 comments File pkg/compiler/

11:45 AM

Sigmund Cherem (Gerrit), Alexander Markov (Gerrit)2

11:35 AM

[S] Change in dart/sdk[main]: [dyn_modules] add snapshot target for faster iteration.

Attention needed from Sigmund Cherem Alexander Markov voted and added 1 comment Votes added by

unread,

[S] Change in dart/sdk[main]: [dyn_modules] add snapshot target for faster iteration.

Attention needed from Sigmund Cherem Alexander Markov voted and added 1 comment Votes added by

11:35 AM

Sigmund Cherem (Gerrit), Alexander Markov (Gerrit)2

11:32 AM

[S] Change in dart/sdk[main]: [dyn_modules] allow extension_type key in dynamic interface.

Attention needed from Sigmund Cherem Alexander Markov added 6 comments Patchset-level comments File-

unread,

[S] Change in dart/sdk[main]: [dyn_modules] allow extension_type key in dynamic interface.

Attention needed from Sigmund Cherem Alexander Markov added 6 comments Patchset-level comments File-

11:32 AM

Nate Bosch (Gerrit), … Commit Queue (Gerrit)3

11:29 AM

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `test/`.

Commit Queue submitted the change Change information Commit message: Remove `var` and `final` from

unread,

[L] Change in dart/sdk[main]: Remove `var` and `final` from parameters in `test/`.

Commit Queue submitted the change Change information Commit message: Remove `var` and `final` from

11:29 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)3

11:06 AM

[M] Change in dart/sdk[main]: [vm,dyn_modules] Rename DebugCheck to Noop and use after debugger() c...

Attention needed from Tess Strickland Alexander Markov added 1 comment File pkg/dart2bytecode/lib/

unread,

[M] Change in dart/sdk[main]: [vm,dyn_modules] Rename DebugCheck to Noop and use after debugger() c...

Attention needed from Tess Strickland Alexander Markov added 1 comment File pkg/dart2bytecode/lib/

11:06 AM

Alexander Markov (Gerrit), Martin Kustermann (Gerrit)9

10:39 AM

[M] Change in dart/sdk[main]: [tfa] Prevent deferred constant accesses to be propagated

Attention needed from Martin Kustermann Alexander Markov added 1 comment File pkg/vm/lib/

unread,

[M] Change in dart/sdk[main]: [tfa] Prevent deferred constant accesses to be propagated

Attention needed from Martin Kustermann Alexander Markov added 1 comment File pkg/vm/lib/

10:39 AM

Lasse Nielsen (Gerrit), Samuel Rawlins (Gerrit)2

10:34 AM

[L] Change in dart/sdk[main]: Update `package:meta` API and docs.

Attention needed from Lasse Nielsen Samuel Rawlins voted and added 1 comment Votes added by Samuel

unread,

[L] Change in dart/sdk[main]: Update `package:meta` API and docs.

Attention needed from Lasse Nielsen Samuel Rawlins voted and added 1 comment Votes added by Samuel

10:34 AM

Martin Kustermann (Gerrit), … Commit Queue (Gerrit)4

3:03 AM

[S] Change in dart/sdk[main]: [dart2wasm] Fix issue of copying mixin applications with deferred pre...

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix issue of copying

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix issue of copying mixin applications with deferred pre...

Commit Queue submitted the change Change information Commit message: [dart2wasm] Fix issue of copying

3:03 AM

Search

Clear search

Close search

Google apps

Main menu