Groups

Dart Code Reviews

1–30 of 124106

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:30 AM

[M] Change in dart/sdk[main]: [modular_aot] Avoid generating code for instance members of mixins

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [modular_aot] Avoid generating code for instance members of mixins

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

9:30 AM

Chloe Stefantsova (Gerrit), Johnni Winther (Gerrit)2

9:29 AM

[L] Change in dart/sdk[main]: [cfe] Don't create old variables when the experiment is enabled

Attention needed from Chloe Stefantsova Johnni Winther voted and added 5 comments Votes added by

unread,

[L] Change in dart/sdk[main]: [cfe] Don't create old variables when the experiment is enabled

Attention needed from Chloe Stefantsova Johnni Winther voted and added 5 comments Votes added by

9:29 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:22 AM

[M] Change in dart/sdk[main]: [modular_aot] Define type arguments field in the built-in classes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [modular_aot] Define type arguments field in the built-in classes

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

9:22 AM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

9:19 AM

[L] Change in dart/sdk[main]: [modular_aot] Translate async/async*/sync*/await/yield/yield* to CFG IR

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [modular_aot] Translate async/async*/sync*/await/yield/yield* to CFG IR

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

9:19 AM

Martin Kustermann (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

9:14 AM

[L] Change in dart/sdk[main]: Fix cookie-date parsing to use the correct algorithm.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: Fix cookie-date parsing to use the correct algorithm.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

9:14 AM

Jonas Jensen (Gerrit)

9:07 AM

[XS] Change in dart/sdk[main]: Don't send crash data when dart:io is unavailable.

Attention needed from Konstantin Shcheglov Jonas Jensen voted Auto-Submit+1 Auto-Submit +1 Open in

unread,

[XS] Change in dart/sdk[main]: Don't send crash data when dart:io is unavailable.

Attention needed from Konstantin Shcheglov Jonas Jensen voted Auto-Submit+1 Auto-Submit +1 Open in

9:07 AM

Tess Strickland (Gerrit), Alexander Markov (Gerrit)3

8:31 AM

[S] Change in dart/sdk[main]: [vm,dynamic_modules] Add private FFI callables to dynamic_interface.yaml

Attention needed from Alexander Markov Tess Strickland added 1 comment File utils/

unread,

[S] Change in dart/sdk[main]: [vm,dynamic_modules] Add private FFI callables to dynamic_interface.yaml

Attention needed from Alexander Markov Tess Strickland added 1 comment File utils/

8:31 AM

FMorschel (Gerrit), Danny Tuppeny (Gerrit)2

5:16 AM

[M] Change in dart/sdk[main]: [DAS] Fixes occurrences for declaring parameters

Attention needed from Brian Wilkerson, FMorschel and Samuel Rawlins Danny Tuppeny added 6 comments

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes occurrences for declaring parameters

Attention needed from Brian Wilkerson, FMorschel and Samuel Rawlins Danny Tuppeny added 6 comments

5:16 AM

Johnni Winther (Gerrit)

5:08 AM

[M] Change in dart/sdk[main]: Issue 63206. Use MissingRequiredSdkClassException to report from Type...

Attention needed from Brian Wilkerson and Konstantin Shcheglov Johnni Winther voted Code-Review+1

unread,

[M] Change in dart/sdk[main]: Issue 63206. Use MissingRequiredSdkClassException to report from Type...

Attention needed from Brian Wilkerson and Konstantin Shcheglov Johnni Winther voted Code-Review+1

5:08 AM

Konstantin Shcheglov (Gerrit), Johnni Winther (Gerrit)2

5:06 AM

[XL] Change in dart/sdk[main]: DeCo. Issue 63214. Add new tests for primary constructors and warnings.

Attention needed from Konstantin Shcheglov Johnni Winther voted and added 2 comments Votes added by

unread,

[XL] Change in dart/sdk[main]: DeCo. Issue 63214. Add new tests for primary constructors and warnings.

Attention needed from Konstantin Shcheglov Johnni Winther voted and added 2 comments Votes added by

5:06 AM

Daco Harkes (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

4:47 AM

[XS] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:47 AM

Alexander Aprelev (Gerrit), Slava Egorov (Gerrit)6

4:39 AM

[L] Change in dart/sdk[main]: [vm/shared] Introduce isolate event loop handling dart api.

Attention needed from Alexander Aprelev and Ryan Macnak Slava Egorov added 7 comments Patchset-level

unread,

[L] Change in dart/sdk[main]: [vm/shared] Introduce isolate event loop handling dart api.

Attention needed from Alexander Aprelev and Ryan Macnak Slava Egorov added 7 comments Patchset-level

4:39 AM

Jens Johansen (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

4:19 AM

[XL] Change in dart/sdk[main]: [CFE] Set proper endOffset on constructor from primary constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: [CFE] Set proper endOffset on constructor from primary constructor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

4:19 AM

Modestas Valauskas (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

3:01 AM

[M] Change in dart/sdk[main]: [vm/compiler] Specialize Int32x4 operators in AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [vm/compiler] Specialize Int32x4 operators in AOT.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:01 AM

Nicholas Shahan (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)7

2:26 AM

[L] Change in dart/sdk[main]: Reapply "[kernel/cfe/etc] Split outline transformation into performOu...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Reapply "[kernel/cfe/etc] Split outline transformation into performOu...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:26 AM

Nate Bosch (Gerrit)

Apr 21

[S] Change in dart/sdk[main]: Move moving forward revisions for: ai, core, dartdoc, ecosystem, i18n...

Attention needed from Brian Quinlan Nate Bosch has uploaded the change for review Nate Bosch would

unread,

[S] Change in dart/sdk[main]: Move moving forward revisions for: ai, core, dartdoc, ecosystem, i18n...

Attention needed from Brian Quinlan Nate Bosch has uploaded the change for review Nate Bosch would

Apr 21

Felipe Morschel (Gerrit), … Samuel Rawlins (Gerrit)4

Apr 21

[M] Change in dart/sdk[main]: [linter] Fixes `simplify_variable_pattern` for typedefs and type para...

Attention needed from Brian Wilkerson and FMorschel Samuel Rawlins voted Code-Review+1 Code-Review +1

unread,

[M] Change in dart/sdk[main]: [linter] Fixes `simplify_variable_pattern` for typedefs and type para...

Attention needed from Brian Wilkerson and FMorschel Samuel Rawlins voted Code-Review+1 Code-Review +1

Apr 21

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Apr 21

[L] Change in dart/sdk[main]: Add new unnecessary_type_name_in_constructor lint

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[L] Change in dart/sdk[main]: Add new unnecessary_type_name_in_constructor lint

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Apr 21

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Apr 21

[S] Change in dart/sdk[main]: [vm] Remove irregular canonical bits.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

unread,

[S] Change in dart/sdk[main]: [vm] Remove irregular canonical bits.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 1

Apr 21

Helin Shiah (Gerrit), Brian Wilkerson (Gerrit)2

Apr 21

[S] Change in dart/sdk[main]: Send IDE and plugin info to analytics

Attention needed from Helin Shiah and Keerti Parthasarathy Brian Wilkerson added 1 comment File pkg/

unread,

[S] Change in dart/sdk[main]: Send IDE and plugin info to analytics

Attention needed from Helin Shiah and Keerti Parthasarathy Brian Wilkerson added 1 comment File pkg/

Apr 21

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Apr 21

[M] Change in dart/sdk[main]: linter: use_late_for_private_fields_and_variables: count field formal...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: linter: use_late_for_private_fields_and_variables: count field formal...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Samuel Rawlins (Gerrit)

Apr 21

[M] Change in dart/sdk[main]: Build devtools with a Python script, rather than Dart

Attention needed from Ivan Inozemtsev and Kenzie Davisson Samuel Rawlins added 1 comment Patchset-

unread,

[M] Change in dart/sdk[main]: Build devtools with a Python script, rather than Dart

Attention needed from Ivan Inozemtsev and Kenzie Davisson Samuel Rawlins added 1 comment Patchset-

Apr 21

Keerti Parthasarathy (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Apr 21

[M] Change in dart/sdk[main]: [primary constructor]Add tests for property editor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [primary constructor]Add tests for property editor

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Apr 21

[M] Change in dart/sdk[main]: linter: Fix false positive with parameter_assignments and negate oper...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: linter: Fix false positive with parameter_assignments and negate oper...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Apr 21

[M] Change in dart/sdk[main]: analyzer: Report invalid @internal annotation on primary constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: analyzer: Report invalid @internal annotation on primary constructors

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Konstantin Shcheglov (Gerrit), … Ryan Macnak (Gerrit)17

Apr 21

[XL] Change in dart/sdk[main]: Breaking changes for analyzer 13.0.0

Konstantin Shcheglov added 1 comment Patchset-level comments File-level comment, Patchset 44 (Latest)

unread,

[XL] Change in dart/sdk[main]: Breaking changes for analyzer 13.0.0

Konstantin Shcheglov added 1 comment Patchset-level comments File-level comment, Patchset 44 (Latest)

Apr 21

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Apr 21

[S] Change in dart/sdk[main]: Elements. Remove MixinFragment.superclassConstraints

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Elements. Remove MixinFragment.superclassConstraints

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Konstantin Shcheglov (Gerrit), … Brian Wilkerson (Gerrit)6

Apr 21

[M] Change in dart/sdk[main]: Issue 56118. Add DartObject.toTypeValueNotExtensionTypeErased() as ex...

Attention needed from Konstantin Shcheglov Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: Issue 56118. Add DartObject.toTypeValueNotExtensionTypeErased() as ex...

Attention needed from Konstantin Shcheglov Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

Apr 21

Alexander Aprelev (Gerrit)

Apr 21

[L] Change in dart/sdk[main]: [vm/shared] Implement Isolate runEventLoopSync.

Attention needed from Slava Egorov Alexander Aprelev voted and added 1 comment Votes added by

unread,

[L] Change in dart/sdk[main]: [vm/shared] Implement Isolate runEventLoopSync.

Attention needed from Slava Egorov Alexander Aprelev voted and added 1 comment Votes added by

Apr 21

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Apr 21

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Treat enum generative constructors as impl...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Treat enum generative constructors as impl...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Apr 21

Search

Clear search

Close search

Google apps

Main menu