Groups

Dart Code Reviews

1–30 of 121057

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Alexander Aprelev (Gerrit)

4:45 PM

[XL] Change in dart/sdk[main]: Revert "Reapply "[vm/shared] Ensure to iterate over mutators, rather ...

Attention needed from Brian Quinlan Alexander Aprelev voted Auto-Submit +1 Commit-Queue +1 Open in

unread,

[XL] Change in dart/sdk[main]: Revert "Reapply "[vm/shared] Ensure to iterate over mutators, rather ...

Attention needed from Brian Quinlan Alexander Aprelev voted Auto-Submit +1 Commit-Queue +1 Open in

4:45 PM

Brian Wilkerson (Gerrit)

4:37 PM

[L] Change in dart/sdk[main]: DAS plugins: analyze and report diagnostics in parts

Attention needed from Samuel Rawlins Brian Wilkerson voted and added 1 comment Votes added by Brian

unread,

[L] Change in dart/sdk[main]: DAS plugins: analyze and report diagnostics in parts

Attention needed from Samuel Rawlins Brian Wilkerson voted and added 1 comment Votes added by Brian

4:37 PM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)3

4:29 PM

[S] Change in dart/sdk[main]: [DAS] Adds priority tests for `CHANGE_TYPE_ANNOTATION` fix

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted and added 2 comments

unread,

[S] Change in dart/sdk[main]: [DAS] Adds priority tests for `CHANGE_TYPE_ANNOTATION` fix

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted and added 2 comments

4:29 PM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

4:16 PM

[M] Change in dart/sdk[main]: Fine. Use shared _writelnIdList(), distinguish 'not asked' from 'empty'.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[M] Change in dart/sdk[main]: Fine. Use shared _writelnIdList(), distinguish 'not asked' from 'empty'.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

4:16 PM

Felipe Morschel (Gerrit), Paul Berry (Gerrit)2

3:37 PM

[S] Change in dart/sdk[main]: [analyzer] Fixes dart path on Windows for DartFormat

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

unread,

[S] Change in dart/sdk[main]: [analyzer] Fixes dart path on Windows for DartFormat

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

3:37 PM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)6

3:24 PM

[L] Change in dart/sdk[main]: Fine. More @trackedXyz annotations.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

unread,

[L] Change in dart/sdk[main]: Fine. More @trackedXyz annotations.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

3:24 PM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)4

3:19 PM

[L] Change in dart/sdk[main]: Fine. Track hasNonFinalField in manifests and requirements.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved

unread,

[L] Change in dart/sdk[main]: Fine. Track hasNonFinalField in manifests and requirements.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved

3:19 PM

Alexander Aprelev (Gerrit), … Commit Queue (Gerrit)5

3:13 PM

[XL] Change in dart/sdk[main]: Reapply "[vm/shared] Ensure to iterate over mutators, rather than onl...

Commit Queue submitted the change Change information Commit message: Reapply "[vm/shared] Ensure

unread,

[XL] Change in dart/sdk[main]: Reapply "[vm/shared] Ensure to iterate over mutators, rather than onl...

Commit Queue submitted the change Change information Commit message: Reapply "[vm/shared] Ensure

3:13 PM

Parker Lougheed (Gerrit), … Slava Egorov (Gerrit)8

3:07 PM

[S] Change in dart/sdk[main]: [dartdev] Don't ignore the `--define` option in `dart run`

Attention needed from Brian Quinlan and Parker Lougheed Slava Egorov voted Code-Review +1 Commit-

unread,

[S] Change in dart/sdk[main]: [dartdev] Don't ignore the `--define` option in `dart run`

Attention needed from Brian Quinlan and Parker Lougheed Slava Egorov voted Code-Review +1 Commit-

3:07 PM

Felipe Morschel (Gerrit), Samuel Rawlins (Gerrit)6

3:04 PM

[M] Change in dart/sdk[main]: [linter] Fixes false-negative `avoid_redundant_argument_values` at an...

Attention needed from Felipe Morschel Samuel Rawlins added 1 comment Patchset-level comments File-

unread,

[M] Change in dart/sdk[main]: [linter] Fixes false-negative `avoid_redundant_argument_values` at an...

Attention needed from Felipe Morschel Samuel Rawlins added 1 comment Patchset-level comments File-

3:04 PM

Felipe Morschel (Gerrit), … Konstantin Shcheglov (Gerrit)5

2:57 PM

[S] Change in dart/sdk[main]: [DAS] Fixes rename local variable for function expression cases

Attention needed from Felipe Morschel Konstantin Shcheglov added 3 comments File pkg/analysis_server/

unread,

[S] Change in dart/sdk[main]: [DAS] Fixes rename local variable for function expression cases

Attention needed from Felipe Morschel Konstantin Shcheglov added 3 comments File pkg/analysis_server/

2:57 PM

Stephen Adams (Gerrit), … Commit Queue (Gerrit)5

2:56 PM

[M] Change in dart/sdk[main]: [dart2js] Add missing case of updating call attributes

Commit Queue submitted the change Change information Commit message: [dart2js] Add missing case of

unread,

[M] Change in dart/sdk[main]: [dart2js] Add missing case of updating call attributes

Commit Queue submitted the change Change information Commit message: [dart2js] Add missing case of

2:56 PM

Lasse Nielsen (Gerrit), … Stephen Adams (Gerrit)9

1:30 PM

[L] Change in dart/sdk[main]: BREAKING CHANGE: Fix `parseIPv4Address` to not allow leading zeros.

Attention needed from Slava Egorov Lasse Nielsen added 2 comments File sdk/lib/core/uri.dart Line

unread,

[L] Change in dart/sdk[main]: BREAKING CHANGE: Fix `parseIPv4Address` to not allow leading zeros.

Attention needed from Slava Egorov Lasse Nielsen added 2 comments File sdk/lib/core/uri.dart Line

1:30 PM

Felipe Morschel (Gerrit), … Phil Quitslund (Gerrit)8

1:21 PM

[M] Change in dart/sdk[main]: [analyzer] Fixes deprecated and removed linter rules diagnostic

Attention needed from Phil Quitslund and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

unread,

[M] Change in dart/sdk[main]: [analyzer] Fixes deprecated and removed linter rules diagnostic

Attention needed from Phil Quitslund and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

1:21 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

1:08 PM

[S] Change in dart/sdk[main]: [DAS] Adds `Remove const` fix to `const_eval_method_invocation`

Commit Queue submitted the change Change information Commit message: [DAS] Adds `Remove const` fix to

unread,

[S] Change in dart/sdk[main]: [DAS] Adds `Remove const` fix to `const_eval_method_invocation`

Commit Queue submitted the change Change information Commit message: [DAS] Adds `Remove const` fix to

1:08 PM

Samuel Rawlins (Gerrit), Brian Wilkerson (Gerrit)2

1:02 PM

[XS] Change in dart/sdk[main]: linter: update visit_registered_nodes rule to use new name

Attention needed from Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

unread,

[XS] Change in dart/sdk[main]: linter: update visit_registered_nodes rule to use new name

Attention needed from Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in

1:02 PM

Ryan Macnak (Gerrit), … Alexander Aprelev (Gerrit)5

12:12 PM

[M] Change in dart/sdk[main]: [vm/shared] Ensure to iterate over mutators, rather than only isolate...

Alexander Aprelev has created a revert of this change Open original change Related details Attention

unread,

[M] Change in dart/sdk[main]: [vm/shared] Ensure to iterate over mutators, rather than only isolate...

Alexander Aprelev has created a revert of this change Open original change Related details Attention

12:12 PM

Felipe Morschel (Gerrit)2

10:36 AM

[L] Change in dart/sdk[main]: [linter] Adds new `private_access_on_public_member` lint

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 2 comments Patchset-

unread,

[L] Change in dart/sdk[main]: [linter] Adds new `private_access_on_public_member` lint

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 2 comments Patchset-

10:36 AM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)5

10:26 AM

[L] Change in dart/sdk[main]: Add handling for error cases in class_test regarding too few or too m...

Commit Queue submitted the change Change information Commit message: Add handling for error cases in

unread,

[L] Change in dart/sdk[main]: Add handling for error cases in class_test regarding too few or too m...

Commit Queue submitted the change Change information Commit message: Add handling for error cases in

10:26 AM

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)5

10:11 AM

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 49679593e3879c9e5a1132ded1fd5d957f1e1f1d

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 49679593e3879c9e5a1132ded1fd5d957f1e1f1d

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

10:11 AM

Johnni Winther (Gerrit)

10:09 AM

[L] Change in dart/sdk[main]: [cfe] Use ArgumentsImpl directly through body building and inference

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[L] Change in dart/sdk[main]: [cfe] Use ArgumentsImpl directly through body building and inference

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

10:09 AM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

9:13 AM

[M] Change in dart/sdk[main]: [CFE] Run coverage update on weekly bot and print a diff

Commit Queue submitted the change Change information Commit message: [CFE] Run coverage update on

unread,

[M] Change in dart/sdk[main]: [CFE] Run coverage update on weekly bot and print a diff

Commit Queue submitted the change Change information Commit message: [CFE] Run coverage update on

9:13 AM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)4

8:43 AM

[XL] Change in dart/sdk[main]: [cfe] Make Factory/TypeAliasConstructor extend InternalExpression

Commit Queue submitted the change Change information Commit message: [cfe] Make Factory/

unread,

[XL] Change in dart/sdk[main]: [cfe] Make Factory/TypeAliasConstructor extend InternalExpression

Commit Queue submitted the change Change information Commit message: [cfe] Make Factory/

8:43 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)5

8:22 AM

[M] Change in dart/sdk[main]: [model] Adjust distance from top calculations in UP in Analyzer

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[M] Change in dart/sdk[main]: [model] Adjust distance from top calculations in UP in Analyzer

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

8:22 AM

Erik Ernst (Gerrit), Sergey Grekhov (Gerrit)3

7:26 AM

[XS] Change in dart/sdk[main]: [co19] Roll co19 to ac76153ee4b741e3ae045e21537bb1108b4d670a

Erik Ernst removed a vote from this change Removed Code-Review+1 by Erik Ernst <eer...@google.com

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to ac76153ee4b741e3ae045e21537bb1108b4d670a

Erik Ernst removed a vote from this change Removed Code-Review+1 by Erik Ernst <eer...@google.com

7:26 AM

Sarah Zakarias (Gerrit), … Commit Queue (Gerrit)4

6:12 AM

[XS] Change in dart/sdk[main]: Bump dartdoc to 53222e20f3a82211a038de4e1710fd57b0403652

Commit Queue submitted the change Change information Commit message: Bump dartdoc to

unread,

[XS] Change in dart/sdk[main]: Bump dartdoc to 53222e20f3a82211a038de4e1710fd57b0403652

Commit Queue submitted the change Change information Commit message: Bump dartdoc to

6:12 AM

Jens Johansen (Gerrit), … Commit Queue (Gerrit)4

3:05 AM

[S] Change in dart/sdk[main]: [CFE] Fixes for instrumenter

Commit Queue submitted the change Change information Commit message: [CFE] Fixes for instrumenter

unread,

[S] Change in dart/sdk[main]: [CFE] Fixes for instrumenter

Commit Queue submitted the change Change information Commit message: [CFE] Fixes for instrumenter

3:05 AM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

3:05 AM

[M] Change in dart/sdk[main]: [CFE] Fix crash in expression evaluation related to type parameters

Commit Queue submitted the change Change information Commit message: [CFE] Fix crash in expression

unread,

[M] Change in dart/sdk[main]: [CFE] Fix crash in expression evaluation related to type parameters

Commit Queue submitted the change Change information Commit message: [CFE] Fix crash in expression

3:05 AM

Ivan Inozemtsev (Gerrit), … Commit Queue (Gerrit)4

2:11 AM

[S] Change in dart/sdk[main]: [infra] Shard dart2js modular tests

Commit Queue submitted the change Change information Commit message: [infra] Shard dart2js modular

unread,

[S] Change in dart/sdk[main]: [infra] Shard dart2js modular tests

Commit Queue submitted the change Change information Commit message: [infra] Shard dart2js modular

2:11 AM

Stephen Adams (Gerrit)

Sep 4

[M] Change in dart/sdk[main]: [dart2js] Choose between while- and for- loops

Attention needed from Mayank Patke Stephen Adams voted and added 1 comment Votes added by Stephen

unread,

[M] Change in dart/sdk[main]: [dart2js] Choose between while- and for- loops

Attention needed from Mayank Patke Stephen Adams voted and added 1 comment Votes added by Stephen

Sep 4

Search

Clear search

Close search

Google apps

Main menu