Dart Code Reviews - Google Groups

Groups

1–30 of 125482

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Danny Tuppeny (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

1:12 AM

[L] Change in dart/sdk[main]: [analysis_server] Add Dart-Code's current client capabilities

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [analysis_server] Add Dart-Code's current client capabilities

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:12 AM

Samuel Rawlins (Gerrit)

Jul 15

[XS] Change in dart/sdk[main]: analyzer: Add note on caret for TestCode

Attention needed from Brian Wilkerson Samuel Rawlins voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[XS] Change in dart/sdk[main]: analyzer: Add note on caret for TestCode

Attention needed from Brian Wilkerson Samuel Rawlins voted Commit-Queue+1 Commit-Queue +1 Open in

Jul 15

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

Jul 15

[M] Change in dart/sdk[main]: analyzer: Deprecate legacy analyzer plugins

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: analyzer: Deprecate legacy analyzer plugins

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jul 15

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

Jul 15

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to _withUnpromotedThisType().

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to _withUnpromotedThisType().

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jul 15

Paul Berry (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jul 15

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 2

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 2

Jul 15

Konstantin Shcheglov (Gerrit)

Jul 15

[XL] Change in dart/sdk[main]: CQ. ConstructorName and ConstructorReference Refactoring.

Konstantin Shcheglov abandoned this change. View Change Abandoned Konstantin Shcheglov abandoned this

unread,

[XL] Change in dart/sdk[main]: CQ. ConstructorName and ConstructorReference Refactoring.

Konstantin Shcheglov abandoned this change. View Change Abandoned Konstantin Shcheglov abandoned this

Jul 15

Ryan Macnak (Gerrit)

Jul 15

[L] Change in dart/sdk[main]: [vm, compiler] Assembler and ELF support for CFI.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

unread,

[L] Change in dart/sdk[main]: [vm, compiler] Assembler and ELF support for CFI.

Attention needed from Alexander Markov New activity on the change Open in Gerrit Related details

Jul 15

Modestas Valauskas (Gerrit), Stephen Adams (Gerrit)4

Jul 15

[XL] Change in dart/sdk[main]: Share SIMD value operations via a dart._simd part

Attention needed from Johnni Winther, Lasse Nielsen, Martin Kustermann and Stephen Adams Modestas

unread,

[XL] Change in dart/sdk[main]: Share SIMD value operations via a dart._simd part

Attention needed from Johnni Winther, Lasse Nielsen, Martin Kustermann and Stephen Adams Modestas

Jul 15

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jul 15

[XS] Change in dart/sdk[main]: [vm/shared/interpreter] Use shared-aware initializer from interpreter.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [vm/shared/interpreter] Use shared-aware initializer from interpreter.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Lasse Nielsen (Gerrit), … Ryan Macnak (Gerrit)3

Jul 15

[M] Change in dart/sdk[main]: Extra testing of inet_pton.

Attention needed from Lasse Nielsen Ryan Macnak added 2 comments Commit Message Line 13, Patchset 5 (

unread,

[M] Change in dart/sdk[main]: Extra testing of inet_pton.

Attention needed from Lasse Nielsen Ryan Macnak added 2 comments Commit Message Line 13, Patchset 5 (

Jul 15

FMorschel (Gerrit), … Liam Appelbe (Gerrit)32

Jul 15

[M] Change in dart/sdk[main]: [linter] Makes `unawaited_futures` report for `FutureOr`

Liam Appelbe has created a revert of this change Open original change Related details Attention set

unread,

[M] Change in dart/sdk[main]: [linter] Makes `unawaited_futures` report for `FutureOr`

Liam Appelbe has created a revert of this change Open original change Related details Attention set

Jul 15

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)2

Jul 15

[XS] Change in dart/sdk[main]: [build] Adjust debug info to avoid needing to configure gdb to find s...

Attention needed from Alexander Markov and Ryan Macnak Alexander Aprelev voted Code-Review+1 Code-

unread,

[XS] Change in dart/sdk[main]: [build] Adjust debug info to avoid needing to configure gdb to find s...

Attention needed from Alexander Markov and Ryan Macnak Alexander Aprelev voted Code-Review+1 Code-

Jul 15

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jul 15

[XS] Change in dart/sdk[main]: Follow up for "[vm] Don't double initialize length fields during obje...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Follow up for "[vm] Don't double initialize length fields during obje...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jul 15

[L] Change in dart/sdk[main]: Parse and validate analyzer plugins in "inner" options files

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: Parse and validate analyzer plugins in "inner" options files

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Alexander Markov (Gerrit)

Jul 15

[S] Change in dart/sdk[main]: [modular_aot] Fix object size in tags

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix object size in tags

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jul 15

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jul 15

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to single enclosingInstanceElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to single enclosingInstanceElement.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

Jul 15

[M] Change in dart/sdk[main]: [vm] Don't double initialize length fields during object graph copying.

Ryan Macnak added 2 comments File runtime/vm/object_graph_copy.cc Line 1835, Patchset 3: Base::

unread,

[M] Change in dart/sdk[main]: [vm] Don't double initialize length fields during object graph copying.

Ryan Macnak added 2 comments File runtime/vm/object_graph_copy.cc Line 1835, Patchset 3: Base::

Jul 15

Konstantin Shcheglov (Gerrit), Paul Berry (Gerrit)2

Jul 15

[S] Change in dart/sdk[main]: CQ. Recover in invalid ThisExpression with InvalidTypeImpl.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

unread,

[S] Change in dart/sdk[main]: CQ. Recover in invalid ThisExpression with InvalidTypeImpl.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

Jul 15

Kevin Moore (Gerrit)

Jul 15

[L] Change in dart/sdk[main]: [dart:io] Coalesce HTTP response headers and body into one socket write

Attention needed from Brian Quinlan and Lasse Nielsen Kevin Moore voted Auto-Submit+1 Auto-Submit +1

unread,

[L] Change in dart/sdk[main]: [dart:io] Coalesce HTTP response headers and body into one socket write

Attention needed from Brian Quinlan and Lasse Nielsen Kevin Moore voted Auto-Submit+1 Auto-Submit +1

Jul 15

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jul 15

[XS] Change in dart/sdk[main]: [vm, arm64e] Fix size of kPlatformDillSize.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: [vm, arm64e] Fix size of kPlatformDillSize.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Samuel Rawlins (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jul 15

[S] Change in dart/sdk[main]: Start analyzer 14.2.0-dev, analyzer_plugin 0.14.15-dev, analyzer_test...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: Start analyzer 14.2.0-dev, analyzer_plugin 0.14.15-dev, analyzer_test...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Konstantin Shcheglov (Gerrit)

Jul 15

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement..

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[M] Change in dart/sdk[main]: CQ. Switch ResolverVisitor to enclosingExecutableElement..

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

Jul 15

Modestas Valauskas (Gerrit)

Jul 15

[M] Change in dart/sdk[main]: [dart2wasm] Unify unmodifiable typed data mixins

Attention needed from Lasse Nielsen Modestas Valauskas voted and added 1 comment Votes added by

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Unify unmodifiable typed data mixins

Attention needed from Lasse Nielsen Modestas Valauskas voted and added 1 comment Votes added by

Jul 15

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jul 15

[M] Change in dart/sdk[main]: [vm/io] Signal to fork()ed child only in non detached mode

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 4

unread,

[M] Change in dart/sdk[main]: [vm/io] Signal to fork()ed child only in non detached mode

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 4

Jul 15

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

Jul 15

[M] Change in dart/sdk[main]: [migrate] Support Dart 3 backwards compatibility.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: [migrate] Support Dart 3 backwards compatibility.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

Jul 15

Konstantin Shcheglov (Gerrit), … Danny Tuppeny (Gerrit)7

Jul 15

[M] Change in dart/sdk[main]: TestCode: handle an escaped shorthand

Attention needed from Samuel Rawlins Danny Tuppeny added 1 comment File pkg/analyzer/lib/src/

unread,

[M] Change in dart/sdk[main]: TestCode: handle an escaped shorthand

Attention needed from Samuel Rawlins Danny Tuppeny added 1 comment File pkg/analyzer/lib/src/

Jul 15

Daco Harkes (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)16

Jul 15

[S] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [deps] Roll dart-lang/native

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Jaime Wren (Gerrit), Daco Harkes (Gerrit)2

Jul 15

[S] Change in dart/sdk[main]: [dartdev] Remove resolved TODO for DynamicLibrary.openFromAssetId in ...

Attention needed from Jaime Wren Daco Harkes added 1 comment File pkg/dartdev/test/native_assets/

unread,

[S] Change in dart/sdk[main]: [dartdev] Remove resolved TODO for DynamicLibrary.openFromAssetId in ...

Attention needed from Jaime Wren Daco Harkes added 1 comment File pkg/dartdev/test/native_assets/

Jul 15

Alexander Markov (Gerrit)

Jul 15

[XL] Change in dart/sdk[main]: [modular_aot] Generate stack maps for GC

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

unread,

[XL] Change in dart/sdk[main]: [modular_aot] Generate stack maps for GC

Attention needed from Slava Egorov New activity on the change Open in Gerrit Related details

Jul 15

Ben Konyi (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

Jul 15

[XS] Change in dart/sdk[main]: Remove stale TODO comment in `flag_test.dart`.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Remove stale TODO comment in `flag_test.dart`.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

Jul 15

Search

Clear search

Close search

Google apps

Main menu