Groups

Dart Code Reviews

1–30 of 121453

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Danny Tuppeny (Gerrit), Brian Wilkerson (Gerrit)7

1:45 PM

[M] Change in dart/sdk[main]: Introduce variables for non-simple parameters when inlining methods

Attention needed from Brian Wilkerson and Samuel Rawlins Danny Tuppeny added 1 comment File pkg/

unread,

[M] Change in dart/sdk[main]: Introduce variables for non-simple parameters when inlining methods

Attention needed from Brian Wilkerson and Samuel Rawlins Danny Tuppeny added 1 comment File pkg/

1:45 PM

Alexander Markov (Gerrit), Nate Biggs (Gerrit)3

1:39 PM

[M] Change in dart/sdk[main]: [dyn_modules] Do not elminate exported duplicate mixin applications

Attention needed from Nate Biggs and Slava Egorov Alexander Markov voted and added 2 comments Votes

unread,

[M] Change in dart/sdk[main]: [dyn_modules] Do not elminate exported duplicate mixin applications

Attention needed from Nate Biggs and Slava Egorov Alexander Markov voted and added 2 comments Votes

1:39 PM

Felipe Morschel (Gerrit), … Danny Tuppeny (Gerrit)26

1:37 PM

[M] Change in dart/sdk[main]: [analyzer] Fixes deprecated and removed linter rules diagnostic

Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins Felipe Morschel voted and

unread,

[M] Change in dart/sdk[main]: [analyzer] Fixes deprecated and removed linter rules diagnostic

Attention needed from Brian Wilkerson, Danny Tuppeny and Samuel Rawlins Felipe Morschel voted and

1:37 PM

Ryan Macnak (Gerrit)

1:34 PM

[M] Change in dart/sdk[main]: Reapply "[standalone] Use fewer syscalls to get entropy on Linux and ...

Attention needed from Slava Egorov Ryan Macnak voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[M] Change in dart/sdk[main]: Reapply "[standalone] Use fewer syscalls to get entropy on Linux and ...

Attention needed from Slava Egorov Ryan Macnak voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

1:34 PM

Danny Tuppeny (Gerrit), Brian Wilkerson (Gerrit)4

12:04 PM

[M] Change in dart/sdk[main]: [anaysis_server] Switch completion tests from element offsets to line...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review+1 Code

unread,

[M] Change in dart/sdk[main]: [anaysis_server] Switch completion tests from element offsets to line...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review+1 Code

12:04 PM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

11:56 AM

[L] Change in dart/sdk[main]: Augment. Rewrite AugmentationTypeParameterCountTest without parts.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[L] Change in dart/sdk[main]: Augment. Rewrite AugmentationTypeParameterCountTest without parts.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

11:56 AM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

11:32 AM

[S] Change in dart/sdk[main]: DAS: Remove unused _MatchShadowedByLocal class

Commit Queue submitted the change Change information Commit message: DAS: Remove unused

unread,

[S] Change in dart/sdk[main]: DAS: Remove unused _MatchShadowedByLocal class

Commit Queue submitted the change Change information Commit message: DAS: Remove unused

11:32 AM

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)9

10:54 AM

[L] Change in dart/sdk[main]: [DAS] Fixes part file handling for some create fixes

Attention needed from Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-

unread,

[L] Change in dart/sdk[main]: [DAS] Fixes part file handling for some create fixes

Attention needed from Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-Review+1 Code-

10:54 AM

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

10:51 AM

[S] Change in dart/sdk[main]: Augment. Restore running AugmentationTypeParameterCountTest, skip ind...

Commit Queue submitted the change Change information Commit message: Augment. Restore running

unread,

[S] Change in dart/sdk[main]: Augment. Restore running AugmentationTypeParameterCountTest, skip ind...

Commit Queue submitted the change Change information Commit message: Augment. Restore running

10:51 AM

Brian Wilkerson (Gerrit)

10:39 AM

[S] Change in dart/sdk[main]: [analysis_server] Enable line ending normalization in completion tests

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1

unread,

[S] Change in dart/sdk[main]: [analysis_server] Enable line ending normalization in completion tests

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1

10:39 AM

Danny Tuppeny (Gerrit), … Brian Wilkerson (Gerrit)5

10:32 AM

[L] Change in dart/sdk[main]: [analysis_server] Switch selections in tests to markup instead of har...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1

unread,

[L] Change in dart/sdk[main]: [analysis_server] Switch selections in tests to markup instead of har...

Attention needed from Danny Tuppeny and Keerti Parthasarathy Brian Wilkerson voted Code-Review +1

10:32 AM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

10:22 AM

[S] Change in dart/sdk[main]: Fine. Skip LibraryDiagnosticsBundle for a file if the same as the las...

Commit Queue submitted the change Change information Commit message: Fine. Skip

unread,

[S] Change in dart/sdk[main]: Fine. Skip LibraryDiagnosticsBundle for a file if the same as the las...

Commit Queue submitted the change Change information Commit message: Fine. Skip

10:22 AM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)12

9:29 AM

[XS] Change in dart/sdk[main]: SDK: Deprecate the ability to implement RegExp and RegExpMatch.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[XS] Change in dart/sdk[main]: SDK: Deprecate the ability to implement RegExp and RegExpMatch.

Commit Queue submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

9:29 AM

Felipe Morschel (Gerrit)2

8:26 AM

[M] Change in dart/sdk[main]: [DAS] Makes "Extract method" refactor ignore `BuildContext context` p...

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

unread,

[M] Change in dart/sdk[main]: [DAS] Makes "Extract method" refactor ignore `BuildContext context` p...

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

8:26 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)4

7:20 AM

[L] Change in dart/sdk[main]: [cfe] Return MemberLookupResult from ExtensionBuilder.lookupLocalMemb...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

unread,

[L] Change in dart/sdk[main]: [cfe] Return MemberLookupResult from ExtensionBuilder.lookupLocalMemb...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

7:20 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)3

6:15 AM

[XL] Change in dart/sdk[main]: [cfe] Add ExtensionInstanceEncoding

Commit Queue submitted the change Change information Commit message: [cfe] Add

unread,

[XL] Change in dart/sdk[main]: [cfe] Add ExtensionInstanceEncoding

Commit Queue submitted the change Change information Commit message: [cfe] Add

6:15 AM

Alexander Aprelev (Gerrit), Lasse Nielsen (Gerrit)6

5:33 AM

[L] Change in dart/sdk[main]: [sdk] Use ScopedThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev and Slava Egorov Lasse Nielsen added 1 comment File sdk/lib/

unread,

[L] Change in dart/sdk[main]: [sdk] Use ScopedThreadLocal for Iterable toString.

Attention needed from Alexander Aprelev and Slava Egorov Lasse Nielsen added 1 comment File sdk/lib/

5:33 AM

Jens Johansen (Gerrit), … Commit Queue (Gerrit)5

4:38 AM

[XL] Change in dart/sdk[main]: [scanner] Better recovery for missing end brace in string interpolation

Commit Queue submitted the change Change information Commit message: [scanner] Better recovery for

unread,

[XL] Change in dart/sdk[main]: [scanner] Better recovery for missing end brace in string interpolation

Commit Queue submitted the change Change information Commit message: [scanner] Better recovery for

4:38 AM

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

2:40 AM

[M] Change in dart/sdk[main]: [analysis_server] Add benchmark for missing end brace in string inter...

Commit Queue submitted the change Change information Commit message: [analysis_server] Add benchmark

unread,

[M] Change in dart/sdk[main]: [analysis_server] Add benchmark for missing end brace in string inter...

Commit Queue submitted the change Change information Commit message: [analysis_server] Add benchmark

2:40 AM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Oct 5

[M] Change in dart/sdk[main]: Fine. Send analysis_statistics events to analytics.

Commit Queue submitted the change Change information Commit message: Fine. Send analysis_statistics

unread,

[M] Change in dart/sdk[main]: Fine. Send analysis_statistics events to analytics.

Commit Queue submitted the change Change information Commit message: Fine. Send analysis_statistics

Oct 5

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Oct 4

[XL] Change in dart/sdk[main]: Start renaming the DartFixKind constants

Commit Queue submitted the change Change information Commit message: Start renaming the DartFixKind

unread,

[XL] Change in dart/sdk[main]: Start renaming the DartFixKind constants

Commit Queue submitted the change Change information Commit message: Start renaming the DartFixKind

Oct 4

Konstantin Shcheglov (Gerrit), Brian Wilkerson (Gerrit)3

Oct 4

[M] Change in dart/sdk[main]: Fine. Send server.analysisWorking event to analytics.

Attention needed from Brian Wilkerson Konstantin Shcheglov added 3 comments File pkg/analysis_server/

unread,

[M] Change in dart/sdk[main]: Fine. Send server.analysisWorking event to analytics.

Attention needed from Brian Wilkerson Konstantin Shcheglov added 3 comments File pkg/analysis_server/

Oct 4

Samuel Rawlins (Gerrit), Elliott Brooks (Gerrit)3

Oct 3

[XS] Change in dart/sdk[main]: Update DevTools rev to 0327830448901920f739259364c3f2f624df5a03

Attention needed from Samuel Rawlins Elliott Brooks voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[XS] Change in dart/sdk[main]: Update DevTools rev to 0327830448901920f739259364c3f2f624df5a03

Attention needed from Samuel Rawlins Elliott Brooks voted Code-Review+1 Code-Review +1 Open in Gerrit

Oct 3

Paul Berry (Gerrit), Brian Wilkerson (Gerrit)3

Oct 3

[S] Change in dart/sdk[main]: [linter] Deprecate `prefer_final_parameters` lint rule

Attention needed from Parker Lougheed and Paul Berry Brian Wilkerson added 1 comment Patchset-level

unread,

[S] Change in dart/sdk[main]: [linter] Deprecate `prefer_final_parameters` lint rule

Attention needed from Parker Lougheed and Paul Berry Brian Wilkerson added 1 comment Patchset-level

Oct 3

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)7

Oct 3

[S] Change in dart/sdk[main]: [analyzer] Adds new message for `INVALID_REFERENCE_TO_GENERATIVE_ENUM...

Commit Queue submitted the change Change information Commit message: [analyzer] Adds new message for

unread,

[S] Change in dart/sdk[main]: [analyzer] Adds new message for `INVALID_REFERENCE_TO_GENERATIVE_ENUM...

Commit Queue submitted the change Change information Commit message: [analyzer] Adds new message for

Oct 3

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)11

Oct 3

[M] Change in dart/sdk[main]: Issue 61676. Fix sorting by relevance in SuggestionCollector.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[M] Change in dart/sdk[main]: Issue 61676. Fix sorting by relevance in SuggestionCollector.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Oct 3

Paul Berry (Gerrit), … Commit Queue (Gerrit)5

Oct 3

[XS] Change in dart/sdk[main]: Elements. Fix enum summary test logical merge conflict.

Commit Queue submitted the change Change information Commit message: Elements. Fix enum summary test

unread,

[XS] Change in dart/sdk[main]: Elements. Fix enum summary test logical merge conflict.

Commit Queue submitted the change Change information Commit message: Elements. Fix enum summary test

Oct 3

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

Oct 3

[XS] Change in dart/sdk[main]: DAS plugins: properly throw and catch when a plugin cannot start

Commit Queue submitted the change Change information Commit message: DAS plugins: properly throw and

unread,

[XS] Change in dart/sdk[main]: DAS plugins: properly throw and catch when a plugin cannot start

Commit Queue submitted the change Change information Commit message: DAS plugins: properly throw and

Oct 3

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Oct 3

[L] Change in dart/sdk[main]: CQ. Add more combinations for resolution workspace in AnalysisContext...

Commit Queue submitted the change Change information Commit message: CQ. Add more combinations for

unread,

[L] Change in dart/sdk[main]: CQ. Add more combinations for resolution workspace in AnalysisContext...

Commit Queue submitted the change Change information Commit message: CQ. Add more combinations for

Oct 3

Kevin Moore (Gerrit), … Commit Queue (Gerrit)5

Oct 3

[M] Change in dart/sdk[main]: Elements. Fix linkNodeTokens() for List<Token>.

Commit Queue submitted the change Change information Commit message: Elements. Fix linkNodeTokens()

unread,

[M] Change in dart/sdk[main]: Elements. Fix linkNodeTokens() for List<Token>.

Commit Queue submitted the change Change information Commit message: Elements. Fix linkNodeTokens()

Oct 3

Search

Clear search

Close search

Google apps

Main menu