Groups

Dart Code Reviews

1–30 of 121812

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Bob Nystrom (Gerrit)

Nov 4

[M] Change in dart/sdk[main]: [private named parameters] Implement in analyzer

Attention needed from Brian Wilkerson, Johnni Winther, Konstantin Shcheglov and Paul Berry Bob

unread,

[M] Change in dart/sdk[main]: [private named parameters] Implement in analyzer

Attention needed from Brian Wilkerson, Johnni Winther, Konstantin Shcheglov and Paul Berry Bob

Nov 4

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[L] Change in dart/sdk[main]: DeCo. Add FieldFormalParameterElement.isDeclaring, ConstructorElement...

Commit Queue submitted the change Change information Commit message: DeCo. Add

unread,

[L] Change in dart/sdk[main]: DeCo. Add FieldFormalParameterElement.isDeclaring, ConstructorElement...

Commit Queue submitted the change Change information Commit message: DeCo. Add

Nov 4

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[XS] Change in dart/sdk[main]: [vm] Improve packing of Sample.

Commit Queue submitted the change Change information Commit message: [vm] Improve packing of Sample.

unread,

[XS] Change in dart/sdk[main]: [vm] Improve packing of Sample.

Commit Queue submitted the change Change information Commit message: [vm] Improve packing of Sample.

Nov 4

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[L] Change in dart/sdk[main]: Add support for logging communications from plugins

Commit Queue submitted the change Change information Commit message: Add support for logging

unread,

[L] Change in dart/sdk[main]: Add support for logging communications from plugins

Commit Queue submitted the change Change information Commit message: Add support for logging

Nov 4

Konstantin Shcheglov (Gerrit), … Paul Berry (Gerrit)3

Nov 4

[L] Change in dart/sdk[main]: DeCo. FieldFormalParameterElement.isDeclaring, ConstructorElement.isD...

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry added 1 comment Patchset-

unread,

[L] Change in dart/sdk[main]: DeCo. FieldFormalParameterElement.isDeclaring, ConstructorElement.isD...

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry added 1 comment Patchset-

Nov 4

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[XS] Change in dart/sdk[main]: [test] Shrink vm/dart/profiler_deep_stack_test.

Commit Queue submitted the change Change information Commit message: [test] Shrink vm/dart/

unread,

[XS] Change in dart/sdk[main]: [test] Shrink vm/dart/profiler_deep_stack_test.

Commit Queue submitted the change Change information Commit message: [test] Shrink vm/dart/

Nov 4

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[M] Change in dart/sdk[main]: [profiler] Don't read from a previous block when a sample overflows t...

Commit Queue submitted the change Change information Commit message: [profiler] Don't read from a

unread,

[M] Change in dart/sdk[main]: [profiler] Don't read from a previous block when a sample overflows t...

Commit Queue submitted the change Change information Commit message: [profiler] Don't read from a

Nov 4

Keerti Parthasarathy (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[S] Change in dart/sdk[main]: [analytics] Split the other workspace types into Blaze, Gn and other

Commit Queue submitted the change Change information Commit message: [analytics] Split the other

unread,

[S] Change in dart/sdk[main]: [analytics] Split the other workspace types into Blaze, Gn and other

Commit Queue submitted the change Change information Commit message: [analytics] Split the other

Nov 4

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[M] Change in dart/sdk[main]: [dart2wasm] Some fixes for the binary wasm deserializer

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Some fixes for the binary wasm deserializer

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Nov 4

Sigmund Cherem (Gerrit), Alexander Markov (Gerrit)4

Nov 4

[M] Change in dart/sdk[main]: [dyn_modules]: support redirecting factories in validator

Sigmund Cherem abandoned this change Related details Attention set is empty Submit Requirements: Code

unread,

[M] Change in dart/sdk[main]: [dyn_modules]: support redirecting factories in validator

Sigmund Cherem abandoned this change Related details Attention set is empty Submit Requirements: Code

Nov 4

Alexander Markov (Gerrit), Sigmund Cherem (Gerrit)2

Nov 4

[L] Change in dart/sdk[main]: [cfe,dyn_modules] Fix dynamic module validation of redirecting factories

Attention needed from Alexander Markov and Johnni Winther Sigmund Cherem voted and added 1 comment

unread,

[L] Change in dart/sdk[main]: [cfe,dyn_modules] Fix dynamic module validation of redirecting factories

Attention needed from Alexander Markov and Johnni Winther Sigmund Cherem voted and added 1 comment

Nov 4

Felipe Morschel (Gerrit)

Nov 4

[L] Change in dart/sdk[main]: [DAS] Fixes `Add missing parameter` fix for super parameters

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes `Add missing parameter`

unread,

[L] Change in dart/sdk[main]: [DAS] Fixes `Add missing parameter` fix for super parameters

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes `Add missing parameter`

Nov 4

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[S] Change in dart/sdk[main]: [infra] Also kill dartvm, gen_snapshot_product and run_vm_tests after...

Commit Queue submitted the change Change information Commit message: [infra] Also kill dartvm,

unread,

[S] Change in dart/sdk[main]: [infra] Also kill dartvm, gen_snapshot_product and run_vm_tests after...

Commit Queue submitted the change Change information Commit message: [infra] Also kill dartvm,

Nov 4

Chloe Stefantsova (Gerrit), Konstantin Shcheglov (Gerrit)2

Nov 4

[L] Change in dart/sdk[main]: [analyzer] Implement static extension setters

Attention needed from Chloe Stefantsova and Paul Berry Konstantin Shcheglov added 7 comments Commit

unread,

[L] Change in dart/sdk[main]: [analyzer] Implement static extension setters

Attention needed from Chloe Stefantsova and Paul Berry Konstantin Shcheglov added 7 comments Commit

Nov 4

Konstantin Shcheglov (Gerrit)

Nov 4

[XL] Change in dart/sdk[main]: [cfe] Support default values in primary constructor parameters

Attention needed from Johnni Winther Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

unread,

[XL] Change in dart/sdk[main]: [cfe] Support default values in primary constructor parameters

Attention needed from Johnni Winther Konstantin Shcheglov voted Code-Review+1 Code-Review +1 Open in

Nov 4

Rohit Saily (Gerrit)

Nov 4

[S] Change in dart/sdk[main]: Add `directoryPath` parameter to single package config creation

Rohit Saily abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[S] Change in dart/sdk[main]: Add `directoryPath` parameter to single package config creation

Rohit Saily abandoned this change Related details Attention set is empty Submit Requirements: Code-

Nov 4

Brian Wilkerson (Gerrit), … Danny Tuppeny (Gerrit)9

Nov 4

[L] Change in dart/sdk[main]: [analysis server] Cancel completion requests if having file changes (...

Attention needed from Jens Johansen Danny Tuppeny added 2 comments Patchset-level comments File-level

unread,

[L] Change in dart/sdk[main]: [analysis server] Cancel completion requests if having file changes (...

Attention needed from Jens Johansen Danny Tuppeny added 2 comments Patchset-level comments File-level

Nov 4

Ömer Ağacan (Gerrit), … Alexander Markov (Gerrit)10

Nov 4

[XL] Change in dart/sdk[main]: Update Dart protobuf, update perfetto protos with protoc_plugin-24.0.0

Attention needed from Ömer Ağacan Alexander Markov added 1 comment File pkg/vm/testcases/

unread,

[XL] Change in dart/sdk[main]: Update Dart protobuf, update perfetto protos with protoc_plugin-24.0.0

Attention needed from Ömer Ağacan Alexander Markov added 1 comment File pkg/vm/testcases/

Nov 4

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)5

Nov 4

[XL] Change in dart/sdk[main]: DeCo. Support for primary constructor in enums.

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

unread,

[XL] Change in dart/sdk[main]: DeCo. Support for primary constructor in enums.

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

Nov 4

Johnni Winther (Gerrit), … Commit Queue (Gerrit)3

Nov 4

[L] Change in dart/sdk[main]: DeCo. Rename, move XyzElementTest_declaringConstructors.

Commit Queue submitted the change Change information Commit message: DeCo. Rename, move

unread,

[L] Change in dart/sdk[main]: DeCo. Rename, move XyzElementTest_declaringConstructors.

Commit Queue submitted the change Change information Commit message: DeCo. Rename, move

Nov 4

Felipe Morschel (Gerrit)

Nov 4

[M] Change in dart/sdk[main]: [DAS] Fixes `Create (extension) method` for unresolved closure return...

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes `Create (extension)

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes `Create (extension) method` for unresolved closure return...

Felipe Morschel has uploaded the change for review Commit message [DAS] Fixes `Create (extension)

Nov 4

Felipe Morschel (Gerrit)2

Nov 4

[L] Change in dart/sdk[main]: [DAS] Fixes `Add field formal parameters` for private named fields

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

unread,

[L] Change in dart/sdk[main]: [DAS] Fixes `Add field formal parameters` for private named fields

Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel added 1 comment Patchset-

Nov 4

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[S] Change in dart/sdk[main]: Remove useLineEndingsForPlatform flag

Commit Queue submitted the change Change information Commit message: Remove useLineEndingsForPlatform

unread,

[S] Change in dart/sdk[main]: Remove useLineEndingsForPlatform flag

Commit Queue submitted the change Change information Commit message: Remove useLineEndingsForPlatform

Nov 4

Chloe Stefantsova (Gerrit)

Nov 4

[M] Change in dart/sdk[main]: [cfe] Add TypeParameterExtension

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

unread,

[M] Change in dart/sdk[main]: [cfe] Add TypeParameterExtension

Attention needed from Johnni Winther Chloe Stefantsova voted Code-Review+1 Code-Review +1 Open in

Nov 4

Nate Biggs (Gerrit), … Commit Queue (Gerrit)4

Nov 4

[S] Change in dart/sdk[main]: [dart2wasm] Fix web/wasm/flute_stress_test in SDK mode

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Fix web/wasm/flute_stress_test in SDK mode

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

Nov 4

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)3

Nov 4

[M] Change in dart/sdk[main]: [dart2wasm] Group all lazily initialized multi-module use constant gl...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

unread,

[M] Change in dart/sdk[main]: [dart2wasm] Group all lazily initialized multi-module use constant gl...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

Nov 4

Jens Johansen (Gerrit), Johnni Winther (Gerrit)5

Nov 4

[M] Change in dart/sdk[main]: [CFE] Expression compilation overwrites types to static types if from...

Attention needed from Ben Konyi and Johnni Winther Jens Johansen added 1 comment File pkg/front_end/

unread,

[M] Change in dart/sdk[main]: [CFE] Expression compilation overwrites types to static types if from...

Attention needed from Ben Konyi and Johnni Winther Jens Johansen added 1 comment File pkg/front_end/

Nov 4

Martin Kustermann (Gerrit)

Nov 4

[S] Change in dart/sdk[main]: [dart2wasm] Make order in which globals are defined not matter

Martin Kustermann abandoned this change Related details Attention set is empty Submit Requirements:

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Make order in which globals are defined not matter

Martin Kustermann abandoned this change Related details Attention set is empty Submit Requirements:

Nov 4

Ömer Ağacan (Gerrit), Slava Egorov (Gerrit)3

Nov 4

[XL] Change in dart/sdk[main]: Update perfetto protos with protoc_plugin-24.0.0

Attention needed from Ömer Ağacan Slava Egorov added 1 comment Patchset-level comments File-level

unread,

[XL] Change in dart/sdk[main]: Update perfetto protos with protoc_plugin-24.0.0

Attention needed from Ömer Ağacan Slava Egorov added 1 comment Patchset-level comments File-level

Nov 4

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)6

Nov 4

[L] Change in dart/sdk[main]: [dart2wasm] Move constants that are used by multiple modules out of m...

Commit Queue submitted the change Change information Commit message: [dart2wasm] Move constants that

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Move constants that are used by multiple modules out of m...

Commit Queue submitted the change Change information Commit message: [dart2wasm] Move constants that

Nov 4

Search

Clear search

Close search

Google apps

Main menu