Groups

Dart Code Reviews

1–30 of 122719

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Konstantin Shcheglov (Gerrit)

8:04 PM

[L] Change in dart/sdk[main]: DeCo. When isOriginDeclaringFormalParameter, return the corresponding...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[L] Change in dart/sdk[main]: DeCo. When isOriginDeclaringFormalParameter, return the corresponding...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

8:04 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)5

7:52 PM

[L] Change in dart/sdk[main]: DAS: Support many primary constructor use cases in ConvertClassToEnum

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[L] Change in dart/sdk[main]: DAS: Support many primary constructor use cases in ConvertClassToEnum

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

7:52 PM

Paul Berry (Gerrit)

5:48 PM

[S] Change in dart/sdk[main]: DeCo. Write documentation comments for FieldFragment and FieldElement.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

unread,

[S] Change in dart/sdk[main]: DeCo. Write documentation comments for FieldFragment and FieldElement.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry voted and added 1 comment

5:48 PM

Konstantin Shcheglov (Gerrit)

5:34 PM

[S] Change in dart/sdk[main]: DeCo. Write documentation coment for FieldFragment and FieldElement.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[S] Change in dart/sdk[main]: DeCo. Write documentation coment for FieldFragment and FieldElement.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

5:34 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

5:33 PM

[S] Change in dart/sdk[main]: [vm] Disable ASAN/MSAN instrumentation in the inner marking loop.

Commit Queue submitted the change Change information Commit message: [vm] Disable ASAN/MSAN

unread,

[S] Change in dart/sdk[main]: [vm] Disable ASAN/MSAN instrumentation in the inner marking loop.

Commit Queue submitted the change Change information Commit message: [vm] Disable ASAN/MSAN

5:33 PM

Ryan Macnak (Gerrit)

5:33 PM

[M] Change in dart/sdk[main]: [vm] Use btrq for x64 write barrier tag updates.

Attention needed from Alexander Markov Ryan Macnak voted and added 1 comment Votes added by Ryan

unread,

[M] Change in dart/sdk[main]: [vm] Use btrq for x64 write barrier tag updates.

Attention needed from Alexander Markov Ryan Macnak voted and added 1 comment Votes added by Ryan

5:33 PM

Jake Macdonald (Gerrit), … Commit Queue (Gerrit)3

5:30 PM

[XS] Change in dart/sdk[main]: Bump ai to 25a627892f5f398dabf78b91d20ac151f7be2b05

Commit Queue submitted the change Change information Commit message: Bump ai to

unread,

[XS] Change in dart/sdk[main]: Bump ai to 25a627892f5f398dabf78b91d20ac151f7be2b05

Commit Queue submitted the change Change information Commit message: Bump ai to

5:30 PM

Kallen Tu (Gerrit)

5:26 PM

[XL] Change in dart/sdk[main]: [cfe] Dot shorthands - Disallow resolving private classes/extension t...

Attention needed from Chloe Stefantsova and Johnni Winther New activity on the change Open in Gerrit

unread,

[XL] Change in dart/sdk[main]: [cfe] Dot shorthands - Disallow resolving private classes/extension t...

Attention needed from Chloe Stefantsova and Johnni Winther New activity on the change Open in Gerrit

5:26 PM

Alexander Aprelev (Gerrit), Alexander Markov (Gerrit)3

4:44 PM

[L] Change in dart/sdk[main]: [vm/shared] Skip runtime deep-immutability check for statically known...

Attention needed from Alexander Markov Alexander Aprelev voted and added 8 comments Votes added by

unread,

[L] Change in dart/sdk[main]: [vm/shared] Skip runtime deep-immutability check for statically known...

Attention needed from Alexander Markov Alexander Aprelev voted and added 8 comments Votes added by

4:44 PM

Paul Berry (Gerrit), … Commit Queue (Gerrit)3

4:24 PM

[L] Change in dart/sdk[main]: DeCo. Tests for index and primary constructor, newHead.

Commit Queue submitted the change Change information Commit message: DeCo. Tests for index and

unread,

[L] Change in dart/sdk[main]: DeCo. Tests for index and primary constructor, newHead.

Commit Queue submitted the change Change information Commit message: DeCo. Tests for index and

4:24 PM

Chloe Stefantsova (Gerrit), … Alexander Markov (Gerrit)6

3:44 PM

[L] Change in dart/sdk[main]: [cfe,vm] Add 'this' expression to super invocation nodes

Attention needed from Chloe Stefantsova Alexander Markov added 2 comments Patchset-level comments

unread,

[L] Change in dart/sdk[main]: [cfe,vm] Add 'this' expression to super invocation nodes

Attention needed from Chloe Stefantsova Alexander Markov added 2 comments Patchset-level comments

3:44 PM

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

3:34 PM

[S] Change in dart/sdk[main]: [DAS] Makes the defined parameters not show as suggestions on constru...

Commit Queue submitted the change Change information Commit message: [DAS] Makes the defined

unread,

[S] Change in dart/sdk[main]: [DAS] Makes the defined parameters not show as suggestions on constru...

Commit Queue submitted the change Change information Commit message: [DAS] Makes the defined

3:34 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)4

3:26 PM

[XL] Change in dart/sdk[main]: DeCo. Refactor index tests.

Commit Queue submitted the change Change information Commit message: DeCo. Refactor index tests.

unread,

[XL] Change in dart/sdk[main]: DeCo. Refactor index tests.

Commit Queue submitted the change Change information Commit message: DeCo. Refactor index tests.

3:26 PM

Danny Tuppeny (Gerrit), … Commit Queue (Gerrit)9

3:24 PM

[M] Change in dart/sdk[main]: [analysis_server] Support String IDs in log replay + run some LSP int...

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[M] Change in dart/sdk[main]: [analysis_server] Support String IDs in log replay + run some LSP int...

Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

3:24 PM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)6

3:09 PM

[S] Change in dart/sdk[main]: DAS: Support primary constructors and empty bodies in convert_class_t...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[S] Change in dart/sdk[main]: DAS: Support primary constructors and empty bodies in convert_class_t...

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

3:09 PM

Brian Wilkerson (Gerrit)

2:34 PM

[M] Change in dart/sdk[main]: [analysis_server] Support primary constructors in navigation

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted and added 2 comments

unread,

[M] Change in dart/sdk[main]: [analysis_server] Support primary constructors in navigation

Attention needed from Danny Tuppeny and Samuel Rawlins Brian Wilkerson voted and added 2 comments

2:34 PM

Erik Ernst (Gerrit), … Konstantin Shcheglov (Gerrit)4

2:32 PM

[M] Change in dart/sdk[main]: Revert analyzer change to have extension members inherit types.

Attention needed from Erik Ernst and Lasse Nielsen Konstantin Shcheglov voted Code-Review+1 Code-

unread,

[M] Change in dart/sdk[main]: Revert analyzer change to have extension members inherit types.

Attention needed from Erik Ernst and Lasse Nielsen Konstantin Shcheglov voted Code-Review+1 Code-

2:32 PM

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

1:59 PM

[M] Change in dart/sdk[main]: [vm] Fix deadlocks in shared field initialization.

Commit Queue submitted the change Change information Commit message: [vm] Fix deadlocks in shared

unread,

[M] Change in dart/sdk[main]: [vm] Fix deadlocks in shared field initialization.

Commit Queue submitted the change Change information Commit message: [vm] Fix deadlocks in shared

1:59 PM

Daco Harkes (Gerrit)

1:56 PM

[XS] Change in dart/sdk[main]: [dartdev] Remove `dart build` preview note

Attention needed from Ben Konyi Daco Harkes voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit

unread,

[XS] Change in dart/sdk[main]: [dartdev] Remove `dart build` preview note

Attention needed from Ben Konyi Daco Harkes voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit

1:56 PM

Kallen Tu (Gerrit), Brian Wilkerson (Gerrit)2

1:46 PM

[M] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthand completions for private types

Attention needed from Kallen Tu and Leaf Petersen Brian Wilkerson voted Code-Review+1 Code-Review +1

unread,

[M] Change in dart/sdk[stable]: [stable][DAS] Fixes dot-shorthand completions for private types

Attention needed from Kallen Tu and Leaf Petersen Brian Wilkerson voted Code-Review+1 Code-Review +1

1:46 PM

Konstantin Shcheglov (Gerrit), Paul Berry (Gerrit)4

1:22 PM

[XL] Change in dart/sdk[main]: DeCo. Refactor index tests, add primary constructor tests.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry added 1 comment Patchset-

unread,

[XL] Change in dart/sdk[main]: DeCo. Refactor index tests, add primary constructor tests.

Attention needed from Johnni Winther and Konstantin Shcheglov Paul Berry added 1 comment Patchset-

1:22 PM

Tess Strickland (Gerrit), … Commit Queue (Gerrit)5

12:48 PM

[M] Change in dart/sdk[main]: [vm] Change how the debugger skips the same position after breakpoints.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 23 is the latest

unread,

[M] Change in dart/sdk[main]: [vm] Change how the debugger skips the same position after breakpoints.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 23 is the latest

12:48 PM

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)3

12:28 PM

[L] Change in dart/sdk[main]: [test] Update isolate stress test input list.

Ryan Macnak abandoned this change. View Change Abandoned -> https://dart-review.googlesource.com/c

unread,

[L] Change in dart/sdk[main]: [test] Update isolate stress test input list.

Ryan Macnak abandoned this change. View Change Abandoned -> https://dart-review.googlesource.com/c

12:28 PM

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)3

12:14 PM

[M] Change in dart/sdk[main]: analyzer: Remove unused EmbedderYamlLocator constructor; simplify

Commit Queue submitted the change Change information Commit message: analyzer: Remove unused

unread,

[M] Change in dart/sdk[main]: analyzer: Remove unused EmbedderYamlLocator constructor; simplify

Commit Queue submitted the change Change information Commit message: analyzer: Remove unused

12:14 PM

Slava Egorov (Gerrit), … Commit Queue (Gerrit)6

11:19 AM

[L] Change in dart/sdk[main]: [vm/immutable] Ensure that canonical instances are deeply-immutable.

Commit Queue submitted the change Change information Commit message: [vm/immutable] Ensure that

unread,

[L] Change in dart/sdk[main]: [vm/immutable] Ensure that canonical instances are deeply-immutable.

Commit Queue submitted the change Change information Commit message: [vm/immutable] Ensure that

11:19 AM

Johnni Winther (Gerrit), … Brian Wilkerson (Gerrit)5

10:04 AM

[L] Change in dart/sdk[main]: [parser][PrimaryConstructors] Support covariant on non-final declarin...

Attention needed from Johnni Winther and Konstantin Shcheglov Brian Wilkerson voted Code-Review+1

unread,

[L] Change in dart/sdk[main]: [parser][PrimaryConstructors] Support covariant on non-final declarin...

Attention needed from Johnni Winther and Konstantin Shcheglov Brian Wilkerson voted Code-Review+1

10:04 AM

Bob Nystrom (Gerrit), … Brian Wilkerson (Gerrit)4

9:59 AM

[XS] Change in dart/sdk[main]: Convert an addReplacement() to addSimpleReplacement().

Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[XS] Change in dart/sdk[main]: Convert an addReplacement() to addSimpleReplacement().

Brian Wilkerson voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

9:59 AM

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)4

9:03 AM

[XS] Change in dart/sdk[main]: Bump dartdoc to 03f48ee08eccdcf2e4cd06678501f07c182bebf5

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

unread,

[XS] Change in dart/sdk[main]: Bump dartdoc to 03f48ee08eccdcf2e4cd06678501f07c182bebf5

Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files

9:03 AM

Chloe Stefantsova (Gerrit), … Alexander Markov (Gerrit)8

8:46 AM

[XL] Change in dart/sdk[main]: [cfe] Add function parameters to closure contexts

Attention needed from Chloe Stefantsova Alexander Markov voted Code-Review+1 Code-Review +1 Open in

unread,

[XL] Change in dart/sdk[main]: [cfe] Add function parameters to closure contexts

Attention needed from Chloe Stefantsova Alexander Markov voted Code-Review+1 Code-Review +1 Open in

8:46 AM

Johnni Winther (Gerrit)

8:34 AM

[L] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Mark cyclic constructors as erroneous

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[L] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Mark cyclic constructors as erroneous

Attention needed from Chloe Stefantsova Johnni Winther voted Commit-Queue+1 Commit-Queue +1 Open in

8:34 AM

Search

Clear search

Close search

Google apps

Main menu