Groups
Groups
Sign in
Groups
Groups
Dart Code Reviews
Conversations
About
Send feedback
Help
Dart Code Reviews
1–30 of 121757
All emails to this list are automatically generated when a code review is updated.
Please do not send emails to this list.
To learn how you can contribute, visit:
https://code.google.
com/p/dart/wiki/Contributing
To view all changes, visit:
https://codereview.
chromium.org/search?repo_guid=
5387d39e155533a4abe4cc1bfe8822
3c824ee2ee
Mark all as read
Report group
0 selected
Johnni Winther (Gerrit)
,
Konstantin Shcheglov (Gerrit)
6
10:12 AM
[L] Change in dart/sdk[main]: [cfe] Add support for primary constructors on enums
Johnni Winther submitted the change Unreviewed changes 4 is the latest approved patch-set. No files
unread,
[L] Change in dart/sdk[main]: [cfe] Add support for primary constructors on enums
Johnni Winther submitted the change Unreviewed changes 4 is the latest approved patch-set. No files
10:12 AM
Simon Binder (Gerrit)
,
Daco Harkes (Gerrit)
5
10:01 AM
[S] Change in dart/sdk[main]: [vm/ffi]: Pass RTLD_DEEPBIND on Linux when loading code assets
Daco Harkes abandoned this change Related details Attention set is empty Submit Requirements: Code-
unread,
[S] Change in dart/sdk[main]: [vm/ffi]: Pass RTLD_DEEPBIND on Linux when loading code assets
Daco Harkes abandoned this change Related details Attention set is empty Submit Requirements: Code-
10:01 AM
Alexander Markov (Gerrit)
, …
Johnni Winther (Gerrit)
6
9:47 AM
[M] Change in dart/sdk[main]: [dyn_modules] Compile all libraries mentioned in dynamic_interface.yaml
Alexander Markov voted and added 2 comments Votes added by Alexander Markov Commit-Queue +2 2
unread,
[M] Change in dart/sdk[main]: [dyn_modules] Compile all libraries mentioned in dynamic_interface.yaml
Alexander Markov voted and added 2 comments Votes added by Alexander Markov Commit-Queue +2 2
9:47 AM
Martin Kustermann (Gerrit)
,
Ömer Ağacan (Gerrit)
5
9:35 AM
[S] Change in dart/sdk[main]: [dart2wasm] Make imported globals/functions have nicer name
Attention needed from Martin Kustermann, Nate Biggs and Ömer Ağacan Martin Kustermann voted and added
unread,
[S] Change in dart/sdk[main]: [dart2wasm] Make imported globals/functions have nicer name
Attention needed from Martin Kustermann, Nate Biggs and Ömer Ağacan Martin Kustermann voted and added
9:35 AM
Martin Kustermann (Gerrit)
, …
Paul Berry (Gerrit)
6
9:34 AM
[XS] Change in dart/sdk[main]: [dart2wasm] Also use --traps-never-happen in deferred loading mode
Martin Kustermann added 1 comment Patchset-level comments File-level comment, Patchset 4 (Latest):
unread,
[XS] Change in dart/sdk[main]: [dart2wasm] Also use --traps-never-happen in deferred loading mode
Martin Kustermann added 1 comment Patchset-level comments File-level comment, Patchset 4 (Latest):
9:34 AM
Johnni Winther (Gerrit)
,
Jens Johansen (Gerrit)
3
7:54 AM
[L] Change in dart/sdk[main]: [CFE] Expression evaluation: access private members in superclasses
Attention needed from Jens Johansen Johnni Winther voted Code-Review+1 Code-Review +1 Open in Gerrit
unread,
[L] Change in dart/sdk[main]: [CFE] Expression evaluation: access private members in superclasses
Attention needed from Jens Johansen Johnni Winther voted Code-Review+1 Code-Review +1 Open in Gerrit
7:54 AM
Jens Johansen (Gerrit)
, …
Commit Queue (Gerrit)
5
7:44 AM
[XS] Change in dart/sdk[main]: [analyzer] BinaryWriter has a smaller buffer
Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files
unread,
[XS] Change in dart/sdk[main]: [analyzer] BinaryWriter has a smaller buffer
Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files
7:44 AM
Sergey Grekhov (Gerrit)
,
Erik Ernst (Gerrit)
4
7:02 AM
[XS] Change in dart/sdk[main]: [co19] Roll co19 to 4d8035cc65081a3afa17029ea2af3dfd2c33aafe
Erik Ernst removed a vote from this change Removed Code-Review+1 by Erik Ernst <eer...@google.com
unread,
[XS] Change in dart/sdk[main]: [co19] Roll co19 to 4d8035cc65081a3afa17029ea2af3dfd2c33aafe
Erik Ernst removed a vote from this change Removed Code-Review+1 by Erik Ernst <eer...@google.com
7:02 AM
Slava Egorov (Gerrit)
,
Martin Kustermann (Gerrit)
3
4:21 AM
[XS] Change in dart/sdk[main]: [gardening] Skip VM-only co19 tests on DDC
Martin Kustermann submitted the change Change information Commit message: [gardening] Skip VM-only
unread,
[XS] Change in dart/sdk[main]: [gardening] Skip VM-only co19 tests on DDC
Martin Kustermann submitted the change Change information Commit message: [gardening] Skip VM-only
4:21 AM
Chloe Stefantsova (Gerrit)
, …
Commit Queue (Gerrit)
10
3:35 AM
[M] Change in dart/sdk[main]: [analyzer] Implement static extension getters
Commit Queue submitted the change with unreviewed changes Unreviewed changes 13 is the latest
unread,
[M] Change in dart/sdk[main]: [analyzer] Implement static extension getters
Commit Queue submitted the change with unreviewed changes Unreviewed changes 13 is the latest
3:35 AM
Felipe Morschel (Gerrit)
, …
Konstantin Shcheglov (Gerrit)
23
Oct 30
[L] Change in dart/sdk[main]: [DAS] Fixes Create setters, getters and fields for using type parameters
Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted and added 2 comments
unread,
[L] Change in dart/sdk[main]: [DAS] Fixes Create setters, getters and fields for using type parameters
Attention needed from Brian Wilkerson and Samuel Rawlins Felipe Morschel voted and added 2 comments
Oct 30
Felipe Morschel (Gerrit)
2
Oct 30
[M] Change in dart/sdk[main]: [DAS] Fixes completion for dot-shorthand in FutureOr<T> and for switches
Attention needed from Kallen Tu and Keerti Parthasarathy Felipe Morschel added 1 comment Patchset-
unread,
[M] Change in dart/sdk[main]: [DAS] Fixes completion for dot-shorthand in FutureOr<T> and for switches
Attention needed from Kallen Tu and Keerti Parthasarathy Felipe Morschel added 1 comment Patchset-
Oct 30
Martin Kustermann (Gerrit)
, …
Commit Queue (Gerrit)
7
Oct 30
[XL] Change in dart/sdk[main]: [dart2wasm] Introduce unresolved accesses & link phase
Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved
unread,
[XL] Change in dart/sdk[main]: [dart2wasm] Introduce unresolved accesses & link phase
Commit Queue submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved
Oct 30
Kallen Tu (Gerrit)
, …
Commit Queue (Gerrit)
7
Oct 30
[L] Change in dart/sdk[main]: [tests] Declaring Constructors - Header clauses, extension type repre...
Commit Queue submitted the change with unreviewed changes Unreviewed changes 10 is the latest
unread,
[L] Change in dart/sdk[main]: [tests] Declaring Constructors - Header clauses, extension type repre...
Commit Queue submitted the change with unreviewed changes Unreviewed changes 10 is the latest
Oct 30
Brian Wilkerson (Gerrit)
, …
Commit Queue (Gerrit)
5
Oct 30
[S] Change in dart/sdk[main]: Fine. Fix for withFineDependencies value in analytics in long sessions.
Commit Queue submitted the change Change information Commit message: Fine. Fix for
unread,
[S] Change in dart/sdk[main]: Fine. Fix for withFineDependencies value in analytics in long sessions.
Commit Queue submitted the change Change information Commit message: Fine. Fix for
Oct 30
Erik Ernst (Gerrit)
, …
Paul Berry (Gerrit)
22
Oct 30
[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer
Attention needed from Erik Ernst Paul Berry added 7 comments Patchset-level comments File-level
unread,
[XL] Change in dart/sdk[main]: Support the feature 'anonymous methods' in the analyzer
Attention needed from Erik Ernst Paul Berry added 7 comments Patchset-level comments File-level
Oct 30
Brian Wilkerson (Gerrit)
, …
Commit Queue (Gerrit)
5
Oct 30
[XL] Change in dart/sdk[main]: DeCo. Build elements from new ASTs.
Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved
unread,
[XL] Change in dart/sdk[main]: DeCo. Build elements from new ASTs.
Commit Queue submitted the change with unreviewed changes Unreviewed changes 6 is the latest approved
Oct 30
Alexander Markov (Gerrit)
, …
Commit Queue (Gerrit)
4
Oct 30
[XS] Change in dart/sdk[main]: [tests] Skip debugger test for AOT runtime
Commit Queue submitted the change Change information Commit message: [tests] Skip debugger test for
unread,
[XS] Change in dart/sdk[main]: [tests] Skip debugger test for AOT runtime
Commit Queue submitted the change Change information Commit message: [tests] Skip debugger test for
Oct 30
Brian Wilkerson (Gerrit)
, …
Kallen Tu (Gerrit)
5
Oct 30
[S] Change in dart/sdk[main]: DeCo. Change to 'class EnumBody implements AstNode', not 'ClassBody'.
Kallen Tu added 1 comment Patchset-level comments File-level comment, Patchset 3: Brian Wilkerson .
unread,
[S] Change in dart/sdk[main]: DeCo. Change to 'class EnumBody implements AstNode', not 'ClassBody'.
Kallen Tu added 1 comment Patchset-level comments File-level comment, Patchset 3: Brian Wilkerson .
Oct 30
Chloe Stefantsova (Gerrit)
, …
Commit Queue (Gerrit)
5
Oct 30
[L] Change in dart/sdk[main]: [cfe] Make TypeParameter an abstract interface
Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved
unread,
[L] Change in dart/sdk[main]: [cfe] Make TypeParameter an abstract interface
Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved
Oct 30
Johnni Winther (Gerrit)
, …
Commit Queue (Gerrit)
4
Oct 30
[XL] Change in dart/sdk[main]: [parser] Change enum listener calls
Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved
unread,
[XL] Change in dart/sdk[main]: [parser] Change enum listener calls
Commit Queue submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved
Oct 30
Erik Ernst (Gerrit)
Oct 30
[M] Change in dart/sdk[main]: Update the spec parser to support new();`
Attention needed from Chloe Stefantsova Erik Ernst added 1 comment Patchset-level comments File-level
unread,
[M] Change in dart/sdk[main]: Update the spec parser to support new();`
Attention needed from Chloe Stefantsova Erik Ernst added 1 comment Patchset-level comments File-level
Oct 30
Felipe Morschel (Gerrit)
, …
Commit Queue (Gerrit)
14
Oct 30
[S] Change in dart/sdk[main]: [DAS] Fixes rename local variable for function expression cases
Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files
unread,
[S] Change in dart/sdk[main]: [DAS] Fixes rename local variable for function expression cases
Commit Queue submitted the change Unreviewed changes 2 is the latest approved patch-set. No files
Oct 30
Konstantin Shcheglov (Gerrit)
, …
Commit Queue (Gerrit)
10
Oct 30
[L] Change in dart/sdk[main]: Fine. Add 'produceErrors' statistics to 'analysis_statistics'.
Commit Queue submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved
unread,
[L] Change in dart/sdk[main]: Fine. Add 'produceErrors' statistics to 'analysis_statistics'.
Commit Queue submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved
Oct 30
Ben Konyi (Gerrit)
, …
Commit Queue (Gerrit)
8
Oct 30
[S] Change in dart/sdk[main]: [dds/dap] Send an Exited event when the debugged process exits
Commit Queue submitted the change Change information Commit message: [dds/dap] Send an Exited event
unread,
[S] Change in dart/sdk[main]: [dds/dap] Send an Exited event when the debugged process exits
Commit Queue submitted the change Change information Commit message: [dds/dap] Send an Exited event
Oct 30
Ömer Ağacan (Gerrit)
, …
Commit Queue (Gerrit)
3
Oct 30
[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused import
Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused import
unread,
[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused import
Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused import
Oct 30
Martin Kustermann (Gerrit)
, …
Commit Queue (Gerrit)
4
Oct 30
[XS] Change in dart/sdk[main]: [dart2wasm] Recreate the library index after TFA to avoid dangling re...
Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files
unread,
[XS] Change in dart/sdk[main]: [dart2wasm] Recreate the library index after TFA to avoid dangling re...
Commit Queue submitted the change Unreviewed changes 3 is the latest approved patch-set. No files
Oct 30
Nate Biggs (Gerrit)
, …
Commit Queue (Gerrit)
8
Oct 30
[L] Change in dart/sdk[main]: [dart2wasm] Unify deferred loading implementation
Commit Queue submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved
unread,
[L] Change in dart/sdk[main]: [dart2wasm] Unify deferred loading implementation
Commit Queue submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved
Oct 30
Ryan Macnak (Gerrit)
, …
Commit Queue (Gerrit)
4
Oct 29
[XS] Change in dart/sdk[main]: [vm, gc] Avoid growth policy data race.
Commit Queue submitted the change Change information Commit message: [vm, gc] Avoid growth policy
unread,
[XS] Change in dart/sdk[main]: [vm, gc] Avoid growth policy data race.
Commit Queue submitted the change Change information Commit message: [vm, gc] Avoid growth policy
Oct 29
Felipe Morschel (Gerrit)
, …
Commit Queue (Gerrit)
21
Oct 29
[M] Change in dart/sdk[main]: [DAS] Fixes regression in completion for unnamed parameters in closures
Felipe Morschel added 1 comment Patchset-level comments File-level comment, Patchset 6: Felipe
unread,
[M] Change in dart/sdk[main]: [DAS] Fixes regression in completion for unnamed parameters in closures
Felipe Morschel added 1 comment Patchset-level comments File-level comment, Patchset 6: Felipe
Oct 29