Groups

Dart Code Reviews

1–30 of 122397

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Alexander Markov (Gerrit), Alexander Aprelev (Gerrit)6

1:44 AM

[XL] Change in dart/sdk[main]: [vm/shared] Ensure stores into shared static variables are checked.

Alexander Aprelev voted and added 6 comments Votes added by Alexander Aprelev Commit-Queue +1 6

unread,

[XL] Change in dart/sdk[main]: [vm/shared] Ensure stores into shared static variables are checked.

Alexander Aprelev voted and added 6 comments Votes added by Alexander Aprelev Commit-Queue +1 6

1:44 AM

Paul Berry (Gerrit)

Dec 20

[M] Change in dart/sdk[main]: analyzer: Remove some deprecated items related to analysis options

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

unread,

[M] Change in dart/sdk[main]: analyzer: Remove some deprecated items related to analysis options

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

Dec 20

Brian Wilkerson (Gerrit), … Paul Berry (Gerrit)4

Dec 20

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

unread,

[L] Change in dart/sdk[main]: meta: Annotate nonVirtual with TargetKind.overridableMember

Attention needed from Samuel Rawlins Paul Berry voted and added 1 comment Votes added by Paul Berry

Dec 20

Parker Lougheed (Gerrit)

Dec 20

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Parker Lougheed has uploaded the change for review Commit message [sdk] Update dart.dev links in dart

unread,

[M] Change in dart/sdk[main]: [sdk] Update dart.dev links in dart:core doc comments

Parker Lougheed has uploaded the change for review Commit message [sdk] Update dart.dev links in dart

Dec 20

Felipe Morschel (Gerrit), … Brian Wilkerson (Gerrit)10

Dec 20

[M] Change in dart/sdk[main]: [analyzer_plugin] Fixes writing recursive type parameter

Attention needed from Erik Ernst, Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-

unread,

[M] Change in dart/sdk[main]: [analyzer_plugin] Fixes writing recursive type parameter

Attention needed from Erik Ernst, Felipe Morschel and Samuel Rawlins Brian Wilkerson voted Code-

Dec 20

Brian Wilkerson (Gerrit), … Konstantin Shcheglov (Gerrit)4

Dec 19

[L] Change in dart/sdk[main]: analyzer: Move the mock 'dart:ui' library to the mock SDK

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

unread,

[L] Change in dart/sdk[main]: analyzer: Move the mock 'dart:ui' library to the mock SDK

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment Patchset-level comments

Dec 19

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[M] Change in dart/sdk[main]: [DAS] Fixes go to imports for annotations constructors

Commit Queue submitted the change Change information Commit message: [DAS] Fixes go to imports for

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes go to imports for annotations constructors

Commit Queue submitted the change Change information Commit message: [DAS] Fixes go to imports for

Dec 19

Felipe Morschel (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[M] Change in dart/sdk[main]: [DAS] Fixes import with prefix to work with annotations

Commit Queue submitted the change Change information Commit message: [DAS] Fixes import with prefix

unread,

[M] Change in dart/sdk[main]: [DAS] Fixes import with prefix to work with annotations

Commit Queue submitted the change Change information Commit message: [DAS] Fixes import with prefix

Dec 19

Brian Wilkerson (Gerrit), … Samuel Rawlins (Gerrit)3

Dec 19

[XS] Change in dart/sdk[main]: Rev tools to 125b9a9a5556fa88ecec26f649e1cddb1623aa2f

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

unread,

[XS] Change in dart/sdk[main]: Rev tools to 125b9a9a5556fa88ecec26f649e1cddb1623aa2f

Samuel Rawlins added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

Dec 19

Ömer Ağacan (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused bash function find_flags

Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused bash

unread,

[XS] Change in dart/sdk[main]: [dart2wasm] Remove unused bash function find_flags

Commit Queue submitted the change Change information Commit message: [dart2wasm] Remove unused bash

Dec 19

Ömer Ağacan (Gerrit), Nate Biggs (Gerrit)8

Dec 19

[L] Change in dart/sdk[main]: [dart2wasm] Catch JS exceptions with the right tag, improve toString ...

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs voted and added 3 comments Votes

unread,

[L] Change in dart/sdk[main]: [dart2wasm] Catch JS exceptions with the right tag, improve toString ...

Attention needed from Martin Kustermann and Ömer Ağacan Nate Biggs voted and added 3 comments Votes

Dec 19

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)9

Dec 19

[S] Change in dart/sdk[main]: Add documentation for the deprecated_factory_method warning

Commit Queue submitted the change Change information Commit message: Add documentation for the

unread,

[S] Change in dart/sdk[main]: Add documentation for the deprecated_factory_method warning

Commit Queue submitted the change Change information Commit message: Add documentation for the

Dec 19

Samuel Rawlins (Gerrit), … Konstantin Shcheglov (Gerrit)7

Dec 19

[M] Change in dart/sdk[main]: analyzer: For must_be_immutable, check fields declared in primary con...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

unread,

[M] Change in dart/sdk[main]: analyzer: For must_be_immutable, check fields declared in primary con...

Attention needed from Samuel Rawlins Konstantin Shcheglov added 1 comment File pkg/analyzer/lib/src/

Dec 19

Konstantin Shcheglov (Gerrit), … Commit Queue (Gerrit)9

Dec 19

[XL] Change in dart/sdk[main]: DeCo. Build extension type primary constructors like regular ones.

Commit Queue submitted the change Change information Commit message: DeCo. Build extension type

unread,

[XL] Change in dart/sdk[main]: DeCo. Build extension type primary constructors like regular ones.

Commit Queue submitted the change Change information Commit message: DeCo. Build extension type

Dec 19

Jens Johansen (Gerrit), … Johnni Winther (Gerrit)6

Dec 19

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Delay adding initializers

Johnni Winther added 1 comment Patchset-level comments File-level comment, Patchset 8 (Latest):

unread,

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Delay adding initializers

Johnni Winther added 1 comment Patchset-level comments File-level comment, Patchset 8 (Latest):

Dec 19

Sergey Grekhov (Gerrit), … Commit Queue (Gerrit)6

Dec 19

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 911100f1901c7e6de8ba5c8c290a0a3b7e33a997

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

unread,

[XS] Change in dart/sdk[main]: [co19] Roll co19 to 911100f1901c7e6de8ba5c8c290a0a3b7e33a997

Commit Queue submitted the change Change information Commit message: [co19] Roll co19 to

Dec 19

Daco Harkes (Gerrit), … Commit Queue (Gerrit)4

Dec 19

[XL] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Commit Queue submitted the change Change information Commit message: [deps] Roll dart-lang/native The

unread,

[XL] Change in dart/sdk[main]: [deps] Roll dart-lang/native

Commit Queue submitted the change Change information Commit message: [deps] Roll dart-lang/native The

Dec 19

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Dec 18

[M] Change in dart/sdk[main]: Fix a crash in the outline computer

Commit Queue submitted the change Change information Commit message: Fix a crash in the outline

unread,

[M] Change in dart/sdk[main]: Fix a crash in the outline computer

Commit Queue submitted the change Change information Commit message: Fix a crash in the outline

Dec 18

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Dec 18

[L] Change in dart/sdk[main]: meta: Annotate visibleForOverriding and visibleForTesting with Target...

Commit Queue submitted the change Change information Commit message: meta: Annotate

unread,

[L] Change in dart/sdk[main]: meta: Annotate visibleForOverriding and visibleForTesting with Target...

Commit Queue submitted the change Change information Commit message: meta: Annotate

Dec 18

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)8

Dec 18

[M] Change in dart/sdk[main]: analyzer: Report unused fields with origin in a primary constructor

Commit Queue submitted the change Change information Commit message: analyzer: Report unused fields

unread,

[M] Change in dart/sdk[main]: analyzer: Report unused fields with origin in a primary constructor

Commit Queue submitted the change Change information Commit message: analyzer: Report unused fields

Dec 18

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)5

Dec 18

[S] Change in dart/sdk[main]: analyzer: Add unused_shown_name test case for dot-shorthands

Commit Queue submitted the change Change information Commit message: analyzer: Add unused_shown_name

unread,

[S] Change in dart/sdk[main]: analyzer: Add unused_shown_name test case for dot-shorthands

Commit Queue submitted the change Change information Commit message: analyzer: Add unused_shown_name

Dec 18

Sigmund Cherem (Gerrit), … Alexander Markov (Gerrit)19

Dec 18

[M] Change in dart/sdk[main]: [ DDC / CFE ] Add support for allowing imports of unsupported libraries

Alexander Markov has created a revert of this change Open original change Related details Attention

unread,

[M] Change in dart/sdk[main]: [ DDC / CFE ] Add support for allowing imports of unsupported libraries

Alexander Markov has created a revert of this change Open original change Related details Attention

Dec 18

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)3

Dec 18

[L] Change in dart/sdk[main]: [perf tesing]Add an option to write out a log with performance relate...

Commit Queue submitted the change Change information Commit message: [perf tesing]Add an option to

unread,

[L] Change in dart/sdk[main]: [perf tesing]Add an option to write out a log with performance relate...

Commit Queue submitted the change Change information Commit message: [perf tesing]Add an option to

Dec 18

Kevin Moore (Gerrit), … Commit Queue (Gerrit)3

Dec 18

[S] Change in dart/sdk[main]: [dart2wasm] Use Expect.listEquals instead of home-rolled solution

Commit Queue submitted the change Change information Commit message: [dart2wasm] Use Expect.

unread,

[S] Change in dart/sdk[main]: [dart2wasm] Use Expect.listEquals instead of home-rolled solution

Commit Queue submitted the change Change information Commit message: [dart2wasm] Use Expect.

Dec 18

Slava Egorov (Gerrit), … Jens Johansen (Gerrit)9

Dec 18

[S] Change in dart/sdk[main]: [vm] Allow Before/After GC to signal `perf`

Jens Johansen added 1 comment Patchset-level comments File-level comment, Patchset 6 (Latest): Ryan

unread,

[S] Change in dart/sdk[main]: [vm] Allow Before/After GC to signal `perf`

Jens Johansen added 1 comment Patchset-level comments File-level comment, Patchset 6 (Latest): Ryan

Dec 18

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Dec 17

[M] Change in dart/sdk[main]: analyzer: Allow TargetKind.constructor annotations on classes with pr...

Commit Queue submitted the change Change information Commit message: analyzer: Allow TargetKind.

unread,

[M] Change in dart/sdk[main]: analyzer: Allow TargetKind.constructor annotations on classes with pr...

Commit Queue submitted the change Change information Commit message: analyzer: Allow TargetKind.

Dec 17

Samuel Rawlins (Gerrit), … Commit Queue (Gerrit)3

Dec 17

[S] Change in dart/sdk[main]: analyzer: Store fewer objects to track analysis options

Commit Queue submitted the change Change information Commit message: analyzer: Store fewer objects to

unread,

[S] Change in dart/sdk[main]: analyzer: Store fewer objects to track analysis options

Commit Queue submitted the change Change information Commit message: analyzer: Store fewer objects to

Dec 17

Kevin Moore (Gerrit)2

Dec 17

[XS] Change in dart/sdk[main]: pkg:perf_witness update SDK constraint so it works with Flutter @ master

Attention needed from Slava Egorov Kevin Moore added 1 comment Patchset-level comments File-level

unread,

[XS] Change in dart/sdk[main]: pkg:perf_witness update SDK constraint so it works with Flutter @ master

Attention needed from Slava Egorov Kevin Moore added 1 comment Patchset-level comments File-level

Dec 17

Parker Lougheed (Gerrit), … Commit Queue (Gerrit)5

Dec 17

[M] Change in dart/sdk[main]: [linter] Clean up details for obvious-type related lints

Commit Queue submitted the change Change information Commit message: [linter] Clean up details for

unread,

[M] Change in dart/sdk[main]: [linter] Clean up details for obvious-type related lints

Commit Queue submitted the change Change information Commit message: [linter] Clean up details for

Dec 17

Felipe Morschel (Gerrit), … Connie Ooi (Gerrit)17

Dec 17

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Connie Ooi voted Code-Review +1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[L] Change in dart/sdk[main]: [linter, DAS] Adds `simplify_variable_pattern` lint and fix

Connie Ooi voted Code-Review +1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Dec 17

Search

Clear search

Close search

Google apps

Main menu