Groups

Dart Code Reviews

1–30 of 123463

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Sigmund Cherem (Gerrit), … Alexander Markov (Gerrit)3

8:59 AM

[XL] Change in dart/sdk[main]: [dyn_modules] Support types in a dynamic interface.

Attention needed from Sigmund Cherem Alexander Markov added 3 comments File pkg/vm/lib/

unread,

[XL] Change in dart/sdk[main]: [dyn_modules] Support types in a dynamic interface.

Attention needed from Sigmund Cherem Alexander Markov added 3 comments File pkg/vm/lib/

8:59 AM

Daco Harkes (Gerrit), … Martin Kustermann (Gerrit)12

8:37 AM

[M] Change in dart/sdk[main]: [record_use] Enum const instances wasm

Attention needed from Daco Harkes Martin Kustermann added 1 comment File sdk/lib/core/enum.dart Line

unread,

[M] Change in dart/sdk[main]: [record_use] Enum const instances wasm

Attention needed from Daco Harkes Martin Kustermann added 1 comment File sdk/lib/core/enum.dart Line

8:37 AM

Danny Tuppeny (Gerrit)

6:37 AM

[M] Change in dart/sdk[main]: [dds/dap] Don't sent output events for skip messages as a result of u...

Attention needed from Ben Konyi and Jessy Yameogo Danny Tuppeny added 1 comment File pkg/dds/

unread,

[M] Change in dart/sdk[main]: [dds/dap] Don't sent output events for skip messages as a result of u...

Attention needed from Ben Konyi and Jessy Yameogo Danny Tuppeny added 1 comment File pkg/dds/

6:37 AM

Parker Lougheed (Gerrit)

6:02 AM

[M] Change in dart/sdk[main]: [linter] Add diagnostic doc for unnecessary_library_directive lint

Parker Lougheed has uploaded the change for review Commit message [linter] Add diagnostic doc for

unread,

[M] Change in dart/sdk[main]: [linter] Add diagnostic doc for unnecessary_library_directive lint

Parker Lougheed has uploaded the change for review Commit message [linter] Add diagnostic doc for

6:02 AM

Chloe Stefantsova (Gerrit), … Commit Queue (Gerrit)11

5:55 AM

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Use MemberLookupResult for redirecting ini...

Commit Queue submitted the change Change information Commit message: [cfe][PrimaryConstructors] Use

unread,

[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Use MemberLookupResult for redirecting ini...

Commit Queue submitted the change Change information Commit message: [cfe][PrimaryConstructors] Use

5:55 AM

Brian Wilkerson (Gerrit), … Slava Egorov (Gerrit)4

5:44 AM

[M] Change in dart/sdk[main]: linter: Support extension types in avoid_slow_async_io rule

Slava Egorov added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): Slava

unread,

[M] Change in dart/sdk[main]: linter: Support extension types in avoid_slow_async_io rule

Slava Egorov added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): Slava

5:44 AM

Jonas Jensen (Gerrit), Konstantin Shcheglov (Gerrit)4

5:03 AM

[M] Change in dart/sdk[main]: Tweaks to avoid failling back to PhysicalResourceProvider when not ne...

Attention needed from Konstantin Shcheglov and Phil Quitslund Jonas Jensen voted Auto-Submit+1 Auto-

unread,

[M] Change in dart/sdk[main]: Tweaks to avoid failling back to PhysicalResourceProvider when not ne...

Attention needed from Konstantin Shcheglov and Phil Quitslund Jonas Jensen voted Auto-Submit+1 Auto-

5:03 AM

Parker Lougheed (Gerrit)

4:52 AM

[L] Change in dart/sdk[main]: [linter] Add diagnostic docs for parameter and arg related lints

Parker Lougheed has uploaded the change for review Commit message [linter] Add diagnostic docs for

unread,

[L] Change in dart/sdk[main]: [linter] Add diagnostic docs for parameter and arg related lints

Parker Lougheed has uploaded the change for review Commit message [linter] Add diagnostic docs for

4:52 AM

Johnni Winther (Gerrit)

4:05 AM

[XL] Change in dart/sdk[main]: CQ. Migrate tests in pkg/analyzer/test/src/fasta/recovery/partial_cod...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate tests in pkg/analyzer/test/src/fasta/recovery/partial_cod...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

4:05 AM

Johnni Winther (Gerrit)

3:58 AM

[XL] Change in dart/sdk[main]: CQ. Remove FastaParserTestCase and related.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[XL] Change in dart/sdk[main]: CQ. Remove FastaParserTestCase and related.

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:58 AM

Johnni Winther (Gerrit)

3:55 AM

[XL] Change in dart/sdk[main]: CQ. Modernize parser recovery tests to use explicit assertParsedNodeT...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

unread,

[XL] Change in dart/sdk[main]: CQ. Modernize parser recovery tests to use explicit assertParsedNodeT...

Attention needed from Konstantin Shcheglov and Paul Berry Johnni Winther voted Code-Review+1 Code-

3:55 AM

Daco Harkes (Gerrit), Sigmund Cherem (Gerrit)7

2:56 AM

[L] Change in dart/sdk[main]: [record_use] Const instances loading units

Attention needed from Sigmund Cherem Daco Harkes added 1 comment File pkg/compiler/lib/src/ssa/

unread,

[L] Change in dart/sdk[main]: [record_use] Const instances loading units

Attention needed from Sigmund Cherem Daco Harkes added 1 comment File pkg/compiler/lib/src/ssa/

2:56 AM

Brian Wilkerson (Gerrit)

12:35 AM

[M] Change in dart/sdk[main]: Add another fix for invalidCovariantModifierInPrimaryConstructor

Brian Wilkerson removed a vote from this change Removed Commit-Queue+1 by Brian Wilkerson <

unread,

[M] Change in dart/sdk[main]: Add another fix for invalidCovariantModifierInPrimaryConstructor

Brian Wilkerson removed a vote from this change Removed Commit-Queue+1 by Brian Wilkerson <

12:35 AM

Nate Bosch (Gerrit)

Mar 9

[XS] Change in dart/sdk[main]: Bump webdev to 4391a9d3001a2dff104e039569a4f692997c58cf

Nate Bosch abandoned this change. View Change Abandoned Rolled in https://dart-review.googlesource.

unread,

[XS] Change in dart/sdk[main]: Bump webdev to 4391a9d3001a2dff104e039569a4f692997c58cf

Nate Bosch abandoned this change. View Change Abandoned Rolled in https://dart-review.googlesource.

Mar 9

Ben Konyi (Gerrit), … Ryan Macnak (Gerrit)10

Mar 9

[L] Change in dart/sdk[main]: [ Service ] Initial implementation of VM Service based on `package:da...

Attention needed from Ben Konyi and Nicholas Shahan Ryan Macnak voted Code-Review+1 Code-Review +1

unread,

[L] Change in dart/sdk[main]: [ Service ] Initial implementation of VM Service based on `package:da...

Attention needed from Ben Konyi and Nicholas Shahan Ryan Macnak voted Code-Review+1 Code-Review +1

Mar 9

Samuel Rawlins (Gerrit), … Konstantin Shcheglov (Gerrit)6

Mar 9

[M] Change in dart/sdk[main]: DAS session logger: Normalize paths as log entries are written.

Samuel Rawlins voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

unread,

[M] Change in dart/sdk[main]: DAS session logger: Normalize paths as log entries are written.

Samuel Rawlins voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is

Mar 9

Liam Appelbe (Gerrit), … Commit Queue (Gerrit)3

Mar 9

[S] Change in dart/sdk[main]: [deps] rev ai, ecosystem, http, test, tools

Commit Queue submitted the change Change information Commit message: [deps] rev ai, ecosystem, http,

unread,

[S] Change in dart/sdk[main]: [deps] rev ai, ecosystem, http, test, tools

Commit Queue submitted the change Change information Commit message: [deps] rev ai, ecosystem, http,

Mar 9

Kallen Tu (Gerrit)

Mar 9

[S] Change in dart/sdk[main]: [tests] Add test for explicit class body on mixin applications.

Attention needed from Kallen Tu and Lasse Nielsen Kallen Tu voted Commit-Queue+1 Commit-Queue +1 Open

unread,

[S] Change in dart/sdk[main]: [tests] Add test for explicit class body on mixin applications.

Attention needed from Kallen Tu and Lasse Nielsen Kallen Tu voted Commit-Queue+1 Commit-Queue +1 Open

Mar 9

Kallen Tu (Gerrit)

Mar 9

[L] Change in dart/sdk[main]: [analyzer] Dot shorthands - FunctionExpressionInvocations can be dot ...

Attention needed from Kallen Tu and Konstantin Shcheglov Kallen Tu voted and added 1 comment Votes

unread,

[L] Change in dart/sdk[main]: [analyzer] Dot shorthands - FunctionExpressionInvocations can be dot ...

Attention needed from Kallen Tu and Konstantin Shcheglov Kallen Tu voted and added 1 comment Votes

Mar 9

Ryan Macnak (Gerrit)

Mar 9

[M] Change in dart/sdk[main]: [build] Generate DW_AT_variables for bin_to_assembly data outputs.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

unread,

[M] Change in dart/sdk[main]: [build] Generate DW_AT_variables for bin_to_assembly data outputs.

Attention needed from Alexander Aprelev New activity on the change Open in Gerrit Related details

Mar 9

Kallen Tu (Gerrit), … Commit Queue (Gerrit)5

Mar 9

[M] Change in dart/sdk[main]: [tests] Variance - out and inout are built-in identifiers.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

unread,

[M] Change in dart/sdk[main]: [tests] Variance - out and inout are built-in identifiers.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

Mar 9

Alexander Markov (Gerrit), … Commit Queue (Gerrit)6

Mar 9

[S] Change in dart/sdk[main]: [modular_aot] Fix live ranges of non-fixed temps, fix serialization o...

Commit Queue submitted the change Change information Commit message: [modular_aot] Fix live ranges of

unread,

[S] Change in dart/sdk[main]: [modular_aot] Fix live ranges of non-fixed temps, fix serialization o...

Commit Queue submitted the change Change information Commit message: [modular_aot] Fix live ranges of

Mar 9

Alexander Markov (Gerrit), … Commit Queue (Gerrit)4

Mar 9

[M] Change in dart/sdk[main]: [modular_aot] Code generation for binary int operations add/sub/mul/o...

Commit Queue submitted the change Change information Commit message: [modular_aot] Code generation

unread,

[M] Change in dart/sdk[main]: [modular_aot] Code generation for binary int operations add/sub/mul/o...

Commit Queue submitted the change Change information Commit message: [modular_aot] Code generation

Mar 9

Johnni Winther (Gerrit), Konstantin Shcheglov (Gerrit)5

Mar 9

[XL] Change in dart/sdk[main]: CQ. Migrate most tests from FastaParserTestCase to ParserDiagnosticsT...

Konstantin Shcheglov submitted the change with unreviewed changes Unreviewed changes 6 is the latest

unread,

[XL] Change in dart/sdk[main]: CQ. Migrate most tests from FastaParserTestCase to ParserDiagnosticsT...

Konstantin Shcheglov submitted the change with unreviewed changes Unreviewed changes 6 is the latest

Mar 9

Alexander Markov (Gerrit), … Commit Queue (Gerrit)5

Mar 9

[XL] Change in dart/sdk[main]: [vm,modular_aot] Boxing/unboxing of int and double values

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[XL] Change in dart/sdk[main]: [vm,modular_aot] Boxing/unboxing of int and double values

Commit Queue submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Mar 9

Brian Wilkerson (Gerrit), … Commit Queue (Gerrit)4

Mar 9

[XS] Change in dart/sdk[main]: Reword the message for representationFieldModifier

Commit Queue submitted the change Change information Commit message: Reword the message for

unread,

[XS] Change in dart/sdk[main]: Reword the message for representationFieldModifier

Commit Queue submitted the change Change information Commit message: Reword the message for

Mar 9

Daco Harkes (Gerrit), … Commit Queue (Gerrit)4

Mar 9

[M] Change in dart/sdk[main]: [dartdev] `dart run` progress updates to `stderr`

Commit Queue submitted the change Change information Commit message: [dartdev] `dart run` progress

unread,

[M] Change in dart/sdk[main]: [dartdev] `dart run` progress updates to `stderr`

Commit Queue submitted the change Change information Commit message: [dartdev] `dart run` progress

Mar 9

Ryan Macnak (Gerrit), … Commit Queue (Gerrit)4

Mar 9

[XS] Change in dart/sdk[main]: [build] Generate debug info for assembly.

Commit Queue submitted the change Change information Commit message: [build] Generate debug info for

unread,

[XS] Change in dart/sdk[main]: [build] Generate debug info for assembly.

Commit Queue submitted the change Change information Commit message: [build] Generate debug info for

Mar 9

Tess Strickland (Gerrit), … Commit Queue (Gerrit)6

Mar 9

[L] Change in dart/sdk[main]: [vm,dyn_modules] Recognize the vm:invisible pragma.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[L] Change in dart/sdk[main]: [vm,dyn_modules] Recognize the vm:invisible pragma.

Commit Queue submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Mar 9

Nourhan Hasan (Gerrit), … Ben Konyi (Gerrit)7

Mar 9

[S] Change in dart/sdk[main]: [vm/service]: expose Pointer<T> address in VM Service Protocol

Attention needed from Daco Harkes and Nourhan Hasan Ben Konyi added 3 comments File pkg/vm_service/

unread,

[S] Change in dart/sdk[main]: [vm/service]: expose Pointer<T> address in VM Service Protocol

Attention needed from Daco Harkes and Nourhan Hasan Ben Konyi added 3 comments File pkg/vm_service/

Mar 9

Search

Clear search

Close search

Google apps

Main menu