Re: [PATCH damus v1] Highlights

[William Casarin]

On Sat, May 04, 2024 at 02:49:12AM GMT, Daniel D'Aquino wrote:
>> On May 3, 2024, at 08:42, William Casarin <jb...@jb55.com> wrote:
>> On Mon, Apr 29, 2024 at 08:06:40PM -0600, ericholguin wrote:
>>
>>> This patch adds highlights (NIP-84) to Damus.
>>>
>>> Kind 9802 are handled by all the necessary models.
>>> We show highlighted events, longform events, and url references.
>>> Url references also leverage text fragments to take the user to the highlighted text.
>>>
>>> [..]
>>
>> Very slick, will test this soon.
>
>I was also going to help test this, but I can’t get the patch to apply
>no matter how I try. I don’t have the original email, so I have been
>trying to get the separate pieces together from this, but I always get
>some kind of error.
>
>If possible, can either of you send me the original patch? I apologize
>for the inconvenience.
>
>(I don’t have the original email because I had my Google Groups setting
>to send me a daily digest instead. I changed that back to avoid this
>issue in the future)
>
>Thanks!

github PRs should sove this problem, we need it for CI anyway so we
might as well just use it. If github ever bans us we can figure out
another CI solution and fallback to email.

There is also a really cool trick you can do:

git config --add remote.origin.fetch '+refs/pull/*/head:refs/remotes/pr/*'

This will mark all github PRs in your tree when `git log --graph`:

https://cdn.jb55.com/s/8662c34eb2ee7299.png