Re: [PATCH damus] Add promotional 'Translate Note' button

3 views
Skip to first unread message

William Casarin

unread,
Feb 26, 2024, 1:58:30 PM2/26/24
to kernelkind, pat...@damus.io, d...@damus.io, pro...@damus.io
On Mon, Feb 26, 2024 at 01:38:58PM -0500, kernelkind wrote:
>>
>> >### Settings > Translation > (select service) > toggle off
>> >'automatically translate notes'. Settings > Translation > Select 'None'
>> >option for the 'Service' dropdown
>>
>> Most people will have this option off no? They will never see this?
>>
>
>Correct, I was just communicating that I was thinking about this edge case

I think in the purple case we should show the translate button:

Logic

```pseudocode
If (automatic translations are off) OR ((user has purple translations enabled) AND (purple account is not active)) {
Show the translate button that prompts purple screen when clicked
}
```

Notice this ignores the automatic translation setting for accounts
configured with the purple translator.

Thoughts?

kernelkind

unread,
Feb 28, 2024, 4:26:05 PM2/28/24
to William Casarin, pat...@damus.io, d...@damus.io, pro...@damus.io
```pseudocode
If (automatic translations are off) OR ((user has purple translations enabled) AND (purple account is not active)) {
        Show the translate button that prompts purple screen when clicked
}
```

The following is a truth table in markdown of the pseudocode:

| Automatic translations | Purple Translations  | Purple account | Promotional Translate Button |
| ---- | ---- | ---- | ---- |
| OFF | ENABLED | NOT ACTIVE | SHOW |
| ON | ENABLED | NOT ACTIVE | SHOW |
| OFF | DISABLED | NOT ACTIVE | SHOW |
| ON | DISABLED | NOT ACTIVE | DON'T SHOW |
| OFF | ENABLED | ACTIVE | SHOW |
| ON | ENABLED | ACTIVE | DON'T SHOW |
| OFF | DISABLED | ACTIVE | SHOW |
| ON | DISABLED | ACTIVE | DON'T SHOW |
 
I don't think it makes sense to display the Promotional Translate Button when the user has an active purple subscription at all. 

Here are the two cases where purple subscription is active and the Promotional Translate Button was shown:

Case 1:
Automatic translations: Off
Purple translations enabled: True
Purple Account active: True

If the user decides they don't want automatic translations, when they click on the 'Translate Note' button, they should get the translation in their NoteContentView, not be shown their membership information (the Purple screen). 

Case 2:
Automatic translations: Off
Purple translations enabled: False
Purple account active: True

If the user for some reason doesn't use purple translations even though they have an active subscription, they shouldn't be shown their membership information. If they don't have any translation system active, maybe we could navigate them to the setting to enable it. But if they have a different translation system active, they should be able to use it in peace if that's their preference.
Reply all
Reply to author
Forward
0 new messages