On Thu, Apr 14, 2016 at 03:36:36PM +0200, David Moreno Montero wrote:
> it is really a long time without real releases (0.7 around 2 years ago),
> and as we approach 1000 stargazers (999 just now), and I just committed the
> commit 1000 (what a coincidence), I think its now good moment for a new
> release 0.8.
> Highlights since 0.7 (in reverse chronological order):
> 1. Stability improvements on the poller (Thanks to Solar designer for help
> tracking it, idea by Rich Felker, fixed by David Moreno).
This is only available in a pull request that you have not merged:
Your commit c80c46d5ff842291f0cce3917e7b8340c43d4315 is not it - I think
it's based on a misunderstanding of Rich's idea, so should not be
attributed to him, nor to me, please. (Of course, the existing commit
message has to stay as-is, but please don't propagate this to the
changelog.) Specifically, this commit does not literally use shutdown(),
postponing the close() call, but instead uses onion's own ->shutdown(),
which does a close() right away, so the problem persists.
> Before the release I would like:
> 1. to merge the fixtimeouts branch
Please don't. Instead, please consider merging the pull request above,
or let me know if you'd like me to resubmit it without those #if 0's
or/and split into two separate pull requests (for the two commits).