Re: Implemented kiosk mode for Mac. (issue 7484029)

f...@ubercode.de

unread,

Mar 26, 2012, 5:11:58 AM3/26/12

to m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

On 2011/10/05 06:09:02, Hironori Bono wrote:
> Have you checked if this change works on Lion? I'm wondering if I can
> commit
> this change.

No, sorry. I wasn't able to get my hands on a Lion machine yet, we cannot
upgrade our Macs at work for some reason.

http://codereview.chromium.org/7484029/

hb...@chromium.org

unread,

Mar 26, 2012, 5:31:55 AM3/26/12

to f...@ubercode.de, m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

Greetings,

Thanks for your response.
It is not a problem if you cannot test this change on Lion. (We will test
it on
Lion.) Is it possible to check the 'commit' check when you are ready to
commit
this change?

Regards,

Hironori Bono

http://codereview.chromium.org/7484029/

commi...@chromium.org

unread,

Mar 26, 2012, 5:41:46 AM3/26/12

to f...@ubercode.de, m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/f...@ubercode.de/7484029/13001

http://codereview.chromium.org/7484029/

commi...@chromium.org

unread,

Mar 26, 2012, 5:41:48 AM3/26/12

to f...@ubercode.de, m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

Can't apply patch for file chrome/browser/ui/browser.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser.cc
Hunk #1 FAILED at 1663.
Hunk #2 succeeded at 5199 (offset 484 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/browser.cc.rej

http://codereview.chromium.org/7484029/

f...@ubercode.de

unread,

Mar 26, 2012, 5:42:49 AM3/26/12

to m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

On 2012/03/26 09:31:55, Hironori Bono wrote:
> Thanks for your response.
> It is not a problem if you cannot test this change on Lion. (We will test
> it
on
> Lion.)

Great! Sorry I didn't get back on this earlier, still hoped we would sort
out
our internal upgrade issues...

http://codereview.chromium.org/7484029/

commi...@chromium.org

unread,

Mar 26, 2012, 11:33:46 AM3/26/12

to f...@ubercode.de, m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/f...@ubercode.de/7484029/25002

http://codereview.chromium.org/7484029/

commi...@chromium.org

unread,

Mar 26, 2012, 11:33:52 AM3/26/12

to f...@ubercode.de, m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

Presubmit check for 7484029-25002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
chrome/browser/ui

Presubmit checks took 1.4s to calculate.

http://codereview.chromium.org/7484029/

f...@ubercode.de

unread,

Mar 26, 2012, 11:35:17 AM3/26/12

to m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

I've merged the changes from trunk and had to change a few things.

http://codereview.chromium.org/7484029/

f...@ubercode.de

unread,

Mar 27, 2012, 9:09:09 AM3/27/12

to m...@chromium.org, sa...@chromium.org, rse...@chromium.org, rohi...@chromium.org, tha...@chromium.org, hb...@chromium.org, chromium...@chromium.org, phajd...@chromium.org

http://codereview.chromium.org/7484029/

Reply all

Reply to author

Forward