CHROMIUM: tegra: clear SDHCI_QUIRK_NO_SDIO_IRQ quirk (issue5976001)

5 views
Skip to first unread message

dah...@nvidia.com

unread,
Dec 17, 2010, 3:43:23 AM12/17/10
to ol...@chromium.org, chromium-...@chromium.org, m...@chromium.org, ol...@chromium.org, vbendeb...@chromium.org
Reviewers: Olof Johansson,

Description:
CHROMIUM: tegra: clear SDHCI_QUIRK_NO_SDIO_IRQ quirk

Disabling SDIO interrupt polling. Polling uses CMD52 which
does not allow system to be idle for longer duration(LP2)

Change-Id: Ib7a0633b880a6070e88242647943f182c0c59d49
From: Rakesh Kumar <kra...@nvidia.com>

BUG=none
TEST=Built kernel and boot, system can enter LP2 when wifi enabled
Signed-off-by: Danny Huang <dah...@nvidia.com>

Please review this at http://codereview.chromium.org/5976001/

SVN Base: http://git.chromium.org/git/kernel-...@chromeos-2.6.36

Affected files:
M drivers/mmc/host/sdhci-tegra.c


Index: drivers/mmc/host/sdhci-tegra.c
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index
361c8e7806837771c09bbe8434358192601ca2c0..7bd64147d1c23b393afa75e5fcde4bd068d8b8f8
100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -110,8 +110,7 @@ static int __devinit tegra_sdhci_probe(struct
platform_device *pdev)
SDHCI_QUIRK_NO_HISPD_BIT |
SDHCI_QUIRK_8_BIT_DATA |
SDHCI_QUIRK_NO_VERSION_REG |
- SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC |
- SDHCI_QUIRK_NO_SDIO_IRQ;
+ SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC;

if (plat->force_hs != 0)
sdhci->quirks |= SDHCI_QUIRK_FORCE_HIGH_SPEED_MODE;


ol...@chromium.org

unread,
Dec 17, 2010, 1:30:56 PM12/17/10
to dah...@nvidia.com, chromium-...@chromium.org, m...@chromium.org, vbendeb...@chromium.org
The workaround is, or was, there for a reason. Unfortunately I lack full
history
for when it was added. There's a chance we will regress some usage by
removing
it.

So, I would like to see a bit more testing before we pick this one up.

http://codereview.chromium.org/5976001/

Reply all
Reply to author
Forward
0 new messages