Modify u-booti code to allow building coreboot payload. [chromiumos/third_party/u-boot-next : chromeos-v2011.03]

198 views
Skip to first unread message

Vadim Bendebury (Code Review)

unread,
Jun 9, 2011, 9:54:47 PM6/9/11
to Vadim Bendebury
Vadim Bendebury has uploaded a new change for review.

Change subject: Modify u-booti code to allow building coreboot payload.
......................................................................

Modify u-booti code to allow building coreboot payload.

Two tweaks are required:

- prevent the preprocessor from complaining when processing
variadic macros

- use the bfd linker instead of GOLD

BUG=chrome-os-partner:3895
TEST=manual:
while in chroot in u-boot-next/files directory run the
following commands:

rm -rf /tmp/c-u-boot
make -j16 ARCH=i386 CROSS_COMPILE=i686-pc-linux-gnu- coreboot-x86_config O=/tmp/c-u-boot
make -j16 ARCH=i386 CROSS_COMPILE=i686-pc-linux-gnu- all O=/tmp/c-u-boot

observe the build succeed.

Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Signed-off-by: Vadim Bendebury <vbe...@chromium.org>
---
M Makefile
M board/chromebook-x86/coreboot/config.mk
2 files changed, 4 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/u-boot-next refs/changes/25/2425/1
--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Vadim Bendebury (Code Review)

unread,
Jun 9, 2011, 9:56:03 PM6/9/11
to Vadim Bendebury
Vadim Bendebury has posted comments on this change.

Change subject: Modify u-booti code to allow building coreboot payload.
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment


Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>

Simon Glass (Code Review)

unread,
Jun 10, 2011, 12:56:59 AM6/10/11
to Vadim Bendebury, Anton Staaf
Simon Glass has posted comments on this change.

Change subject: Modify u-booti code to allow building coreboot payload.
......................................................................


Patch Set 1: Looks good to me, approved

LGTM

Is this the Italian U-boot? :-) Also wondering if the hyphen in coreboot-x86 might not be a great idea.

--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment


Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Gerrit-Reviewer: Anton Staaf <robo...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>

Vadim Bendebury (Code Review)

unread,
Jun 10, 2011, 1:39:12 AM6/10/11
to Vadim Bendebury, Anton Staaf, Simon Glass
Vadim Bendebury has posted comments on this change.

Change subject: Modify u-boot code to allow building coreboot payload.
......................................................................


Patch Set 2: Verified

Translated the title from Italian :)

--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 2


Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Simon Glass (Code Review)

unread,
Jun 10, 2011, 1:41:34 AM6/10/11
to Vadim Bendebury, Anton Staaf
Simon Glass has posted comments on this change.

Change subject: Modify u-boot code to allow building coreboot payload.
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 2


Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Vadim Bendebury (Code Review)

unread,
Jun 10, 2011, 1:47:25 AM6/10/11
to Vadim Bendebury, Anton Staaf, Simon Glass
Vadim Bendebury has submitted this change and it was merged.

Change subject: Modify u-boot code to allow building coreboot payload.
......................................................................


Modify u-boot code to allow building coreboot payload.

Two tweaks are required:

- prevent the preprocessor from complaining when processing
variadic macros

- use the bfd linker instead of GOLD

BUG=chrome-os-partner:3895
TEST=manual:
while in chroot in u-boot-next/files directory run the
following commands:

rm -rf /tmp/c-u-boot
make -j16 ARCH=i386 CROSS_COMPILE=i686-pc-linux-gnu- coreboot-x86_config O=/tmp/c-u-boot
make -j16 ARCH=i386 CROSS_COMPILE=i686-pc-linux-gnu- all O=/tmp/c-u-boot

observe the build succeed.

Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Signed-off-by: Vadim Bendebury <vbe...@chromium.org>
---
M Makefile
M board/chromebook-x86/coreboot/config.mk
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
Simon Glass: Looks good to me, approved
Vadim Bendebury: Verified


--
To view, visit http://gerrit.chromium.org/gerrit/2425
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I028afd9bb7269db8b16730a065dd64d83e5a158a
Gerrit-PatchSet: 2


Gerrit-Project: chromiumos/third_party/u-boot-next
Gerrit-Branch: chromeos-v2011.03
Gerrit-Owner: Vadim Bendebury <vbe...@chromium.org>

Reply all
Reply to author
Forward
0 new messages