Missing base files for rietveld

[Chris Bentzel]

In  http://codereview.chromium.org/9416031/ I am somehow missing the base file for chrome/renderer/chrome_content_renderer_client.cc

I re-ran a bunch of times with print statements in upload.py, and it looks like I am sending up a valid hash for that file as part of the POST data in the /upload. The --base-url is svn://svn.chromium.org/chrome/trunk/src

I have --download_base set to the default of False. The response to my /upload POST has "nobase" before each of the patches in the response, so I don't end up uploading any additional base files.

However, during the final  /upload_complete/ request, I get a 500 response with "base files missing". The commit queue also complains about this. 

When I do a visual diff in rietveld the diff appears correct, and the try bots were able to patch and run correctly.

 

I could try setting download_base to True, but I'm a bit perplexed about the behavior I'm seeing and would like to understand it better.

[Marc-Antoine Ruel]

It's a rietveld bug. It happens when you visit the url before it has finished uploading the files. There is no known quick fix beside starting over.

M-A

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Chris Bentzel]

Could I just manually hack so it ignores the "nobase" for the one file I care about?

Guess if the only alternative is starting over I may as well try it.

[Chris Bentzel]

On Wed, Mar 7, 2012 at 5:17 PM, Chris Bentzel <cben...@chromium.org> wrote:

Could I just manually hack so it ignores the "nobase" for the one file I care about?

Yeah, that didn't work.

[Evan Martin]

On Wed, Mar 7, 2012 at 2:13 PM, Marc-Antoine Ruel <mar...@chromium.org> wrote:
> It's a rietveld bug. It happens when you visit the url before it has
> finished uploading the files. There is no known quick fix beside starting
> over.

You could probably hack it by
1) git checkout -b hack origin
2) echo >> chrome/renderer/chrome_content_renderer_client.cc
3) git commit -am hack
4) git checkout my-original-branch
5) git merge hack
6) git cl upload hack

This will use the file with the extra trailing newline as the "base" file.

[Ryan Sleevi]

An easier solution is that when I've had this happen, as long as it wasn't the very first patchset, I just remove all the patchsets with missing bases. Then just re-upload. As long as you don't load the URL in between things, "it just works".