Sheriff: Disable many weblayer tests on Windows [chromium/src : master]

39 views
Skip to first unread message

Fergus Dall (Gerrit)

unread,
Dec 16, 2019, 6:57:33 PM12/16/19
to cricke...@chromium.org, darin...@chromium.org, weblay...@chromium.org, chromium...@chromium.org

Patch set 1:Commit-Queue +2

View Change

    To view, visit change 1970299. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I3b25c2ecca3ca123e5e40d47f78c6f6f1f33440d
    Gerrit-Change-Number: 1970299
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fergus Dall <side...@google.com>
    Gerrit-Reviewer: Fergus Dall <side...@google.com>
    Gerrit-Comment-Date: Mon, 16 Dec 2019 23:57:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Commit Bot (Gerrit)

    unread,
    Dec 16, 2019, 7:18:44 PM12/16/19
    to Fergus Dall, cricke...@chromium.org, darin...@chromium.org, weblay...@chromium.org, chromium...@chromium.org

    Commit Bot submitted this change.

    View Change

    Approvals: Fergus Dall: Looks good to me; Commit
    Sheriff: Disable many weblayer tests on Windows

    ErrorPageBrowserTest.404WithEmptyBody
    ErrorPageBrowserTest.NameNotResolved
    NavigationBrowserTest.HttpClientError
    NavigationBrowserTest.HttpConnectivityError
    NavigationBrowserTest.HttpServerError
    NavigationBrowserTest.NoError
    NavigationBrowserTest.SSLError
    SSLBrowserTest.NavigateAway
    SSLBrowserTest.Proceed
    SSLBrowserTest.Reload
    SSLBrowserTest.TakeMeBack
    SSLBrowserTest.TakeMeBackEmptyNavigationHistory
    WebLayerBrowserTest.Basic
    WebLayerWebUIBrowserTest.WebUI

    Bug: 1034764

    TBR=weblay...@chromium.org

    Change-Id: I3b25c2ecca3ca123e5e40d47f78c6f6f1f33440d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970299
    Reviewed-by: Fergus Dall <side...@google.com>
    Commit-Queue: Fergus Dall <side...@google.com>
    Cr-Commit-Position: refs/heads/master@{#725333}
    ---
    M weblayer/browser/errorpage_browsertest.cc
    M weblayer/browser/navigation_browsertest.cc
    M weblayer/browser/ssl_browsertest.cc
    M weblayer/browser/webui/webui_browsertest.cc
    M weblayer/test/weblayer_browser_test_test.cc
    5 files changed, 20 insertions(+), 0 deletions(-)


    To view, visit change 1970299. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I3b25c2ecca3ca123e5e40d47f78c6f6f1f33440d
    Gerrit-Change-Number: 1970299
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fergus Dall <side...@google.com>
    Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
    Gerrit-Reviewer: Fergus Dall <side...@google.com>
    Gerrit-MessageType: merged

    John Abd-El-Malek (Gerrit)

    unread,
    Dec 18, 2019, 1:39:45 PM12/18/19
    to Commit Bot, Fergus Dall, cricke...@chromium.org, darin...@chromium.org, weblay...@chromium.org, chromium...@chromium.org

    John Abd-El-Malek has created a revert of this change.

    View Change

    To view, visit change 1970299. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: master
    Gerrit-Change-Id: I3b25c2ecca3ca123e5e40d47f78c6f6f1f33440d
    Gerrit-Change-Number: 1970299
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fergus Dall <side...@google.com>
    Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
    Gerrit-Reviewer: Fergus Dall <side...@google.com>
    Gerrit-MessageType: revert
    Reply all
    Reply to author
    Forward
    0 new messages